[13:34] <wgrant> henninge: Thanks. Can you ec2 that?
[13:34] <henninge> wgrant: sure ;)
[13:34] <wgrant> Thanks.
[14:03] <bac> hi henninge, can you do a review for me?
[14:03] <henninge> HI bac, sure.
[14:04] <bac> henninge: cool.  it's in the usual place.  :)
[14:04] <henninge> bac: you can help me with one, too. I was just looking at our style guide.
[14:04] <bac> henninge: i'll try
[14:05] <henninge> bac: https://code.edge.launchpad.net/~wgrant/launchpad/bug-629921-packages-empty-filter/+merge/37339
[14:07] <wgrant> I was wondering about that myself.
[14:07] <wgrant> The style guide wasn't exactly clear.
[14:09] <bac> henninge, wgrant: the style guide seems clear to me, though i'm not defending it in this case.
[14:09] <henninge> bac, wgrant: Sorry, got distracted. Yes, that's exactly what I was about to ask ... ;)
[14:10] <henninge> bac: I see the use of "any" a similar border case.
[14:12] <henninge> e.g. I have been writing code lately like this "if translations is not None and any(translations):" to check for empty strings or none in translations.
[14:19] <bac> wgrant: why do you care if requested_name_filter[0] is None or not?  why not just return requested_name_filter[0], after checking that it exists?
[14:20] <bac> i mean:  if len(requested_name_filter) > 0: return requested_name_filter[0]
[14:20] <bac> you return None when the test fails anyway
[14:20] <wgrant> bac: I want to return None if it's "".
[14:20] <wgrant> That's the whole point of the bug.
[14:21] <bac> wgrant: well, yeah, there is that...  :)
[14:21] <wgrant> Heh.
[14:21] <bac> wgrant: then i think lifeless' suggestion is the cleanest, PSG be damned
[14:21] <wgrant> Great, thanks.
[14:22] <wgrant> Can someone please bless and land that, then?
[14:26] <henninge> wgrant: approved. I'll land both your branches.
[14:27] <wgrant> Thanks henninge, bac.
[14:43] <allenap> henninge: Would you be able to review my branch? I can't be here unfortunately, so please say no if that's a problem.
[14:44] <henninge> allenap: put it in the queue and I'll try. ;)
[14:45] <bac> mrevell: can you do a text review of https://code.edge.launchpad.net/~bac/launchpad/bug-639703-pg-bugs/+merge/37463 ?
[14:46] <mrevell> sure bac
[14:46] <bac> thanks
[15:42] <henninge> bac: You are creating a view purely to have it aggregate an "official_malone" property?
[15:43] <henninge> bac: I think this is something the ProjectGroup class should do - and thus the tests should be for that class, too.
[15:46] <henninge> bac: I mean, thre should be a ProjectGroup.official_malone property that loops through the product, as does the view now.
[15:46] <henninge> s/product/products/
[18:21] <henninge> abentley: Hi!
[18:21] <abentley> henninge: hi!
[18:22] <henninge> abentley: I ran late and cannot start on Gavin's branch as I had intended. Can you take it, although he's not here?
[18:22] <abentley> henninge: okay.
[18:22] <henninge> He said it's ok if we don't do it because he's not here.
[18:22] <henninge> abentley: thanks!
[18:23] <henninge> abentley: good bye ;)
[18:23] <abentley> henninge: bye!
[20:17] <jcsackett> abentley: do you have time to look at an MP with literally one line change? https://code.edge.launchpad.net/~jcsackett/launchpad/messages-translated-652264/+merge/37508
[20:21] <abentley> jcsackett: r=me
[20:21] <jcsackett> thanks, abentley.