[04:20] lifeless: ping [04:27] hey [04:28] lifeless: i have put up for review an enhancement to allow logging of sql bind parameters, to make performance tuning easier [04:28] https://code.edge.launchpad.net/~wallyworld/launchpad/log-sql-bind-variables/+merge/37552 [04:28] can you take a look and see if you agree with it? [04:28] thnks :-) [04:28] I reviewed it already [04:29] wow, that quick [04:29] no messing :) [04:29] let me look and see if you approved :-) [04:30] cool. thanks. [08:12] hi henninge [08:12] Oh hi bac! You are ahead of me time-zone-wise, right ... ;-) [08:13] henninge: thanks for the review yesterday. i know you think i'm on crack, but the hoo-ha with the involvement portlet was following a pattern already employed. [08:13] bac: is crack cheap in vietman? [08:13] henninge: however, in light of your questions i'm having a hard time defending it. :( [08:14] bac: What would be the advantage of doing it that way? [08:15] henninge: well, the original thought was to not repeat the code. but i cannot rationalize why it should be in a portlet rather than the model [08:15] exactly ... ;-) [08:16] henninge: you'll see in answers and maybe translations the same thing is done [08:16] well, it's never too late to mend our old ways. ;) [08:17] I mean, there is a lot of old code in LP that neither you nor I would have written that way. Non need to continue the errors of others. [08:18] henninge: please don't joke about me + crack + vietnam. [08:18] :) [08:18] henninge: i completely agree [08:18] ;) [08:40] stub: Hi! Are you up for a database review? [08:41] henninge: I see a merge proposal containing nothing but sampledata rebuilt with PG 8.3 instead of PG 8.4 [08:41] stub: yes, I just realized that myself. [08:42] the 8.3 vs. 8.4 diffference [08:42] How come I am not running 8.4 locally? [08:42] stub: also, I just added a diff for the other files that were changed. === jtv changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [08:44] henninge: after installing PG8.4 you still need to change your conf files so that 8.3 doesn't start and 8.4 does [08:44] oh [08:44] * henninge checks that 8.4 is installed ... should be [08:44] start.conf needs to have 'auto' [08:46] henninge: even if they're both installed, you may still be running 8.3 on the expected port (5432). Try running "psql" [08:47] jtv: I understand and psql reports 8.3 [08:47] henninge: that's the version of psql itself, so that tells us you have 8.3 still installed. [08:48] I'm trying to remember how to ask for the backend version. [08:48] ah yes, "show server_version;" [08:48] jtv: it is obviously 8.3 because the sampledata I generated reports 8.3 [08:48] * henninge tries that [08:48] 8.3.9 [08:49] henninge: in /etc/postgresql/8.4/main/postgresql.conf, make sure that "port" is set to 5432. [08:50] henninge: the package installation scripts will set it to 5433 if there's already another postgres version set to run on 5432. [08:51] bac: start.conf in both 8.3. and 8.4 contain only one directive: "auto" [08:51] jtv: will look at that [08:51] henninge: yes, you must remove the one from 8.3 [08:51] henninge: unless you need 8.3 for some reason you can just blow away the 8.3 config directory [08:51] Probably best to un-install 8.3 entirely, with --purge, yes. [08:52] henninge: and possibly run launchpad-database-config, or whatever it is called [08:52] It's a bit of a trap that doing this, by default, will leave you with 8.4 running on 5433 and all connection attempts on the default port failing as if you have no backend running. [08:52] jtv: the script will take care of that [08:52] Oh good [08:53] launchpad-database-setup [09:01] jtv, bac: I am a bit unsure what to do: http://paste.ubuntu.com/506314/ [09:02] henninge: would you mind having a look at PillarView? [09:02] bac: sure [09:02] henninge: try removing all of those that have "8.3" in them, but also installing their 8.4 equivalents in the same run. [09:03] henninge: also, there's no problem with temporarily dropping the lp packages if that makes things easier. The 8.3 stuff should go in any case. [09:03] jtv: that's what I was more worried about [09:04] I think I already have all the 8.4 stuff installed. [09:04] henninge: then just uninstall this stuff and then re-install the lp packages. [09:05] it'll probably come up with conflicts and two resolution scenarios, one using pg 8.3 and one using pg 8.4. [09:05] (not that I'm too familiar with aptitude) [09:05] jtv: I don't usually use it either. I just did not find the purge option on apt-get. [09:06] apt-get remove --purge [09:06] * henninge tries that [09:07] jtv: much better! http://paste.ubuntu.com/506320/ [09:08] henninge: i'm hesitant to unroll all of the PillarView logic and move it to the model without discussing it with sinzui. [09:08] henninge: i think i'd like to land what i have, repeating the existing pattern, and then fix them all together if that is what we decide to do [09:08] bac: please do that. I did not think that it is that much. [09:09] bac: yes, please file a bug about it. [09:09] rt [09:09] rt? [09:09] right then [09:09] ? [09:09] "roger that" [09:09] :-) [09:09] my friend the former helicopter pilot infected everyone with saying it [09:10] bac: careful with that… you may trigger an allergic psychotic reaction in losas [09:34] stub: please look at the mp again. I'll request a db review from you on it if that's ok. [09:35] stub: oh, nm. You already did ... ;-) [09:35] I already approved it didn't I? [09:35] yes, I just noticed. Thanks! [09:38] I need a testfix review: https://code.edge.launchpad.net/~lifeless/launchpad/test/+merge/37571 [09:39] * henninge waits for diff to become available [09:43] lifeless: simple enough fix, thank you, but can you please rename _setup to _is_setup or _is_set_up? [09:43] lifeless: r=me === noodles775 changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [jtv, noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:02] noodles775: I can trade you a review in a few minutes [10:02] (well, it'll take more than "a few minutes" before you reap the benefits, but still :) [10:03] jtv: great! [10:05] jtv: can you have a quick look at this code-wise first, please? [10:05] https://code.edge.launchpad.net/~henninge/launchpad/db-devel-translationmessage-pofile/+merge/37563 [10:05] I think I can promise a quick look… [10:06] 2749 lines of diff… which of those need my quick look? :) [10:07] jtv: 2456-2478 [10:07] :-P [10:08] henninge: grrr truncated diff [10:09] jtv: look in the comments! [10:09] the rest is just removing lots of 'pofile' and 'NULL' from sampledata [10:10] henninge: I have to _get_ at the comments first… [10:10] ? They are at the top, above the diff, are they not? [10:11] oh, you are going through the mails ... [10:13] henninge: oh, the MP comments. I thought you meant code comments. [10:14] jtv: there is this https://launchpadlibrarian.net/57120537/review.diff and this https://launchpadlibrarian.net/57122440/inc.diff [10:14] jtv: but you can see it all on the mp page. [10:14] henninge: yes, I see [10:19] henninge: wow, passing vars() to a % is pretty nasty… didn't know we did that. For a doctest I guess it doesn't matter that much. [10:20] jtv: Not using the factory here seems pretty out of place, too. [10:20] But fixing that is out of scope for this db-oriented branch. [10:20] henninge: ultimately most or all of our doctests should just go away and leave us in peace. [10:20] anyway, approved. [10:20] jtv: thanks [10:20] noodles775: getting to your branch now [10:21] jtv: great, thanks. I've just reviewed yours. [10:21] thanks [10:24] noodles775: the "dynamic name for the action" you refer to is the text in the button at the bottom, right? [10:24] jtv: yeah, so that it displays "Sync selected Warty versions into Hoary" (with appropriate substitutions). [10:24] gotcha [10:25] I never thought about that; didn't think it'd have to come out of a vocabulary. [10:25] huh? the dynamic vocabulary issue is a separate one... what did you mean exactly? [10:25] noodles775: ah, that makes more sense [10:26] Just trying to parse your MP with a bit of a headache. :) [10:26] urgh... hope it's not too painful. [10:26] thanks for the rewording suggestions, mrevell [10:26] noodles775: no, I'll just take it out on some poor engineer in a review. [10:26] :P [10:27] noodles775: it goes like this… I thought point 2) in the MP detailed your approach to solving point 1), though there's nothing in particular to indicate that. [10:27] mrevell: should we really say "Sorry" though? === bigjools changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [jtv, noodles775,bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:31] noodles775: I'm not much at home in zope but istm what you want is an alternative to custom_widget that you can invoke from, say, __init__ [10:32] jtv: well, the vocabularies are actually specified on the field, not the widget (the widget then grabs them from the field). [10:33] jtv: IMO, if zope had something like the IContextSourceBinder, IViewSourceBinder, that would work. [10:34] AFAICS, zope does allow a vocab factory to implement ISource instead, which I had thought in the past was a more general way that would allow what I needed, but I've never managed to get it to initialise from the view. [10:34] Hence, the solution I used in this branch. [10:34] noodles775: this sounds familiar [10:35] I might ask one of the zope guys to take a look later when they are around, incase there is something I've missed. [10:35] noodles775: smart move [10:36] mrevell: ping [10:37] hey there bac [10:37] mrevell: i have a counter proposal [10:37] howzabout: [10:37] Sorry, you can't report a bug for the $ProjectGroup project group. None of the [10:37] projects within the group use Launchpad for bug tracking. Please check the [10:37] $ProjectGroup website for details of where they track bug reports. [10:37] argh, no, that's yours [10:37] noodles775: it's really galling that you have to go into class attributes to get at the label… I don't suppose you could somehow _easily_ set self.actions to a copy of self.__class__.actions and manipulate that instead? [10:37] haha, I thought it looked good bac [10:37] You cannot report a bug for as none of [10:37] the projects within the group use Launchpad for bug tracking. [10:37] Please check the individual projects for details [10:37] of where bugs are reported. [10:38] a) we don't know if the project group has a web site [10:38] b) i didn't like starting off with "Sorry" [10:38] it is a shame but it isn't my fault so why should i apologize? [10:39] * mrevell is British [10:39] that's all the explanation you need [10:39] bac: +1 on your version. [10:39] I like it [10:39] yes, and when i read that i heard it in your voice [10:39] jtv: agreed, but no, I didn't see an obvious easier way, hence my question on the MP. I'll take another look though. [10:39] as a Dutch poet ones wrote about theBritish: "mylord's final word is: please excuse my rigor mortis" [10:39] :) [10:39] s/ones/once/ [10:40] thanks mrevell [10:40] You're welcome. [10:40] Or, as Americans seem to prefer, "Mmm hmm". [10:41] noodles775: I wonder if it's possible to use a factory instead of a class for the view. [10:42] mrevell: also, i'm concerned about using the project display name in that sentence [10:42] mrevell: sometimes it will be "Mozilla" and others "Bazaar Project" [10:42] bac: Oh, because people put hard-to-parse things as their display name. [10:43] (little Robbie Tables as we call him) [10:43] heh [10:43] mrevell: not hard to parse but sometimes it would need a 'the' and others not [10:43] wft do we call "the"? [10:43] article? [10:43] ah, yes, an article [10:44] lovely language, English: it has "the" definite article but your choice of "an" indefinite article. [10:44] jtv:shush, we're working here [10:44] noodles775: completely different thing meanwhile… ll. 74—79 doesn't format the list comprehension quite right. [10:44] * jtv shushes [10:45] jtv: line 79 should be indented? [10:45] mrevell: in the project registration we do encourage them to end with "Project", so we should word for that? [10:45] bac: It's a little awkward but how about this? "You cannot report a bug for the project group ''"? [10:46] noodles775: I think this one will become easier if you keep the list comprehension in a variable. [10:46] noodles775: we're supposed to break the line after the opening bracket, not before. [10:47] Right, I missed that. [10:47] mrevell: yeah, that is awkward [10:48] bac: I suppose we don't have to explicitly state the project group name. *Presumably* the person knows which project group they're trying to report a bug on ... but I'm always a fan of being explicit because I know it's easy to confuse people when you're not. [10:50] noodles775: in line 159 of the diff, s/syncs/sync/ ? [10:50] jtv: yep. [10:51] (given how little I know about this, either way could have been valid) [10:52] noodles775: I didn't know you could construct a BeautifulSoup out of a view. That's neat. [10:53] brb === jtv is now known as jtv-afk [10:53] Yeah, I forget where I saw it first, but it's handy for unit-tesing special case things in the template. [10:53] bac: please push the latest revision of your branch. ;) [10:54] henninge: ok, i was just about to [10:54] henninge: why so pushy? :) [10:54] GTD ;-P [10:55] mrevell: i looked at how it was used in context other places in that template and just stuck with what i wrote originally [10:55] Okay. [11:05] henninge, mrevell: could you update the MP, please? [11:06] henninge: what about the UI? did you consider it as a UI reviewer or should i just run it past sinzui? [11:07] bac: no, I have not but let me have a look. [11:08] henninge: for the MP you'll have to state "code/UI*" or something like that [11:08] which will no doubt confuse our tools [11:08] bac: oh, I cannot do two different reviews? [11:08] never tried it before [11:08] henninge: nope, it takes the latest type [11:09] :( [11:09] bac: I'll just comment on the ui, then. [11:09] henninge: i think a combined type would be better [11:09] fwiw [11:10] even if it confuses our tools? ;) [11:12] bac: what's the url for seeing and adding projectgroups? [11:12] I forgot === jtv-afk is now known as jtv [11:12] henninge: we hid it at lp.net/projectgroups [11:13] ah, I tried +projectgroups [11:13] I sense a bit of inconsistency here ... ;) [11:13] there's also /builders. I keep typing /+builders instead. [11:14] I wonder if I could call my project "builders" === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [jtv, noodles775,bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:21] henninge: lp.net/people, lp.net/projects, lp.net/distros ... [11:22] bac: then maybe t.lp.net/+translationgroups is the inconsistency? [11:22] and +languages? [11:22] I know, they are not pillars but do the users see the difference? [11:29] bac: have a look at this, please: [11:29] https://bugs.staging.launchpad.net/mailclipper [11:33] nm, I'll post a screenshot [11:37] henninge: what is your question about mailclipper? [11:38] bac: that's how uncofigured bugtracker looks on a project [11:39] http://people.canonical.com/~henninge/screenshots/unconfigured_bugtracker.png [11:39] and here is how an unconfigured blueprints looks on a project group: [11:39] http://people.canonical.com/~henninge/screenshots/unconfigured_blueprints_pg.png [11:40] bac: so your screenshots is at least missing a page heading and the breadcrumbs. [11:40] but I also like how noodles (I think it was him) added those help links on the project page. [11:41] noodles775: I approved your code. Tried some more to find alternatives for the dynamic label, but no luck. I do hope you find something. === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: jtv || queue: [noodles775,bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:41] hi gmb—I think noodles775 just reviewed me. [11:42] gmb: …and I just reviewed noodles775. [11:42] Heh. [11:42] nm; I'll start on bigjools instead === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: bigjools || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:43] it's trivial [11:44] bigjools: Indeed. It's approved. === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:46] gmb: fast work :) [11:51] Small branch :) [11:51] And lots of people doing work for me. [11:51] Always fun to be fashionably late... [11:58] Thanks jtv [11:58] np, thank you too [12:18] gary_poster: Hi! I'm wondering if you'd be able to look at two zope questions at https://code.edge.launchpad.net/~michael.nelson/launchpad/652838-select-diffs-for-syncing/+merge/37572 [12:20] noodles775: on call, will look, formlib may in fact suck at this [12:20] Thanks gary_poster, no rush :) [12:21] hi gmb, i'm working on the bugs index page for project groups that do not use launchpad. henninge has pointed out that page doesn't [12:21] have a title or breadcrumbs [12:21] i see that the project group page never had either. do you know why? [12:22] deryck: perhaps you know about ^^^ [12:22] bac: No, I don't; [12:23] My first guess would be "we didn't have time before 3.0 and then other things got in the way" [12:23] gmb: probably. [12:23] gmb: so you wouldn't be hurt if i added such things? [12:24] if i can figure it out, that is... [12:24] bac, yeah, no good reason. Just oversight. [12:25] bac: I don't think it would hurt the page. It may hurt your brain; I can't remember how knotty the +index pages are... [12:25] gmb: very convoluted [12:26] bac: you should have an example in the blueprint page for project groups, or not? [12:26] henninge: you'd think. this bug page is complicated [12:26] :( [12:31] Yeah, don't make the mistake of thinking that just because we're not Soyuz we can't write curiously intricate* code. [12:31] *replace with "spaghetti" as appropriate [12:34] gmb, can you do ui reviews? [12:37] leonardr: 'fraid not. [12:37] gmb, np. is it okay to get the non-ui code reviewed before the ui is approved? (i have actually never done a ui review before) [12:39] leonardr: Sure, that's fine. [12:39] leonardr: also, you can request a review from launchpad-ui-reviewers and then ping someone (henninge and salgado are currently mentats, so may want some more). [12:40] noodles775: edwin already reviewd it, so i need a non-mentat reviewer to check his review [12:41] leonardr: ah, who's his mentor, or does he not have one? [12:42] noodles775: i got edwin's review about 2 weeks ago and then lifeless put the brakes on the branch, so i don't really remember anything. i may just start over [12:46] gmb, the branch is https://code.edge.launchpad.net/~leonardr/launchpad/rename-grant-permissions/+merge/36363 [12:46] edwin, when you get in, let me know who your mentor is === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: leonardr || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:48] hmm, that diff looks like there's a branch i haven't merged in or something [12:49] gmb, hold off a bit [12:50] * gmb holds [12:55] ok, the problem was i'd proposed a merge against db-devel instead of devel. but now i see a two-week-old XXX in the diff, so i may be a while longer [12:55] gmb, if you're almost at eod, don't wait around for me [12:56] leonardr: It's just coming up to 1pm for me, so I'll go and grab lunch. If you're still going on this at about 5pm my time I'll let you know that I'm EODing :) [12:56] ok === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:02] leonardr: I've taken your branch out of the queue for now; just re-add it when it's ready. [13:02] gmb. thanks === matsubara-afk is now known as matsubara [13:07] henninge or salgado: do either of you have time for a UI review? https://code.edge.launchpad.net/~michael.nelson/launchpad/652838-select-diffs-for-syncing/+merge/37572 [13:07] I don't think there's much to review here, it's just standard selection/form submission. [13:30] noodles775, I'll do it in a couple hours if henninge doesn't beat me to it [13:31] Thanks salgado. [13:31] * henninge is not the beating type ... [13:41] l [13:42] heh, another great use of the posture sensing ubuntu interface would be to optionally ensure the window you're looking at has focus (if you haven't explicitely given focus to a window in the last n seconds). === leonardr changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: lunch || queue: [leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [14:18] henninge, can you do a ui review for me? [14:18] https://code.edge.launchpad.net/~leonardr/launchpad/rename-grant-permissions/+merge/37590 [14:18] edwin did a review about two weeks ago, as recorded in the mp linked to from that me [14:20] or salgado, you can do my ui review after noodles755's [14:20] https://code.edge.launchpad.net/~leonardr/launchpad/rename-grant-permissions/+merge/37590 === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [14:21] leonardr: Is your branch ready for code review now, too? [14:22] gmb: yes it is [14:23] leonardr: Okay, I'll look shortly. [14:23] great === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: leonardr || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [14:31] henninge, can you take leonard's? [14:37] gmb, pushing a tiny test refactoring (r11591) [14:38] k [14:39] salgado, leonardr: yup, in 15 min. [14:54] leonardr: code is r=me. [14:54] leonardr: Nice work, BTW :) [14:54] gmb, thanks [14:57] leonardr: looking now === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:17] leonardr, ping [15:19] sinzui, hi [15:20] I am reading your doctest [15:20] ok [15:21] leonardr, "The Ubuntu desktop called mycomputer" <- how do you know I am not running Mint or Fedora [15:23] sinzui: it's the client's responsibility to put the right string in there [15:23] that said, i have no idea how the client is supposed to know [15:24] okay [15:24] i'm kind of thinking uname -o but that gives "GNU/Linux" (which might be good enough?) [15:25] leonardr, "all applications running on mycomputer" <- I think this is an exaggeration. All applications running when I am logged in is closer to the truth [15:26] This is hard because most users do not distinguish between sessions and that procs run as under multiple users [15:26] sinzui: yes, i would say that knowing the truth is a prerequisite to knowing that that's an exaggeration [15:26] :) [15:27] use "choose" instead of "click". I can use a touch screen or keyboard [15:29] leonardr, if we used the exaggerated language, how will we respond to the bug reports from the knowledgeable? [15:31] sinzui: we tell them the whole truth and say that the wording is geared towards the casual user [15:31] sinzui: platform.linux_distribution() will give me 'Ubuntu' [15:32] but it is a 2.6ism [15:32] fab [15:32] so i guess i will use platform.dist() instead [15:34] leonardr, Other that the removal of the word "click" I have no suggested changes. [15:35] sinzui: ok. is this an official ui review? [15:35] yes [15:35] I will approve it now [15:37] leonardr: I was about to tell you that I cannot reach the page ... [15:38] leonardr: I get an openid login page and then "you're not allowed here". [15:39] I don't see a warning [15:39] henninge: this is not a page you can just visit in your web browser [15:40] a client such as launchpadlib needs to do some setup work first [15:40] it's not a normal part of launchpad [15:40] leonardr: yes, that is what I get when I do that. === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:40] browser pops up with a login page. [15:40] salgado: thanks. And yes, the all/none checkbox is included on the mockup, I hope to add it in a later branch, but it's not a priority right now. [15:40] morning gmb [15:40] salgado: who's your ui mentor again? [15:41] henninge: walk me through it step by step. what do you do? [15:41] noodles775, sinzui [15:41] Hi mars [15:42] leonardr: 1. "make run" in your branch [15:42] sinzui: do you have time? https://code.edge.launchpad.net/~michael.nelson/launchpad/652838-select-diffs-for-syncing/+merge/37572 [15:42] leonardr: 2. "python" in another terminal [15:42] leonardr: that's a system python [15:42] noodles775, I am just finishing leonardr's review. I will start yours in a few minutes [15:42] Thanks sinzui. [15:43] leonardr: 3. "from launchpadlib.launchpad import Launchpad" === allenap changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:43] leonardr: 4. "l = Launchpad.login_with("Ubuntu desktop (Bob's Computer)", service_root="dev", allow_access_levels=["DESKTOP_INTEGRATION"])" [15:43] gmb, mars: Either of you fancy a short branch? [15:43] mars: Could you take allenap's branch? [15:43] sure [15:43] I'm trying not to context switch. [15:43] mars: Thanks. [15:43] allenap, what do you have? [15:44] henninge: you want "System-wide: Ubuntu desktop (Bob's Computer)" [15:44] mars: https://code.edge.launchpad.net/~allenap/launchpad/structural-subscriptions-with-filters-5/+merge/37608 === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:45] allenap, I assume this is the branch listed in the topic? [15:45] leonardr: ah, I took that from the original MP but I admit I did not read through the comments. [15:45] henninge: yeah, it changed so that you could say "System-wide: Android phone (...)" instead of always having to say "desktop" [15:45] mars: Yep. [15:45] Thank you :) [15:45] leonardr: ok, I see it now ;) [15:47] great [15:48] henninge, fyi, sinzui just did the ui review [15:48] allenap, done, r=mars. === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:48] mars: Cheers! [15:49] leonardr: I saw that but I have two more comments. I just put that in there. [15:49] ok [15:49] thanks [15:49] mars: could you review https://code.edge.launchpad.net/~brian-murray/launchpad/bug-supervisor-permissions/+merge/37514 ? [15:50] bdmurray, sure === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,bdmurray || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:50] leonardr: btw, a screenshot would have sped this up a lot. ;-) [15:51] henninge: sorry, i almost never do anything that has any ui component, so i'm new to this [15:51] leonardr: np [15:52] noodles775, you have my approve with a remark about button case [15:55] mrevell, can i ask you to look at the wording in the branch https://code.edge.launchpad.net/~leonardr/launchpad/rename-grant-permissions/+merge/37590 ? [15:56] I'd be very happy to leonardr. [15:57] Thanks sinzui [16:01] bdmurray, done, r=mars === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:02] mars: great, thanks! [16:08] mrevell, leonardr: screenshot for your convenience: http://people.canonical.com/~henninge/screenshots/desktop-integration-warning.png [16:08] :-) [16:08] mrevell: i'd also like your opinion on a good heading for the page [16:08] thanks henninge, have you added me to the review? [16:08] I'd be glad to. [16:09] mrevell: done === gmb changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === deryck is now known as deryck[lunch] [16:43] henninge, is there any special technique for showing a page's heading, or shall i just scrape the h1 tag? [16:46] leonardr: no, I think it's just an h1. [16:46] the style sheet will take care of the rest [16:47] leonardr: but put it inside the top-portlet container. [16:47] henninge: i meant for testing that it has a certain value [16:47] leonardr: I don't understand [16:48] henninge: if i put

Integrating $computer into your Launchpad account

in the template, i need to add a test that "Integrating Bob's Computer into your launchpad account" shows up [16:50] leonardr: I'd just get the top-portlet and do "print extract_text" [16:50] extract_text(tag) [16:50] ok === deryck[lunch] is now known as deryck === matsubara is now known as matsubara-lunch [17:12]