| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| noodles775 | r or rs for a oneline js testfix? http://pastebin.ubuntu.com/507097/ | 09:35 |
|---|---|---|
| * noodles775 lands it. | 09:37 | |
| === gmb changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [gmb(http://is.gd/fNK3P)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | allenap, deryck, adeuring: Do any of you gents have time to review my branch? I'd like to try and get it into EC2 early this afternoon so that I can deal with any fallout before my EoD | 12:35 |
| adeuring | gmb: I'll do it | 12:36 |
| gmb | adeuring: Excellent, thank you. | 12:36 |
| gmb | adeuring: FTR, it's mostly code moves, so the contents of BugSubscriptionSubscribeSelfView are already-reviewed code from BugTaskView (if that helps at all). | 12:37 |
| adeuring | gmb: thanks | 12:38 |
| adeuring | gmb: r=me | 13:05 |
| gmb | adeuring: Thanks. | 13:05 |
| === gmb changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| henninge | stub: ping ;) | 14:17 |
| henninge | stub: I need a new patch number because 21 is already in use for lp_OpenIdentifier. | 14:20 |
| henninge | https://code.edge.launchpad.net/~henninge/launchpad/db-devel-translationmessage-pofile/+merge/37563 | 14:21 |
| stub | henninge: 2208-23-0 | 14:22 |
| stub | henninge: Sorry about that. I must have gotten distracted before marking it down. | 14:23 |
| henninge | stub: np, thanks. | 14:23 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === gary_poster is now known as gary-dentist | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Speaking of reviews, jelmer, are you up for one? | 15:11 |
| noodles775 | https://code.edge.launchpad.net/~michael.nelson/launchpad/638090-base_version-property-for-differences/+merge/37742 | 15:11 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | noodles775: I can review your branch. | 15:41 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Great, thanks EdwinGrubbs :) | 15:41 |
| EdwinGrubbs | noodles775: I think test_base_version_common could be fleshed out so that it verifies that it chooses the right version when there are multiple common versions and that it ignores versions that aren't in common. | 16:08 |
| noodles775 | EdwinGrubbs: yep, adding now. | 16:09 |
| EdwinGrubbs | noodles775: should a series with versions [1.0, 3.0] and a parent series with versions [1.0, 2.0, 3.0] return 3.0? I ask because 3.0 seems is a common version, but the term "base version" makes me think of bzr, in which case it would be 1.0. | 16:10 |
| noodles775 | EdwinGrubbs: yes, it's the most recent version that both the parent series and the derived series have in common. | 16:11 |
| noodles775 | EdwinGrubbs: http://pastebin.ubuntu.com/507317/ <-- pushing as r9851 | 16:16 |
| EdwinGrubbs | noodles775: that looks good, but the status parameter shouldn't have spaces around "=". Also, you could make it shorter with a for loop to create versions 1.0 and 1.1. | 16:18 |
| noodles775 | Yep. | 16:19 |
| EdwinGrubbs | noodles775: r=me | 16:20 |
| === sinzui changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Thanks EdwinGrubbs | 16:21 |
| sinzui | EdwinI have a branch that fixes the oops caused by large messages | 16:21 |
| noodles775 | EdwinGrubbs: jfyi, http://pastebin.ubuntu.com/507322/. Thanks. | 16:24 |
| EdwinGrubbs | looks good | 16:25 |
| === matsubara is now known as matsubara-lunch | ||
| === gary-dentist is now known as gary-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado is now known as salgado-lunch | ||
| bdmurray | Could I get https://code.edge.launchpad.net/~brian-murray/launchpad/modify-official-bug-tags-permissions/+merge/37758 reviewed? | 17:54 |
| === benji is now known as benji-lunch | ||
| jcsackett | bdmurray: if you're asking for oncall, it helps to add yourself to the queue as well, in the channel info. | 18:00 |
| === bdmurray changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui, bdmurray] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === jcsackett changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui, bdmurray, jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jcsackett | EdwinGrubbs: there is clearly a long line ahead of me, but when/if you get to it, here's my MP: https://code.edge.launchpad.net/~jcsackett/launchpad/project-involvement-translations-contradiction-652287/+merge/37763 | 18:01 |
| jcsackett | if you don't think you'll have time today, i'll run someone else down. | 18:01 |
| === deryck[lunch] is now known as deryck | ||
| === gary-lunch is now known as gary-phone | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: bdmurray || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado-lunch is now known as salgado | ||
| === gary-phone is now known as gary_poster | ||
| === Ursinha is now known as Ursinha-lunch | ||
| EdwinGrubbs | jcsackett: The review has been sent. I have to merge your branch into my upcoming branch to resolve some merge conflicts, so please land this as soon as possible so I don't have to delay landing my branch when it is ready. | 19:24 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === salgado is now known as salgado-afk | ||
| sinzui | EdwinGrubbs, I reviewed your branch: https://launchpad.dev/apache and https://launchpad.dev/gnome both oops | 22:36 |
| sinzui | I like your code changes. I do not see the cause of the oops | 22:36 |
| === benji changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| benji | EdwinGrubbs: comin' atcha: https://code.edge.launchpad.net/~benji/launchpad/bug-612754-2/+merge/37797 | 22:39 |
| === Ursinha is now known as Ursinha-afk | ||
| === matsubara is now known as matsubara-afk | ||
| EdwinGrubbs | sinzui: thanks for the review. I've pushed up my fixes. | 23:10 |
| EdwinGrubbs | benji: I'm starting on your mp now. | 23:24 |
| benji | EdwinGrubbs: cool; I've got to head out but I'll check back later | 23:25 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!