=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
[09:35] <noodles775> r or rs for a oneline js testfix? http://pastebin.ubuntu.com/507097/
[09:37]  * noodles775 lands it.
=== gmb changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [gmb(http://is.gd/fNK3P)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:35] <gmb> allenap, deryck, adeuring: Do any of you gents have time to review my branch? I'd like to try and get it into EC2 early this afternoon so that I can deal with any fallout before my EoD
[12:36] <adeuring> gmb: I'll do it
[12:36] <gmb> adeuring: Excellent, thank you.
[12:37] <gmb> adeuring: FTR, it's mostly code moves, so the contents of BugSubscriptionSubscribeSelfView are already-reviewed code from BugTaskView (if that helps at all).
[12:38] <adeuring> gmb: thanks
[13:05] <adeuring> gmb: r=me
[13:05] <gmb> adeuring: Thanks.
=== gmb changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
[14:17] <henninge> stub: ping ;)
[14:20] <henninge> stub: I need a new patch number because 21 is already in use for lp_OpenIdentifier.
[14:21] <henninge> https://code.edge.launchpad.net/~henninge/launchpad/db-devel-translationmessage-pofile/+merge/37563
[14:22] <stub> henninge: 2208-23-0
[14:23] <stub> henninge: Sorry about that. I must have gotten distracted before marking it down.
[14:23] <henninge> stub: np, thanks.
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== gary_poster is now known as gary-dentist
=== noodles775 changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:11] <noodles775> Speaking of reviews, jelmer, are you up for one?
[15:11] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/638090-base_version-property-for-differences/+merge/37742
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:41] <EdwinGrubbs> noodles775: I can review your branch.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:41] <noodles775> Great, thanks EdwinGrubbs :)
[16:08] <EdwinGrubbs> noodles775:  I think test_base_version_common could be fleshed out so that it verifies that it chooses the right version when there are multiple common versions and that it ignores versions that aren't in common.
[16:09] <noodles775> EdwinGrubbs: yep, adding now.
[16:10] <EdwinGrubbs> noodles775: should a series with versions [1.0, 3.0] and a parent series with versions [1.0, 2.0, 3.0] return 3.0? I ask because 3.0 seems is a common version, but the term "base version" makes me think of  bzr, in which case it would be 1.0.
[16:11] <noodles775> EdwinGrubbs: yes, it's the most recent version that both the parent series and the derived series have in common.
[16:16] <noodles775> EdwinGrubbs: http://pastebin.ubuntu.com/507317/ <-- pushing as r9851
[16:18] <EdwinGrubbs> noodles775: that looks good, but the status parameter shouldn't have  spaces around "=". Also, you could make it shorter with a for loop to create versions 1.0 and 1.1.
[16:19] <noodles775> Yep.
[16:20] <EdwinGrubbs> noodles775: r=me
=== sinzui changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:21] <noodles775> Thanks EdwinGrubbs
[16:21] <sinzui> EdwinI have a branch that fixes the oops caused by large messages
[16:24] <noodles775> EdwinGrubbs: jfyi, http://pastebin.ubuntu.com/507322/. Thanks.
[16:25] <EdwinGrubbs> looks good
=== matsubara is now known as matsubara-lunch
=== gary-dentist is now known as gary-lunch
=== deryck is now known as deryck[lunch]
=== matsubara-lunch is now known as matsubara
=== salgado is now known as salgado-lunch
[17:54] <bdmurray> Could I get https://code.edge.launchpad.net/~brian-murray/launchpad/modify-official-bug-tags-permissions/+merge/37758 reviewed?
=== benji is now known as benji-lunch
[18:00] <jcsackett> bdmurray: if you're asking for oncall, it helps to add yourself to the queue as well, in the channel info.
=== bdmurray changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui, bdmurray] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== jcsackett changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: noodles775 || queue: [sinzui, bdmurray, jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[18:01] <jcsackett> EdwinGrubbs: there is clearly a long line ahead of me, but when/if you get to it, here's my MP: https://code.edge.launchpad.net/~jcsackett/launchpad/project-involvement-translations-contradiction-652287/+merge/37763
[18:01] <jcsackett> if you don't think you'll have time today, i'll run someone else down.
=== deryck[lunch] is now known as deryck
=== gary-lunch is now known as gary-phone
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: bdmurray || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== salgado-lunch is now known as salgado
=== gary-phone is now known as gary_poster
=== Ursinha is now known as Ursinha-lunch
[19:24] <EdwinGrubbs> jcsackett: The review has been sent. I have to merge your branch into my upcoming branch to resolve some merge conflicts, so please land this as soon as possible so I don't have to delay landing my branch when it is ready.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha-lunch is now known as Ursinha
=== salgado is now known as salgado-afk
[22:36] <sinzui> EdwinGrubbs,  I reviewed your branch: https://launchpad.dev/apache and https://launchpad.dev/gnome both oops
[22:36] <sinzui> I like your code changes. I do not see the cause of the oops
=== benji changed the topic of #launchpad-reviews to: On call: Edwin || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[22:39] <benji> EdwinGrubbs: comin' atcha: https://code.edge.launchpad.net/~benji/launchpad/bug-612754-2/+merge/37797
=== Ursinha is now known as Ursinha-afk
=== matsubara is now known as matsubara-afk
[23:10] <EdwinGrubbs> sinzui: thanks for the review. I've pushed up my fixes.
[23:24] <EdwinGrubbs> benji: I'm starting on your mp now.
[23:25] <benji> EdwinGrubbs: cool; I've got to head out but I'll check back later