/srv/irclogs.ubuntu.com/2010/10/08/#launchpad-dev.txt

sinzuiwgrant, I do not know. mars and gary will know00:00
wgrantCan someone mentor StevenK's code* of https://code.edge.launchpad.net/~wgrant/launchpad/bug-655648-a-f-maverick/+merge/37820?00:08
lifelesswgrant: yes we can switch it off00:12
lifelessspm: deathrow fialing to run ?00:30
spmwhat's the logs say?00:30
wgrantErk.00:30
wgrantWhen did it start to fail?00:30
wgrantIs it complaining that it can't remove files because LFCs are missing?00:30
lifelesswgrant: one day ago00:31
wgrantOne day ago, or 13 hours ago?00:31
lifelessspm: The script 'process-death-row' didn't run on 'cocoplum' between 2010-10-07 22:07:04 and 2010-10-07 23:07:04 (last seen 2010-10-06 07:13:08.625020)00:31
wgrantOh, cocoplum.00:32
lifelesswgrant: first error was The script 'process-death-row' didn't run on 'cocoplum' between 2010-10-06 15:07:04 and 2010-10-06 16:07:04 (last seen 2010-10-06 07:13:08.625020)00:32
lifelessand00:32
lifelessThe script 'process-death-row' didn't run on 'germanium' between 2010-10-06 11:07:03 and 2010-10-06 13:07:03 (last seen 2010-10-06 07:33:51.715570)00:32
wgrantIs germanium's OK?00:32
spmlifeless: no, the logs from cocoplum for that script. they'll be on devpad00:32
wgrantCrap.00:32
wgrantSo it predates the DB surgery last night.00:33
wgrantThat's a good thing.00:33
lifelessspm: where would I look?00:36
lifelesswgrant: publish queue or pload ?00:37
spmdevpad? heh, what I usually do is 'locate death' and infer from there :-)00:38
wgrantlifeless: pload?00:38
lifeless2010-10-07 20:33:04 INFO    Creating lockfile: /var/lock/launchpad-process-death-row.lock00:38
lifeless2010-10-07 20:45:06 ERROR   Unexpected exception while doing death-row unpublish00:38
lifeless -> http://launchpadlibrarian.net/57251973/rbZP27X6hCTbVYqO1d4X8iLXCSg.txt (terminating connection due to administrator command00:38
lifelessserver closed the connection unexpectedly00:38
lifeless        This probably means the server terminated abnormally00:38
lifeless        before or while processing the request.00:39
lifeless)00:39
wgrantWell, that is awesome.00:39
lifelessspm: there are death-row entries in the log file, what does the 'failed to run' stuff look for ?00:39
lifelesswgrant: it continues:00:39
lifeless)00:39
lifeless2010-10-07 20:45:15 INFO    Processing http://ppa.launchpad.net/soren/ppa/ubuntu00:39
lifeless2010-10-07 21:03:05 INFO    Creating lockfile: /var/lock/launchpad-process-death-row.lock00:39
wgrantSo it mysteriously died without saying anything?00:40
spmthat last line is a continual source of useless information across a bunch of scripts. it's not creating a lock file; it's starting to try and create a lock file and may or not have succeeded.00:40
spmit looks to be nicely hung, just awaiting being drawn and quartered.00:43
spmProcess 32346 attached - interrupt to quit00:43
spmrestart_syscall(<... resuming interrupted call ...>00:43
wgrantIs it running with maximum verbosity?00:43
spm-vv00:43
wgrantDoes that show DEBUG? I forget.00:44
spmi've killed cocoplum00:44
spmyes00:44
wgrantWhere was cocoplum's hanging?00:44
wgrant(in the log)00:44
spmthis is where it gets tricky to tell00:48
spmbut if I hazard a guess: 2010-10-07 22:10:11 DEBUG   Unpublishing death row for Primary Archive for Ubuntu.00:49
wgrantWll, that's handy.00:49
wgrantCan you set that LP_DEBUG_SQL thingy and run it again?00:49
wgrantSince it's not being very verbose...00:49
lifelessspm: does nagios alert on this condition?00:53
spmlifeless: no; that's what scriptactivity is for00:53
lifelessperhaps we should feed that into nagios00:54
spmgiven the number of apparently false alarms we're getting from scriptactivity; I'd be unhappy at doing that atm :-(00:54
lifelessok00:55
lifelessare there any false alarms without bugs?00:55
spmbasically we've been doing a major ... redo(?) of nagios alerts the past few months. so critical alerts really are critical; with a special subset of those being ZOMG critical. everything else is warning; with the idea that they get manually scanned, vs an actual alert. "Red Fatigue" is a real problem.00:56
lifelessI get that00:57
lifelessI'm asking if the false alarms have had bugs created for them00:57
wgrantlucid_db_lp hates me.00:57
wgrant...00:59
wgrantSomehow production-devel got merged into db-devel with my branch. Despite not showing up in the MP diff.00:59
lifelesswgrant: heh; did you  build your branch on my cp branch ?01:00
wgrantYes, but then I replayed on top of db-devel. Apparently that created a merge from production-devel.01:02
wgrantAnd somehow the diff doesn't include the merged changes.01:02
lifelesswhat rev01:04
lifelessof db-devel01:05
wgrant987501:05
wgranthttps://code.edge.launchpad.net/~wgrant/launchpad/bug-655614-disabled-arch-indices/+merge/3784901:05
spmlifeless: (sorry distracted a bit there) I'm not aware of bugs being filed; I'd assume that those who are responsible for the scripts in question are reading the logs on devpad for same and filing bugs from that? :-)01:10
lifelesswgrant: the diff doesn't update once merged.01:10
lifelessspm: I make no such assumption.01:10
wgrantlifeless: I know.01:11
wgrantlifeless: So the diff should show the result of the merge.01:12
wgrantBut it ignores the fact that there's a production-devel in there.01:12
lifelessspm: can you start either filing drive-by bugs when you get a false alert - any false alert, or failing that at least email me and I'll file the bugs.01:13
lifelesswgrant: the content of the commit on db-devel is definitely fine.01:15
wgrantlifeless: bzr cdiff -c9875 doesn't show a windmill change in versions.cfg?01:16
lifelesswgrant: well it has lib/devscripts/ec2test/tests/test_remote.py changed01:17
wgrantRight, that's another one. Note how that doesn't show up in the MP diff.01:18
lifelesswgrant: and versions.cfg01:18
lifeless-# r1544 of lp:windmill (the tip revision at the time of packaging).01:18
lifeless+# r1440 of lp:~bjornt/windmill/1.3-lp. It includes our patches to make test01:18
spmlifeless: heh, by false alerts; i mean that some of these generate errors semi frequently; and those failure alerts go to the LP list; and no one in turns says "hey this is a problem! the logs say X, can a losa investigate Y; I've filed Bug Z to track this" ergo, false alarm.01:18
mwhudsonlike oops-prune, for example?01:18
spmright01:18
spmtho that one did exactly as I described. diogo did chase it up and file a bug.01:19
mwhudsonalthough for that one, i thought it was a conscious decision that it didn't warrant a CP01:19
wgrantlifeless: So why isn't that in the MP diff?01:19
mwhudsonso the monitoring arguably should have been disabled01:19
lifelessspm: ergo a bug should be filed that it should not generate that error01:19
wgrantThe MP diff isn't very useful if it doesn't show the real diff.01:20
spmotherwise we're just middlemanning the information for developers. we as losas are going to be looking at the exact same info that the developers already have access to. so we're duplicating for no reason.01:20
lifelessspm: if the bug gets marked 'invalid' clearly it *is* an error and *should* be addressed.01:20
spmmwhudson: yeah. that's a trap. disabling is very easy to forget to re-enable.01:21
spmso you end up with convoluted loops like we have with the staging restores. we have a text lock file that stops stagnig alerts during updates; but have anotehr alert that checks for the age of that lock. meta alerts ftw.01:22
mwhudsonat '+ 1 month' mail ...01:23
lifelessspm: there is a difference in focus between day to day reactive and feature work01:23
lifelessspm: I'm not advocating lots of handoffs; I'm saying that operational issues should:01:23
lifeless - trap to the monitoring system [nagios]01:24
lifeless - not trap if nothing is wrong01:24
lifelessand that when you see a trap, if its ignorable, we should change things to not trap.01:24
lifelessI appreciate that the scriptactivity stuff isn't hooked to nagios, but it would be better if it was, and if we can't because its too noisy, we need to fix that.01:24
lifelessand the losas are best placed to judge.01:25
spmright. And I'm saying we're so flat out reacting to ignorable alerts; or puppetting requests that other salready have all the info they require; they we have approx zero time to focus on all tyhe feature reqeusts that are asked of us.01:25
lifelessspm: so the way to dig out of that is to fix things one at a time; ignorable alerts seem straight forward. I won't know if its one of those unless you or someone else tell me.01:26
spmit's not an us vs them situation here. its "our" system, and as we move more to regular rollouts etc, devs NEED to start being more aware of operational stuff happening. they can't shunt it aside as "oh I'm working on a feature"01:27
lifelessspm: I agree01:27
lifelessspm: who *should* I be asking to ensure that ignorable mails are turned into bug reports?01:27
spmso personal take - if the scriptactivity reports, which are really operationally lite compared to alerts; are the first step devs have to see an operation area and fix it, so it is less noisy and more useful for them.01:28
spmscriptactivity is purely under the control of dev's.01:28
spmour involvement tehre is around ensuring things are added to be checked for failure. which is itself a failure state :-)01:29
spmso look at cocobanana and germanium with the process-death-row alerts.  they're generating emails every hour. is this appropriate? it needs fixing, sure, manual intervention was required. But how long can it remain broken before we need to look? Were the logs recorded sufficient to identify what was the problem?01:31
spmis it a critical service like, eg the branchscanner which is time sensitive and IMHO should be nagios'ed; or more "important, not critical"01:32
spmand if so; how can we modify the logic in the activity report so we get timely alerts without dying under noise01:33
spmideally, every one of those scriptactivity responses would get a personal ACK, "this is noise, bug X; this is a problem losas do Y"01:34
lifelessspm: so01:35
lifelessspm: things like nagios understand the idea of edge/level triggering of notifications01:38
lifelessspm: reproducing that in other tools seems pointless01:38
spmhrm. sorta?. In that you have 4 states: unknown. critical. warning. ok. And nagios is geared to aprporpaitely deal with that. How those states are defined, is not a nagios thing; we have bunches of scripts to get these for funkier corners of losaville. I put SA into the same boat.01:45
spmbut who gets the alerts, and how timely they are is a BIG component here.01:46
spmor rephrase. Critical bug reports. should they be tied to nagios? (going for absurd by way of demonstratin')01:47
spmso a critical security bug gets an sms sent to The Developer On Duty; and if they don't ACK within 10 minutes it goes to a team lead; and if they don't ACK in 10, it goes to francis.01:48
spmif X breaking is more a case of "we can wait a few hours, or days" then SMS alerts is the wrong way; and just get the script in question to send a more descriptive and full email to a generic list; nagios is overengineered and heavy weight for this case.01:49
spmie. it's friday. a week into our shift to daylight savings, and I personally still haven't adjusted the hours I get SMS alerts. multiply that by more people? urg.01:50
lifelessspm: there's a pretty strong argument we should be running a 24x7 shop for security issues01:54
lifelessspm: so I don't think thats particularly absurd01:54
lifelessspm: I also get and agree that we shouldn't be alerting everyone on every fault, but again, reimplementing filtering and routing of that in an adhoc lp specific script seems unoptimal01:55
spmas in adjusting how often we send out alerts and who they get escalated to etc? shrug, 6 of 1. for security alerts; if you really want to go that way, sure. nagios would be best; but if we just want to send a simple email; it's overkill. The logic on what is/not an alert will still need to be written. that part must happen.01:59
lifelessyes01:59
lifelessand my first comment was that when that logic is wrong its a bug, and it needs to be filed.02:00
lifelesswhich I stand by.02:00
spmat the moment that logic is (simplisticly) in the scriptactivity script; so that's the obvious place to fix it.02:00
lifelesssure, I made no comment at the start of this conversation about where to fix it.02:00
spmit has been a wide ranging discussion full of interesting and pertinent ideas and concepts. :-)02:01
lifelesshah02:02
lifeless:)02:02
spmbut yes, back to the start. atm, for better or worse, and for a while longer; reports out of scriptactivity are going to still go to the LP list. If those messages atm are noisy, or not as helpful, or indicative of bugs needing to be filed, then my 2c is that the recipients - the LP list - should be filing bugs about them. if we want losas to do bug filing; then the obvious fix is send the results to losas@. Which'd get me crucified by the others, but02:10
spmanyway.02:10
spmor phrased another way - losas are responsible for real time alerts; lp-devs are responsible for not-realtime alerts.02:11
spmgrotesquely simplified.02:11
lifelessspm: scriptactivity failures are realtime IMNSHO, thats also a massive simplification02:12
spmI'm not sure they are.02:12
spmsome of those scripts run every 5 minuyes; but we only care about alerts after 12+ hours.02:12
spmcheckwatches springs to mind as culprit #102:12
spmthe poorly named nightly.sh, has a whole bunch of scripts in it. some that take 5+ hours to run. an additional hour or 3 on waiting for a success/fail result isn't urgent.02:14
lifelessso simplisticly, scriptactivity should only be looking for a run every 12 hours02:14
lifelesstheres a mismatch there.02:14
spmmade worse that the scripts in nightly.sh are serial; and get bounced around start/stop times by other scripts being fast or slow02:14
spmhrm. possibly comms misunderstanding; we have 22 separately timed runs (crontab entries) for scriptactivity; which in turn measures some 22 x ?? scripts.02:16
spmeg: nightly.sh:02:16
spm0 5 * * * $LP_PY /srv/launchpad.net/production/launchpad/scripts/script-monitor.py -U statistician 1440 loganberry:karma-update loganberry:allocate-revision-karma loganberry:launchpad-stats loganberry:expire-questions loganberry:checkwatches loganberry:productreleasefinder loganberry:update-cache loganberry:launchpad-targetnamecacheupdater loganberry:flag-expired-memberships loganberry:update-personal-standing02:16
spmie. check for a successful run of those scripts on those server(s) once a day at 5am, for activity in the last 24 hours.02:17
spmwhich gets busted nicely; if said script in total takes 24.1 hours to run.02:18
lifelesswell shannon has something to say about that02:19
lifelesshave to sample at twice the frequency you want to measure02:20
spmI think my head imploded trying to appreciate that; so I'll just go for the wise 'nod'02:23
lifelessso we need 12 hourly probes02:23
lifelesslooking for a run in the last 2402:23
lifelessactually thats not quite right02:26
lifelesswe want 12 hourly probes and an error message if we have two successive probes with no activity, we also need that when those long scripts take forever, we a) consider them as one group and b) report on activity as it goes02:27
LPCIBotProject devel build (100): STILL FAILING in 3 hr 28 min: https://hudson.wedontsleep.org/job/devel/100/02:39
LPCIBotLaunchpad Patch Queue Manager: [r=EdwinGrubbs][ui=none][bug 652007] Switch mlist-sync to use02:39
LPCIBotLaunchpadScript as its base.02:39
_mup_Bug #652007: scripts/mlist-sync.py should use LaunchpadScript as a base <mailing-lists> <oops> <Launchpad Registry:Fix Committed by sinzui> <https://launchpad.net/bugs/652007>02:39
wgrantHm.02:49
wgrantbin/kill-test-services is broken.02:49
wgrantThe librarian stuff has been changed.02:49
lifelessah fnord02:50
lifelessa) its untested02:50
lifelessb) its untested02:51
lifelessc) we should really move to the model I wrote up :)02:51
LPCIBotProject db-devel build (59): STILL FAILING in 3 hr 41 min: https://hudson.wedontsleep.org/job/db-devel/59/03:22
LPCIBotLaunchpad Patch Queue Manager: [testfix][rs=sinzui][ui=none] Resolved adapter conflicts in03:22
LPCIBotconfigure.zcml.03:22
sinzuispm: I want to move productreleasefinder to a separate script or run it in parallel. Half of those scripts do not need exclusive use of the database03:33
bacspiv:  the test suite has some known spurious tests and i think your branch got hit by them all.  :(04:17
spivbac: I'm a lucky guy!04:18
bacyep.  so i'm going to wade through the discussion and see where we are.  will land after things return to normalcy but will probably miss today's PQM deadline.  no big deal since this isn't a rush by any means.04:19
spivNo, clearly not :)04:21
spmsinzui: sure. probably as part of the current release? or maybe as a CP or something? I guess the only Q I'd have - did you have a particular time you wanted it to run within; or just leave it to us to try and pick a "not as busy" time?04:35
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
LPCIBotProject db-devel build (60): STILL FAILING in 1 hr 29 min: https://hudson.wedontsleep.org/job/db-devel/60/04:51
LPCIBot* Launchpad Patch Queue Manager: [rs=buildbot-poller] automatic merge from stable. Revisions: 11689,04:51
LPCIBot11690 included.04:51
LPCIBot* Launchpad Patch Queue Manager: [release-critical=edwingrubbs][rs=mwhudson][ui=none][no-qa] Rollback dropping of BranchRevision.id04:51
lifelessspm: deadrows still dead04:52
spmi think that's a lie; the logs suggest stuff is happening.04:54
lifelessso the scriptactivity check for it is wrong?04:54
spmoverly aggressive *atm*; probably04:54
lifelessI'll file a bug04:54
spmdunno if a spike in actions causing it to appear to fail or something funky04:54
lifelessif the script is running04:55
lifelessand scriptactivity is complaining, then our detection logic is flawed.04:55
spm(last seen 2010-10-06 07:33:51.715570) <== that worries me04:55
spmI know we've seen one script previously (don't recall which) that was working, to a point; and would then die. so stuff was happening but the magic record "I have finished successfully!" wasn't getting written.04:56
=== Ursinha is now known as Ursinha-afk
spmStevenK: ^^ can you offer any insights as to what/where/why we can look for what's up?04:57
mwhudsonyou can also have the fun where the outage causes so much work to build up that it takes longer than the check period to complete04:59
mwhudsonreally scriptactivity is pretty awful05:00
spmhttps://pastebin.canonical.com/38362/05:05
spmvis last current entry: 2010-10-08 02:58:28 INFO    Processing http://ppa.launchpad.net/mozillateam/ppa/ubuntu <== germanium05:05
spmso stuff is happening; but we're not getting completion.05:05
spm*successful* completion.05:06
mwhudsoncan you see when the currently running process started?05:06
spm~ 3.5 hours ago05:06
mwhudsonah05:09
mwhudsonso i think my guess seems likely05:09
spmhrm. maybe. I suspect there's more to it than that tho.05:09
spmthe current process, via the log, has been "stuck" for an hour.05:10
spmugh. there's whole bunches of oop's on germanium which aren't (apparently) on lp-oops05:11
spmbah. the oops themselves are on devpad tho05:13
spmeg /x/launchpad.net-logs/production/germanium/lp_publish/2010-10-06/85613.PPAPUBLISH85405:13
StevenKI wonder if they all are PoolOverwrite05:25
spmappear to be05:40
spmbased on the random 4 I've catted05:40
LPCIBotProject devel build (101): STILL FAILING in 3 hr 25 min: https://hudson.wedontsleep.org/job/devel/101/06:04
LPCIBotLaunchpad Patch Queue Manager: [r=danilo][ui=none][bug=652256] Adds a configuration link for06:04
LPCIBottranslations_usage on the product translations front page.06:04
LPCIBotProject db-devel build (61): STILL FAILING in 17 min: https://hudson.wedontsleep.org/job/db-devel/61/06:21
wgrantStevenK, spm: deathrow is failing with PoolOverwriteErrors?06:30
spmwgrant: not sure. something is failing with those errors; the oops isn't actually recording what script is doing the failing.06:31
wgrantAh, that would be p-d, then.06:31
wgrantpublish-distro, that is.06:32
wgrantAlthough those shouldn't be happening any more.06:32
* StevenK kicks Firefox and Thunderbird06:33
wgrantStevenK: Chromium! Evolution!06:33
StevenKwgrant: Evolution doesn't like IMAP mailboxes with >10,000 messages for me06:34
wgrantStevenK: Even in Maverick?06:34
wgrantIt was a bit bad in Lucid, but works OK in Maverick.06:34
StevenKEvolution still makes me twitch06:34
wgrant:(06:34
lifelessStevenK: Ever hacked on it ?06:37
StevenKlifeless: On Evolution? Nope06:39
lifelessdo so, *then* you'll have reason to twitch06:40
StevenKDon't make me look at the bad code06:40
lifelessits not 'bad'06:40
spmisn't this the place someone says "patches accepted"?06:42
lifelesslies06:42
spm*where* someone says. gah06:42
wgrantStevenK: i-d-s copies packagesets now, doesn't it?06:48
StevenKwgrant: Yes06:49
StevenKwgrant: I have a branch to limit which ones are copied, too06:50
wgrantStevenK: NewReleaseCycleProcess still says to copy them manually.06:50
wgrantAnd it suggests that -a will be needed to exclude disabled archs.06:50
wgrantBut I think that was CPd a couple of days back.06:50
StevenKYes, I know, I need to talk to Colin again06:50
wgrantOK, great.06:51
* wgrant gives the publisher a couple of good stabs.07:50
StevenKWhich tentacle are you trying to cut off?07:50
wgrantRefactoring the crap I was dealing with last night. Mostly Release generation.07:51
wgrantIt has this awesome reorder_components function, which looks safe enough (it creates a new list).07:51
wgrantBut of course it also calls .remove on the old list.07:51
wgrantSo it looks like it's going to be non-destructive to its input, but then completely obliterates it.07:52
wgrantHm, that's actually a bit interesting. It will have been mutating the publisher's internal config.07:53
wgrantSurprising that it works.07:53
wgrantEven better is that the tests don't care.07:56
=== almaisan-away is now known as al-maisan
wgrantbigjools: Morning. dogfood looks happy!09:03
bigjoolsmorning09:04
wgrantThe publisher tests do not whinge if you disable publication for non-Release pockets :(09:12
=== bigjools changed the topic of #launchpad-dev to: INCIDENT: process-death-row failing for PPA and Ubuntu || Launchpad Development Channel | Week 3 of 10.10 | PQM is Release-Critical (Release manager: EdwinGrubbs) | firefighting: stable has test failures | https:/​/​dev.launchpad.net/​ | Get the code: https:/​/​dev.launchpad.net/​Getting
=== bigjools changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 3 of 10.10 | PQM is Release-Critical (Release manager: EdwinGrubbs) | firefighting: stable has test failures, process-death-row failing for PPA and Ubuntu | https:/​/​dev.launchpad.net/​ | Get the code: https:/​/​dev.launchpad.net/​Getting
lifelessstub: are you going to be able to make the cassandra training? will you be staying for the end of the week ? [I'll stay for the 2 end days if you're going to stay, otherwise I'll just go for the 3 days training.09:41
lifelessstub: also, can tables be renamed in postgresql?09:41
stubI think I'm going for the 3 days training.09:41
stubYes, tables can be renamed in PostgreSQL09:41
jmlmwhudson: hi09:41
jmlmwhudson: only a little09:42
jmlmwhudson: I was a little surprised that the service wasn't written with Twisted09:42
lifelessstub: when will you know ?09:42
stubEarly next week - I need to ensure I can sort out paperwork and stuff earlier than expected.09:43
lifelessok09:43
lifelessI'll hold off booking for now09:43
lifelessdoing the extra 2 days experimenting with stuff for LP with you could be great.09:44
stubCome home via Bangkok ;)09:44
lifelessthe routing on that would be nuts I think, now that I'm in NZ09:45
pooliehello stub, jml, lifeless09:47
jmlpoolie: hi09:51
jmlpoolie: replying to some of your emails09:52
jmlpoolie: wrt your dkim branch... I don't think you should try too much harder to refactor that bit.09:52
jmlpoolie: I think someone should though. in a different branch.09:53
poolieyour reply about notifications the other day made my day09:53
jml:)09:54
spivbac: heh, a completely different failure this time09:56
bacspiv: well, that keeps things interesting...09:59
pooliejml we all seem to be pretty much in agreement then10:01
pooliei may put up a change10:01
pooliejust wondered if i was missing something10:01
wgrantspiv: Ah, you're trying to compete with my 6 unique failures for a single branch?10:01
spivwgrant: well, 2 from 2 tries so far.10:03
spivThis time it's a spurious windmill failure.10:03
spivLast time it was 4 (non-windmill) failures.10:04
pooliethis is really sweet10:09
pooliejust add "variations = [VaryByHttpClientImplementation()]" to a test class and it spans out10:09
pooliebetter than writing load_tests10:09
jmlpoolie: that is cool10:37
jmlpoolie: what does that?10:37
pooliehttp://bazaar.launchpad.net/~mbp/bzr/597791-http-tests/annotate/head:/bzrlib/tests/test_variations.py10:38
pooliejml, and http://bazaar.launchpad.net/~mbp/bzr/597791-http-tests/annotate/head:/bzrlib/tests/test_http.py10:38
pooliei may split/copy it into testtools10:38
jmlyeah.10:39
jmlfor some reason, testscenarios is a separate project10:39
poolieoh, or testscenarios10:40
pooliehard to keep up10:40
poolieand testfixtures is another one again i think10:40
jmlyeah10:41
jml"do one thing and do it well" vs "make it easy to find, discover & maintain these things"10:43
jmlI guess if I had more energy I'd try to come up with a good over-arching name for the project of high quality testing tools for Python10:45
jmland then make a cool website and stuff10:45
lifelesspoolie: I'd love a patch for testscenarios to do that10:59
poolieyeah, it's a funny thing10:59
lifelessjml: tip ? :P10:59
poolieactivation energy to do and test it in another library, and to bump the dependency10:59
pooliehow about if you review it here and if we're happy, i'll move it11:00
poolieis the general plan to copy or to move?11:00
lifelessI don't think bzr uses testscenarios itself, yet.11:00
lifelesswill chat more next week; gnight.11:00
jmlg'night.11:01
=== al-maisan is now known as almaisan-away
=== bigjools changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 3 of 10.10 | PQM is Release-Critical (Release manager: EdwinGrubbs) | firefighting: stable has test failures | https:/​/​dev.launchpad.net/​ | Get the code: https:/​/​dev.launchpad.net/​Getting
=== matsubara-afk is now known as matsubara
=== almaisan-away is now known as al-maisan
jmlif we wanted to have future distroseries for Ubuntu open on Launchpad so that people could assign bugs to those future distroseries, what would we need to do?14:08
wgrantIt should mostly work now.14:09
=== Ursinha-afk is now known as Ursinha
wgrant(I talked about this a bit with cjwatson earlier)14:09
wgrantWe can have a new series set to Experimental, and it will happily coexist uninitalised.14:10
jmlhmm.14:10
wgrantI think all uploads will be held in NEW. Perhaps they should be rejected.14:10
wgrant(until a couple of months back it would have caused publisher carnage, but that was fixed)14:11
jmlArguably that should be independent of the series status14:11
jmlright, but maybe code other than the publisher will break if we start doing that14:11
jmlalso, "Experimental" isn't such a great status for Natty14:12
wgrantIt's not, no.14:12
sinzuijml: I agree with wgrant. We can do it now, but it will not be open for building and translations.14:12
wgrantOh, there's also Future.14:13
wgrantForgot about that status.14:13
jmlthat's a much more appropriate status14:13
jmlwho would have permission to try an experiment on staging?14:14
jml(I know staging isn't up right now)14:14
jmland by permission I mean computer permisson14:14
wgrantIt's possible that ~ubuntu-drivers could do it, but it may well need an ~admin.14:14
jmlI'm surrounded by people who have the authority to do so :)14:14
wgrant(I'm not sure I've ever seen Future used outside Debian)14:15
wgrant(so it may not even be exposed in the UI)14:15
jmlright14:15
wgrantYeah, it needs an admin.14:16
jmlso "mostly work" might be more accurately phrased "doesn't work"14:16
wgrantWell, Experimental would work fine.14:16
wgrantGr no staging.14:17
jmlanother question, when is the psycopg problem going to be fixed so I can upgrade in peace?14:17
sinzuijml: the bug was marked fixed a few days ago14:18
jmlsinzui: what do I have to do to get the fix?14:18
wgrantIt's not fixed..14:19
wgrantlaunchpad-dependencies depends on the old version.14:19
sinzuimaybe wait for deps to update14:19
jmlwgrant: yeah, that's what I mean :)14:19
wgrantForcing installation of the old version is not a fix. It breaks upgrades and introduces all sorts of madness.14:20
wgrantThe real fix is inhibited by an argument over who is at fault.14:20
wgrantsinzui: I can't view bug listings at all for a distro that doesn't use Launchpad Bugs. Is this intentional?14:23
wgrantNot even +bugs works.14:23
sinzuiwgrant,  not exactly. I expected hacking the url to work14:24
wgrantjml: Release nominations work as expected for Experimental and Future series.14:24
jmlwgrant: thanks.14:25
jmlwgrant: I'm just mucking around on a launchpad.dev instance now14:25
jmlI notice that we can't register a series as "Future". It seems to default to Experimental, but I'm not sure why that is.14:25
sinzuijml: there are some old rules about the status of a new series and how it can progress through the status14:26
wgrantHah, newSeries does, yes. How very odd.14:26
jmlsinzui: that makes me want to ask a bunch of questions:14:27
jmlsinzui: 1. what are these rules?14:27
jmlsinzui: 2. are these rules still appropriate? what was the justification for them?14:27
wgrantSome of the rules are still critical to Soyuz operation.14:27
jmlsinzui: 3. why are these rules not obvious on the series registration page?14:27
wgrantThe one about starting in Experimental... not so much.14:27
sinzuithe exist to ensure you cannot accidental move an ubuntu series back in status. If you make a mistake, god speed, find a losa and hack the db!14:27
jmlwgrant: it would be nice to decouple soyuz operation and distroseries status, I think14:28
wgrantjml: Probably.14:28
wgrantWe need a tristate column to control the state of the RELEASE pocket, mainly.14:29
sinzuijml, wgrant Only losas are creating series. Drivers cannot update the statues. We reply on a losas to do this. This is an Ubuntu exception14:29
jmlsinzui: I don't understand... how can rules about the status of a *new* series prevent accidentally moving a series back in status14:29
jmlsinzui: why are only losas allowed to create series?14:29
wgrantBecause they can seriously break Soyuz if done badly.14:29
sinzuiUbuntu wants it that way14:29
jmlsinzui: pretend they don't.14:29
sinzuiI send an email to several people asking why this is14:29
sinzuibdmurray, deduced the issue is that Ubuntu made its driver team the owners. There are too many untrusted people who would have permission to create series14:30
jmlsinzui: where is this documented?14:31
sinzuibdmurray, sent an email last month explaining the issue and suggested that Ubuntu have an separate owner team14:31
jmlsinzui: how would I have found out about this if you were asleep?14:31
sinzuijml: There is a bug about this. I have sent many emails to the Lp list overt the last two years. mdz also asks about what a driver can do (Ubuntu driver team or driver role?), and the Ubuntu council is where the recent emails were14:32
wgrant(there is one thing that ~ubuntu-drivers can (but shouldn't be able to) do that nobody has mentioned yet)14:33
sinzuijml: bug 17437514:34
_mup_Bug #174375: Distribution drivers permissions may need redesign <Launchpad Registry:Triaged> <ubuntu-community:Confirmed for techboard> <https://launchpad.net/bugs/174375>14:34
jmlwgrant: which is?14:35
wgrantjml: Well, check the owner of the Ubuntu primary archive...14:35
wgrantAnd weep.14:35
jmlwgrant: I don't know how to do that.14:36
wgrantWell, it's ~ubuntu-drivers.14:36
wgrantSo they can copy stuff in and probably add permissions.14:36
wgrant(just noticed this now; it's not really related to the distribution.driver field, besides being the same team)14:37
jmldo I have to bug a losa if I want to experiment on staging?14:39
Chexjml: if you mean working on the servers behind the web-interface of staging, then yes, through us14:40
jmlChex: in this particular context I mean creating a new series of Ubuntu14:41
jmlonce staging has restored itself to its usual glory, of course14:41
wgrantIt has been down for hours... I fear that it will not.14:41
jmloh. pity.14:41
wgrantI am hopeful that it's because someone is secretly setting up qastaging.14:42
wgrantBut I doubt it.14:42
sinzuiChex, wgrant, jml: Edwin reported that staging has been down now for at least 12 hours14:49
sinzuiChex, is staging stuck?14:49
* sinzui has qa to do on staging14:49
dobeyhey abentley15:33
abentleydobey: hey.15:34
dobeyhow's it going?15:34
abentleydobey: alright.  Yourself?15:34
dobeypretty good15:34
dobeyany luck with the branch scanning db issue?15:35
sinzuidoes any one have power to moderate launchpad-feedback? flacoste?15:35
flacostesinzui: i have15:35
flacostesinzui: i'll take care of it15:35
sinzuithanks15:35
abentleydobey: I am waiting for Chex to tell me what the procedure is to reinstate the needed db permissions.15:36
dobeyabentley: ok15:37
=== salgado is now known as salgado-lunch
abentleydobey: the fix will be permanent when we do our next rollout, but I'm trying to get it reinstated now.15:38
bigjoolsjml: what do you think about this: http://bazaar.launchpad.net/~julian-edwards/launchpad/builderslave-resume/revision/1166115:39
dobeyabentley: ok. i'm just asking about it constantly because tarmac requires metadata from the LP API that is only available when rescan succeeds, and we have some u1 branches that are not getting rescanned properly15:40
jmlbigjools: the comment and the logic look ok. I'm surprised that transaction.commit() doesn't do the reset though15:41
abentleydobey: I understand that you need it.  I think it's unacceptable that it's breaking, but I don't have the power to fix it myself.15:41
jmlbigjools: also, I need to talk about packagesets15:42
jmlbut maybe that's Monday15:42
flacostesinzui: done, there were 3 messages not spam15:42
bigjoolsjml: the tests pass... not sure what else to say about it15:42
bigjoolsjml: when would you like to talk about packagesets?15:42
bigjoolsoh Monday15:42
jmlbigjools: what does write_transaction do that's different to transaction.commit()?15:43
bigjoolsI think the firefighting this week has made me blind15:43
dobeyabentley: understandable15:43
bigjoolsjml: the decorator is itself decorated with the reset_store one15:43
sinzuithanks flacoste15:43
jmlI'm pretty sure I have more grey hairs today than I did Monday.15:43
jmlbigjools: ahh, ok.15:43
bigjoolsjml: which is a little nasty for partial commits15:44
jmlbigjools: yeah15:44
* bigjools now intrepidly steps forward into the buildd-slavescanner.txt wilderness15:45
jmlbigjools: perhaps write_transaction shouldn't have the reset_store decorator, and the librarian should have reset_store explicitly on methods that currently have write_transaction15:45
bigjoolsjml: yeah I did raise that with gary_poster, I think it warranted some careful testing to see if that reset is still needed, since it might be a hangover from sqlobject15:46
gary_posteryes, removing that is a bit of a big deal15:47
gary_postersince we also do that for transactions15:47
gary_posterin the webapp15:47
gary_posterLandscape doesn't reset store15:47
bigjoolsinteresting15:47
gary_posterBut it's been like this for us for so long that I'm afraid that we might rely on it15:48
bigjoolsI wonder how much of this stuff is slowing us down15:48
jmlbigjools: but what I'm saying is that we don't have to worry about that15:48
gary_posterso changing it would be one of those "who knows what will fall over when we switch it on"15:48
jmlbigjools: we split it off write_transaction, and then change the places where write_transaction is used so that it uses reset_store explicitly15:48
bigjoolsgary_poster: indeed!15:48
jmlabsolutely 0 risk.15:48
bigjoolsjml: yes, it's only used in one other place15:49
gary_posterbut then we expose something that has untested semantics?15:49
gary_postersorry, I had a nick ping, but am not really fully in context yet15:49
gary_posterIOW, why do we want to remove it out of write_transaction, if we are worried it might be necessary in write_transaction?15:50
bigjoolsgary_poster: 'tis ok, it's not urgent by any means, and jml is talking about something different.  But I reckon we should spend some time examining if the reset is needed at some point.15:50
gary_postercompletely agree15:50
gary_posterI've wondered about that since I started, actually15:51
gary_poster(ish ;-) )15:51
bigjoolsgary_poster: it may have been needed by the sqlobject compat layer, I wonder if jamesh would know15:53
gary_posterhe did15:53
gary_posterhe told me that it was15:54
bigjoolsaha15:54
gary_posterso like I said, we probably don't need it15:54
gary_posterexcept that it may be a pervasive, underlying assumption for some of our code now15:54
bigjoolsright15:54
bigjoolsyeah :(15:54
bigjoolsbut our 100% test coverage would root that out!15:55
* bigjools runs15:55
gary_poster:-)15:55
sinzuihenninge, noodles775: have you discussed UI review graduation15:58
henningesinzui: no and noodles775 is not my mentor ... ;)15:59
sinzuihenninge, thanks, sorry about my incompetence.15:59
henningesinzui: np15:59
noodles775:)16:12
=== salgado-lunch is now known as salgado
=== Ursinha is now known as Ursinha-lunch
rockstarEdwin-afk, ping16:41
jcsackettsinzui: you encountered oddities with metal:head_epilogue and conditional content, right? specifically the condition being ignored and it always being there?16:44
sinzuibac did16:45
jcsackettah. do you remember what he did to get around that?16:46
jcsackettalternatively: bac? you still around?16:46
* sinzui checks pastebin16:46
sinzuijcsackett, http://pastebin.ubuntu.com/507152/16:47
jcsackettsinzui: thanks.16:51
=== Ursinha-lunch is now known as Ursinha
=== benji is now known as benji-lunch
=== gary_poster is now known as gary-lunch
=== matsubara is now known as matsubara-lunch
=== al-maisan is now known as almaisan-away
dobeyabentley: still around?18:02
abentleydobey: yes.18:02
dobeyabentley: so it looks like Chex did the patch, but am still seeing a couple branches (that were already pushed), waiting to be rescanned. any ideas on how to get them to 'finish' the rescan?18:04
abentleydobey: Yes, the branches need to be write-locked and unlocked to generate a new scan job.  Pushing to them should do the trick, or I can do a manual thing.18:05
dobeyabentley: can you do the manual thing? the owner of the two branches i'm looking at isn't around, so i can't ask him to repush at the moment18:06
abentleydobey: sure.  What branches?18:06
dobeyhttps://code.edge.launchpad.net/~rodrigo-moya/libubuntuone/dont-depend-on-gconf18:06
dobeyhttps://code.edge.launchpad.net/~rodrigo-moya/ubuntuone-client/dont-use-dialog-vbox18:06
dobeythose two18:06
abentleydobey: okay, those should get scanned in the next minute.18:09
dobeyabentley: great. thanks much!18:09
abentleydobey: you're welcome.  Sorry for the glitch.18:10
=== benji-lunch is now known as benji
marsA good Friday laugh: http://people.canonical.com/~mars/performance.png :)18:34
bigjoolsI feel like the guy at the bottom this week18:35
marslol18:35
=== gary-lunch is now known as gary_poster
bigjoolsg'night all18:37
marsgood night bigjools18:37
gary_postersinzui: I'm trying to figure out an immediate way to help Darwin @ https://answers.edge.launchpad.net/launchpad-foundations/+question/128430 .  I was going to suggest that he merge his accounts (pointing to https://help.launchpad.net/YourAccount/Merging).18:56
gary_posterHowever, to do that without screwing up his PPA he would need to log into his primary account.  I could suggest merging his account to the secondary account, and then changing his name for him back to his primary account.18:56
gary_posterThoughts or ideas?18:56
gary_posterAlternatively, I could try to construct SQL to try to figure out what is going on and ask the LOSAs to run it, but that's going to be such an expensive flail that I was hoping there would be another way18:56
sinzuigary_poster, The reverse merge and rename is viable. I have suggested it to users as well.18:57
gary_posterok thanks sinzui.  I'll give it a whirl, and hope stub can investigate the underlying problem18:57
sinzuigary_poster, deleting a PPA is very destructive, you cannot get it back...the name is taken forever18:57
gary_postersinzui: does that mean that the reverse merge/rename is dead for him?18:58
gary_poster(cause he has a PPA in the primary account)18:58
sinzuiWe cannot rename someone with a PPA. It must be deleted first18:58
sinzuiI do not think you can merge a profile with a PPA18:59
gary_poster:-(18:59
gary_posterSo not an option18:59
gary_posterSo DB fiddling is the only real option18:59
sinzuigary_poster, are the account ids wrong/switched?18:59
gary_posterhe doesn't have access to his primary account anymore.  He reports that he tried a password reset and never got an email back.  Unless something is seriously hosed in the LP database, that's probably what I need him to do.19:01
gary_poster(I mean, work with ISD to get the password reset working for him)19:01
sinzuigary_poster, did the user delete an email address on his baudm profile19:01
gary_postersinzui: he didn't report doing so, but I don't see how he could be where we are without doing so19:02
gary_poster(I have not asked, but would be happy to if you thought it were worthwhile)19:02
sinzuipassword reset is automatic from a form. it sends it to your email address. Follow the link and you are done.19:02
gary_posterhe says he didn't get the email19:02
gary_posterI'll pursue that19:03
flacostegary_poster: do you know if stub qa-ed rev 9762?19:03
gary_posternot by number :-) looking...19:03
flacostegary_poster: see https://devpad.canonical.com/~lpqateam/qa_reports/deployment-db-stable.html19:03
gary_posterk19:03
flacostewe are now on 988019:03
=== salgado is now known as salgado-physio
cr3when should an interface inherit from another interface or the model implement that interface?19:07
cr3for example, the Product class implements IHasLogo and the IProduct interface inherits from IHasLogo too19:09
gary_posterit's a semantic question cr3.  If an interface semantically subsumes another interfaces, it should inherit.  OTOH, if a class happens to implement two semantically different interfaces, the interfaces themselves should not inherit19:12
gary_posterflacoste: what you see is an instance of bug 640566.  The old bug was added into the mix erroneously.  The new revision was in fact QAd according to the other bug: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/64497519:13
_mup_Bug #640566: qa-tagger should not consider linked bugs to branches when bugs are already Fix Released <new-merge-workflow> <qa-tagger:In Progress by ursinha> <https://launchpad.net/bugs/640566>19:13
_mup_Bug #644975: Export OpenIdIdentifier to Canonical SSO <qa-ok> <Canonical SSO provider:New> <Launchpad Foundations:Fix Committed by stub> <https://launchpad.net/bugs/644975>19:13
gary_posterI am determining with Ursinha now what we should do practically about that old bug19:14
=== matsubara-lunch is now known as matsubara
cr3gary_poster: in the case of IHasLogo though, if the IProduct interface already inherits from IHasLogo, does it make semantic sense for the Product implementation to explicitly call implements for the IHasLogo interface, shouldn't it be implied by calling implements for the IProduct interface?19:14
flacostegary_poster: ah, ok, that means the report isn't useful at this stage then19:14
flacostegary_poster: to determine which revision can be rolled out19:14
Ursinhaflacoste, this kind of situation is an exception19:14
gary_posterflacoste: correct, when people use the same branch repeatedly, it falls over until that bug is fixed19:15
flacostewhich is common in our team at this stage19:15
gary_posterflacoste: I'm going to mark that qa-ok, on Ursinha's suggestion19:15
flacostestub, lifeless and others do this19:15
flacosteok19:15
flacostestaging is down btw19:15
flacostewe are stuck on a replication error19:15
gary_posterThey are the only two AFAIK, but in any case Ursinha is working on it19:15
flacosteI've been known to reuse branches also19:15
flacostenot that i'm a big commiters anymore19:16
gary_poster:-)19:16
gary_posterok report should be happy again next time it runs19:16
gary_posterflacoste: staging replication error: my only remediation options are to ask LOSAs to review the kinds of things stub have asked them to review in the past, or wake up stub, or send stub an email.  My inclination is to send stub an email, since I assume LOSAs have already done "the usual" whatever that is.  Agree/disagree?19:18
flacostegary_poster: it also means that it's likely that we won't have an estimate the time the DB upgrade take19:19
gary_posterflacoste: yes19:19
flacosteChex: have you gone through the usual slony debug checklist?19:19
Ursinhagary_poster, flacoste, it's updated now: https://devpad.canonical.com/~lpqateam/qa_reports/deployment-db-stable.html19:22
gary_posterThanks Ursinha19:23
flacosteUrsinha: do we have a bug to include the revision until tip?19:24
flacosteUrsinha: for example, on https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html, i have no idea how many revisions follow that not-qaed revision19:25
flacosteif it's only 1, it's not the same things as if there are 10 other revisions after that19:25
Ursinhaflacoste, no, there's not19:25
Ursinhamakes sense19:25
flacostei'll file one19:25
flacostewhat project?19:25
Ursinhaflacoste, qa-tagger19:25
gary_posterUrsinha: I was pretty sure that these are shown19:30
gary_posterBut maybe I misremember :-/19:31
Ursinhagary_poster, iirc they were never there19:31
Ursinhamars knows better19:31
flacosteUrsinha: bugs 65712 and 65701519:31
gary_posterUrsinha: ok, you would probably know :-) .19:31
flacostebug 65701219:31
_mup_Bug #657012: Display the revision number of tip on the report <qa-tagger:New> <https://launchpad.net/bugs/657012>19:31
flacosteand bug 65701519:32
_mup_Bug #657015: Deployable revisions report should go until tip <qa-tagger:New> <https://launchpad.net/bugs/657015>19:32
marsUrsinha, ? reading backscroll19:32
marsAh, yes.  Ursinha, they are included in the fake report but the real application does not produce them19:34
Ursinhathanks flacoste19:41
Ursinhaand mars19:41
sinzuigary_poster, I updated the bug. We should request a losa to try a merge from edge to see if it fixes the users login issue19:46
gary_posterI was just reading your reply sinzui, thank you.  OK, I'll try that.19:47
gary_postersinzui: djclue917 got an email address when he used that email address again, somehow, I think.19:48
gary_posteroh, duh, you said this19:48
sinzuilogin is so very confusing that I cannot remember what I say about it either19:49
sinzuigary_poster, since the address is not preferred, I wonder if it is possible that the address was taken from the Lp profile...Lp profile -> 3 addresses, but two accounts with different email addresses.19:51
gary_postersinzui: does the lock on this page show that the email address is preferred now? https://edge.launchpad.net/~djclue91719:55
sinzuiThe lock means it is hidden.19:55
gary_posteroh ok19:55
sinzuigary_poster, you have demi-god powers to see it19:55
gary_postergo, me!19:55
marsgary_poster or benji, API question for you: do you know what happens if you log in twice, passing different parameters to allow_access_levels?20:06
marslogin_with(allow_access_levels=["READ_PUBLIC", "READ_PRIVATE"])20:06
marsthen, log in again with: login_with(allow_access_levels=["READ_PUBLIC", "WRITE_PUBLIC"])20:07
benjimars: I don't know definitively, but my strong suspiction would be taht the second superceeds the first20:07
gary_posternot offhand, mars.  if benji doesn't, can look around.20:07
gary_posterwell, I'd hope so, but that doesn't mean it's so :-)20:07
marsbenji, by supercedes, do you mean it will ask you to authorize the application again?20:07
marssince you changed the token's authorization20:08
* gary_poster hopes so20:08
marsyes, that is what I suspected20:08
gary_posterhave you tried, mars?  that's what I'd do, with staging, since we are coming up empty20:08
marsgary_poster, not yet, will do so.  benji, gary_poster, thanks for the help20:09
gary_postersuch as it was, in my case :-)20:09
benjimars: yep, that is my expecation (and hope)20:10
rockstarabentley, you know what would be cool?  A pump command that could work while I'm in the pipe I want changes to get pumped to.20:12
abentleyrockstar: yeah, I sometimes want that.20:17
abentleyrockstar: I think you can abuse pump --from-submit for that, but that will also apply any changes from the submit branch.20:19
rockstarabentley, yeah, and then we get weird criss-cross merges too.  I always have to be careful with that.  :)20:20
abentleyrockstar: err, --from-submit will rarely give you criss-cross.20:21
abentleyrockstar: only if, say, you submit your first pipe, then merge & commit, then merge again after the pipe lands.20:22
marsgary_poster, do you remember the conditions under which a staging code update happens?20:25
marsI am looking at the graphs and there appears to be no regular pattern there20:25
gary_postermars, I think code updates happen as soon as a new revision is available, as checked by some time-regular cron-like thing; and db updates are on the weekend20:26
marsgary_poster, ok, thanks.  I'll just say 'is down regularly'20:26
james_wmars, I don't think it asks you to reauth20:26
james_wmars, I think you just get 403 if you now want to do something that you didn't ask for permission for earlier20:27
marsjames_w, when escalating or dropping permissions?20:27
marsah20:27
james_wmars, neither way does anything to existing tokens I don't think20:27
marsok.  Thanks james_w20:27
james_wdropping is clearly not going to cause functional issues20:27
=== salgado-physio is now known as salgado
james_wI may be wrong though, but I think that allow_access_levels is just sent to launchpad in the GET request to +authorize-token20:28
benjigary_poster: on a freshly installed kubunto machine plus apt-get install python-keyring-kwallet I get "OSError: can't get access to dbus" when trying to store a password21:21
gary_posterbah21:22
gary_posterbenji, sounds like it's time to trash keyring with prejudice21:22
benjiI concur.21:23
gary_postercool, go for it21:24
james_wwith what in preference?21:25
benjigary_poster: do you want me to whip up a KWallet integration to go with our Gnome keyring support or go with what we have until the time comes?21:25
dobeywhy is the prerequisite on a merge proposal a link to a branch, and not a merge proposal?21:25
gary_posterbenji: assuming KWallet integration is on the order of half a day to a day, go for it21:26
benjisounds good21:26
gary_postercool21:26
dobeygary_poster, benji: if this is in Python, which I presume it is, why not use python-keyring?21:26
gary_posterdobey: that's exactly what we are talking about.  We've encountered several annoyances with it.  The straw that broke the camels back was that it doesn't seem to work on Kubuntu, which, other than Ubuntu/Gnome, is the other keyring that we care about.21:27
james_whave you filed a bug?21:28
benjijames_w: not yet, but it's on my list21:29
dobeygary_poster: that's odd21:29
gary_posterdobey: "why is the prerequisite on a merge proposal a link to a branch, and not a merge proposal?" I don't understand why it would be a merge proposal, so I don't understand your perspective yet21:30
rockstarabentley, shall we have our standing up?21:32
dobeygary_poster: so we just ran into, and i filed bug #657038 with tarmac. and i'm working on a fix to tarmac to deal with it, but it doesn't seem like prerequisites work the optimal way for that. it seems like i would want to specify a merge proposal, because i am requiring the prerequisite to be merged into its target, before my proposal can land.21:32
_mup_Bug #657038: Branches with prerequisites can land without prerequisite having landed <Tarmac:In Progress by dobey> <https://launchpad.net/bugs/657038>21:32
abentleyrockstar: sure.21:32
dobeygary_poster: and since a branch can have many proposals with different targets associated, there is no easy way to determine what the developer meant by specifying a prerequisite21:33
gary_posterdobey, ah I see.  AFAIK, prerequisites are only about presenting diffs from LP's perspective.  I can see why you would want that, and I expect the difference simply comes from the fact that the prerequisites weren't originally envisioned for that use case.21:35
dobeygary_poster: so total usability fail then :)21:36
gary_posterfor this use case, yes, sounds like it21:37
dobeywell for both use cases21:37
dobeybecause in the "show a different diff on LP" case, the diff doesn't necessarily show what will actually land21:37
gary_posterMPs weren't made for tarmac21:40
dobeyignoring tarmac21:40
dobeyif LP is showing a diff based on the prerequisite, and that proposal is approved/landed before the prerequisite, it might actually result in code being landed that wasn't shown in the diff, or finished being reviewed21:41
gary_poster(not that I don't think tarmac ought to be a driver, actually)21:41
gary_posterapproved out-of-order is fine, and even nice to have IME.  Comes in handy for trivial branches after big honking branches.21:45
gary_posterBut anyway, I see your point.21:45
gary_posterMake a bug. See where it goes. :-)21:45
dobeywell, it's good if the "trivial" branch doesn't also include the changes from the "big honking" branch. but if it doesn't, then there probably isn't much need for specifiying a prerequisite :)21:47
gary_posterit did21:47
gary_posterthey did21:47
dobeyas it is now though, there's no easy way to implement a check to ensure that the 'big honking branch' lands first, to avoid having the 'trivial branch' land with unapproved code21:49
dobeyno?21:49
brycehI've been getting spurious warnings about LPModerate and XMLRPCRunner import errors - I am guessing I need to have something installed that isn't?  (This is lucid, dist-updated to current, with db-devel head)  http://pastebin.ubuntu.com/509048/21:50
gary_posterdobey, right, which is the use case that tarmac has that I didn't have when I was doing things manually.  MPs were a way of social communication for me, rather than a mechanism for enforcement and automation, and I think that's how they started in vision.  I landed things myself, as it was appropriate to do so.  But anyway, like I said, file a bug!21:54
dobeyyeah i will21:55
gary_posterbryceh: smells like Mailman failed to build to me.  Possible?21:55
brycehgary_poster, it's set to the stock defaults, I've not touched it in any way... does it require configuration for launchpad?21:56
gary_posterbryceh: I mean, the mailman that launchpad builds itself in the Make21:56
gary_posternot system mailman21:57
brycehoh, well I notice in the db-devel bzr log there's been some changes to it, but I've not made any changes21:57
gary_posterbryceh: did you look at the output of make when you built this branch?  If not, try make clean && make, and see if it seems ok21:59
gary_posterif so, retry tests21:59
brycehok21:59
* gary_poster hopes it will then work, because he hasn't seen this problem21:59
brycehmuch better, thanks gary!22:05
gary_posteryay, bryceh :-)22:05
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
=== matsubara-afk is now known as matsubara
=== matsubara is now known as matsubara-afk
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!