| === bac changed the topic of #launchpad-reviews to: On call: - || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | Hi I'm on-call now. bring out your reviews... | 04:01 |
|---|---|---|
| StevenK | Except you set yourself as the branch being reviewed, not who is on-call | 04:05 |
| bac | StevenK: yeah, well... | 04:15 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | more happy StevenK? :) | 04:15 |
| StevenK | Heh, slightly. :-) | 04:29 |
| wgrant | I feel timezone-confused. | 04:32 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| bac | why is that wgrant? | 05:06 |
| === bac changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | hi bigjools | 11:40 |
| bigjools | hey bac | 11:40 |
| bac | bigjools: did you verify your def-row db query change on the live db? | 11:40 |
| bac | it looks good to me... | 11:41 |
| bigjools | bac: it's already cowboyed, so yes :) | 11:41 |
| bac | :) | 11:41 |
| bac | alrighty | 11:41 |
| * bigjools is doing two CP MPs at the moment :/ | 11:41 | |
| === matsubara-afk is now known as matsubara | ||
| === Ursinha-afk is now known as Ursinha | ||
| jcsackett | anyone available to review a 93 line MP? https://code.edge.launchpad.net/~jcsackett/launchpad/mirrors-tell-where-they-live-652134/+merge/37925 | 14:59 |
| === salgado is now known as salgado-lunch | ||
| allenap | jcsackett: I'll do it. Can you review one of mine? | 15:48 |
| jcsackett | allenap: i am not a reviewer yet. :-P | 15:49 |
| allenap | jcsackett: Drat! You get this one for free then :) | 15:49 |
| jcsackett | thanks allenap. i'll owe you one in november when i start the reviewing thing. :-) | 15:50 |
| sinzui | allenap, I can review | 16:16 |
| allenap | sinzui: Woohoo, thanks :) | 16:17 |
| allenap | sinzui: You have probably found it already, but if not: https://code.edge.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823/+merge/37976 | 16:17 |
| sinzui | allenap, I see metal:use-macro="view/macro:page/main_side", but this template does not use the side. Is the intent to add navigation to see other listings such as indirect bug subscriptions or blueprints? | 16:33 |
| allenap | sinzui: I don't know if that's the intent, but it can be changed back later. I'll switch to main_only. | 16:34 |
| === salgado-lunch is now known as salgado | ||
| sinzui | okay | 16:34 |
| sinzui | r=me. This branch does make the code clearer. | 16:35 |
| allenap | sinzui: Thanks. | 16:39 |
| === Ursinha is now known as Ursinha-lunch | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === benji is now known as benji-lunch | ||
| === gary_poster is now known as gary-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === benji-lunch is now known as benji | ||
| === gary-lunch is now known as gary_poster | ||
| === salgado is now known as salgado-physio | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-physio is now known as salgado | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| === matsubara-afk is now known as matsubara | ||
| === matsubara is now known as matsubara-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!