=== bac changed the topic of #launchpad-reviews to: On call: - || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [04:01] Hi I'm on-call now. bring out your reviews... [04:05] Except you set yourself as the branch being reviewed, not who is on-call [04:15] StevenK: yeah, well... === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [04:15] more happy StevenK? :) [04:29] Heh, slightly. :-) [04:32] I feel timezone-confused. === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk [05:06] why is that wgrant? === bac changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:40] hi bigjools [11:40] hey bac [11:40] bigjools: did you verify your def-row db query change on the live db? [11:41] it looks good to me... [11:41] bac: it's already cowboyed, so yes :) [11:41] :) [11:41] alrighty [11:41] * bigjools is doing two CP MPs at the moment :/ === matsubara-afk is now known as matsubara === Ursinha-afk is now known as Ursinha [14:59] anyone available to review a 93 line MP? https://code.edge.launchpad.net/~jcsackett/launchpad/mirrors-tell-where-they-live-652134/+merge/37925 === salgado is now known as salgado-lunch [15:48] jcsackett: I'll do it. Can you review one of mine? [15:49] allenap: i am not a reviewer yet. :-P [15:49] jcsackett: Drat! You get this one for free then :) [15:50] thanks allenap. i'll owe you one in november when i start the reviewing thing. :-) [16:16] allenap, I can review [16:17] sinzui: Woohoo, thanks :) [16:17] sinzui: You have probably found it already, but if not: https://code.edge.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823/+merge/37976 [16:33] allenap, I see metal:use-macro="view/macro:page/main_side", but this template does not use the side. Is the intent to add navigation to see other listings such as indirect bug subscriptions or blueprints? [16:34] sinzui: I don't know if that's the intent, but it can be changed back later. I'll switch to main_only. === salgado-lunch is now known as salgado [16:34] okay [16:35] r=me. This branch does make the code clearer. [16:39] sinzui: Thanks. === Ursinha is now known as Ursinha-lunch === Ursinha-lunch is now known as Ursinha === benji is now known as benji-lunch === gary_poster is now known as gary-lunch === matsubara is now known as matsubara-lunch === benji-lunch is now known as benji === gary-lunch is now known as gary_poster === salgado is now known as salgado-physio === matsubara-lunch is now known as matsubara === salgado-physio is now known as salgado === salgado is now known as salgado-afk === matsubara is now known as matsubara-afk === matsubara-afk is now known as matsubara === matsubara is now known as matsubara-afk === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha