[03:19] <bac> hi jtv
[03:20] <bac> jtv: i'm answering your review.  the reason i made 'target' and 'naked_translatable' properties was so i could have the base class show them with a NotImplementedError, which I thought was more explicit than just a comment stating they are expected to be provided by subclasses.  Overkill?
[04:18] <lifeless> bac: I think that that is ok, but of questionable value
[04:18] <bac> lifeless: yeah, i gutted it
[04:18] <lifeless> bac: just a ':ivar target: ....' in the class docstring is enough IMO
[06:28] <jtv> bac: does bzr lp-send make you write good cover letters somehow?
=== jtv changed the topic of #launchpad-reviews to: On call: jtv || Reviewing: - || queue: []  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[07:39] <bac> jtv: what are you asking wrt lp-send?
[07:40] <jtv> bac: well I said your cover letter was good, and you replied that it was something to do with bzr lp-send.
[07:40] <bac> jtv: well, lp-send, if you have the right plugins installed, creates the nice template.  but you knew that, right?
[07:41] <jtv> no, I had no idea.
[07:41] <jtv> Could you show me?
[07:41] <bac> now the quality of the text inserted is up to the user
[07:41] <jtv> Of course.
[07:41] <jtv> But a template would help.  I'm just looking at another MP that skips such things as tests, lint, and pre-imp.
[07:42] <jtv> bac: how do I set up lp-send?
[07:42] <bac> jtv: http://pastebin.ubuntu.com/512173/
[07:42] <bac> i *think* lpreview and lpreview_body are required
[07:42] <bac> lp:lpreview-body, i think
[07:43] <jtv> I just created the lpreview link… where do I get lpreview-body?
[07:43] <bac> i thought this was common knowledge
[07:43] <bac> ^^
[07:43] <bac> bzr lp:lpreview-body lpreview_body
[07:43] <bac> er, put a 'get' in there
[07:44] <jtv> Perhaps it is.  But I'm always a thousand emails behind and there are no reviewer meetings timed well for this part of the world.
[07:44] <bac> this is all abentley's work from ages ago, i think
[07:44] <bac> jtv: don't i know it!  :(
[07:44] <bac> 7am is too early for you?
[07:44] <jtv> bac: yes, that's about 2 hours before I start.
[07:45] <bac> so if i sleep late i shouldn't count on you to cover me?
[07:45] <jtv> I could get up earlier, but that comes out of overlap with my team
[07:45] <bac> between the chickens and the time adjustment i am up plenty early
[07:45] <jtv> bac: probably not… it's worth trying, but last night I gave up trying to get help for staging around 02:00 AM.
[07:46] <jtv> You can imagine what that does to the early rising
[07:53] <bac> jtv: i look forward to reading your next merge proposal
[07:53] <jtv> :)
=== jtv is now known as jtv-afk
=== jtv-afk is now known as jtv
=== jtv changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: []  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha-afk is now known as Ursinha
=== allenap changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:01] <flacoste> me
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-lunch
=== deryck is now known as deryck[lunch]
=== gary_poster is now known as gary-lunch
=== benji is now known as benji-lunch
=== salgado is now known as salgado-physio
=== deryck[lunch] is now known as deryck
=== bigjools is now known as bigjools-afk
=== Ursinha-lunch is now known as Ursinha
=== benji-lunch is now known as benji
=== gary-lunch is now known as gary_poster
=== bigjools-afk is now known as bigjools
=== matsubara is now known as matsubara-lunch
[18:29] <bdmurray> leonardr: my branch from yesterday is ready for re-review
[18:29] <leonardr> bdmurray, roger
[18:53] <leonardr> bdmurray, r=me with minor changes
=== salgado-physio is now known as salgado
=== matsubara-lunch is now known as matsubara
[19:26] <jcsackett> anyone have time for a code review on this? https://code.edge.launchpad.net/~jcsackett/launchpad/projectgroup-branches-652156/+merge/38355
[19:26] <jcsackett> mostly template work and tests.
=== mwhudson_ is now known as mwhudson
=== Ursinha is now known as Ursinha-bbl
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk