=== Ursinha is now known as Ursinha-afk
=== bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[07:58] <bac> hi wgrant
[08:15] <bac> wgrant, i'm trying to review your branch for publisher indices.  i cannot get the tests to run due to a cyclical import problem.  did you see that?
[08:24] <bac> hi StevenK, you around?
[08:31] <StevenK> bac: Indeed
[08:32] <bac> hi StevenK, i'm trying to run some archive publisher tests and am getting import errors
[08:32] <StevenK> bac: Can you pastebin them?
[08:32] <bac> the class is being exported so i think it is a cyclical import problem. and it shows up in trunk
[08:32] <bac> StevenK: will do
[08:34] <bac> StevenK: http://pastebin.ubuntu.com/513667/
[08:49] <wgrant> bac: That's well-known.
[08:49] <wgrant> There was a bug filed a couple of days ago.
[08:49] <bac> wgrant: ah, ok
[08:49] <wgrant> You can't use -m lp.archivepublisher or various other Soyuzy things.
[08:49] <wgrant> I just -t archivepublisher.
[08:50] <bac> wgrant: thanks
[08:50] <bac> StevenK: ^^, nm
[08:50] <StevenK> bac: Yes, I saw.
[08:51]  * wgrant has another 6 branches to follow that one.
[08:51]  * StevenK can't land anything due to buildbot being in testfix because db-devel failed
[08:52] <StevenK> And I can't tell why, and lifeless wants to know why
[08:52]  * wgrant can't land anything because his branches keep getting rejected with seven different errors.
[09:09] <wgrant> bac: I'm going to hope that you're not in your usual TZ at the moment.
[09:09] <bac> wgrant: no, i've relocated for a bit
[09:10] <bac> UTC+7
[09:10] <wgrant> Aha.
[09:10] <wgrant> This makes more sense.
[09:11] <bac> wgrant: you use method(param=[]) a couple of place.  you know that can cause problems?
[09:12] <wgrant> bac: Isn't that only a problem if I mutate the arg?
[09:14] <bac> wgrant: yes.  i *thought* we had something in PSG about always avoiding it
[09:18]  * wgrant needs to eat now, but will remove it later if you can find a reference.
[09:19] <bac> wgrant: why not change to a tuple?
[09:19] <lifeless> wgrant: its highly sensitive to bad changes in the future
[09:19] <lifeless> wgrant: a tuple or None would be safer
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[09:21] <adeuring> morning bac
[09:21] <bac> hi adeuring
[09:28] <bac> adeuring: not much going on here.  three branches need review in +activereviews.  i'm starting on gary's
=== bac changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: gary,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[09:29] <adeuring> bac: ok, I'll take brian's. But I need more coffee first ;)
[09:29] <wgrant> bac: Ah, true, I could. They used to have a single item each, and the extra two characters to tupleise them felt bad.
[09:29] <wgrant> But it's easy now, so I will do it.
[09:29] <bac> adeuring: ok
[09:29] <bac> wgrant, always taking the easy route.  :)
[09:29] <bac> thanks
[09:30]  * bac hates the single-element tuple syntax
[09:30] <wgrant> Yes.
[09:31] <StevenK> bac: (Why,) ? :-)
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: gary, bdmurray || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[09:36] <wgrant> bac: Fixed. Could you try to ec2 it?
[09:36] <bac> wgrant: ugh, the hard part
[09:37] <wgrant> bac: It hopefully can't beat the number of failures that my other branch has.
[09:51] <bigjools> thanks for reviewing my branch lifeless
=== StevenK changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: gary, bdmurray || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:06] <adeuring> StevenK: could you explain a bit what the difference is HttpServer and FixedHttpServer, and why is fixes a threading issue?
[10:06] <StevenK> adeuring: The easiest answer I can give you is the thread on launchpad-dev
[10:06] <adeuring> StevenK: ah, ok...
[10:06] <StevenK> adeuring: Using FixedHttpServer is mwhudson's suggestion
[10:07] <adeuring> StevenK: i was in holiday most of this week. can you tell me the subject of the thread?
[10:08] <adeuring> StevenK: never mind, found it already
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: gary, StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:09] <StevenK> adeuring: I'm happy to talk to mwhudson or thumper about this branch if you prefer
[10:10] <adeuring> StevenK: I just want to understand at least a bit what the magic behind this small change is; let me read the ml thread first ;)
[10:16] <adeuring> StevenK: r=me. Thanks for fixing this issue!
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: gary, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:42] <bac> adeuring: i leave the reviewing to you as i EOD/EOW.  :)
[10:42] <bac> that's nerd for TGIF
[10:43] <adeuring> bac: nice weekend!
[10:43] <bac> adeuring: thanks, you too.  nerdfest tomorrow, delayed 10.10 release party
[10:43] <adeuring> bac: enjoy!
[12:03] <wgrant> adeuring: I've a rather trivial sed branch for you, if you have a moment.
[12:04] <wgrant> https://code.edge.launchpad.net/~wgrant/launchpad/bug-661109-buildable-architectures/+merge/38529
=== wgrant changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [wgrant, wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:51] <adeuring> wgrant: sure, I'll look. sorry for the late answer - was out for lunch
[12:52] <jelmer> wgrant: btw, thanks for your comments with regard to my duplicated ancestry branch earlier. I've just put up a new one that just gets rid of the assertion completely.
[12:58] <wgrant> jelmer: Great.
[12:59] <wgrant> jelmer: I think that's probably the right idea.
[12:59] <wgrant> Since it doesn't actually care about overrides.
[13:00] <wgrant> adeuring: publisher-release-cleanup is a bit messy, unfortunately. But the other one is trivial.
[13:01] <adeuring> wgrant: no problem. At least "mesy cleanup" sounds interesting ;)
[13:01] <wgrant> It's the first of probably 7 or so branches to clean up that code :/
[13:02] <adeuring> wgrant: r=me on buildable-architectures
[13:02] <adeuring> I'll run it through ecs
[13:02] <adeuring> ...ec2
[13:02] <wgrant> adeuring: Thanks.
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing:  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:04] <adeuring> On call: adeuring || Reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:39] <gmb> adeuring: Can I add https://code.edge.launchpad.net/~gmb/launchpad/fix-bugzilla-sans-alias-bug-660873/+merge/38533 to your queue?
[13:39] <adeuring> gmb: sure
=== gmb changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: wgrant || queue: [gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:40] <gmb> adeuring: Thanks.
[14:15] <adeuring> wgrant: r=me for your other mp too
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
[14:34] <adeuring> gmb: r=me
[14:34] <gmb> adeuring: Thanks.
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:47] <allenap> adeuring: Can I have an rs=you for merging stable into db-devel to resolve conflicts?
[14:48] <adeuring> allenap: as far as an rs without a look into the sources is possibble, sure ;)
[14:48] <allenap> adeuring: It's difficult to show what I did really.... the tests pass though!
[14:49] <adeuring> adeuring: ok, so rs=me...
[15:13] <allenap> adeuring: Got time for another? https://code.edge.launchpad.net/~allenap/launchpad/check-mappings-and-sets-for-proxy/+merge/38539
[15:13] <adeuring> allenap: sure
[15:14] <allenap> Thanks.
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:29] <adeuring> allenap: r=me
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:42] <allenap> adeuring: Thanks.
[16:00] <jelmer> adeuring: can I add a small branch to your queue?
[16:00] <adeuring> jelmer: sure
[16:01] <jelmer> adeuring: Thanks - the branch is at https://code.edge.launchpad.net/~jelmer/launchpad/135610-duplicated-ancestry-2/+merge/38521
=== jelmer changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:04] <adeuring> jelmer: would it be difficult to avoid this situation that there are (for a short time, if i understand correctly) two PUBLISHED records?
[16:05] <jelmer> adeuring: It should be possible, but it is nontrivial.
[16:06] <adeuring> jelmer: ok, so r=me then
[16:06] <jelmer> adeuring: Thanks!
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji is now known as benji-lunch
[16:31] <deryck> adeuring, hi.  I have a branch for review if you like.
[16:31] <adeuring> deryck: sure
[16:32] <deryck> adeuring, thanks!  https://code.edge.launchpad.net/~deryck/launchpad/better-testing-for-status-changes/+merge/38552
[16:52] <adeuring> deryck: I think it might make sense to change the test setup so that the product owner is not a member of the bug supervisor team; right now, the term "or user.inTeam(pillar.owner)" in canTransitionToStatus() is not executed
[16:52] <deryck> adeuring, ok, that's a good idea.  I can do that.
[16:53] <adeuring> deryck: thanks! another suggestion, before you start ;)
[16:53] <deryck> sure
=== salgado is now known as salgado-lunch
[16:55] <adeuring> deryck: you don't test at all for celebrities.bug_watch_updater, celebrities.bug_importer, celebrities.janitor. You could add these tests quickly by definig a base class for tests of "extended permissions", where you do not define the user who is tested, then derive the "real" test classes for supervisor, owner and the celebrities.
[16:55] <adeuring> That should make the tests a bit shorter and more comprehensive
[16:57] <deryck> sure, I like that idea.  I can do that, too.
[16:57] <adeuring> deryck: cool, thanks!
[16:58] <deryck> thank you!
[17:09] <deryck> adeuring, it will probably take me a bit to make those changes, so I'll just ping back when done on Monday, if that works for you.
[17:10] <adeuring> deryck: sure, no problem
=== matsubara is now known as matsubara-lunch
[17:18] <allenap> adeuring: Got time for a very simple one? https://code.edge.launchpad.net/~allenap/launchpad/wire-up-filter-subs-bug-655567-devel/+merge/38562
[17:18] <adeuring> allenap: sure
[17:18] <allenap> adeuring: It's already reviewed and landed in db-devel, so I just need a +1 to land on devel.
[17:20] <adeuring> allenap: so, rs=me
[17:20] <allenap> adeuring: Thanks.
[17:20] <allenap> adeuring: For the sake of my extreme laziness, can you approve the merge proposal so I can use ec2 land? ;)
[17:21] <adeuring> allenap: one
[17:21] <adeuring> ...done
[17:21] <allenap> Thanks :)
=== deryck is now known as deryck[lunch]
=== gary_poster is now known as gary-lunch
=== benji-lunch is now known as benji
[18:09] <EdwinGrubbs> adeuring, gmb, sinzui: Can one of you review my fix for my previous fix that conflicts with someone else's fix? Arg. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/remove-redundant-initialisedistroseries-section/+merge/38571
[18:10] <sinzui> I can when the diff updates
=== adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[18:12] <sinzui> EdwinGrubbs, I see you diff
[18:12] <EdwinGrubbs> sinzui: what does that sentence mean?
[18:13] <sinzui> EdwinGrubbs, Why do we not see the other inclusion. Was the other section added in another location?
[18:13]  * sinzui thinks the file should be in alphabetical order
[18:14] <EdwinGrubbs> sinzui: right, it was added in the middle of the file.
[18:15] <sinzui> okay r=me to land
=== matsubara-lunch is now known as matsubara
=== gary-lunch is now known as gary_poster
[18:35] <EdwinGrubbs> salgado-lunch: I have a branch that needs a ui review if you want: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-652232-person-code-action-links/+merge/38574
=== deryck[lunch] is now known as deryck
=== gary_poster is now known as gary-bbs
=== salgado-lunch is now known as salgado
[19:08] <salgado> Edwin-afk, sure, I'll take it
=== gary-bbs is now known as gary_poster
[19:42] <abentley> rockstar: could you please review https://code.edge.launchpad.net/~abentley/launchpad/partial-ancestry-scanner/+merge/38582 ?
[19:43] <rockstar> abentley, ack.
=== matsubara is now known as matsubara-afk