ara | good morning! | 07:32 |
---|---|---|
alourie | good morning | 07:34 |
Claudinux | morning ara | 07:40 |
ara | morning alourie, Claudinux | 07:41 |
alourie | morning ara | 07:43 |
alourie | ara: do you have a moment? | 07:45 |
ara | alourie, yes, sure | 07:52 |
alourie | ara: I have the small change I wanted to propose for the qa.u.com; how would I proceed? Should I open a bug? | 07:53 |
ara | alourie, you open a bug. Then publish your branch as: bzr push lp:~alourie/ubuntu-qa-website/fix_bug_xxxxxxx --fixes lp:xxxxxx | 07:56 |
ara | and then propose a merge explaining how your branch fixes the issue | 07:56 |
alourie | ara: great, I'll try | 08:04 |
alourie | ara: what tags should I add to the bug report? | 08:23 |
ara | qa-website | 08:23 |
alourie | ok | 08:24 |
alourie | ara: --fixes ; "no such option"? | 08:25 |
ara | what version of bzr do you have? | 08:26 |
ara | alourie, my bad, the --fixes is when you commit, not when you push | 08:27 |
ara | you can bzr uncommit | 08:28 |
ara | and then | 08:28 |
ara | bzr commit -m "........" --fixes lp:xxxxxx | 08:28 |
alourie | ara: right, that worked :-) | 08:30 |
alourie | ara: done, bug 663124 | 08:32 |
ubot4 | alourie: Bug 663124 on http://launchpad.net/bugs/663124 is private | 08:32 |
alourie | ^^ that's strande | 08:33 |
alourie | *strange | 08:33 |
ara | alourie, that happens sometimes when lp is read-only | 08:33 |
ara | or something else is going on, no worries, I'll have a look to your changes | 08:33 |
ara | alourie, I think you wanted to say "shouldn't have comments enabled" in the description of the bug | 08:34 |
alourie | ara: you're right, thanks! Fixed | 08:35 |
ara | alourie, sorry, I had to reject your change. Can you please see my comments? thanks | 08:49 |
alourie | ara: sure, no problem | 08:59 |
ara | alourie, any change that it is not involved directly with content, it is probably a theme issue | 08:59 |
alourie | ara: agreed | 08:59 |
Psychodelius | hi all | 09:00 |
ara | hi Psychodelius | 09:00 |
ara | alourie, if you check, under the theme, the file "pages.php" you will see clearly where to make your change | 09:02 |
alourie | ara: as I see it, it's in the comments.php | 09:12 |
alourie | and it comments_open that handles it | 09:12 |
ara | alourie, no, it is pages.php | 09:12 |
ara | sorry, page.php | 09:13 |
ara | if you delete <?php comments_template(); ?> from there, it should do the trick | 09:13 |
alourie | ara: ah | 09:13 |
ara | comments.php handles the comments for every kind of post | 09:13 |
alourie | right | 09:13 |
alourie | ara: sorry, it's been awhile since php, it'll take a few moments to resync | 09:14 |
alourie | ara: ok, got it. It will include small update to css as well, because otherwise it will not look good | 09:27 |
ara | alourie, cool, thanks | 09:28 |
alourie | ara: should I push to the same branch? Or a new one? | 09:33 |
ara | alourie, I knew one, because you have to branch the wp-theme branch, and not the other one | 09:37 |
alourie | ara: ok | 09:44 |
ara | *new | 09:44 |
alourie | ara: done | 09:48 |
ara | alourie, the diff looks a bit strange, did you propose the merge against wp-theme? | 10:10 |
ara | alourie, ah, I see, you proposed the merge against lp:ubuntu-qa-website | 10:10 |
ara | you have to propose it against the wp-theme branch | 10:11 |
ara | lp:~ubuntu-qa-website-devel/ubuntu-qa-website/wp-theme | 10:12 |
alourie | ara: this seems to be not my day :-) | 10:23 |
ara | alourie, don't worry, once you get it right once, the rest will come correctly :) | 10:26 |
alourie | ara: ok, I've created a new request and provided the mentioned branch. I hope now it is the right thing | 10:27 |
alourie | ah, it seems to be right | 10:28 |
ara | alourie, great, thanks | 10:28 |
ara | alourie, OK, I will try the changes later today. Thanks a lot! | 10:32 |
alourie | ara: thanks! | 10:44 |
ara | alourie, your welcome | 10:45 |
alourie | wow, I now feel like I'm contributing :-) | 10:55 |
ara | :) | 10:59 |
alourie | ara: why don't I see feeds and background pic on my local WP? Should I do something I didn't? | 12:28 |
ara | alourie, that content is on the server, only, but it shouldn't be important to make changes locally | 13:38 |
alourie | ara: ah, ok, thanks | 13:40 |
jibel | mvo, is the test suite coming with the sources of u-m up to date ? every datasource refers to feisty ? or does it need a refresh ? | 13:59 |
mvo | jibel: test_prerequists.py is outdated | 14:10 |
mvo | the rest should be fine | 14:10 |
jibel | mvo, okay thanks. | 14:13 |
mvo | jibel: I also make it run on build now, so that we catch the issues right away | 14:17 |
jibel | mvo, I'm verifying bug 656881 and was looking for a way to test more than a simple package update. | 14:18 |
ubot4 | Launchpad bug 656881 in update-manager (Ubuntu Maverick) (and 2 other projects) ""Install" button sometimes doesn't do anything (affects: 1) (heat: 501)" [Medium,Fix released] https://launchpad.net/bugs/656881 | 14:18 |
=== Tscheesy_ is now known as Tscheesy | ||
=== Claudinux_ is now known as Claudinux |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!