| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| lifeless | anyone reviewing? | 05:40 |
|---|---|---|
| lifeless | https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39011 | 05:47 |
| === lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39011] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| lifeless | oh bugger, prereq branch | 05:48 |
| lifeless | right, thats better | 05:49 |
| lifeless | https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013 | 05:49 |
| === lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === StevenK changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013 ,StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === jtv changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | lifeless: out of pure, unenlightened self-interest I'm grabbing yours off the queue and reviewing it. | 09:08 |
| lifeless | why thank you | 09:09 |
| StevenK | allenap: O hai, aren't you OCR today? | 10:12 |
| allenap | StevenK: Oh, yes I am! | 10:19 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matthew_ is now known as mrevell | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | allenap: yay, you have an empty queue again! Unfortunately I didn't get around to Ian's branch last night, but I took Robert's kiloline branch off the queue today to make up for it. | 10:46 |
| allenap | jtv: Woohoo, thank you :) | 10:47 |
| === matsubara_ is now known as matsubara | ||
| === Ursinha-afk is now known as Ursinha | ||
| jtv | allenap: got one for ya! Simple API branch. https://code.launchpad.net/~jtv/launchpad/bug-664327/+merge/39036 | 14:02 |
| allenap | jtv: Cool. I'm doing wallyworld's branch right now, but I'll do yours straight after. | 14:03 |
| jtv | great, thanks | 14:03 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworkd || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | beat me to it :) | 14:03 |
| === danilo_ is now known as danilos | ||
| gmb | allenap: Got another one for you if you've time: https://code.edge.launchpad.net/~gmb/launchpad/include-bnl-bug-651108/+merge/39047 | 15:42 |
| allenap | gmb: Yeah, I've got time. | 15:42 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [jtv, gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | allenap: Thanks: https://code.edge.launchpad.net/~gmb/launchpad/include-bnl-bug-651108/+merge/39047, when it comes round. | 15:42 |
| === Ursinha is now known as Ursinha-lunch | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | jtv: wallyworld's review is taking a long time so I did yours quickly. | 15:49 |
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | rockstar: Would you mind doing a js review of https://code.edge.launchpad.net/~wallyworld/launchpad/improved-broken-link-handling/+merge/37095? I've done one already, but my javascript is a bit rusty, especially in the context of Launchapd. | 16:54 |
| === benji is now known as benji-lunch | ||
| allenap | gmb: I'm probably not going to get your branch reviewed until much later this evening. Is that okay? | 17:29 |
| === Ursinha-lunch is now known as Ursinha | ||
| === matsubara-lunch is now known as matsubara | ||
| allenap | gmb: There are conflicts in tales-cache.txt. | 17:38 |
| gmb | Aaa | 17:39 |
| gmb | allenap: Please ignore them. I've already fixed them once, not sure why they'd show up again. I'll look into it but that's more to do with mars' branch than mine. | 17:40 |
| allenap | gmb: Okay. | 17:41 |
| gmb | Ta | 17:41 |
| === allenap changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| === benji-lunch is now known as benji | ||
| === salgado-lunch is now known as salgado | ||
| leonardr | salgado or sinzui, maybe one of you wants to review my very small branch https://code.edge.launchpad.net/~leonardr/wadllib/package-to-include-sample-data/+merge/39072 ? | 18:51 |
| === deryck[lunch] is now known as deryck | ||
| lifeless | leonardr: why is that branch private? | 18:56 |
| leonardr | lifeless: probably a wadllib setting | 18:57 |
| lifeless | anyhow it looks fine to me | 18:58 |
| leonardr | lifeless et al: it is a wadllib setting, and i don't see where to change it. (branches off of wadllib are private by default) | 19:04 |
| lifeless | branch policy then - ask a losa to change it | 19:05 |
| leonardr | ok | 19:05 |
| abentley | rockstar: around? | 19:16 |
| rockstar | abentley, about to head out to lunch | 19:20 |
| abentley | rockstar: okay, ping me later. | 19:21 |
| rockstar | abentley, ack | 19:21 |
| rockstar | abentley, heya. | 20:51 |
| abentley | rockstar: hi. OTP | 20:52 |
| rockstar | abentley, okay. | 20:52 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!