=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
[05:40] <lifeless> anyone reviewing?
[05:47] <lifeless> https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39011
=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39011] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[05:48] <lifeless> oh bugger, prereq branch
[05:49] <lifeless> right, thats better
[05:49] <lifeless> https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013
=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== StevenK changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/librarian/+merge/39013 ,StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== jtv changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[09:08] <jtv> lifeless: out of pure, unenlightened self-interest I'm grabbing yours off the queue and reviewing it.
[09:09] <lifeless> why thank you
[10:12] <StevenK> allenap: O hai, aren't you OCR today?
[10:19] <allenap> StevenK: Oh, yes I am!
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matthew_ is now known as mrevell
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:46] <jtv> allenap: yay, you have an empty queue again!  Unfortunately I didn't get around to Ian's branch last night, but I took Robert's kiloline branch off the queue today to make up for it.
[10:47] <allenap> jtv: Woohoo, thank you :)
=== matsubara_ is now known as matsubara
=== Ursinha-afk is now known as Ursinha
[14:02] <jtv> allenap: got one for ya!  Simple API branch.  https://code.launchpad.net/~jtv/launchpad/bug-664327/+merge/39036
[14:03] <allenap> jtv: Cool. I'm doing wallyworld's branch right now, but I'll do yours straight after.
[14:03] <jtv> great, thanks
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworkd || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:03] <jtv> beat me to it :)
=== danilo_ is now known as danilos
[15:42] <gmb> allenap: Got another one for you if you've time: https://code.edge.launchpad.net/~gmb/launchpad/include-bnl-bug-651108/+merge/39047
[15:42] <allenap> gmb: Yeah, I've got time.
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [jtv, gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:42] <gmb> allenap: Thanks: https://code.edge.launchpad.net/~gmb/launchpad/include-bnl-bug-651108/+merge/39047, when it comes round.
=== Ursinha is now known as Ursinha-lunch
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: wallyworld || queue: [gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:49] <allenap> jtv: wallyworld's review is taking a long time so I did yours quickly.
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:54] <allenap> rockstar: Would you mind doing a js review of https://code.edge.launchpad.net/~wallyworld/launchpad/improved-broken-link-handling/+merge/37095? I've done one already, but my javascript is a bit rusty, especially in the context of Launchapd.
=== benji is now known as benji-lunch
[17:29] <allenap> gmb: I'm probably not going to get your branch reviewed until much later this evening. Is that okay?
=== Ursinha-lunch is now known as Ursinha
=== matsubara-lunch is now known as matsubara
[17:38] <allenap> gmb: There are conflicts in tales-cache.txt.
[17:39] <gmb> Aaa
[17:40] <gmb> allenap: Please ignore them. I've already fixed them once, not sure why they'd show up again. I'll look into it but that's more to do with mars' branch than mine.
[17:41] <allenap> gmb: Okay.
[17:41] <gmb> Ta
=== allenap changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck is now known as deryck[lunch]
=== benji-lunch is now known as benji
=== salgado-lunch is now known as salgado
[18:51] <leonardr> salgado or sinzui, maybe one of you wants to review my very small branch https://code.edge.launchpad.net/~leonardr/wadllib/package-to-include-sample-data/+merge/39072 ?
=== deryck[lunch] is now known as deryck
[18:56] <lifeless> leonardr: why is that branch private?
[18:57] <leonardr> lifeless: probably a wadllib setting
[18:58] <lifeless> anyhow it looks fine to me
[19:04] <leonardr> lifeless et al: it is a wadllib setting, and i don't see where to change it. (branches off of wadllib are private by default)
[19:05] <lifeless> branch policy then - ask a losa to change it
[19:05] <leonardr> ok
[19:16] <abentley> rockstar: around?
[19:20] <rockstar> abentley, about to head out to lunch
[19:21] <abentley> rockstar: okay, ping me later.
[19:21] <rockstar> abentley, ack
[20:51] <rockstar> abentley, heya.
[20:52] <abentley> rockstar: hi.  OTP
[20:52] <rockstar> abentley, okay.
=== matsubara is now known as matsubara-afk