/srv/irclogs.ubuntu.com/2010/10/27/#launchpad-dev.txt

lifelessflacoste: we're waiting for my patch disabling the edge redirect code to propogate through QA00:11
wgrantlifeless: What about recipes?00:15
lifelesswgrant: we're waiting for N things00:23
lifelesswgrant: one at a time00:23
wgrantlifeless: But if the redirect removal lands, then recipes vanish from Launchpad.00:32
wgrantlifeless: Which may be slightly undesirable.00:32
wgrants/lands/deloys/00:33
wgrant+p00:33
lifelesshuh, no00:37
lifelessfood, whilst I leave you to look closer.00:38
LPCIBotProject devel build (156): FAILURE in 3 hr 33 min: https://hudson.wedontsleep.org/job/devel/156/02:11
LPCIBot* Launchpad Patch Queue Manager: [r=bac][ui=none][bug=666580] Make getMessageDispositions much more02:11
LPCIBotefficient in the number of DB queries.02:11
LPCIBot* Launchpad Patch Queue Manager: [r=jml][ui=none][no-qa] Remove with_statement.02:11
LPCIBot* Launchpad Patch Queue Manager: [r=jml][ui=none][bug=54946, 496574, 497282, 611258,02:11
LPCIBot618955] New almost-fully-asynchronous buildd-manager with lots of hot02:11
LPCIBotsexy bug fixes.02:11
wgrantlifeless: I see nothing in that MP which enables BFB on lpnet.02:31
wgrantUnless you've also changed the prod configs, I guess.02:31
lifelesswgrant: disabling the edge redirect doesn't remove the edge appservers02:34
lifelessand yes, the prod configs have (naturally) changed02:34
wgrantlifeless: It doesn't remove them, but it stops people from being redirected, so it effectively removes them.02:36
thumperlifeless: did you change the prod config to enable recipes?02:36
thumperlifeless: it isn't is_edge02:37
lifelessno02:37
lifelesswe're adding a feature scope to support recipes02:37
lifelesswe're stalled on the edge removal on that02:37
wgrant... that is what I was asking.02:38
wgrantAha.02:38
lifelesswgrant: see lp-foundations bugs02:38
thumperlifeless: why stalled on edge removal?02:43
lifelessjml doesn't want recipes on prod for all users02:44
lifelessonly beta02:44
lifeless(and preferrably a dedicated smaller beta team)02:44
lifelessso we need to add a scope that selects teams.02:44
thumperok02:45
lifelessthumper: there's no panic on removing edge, we have time to do it methodically02:46
thumperok02:46
lifelessall due haste, no panic.02:47
wgrantlifeless: So you just CP'd up to r11738?02:50
lifelessdeployed, yes.02:50
wgrantHopefully the publisher won't explode.02:50
lifelessCP's no longer exist.02:50
wgrantShh.02:50
lifelesswgrant: why would it? We didn't deploy to soyuz machines02:50
wgrantAh.02:50
wgrantSo the Fix Released was a lie.02:50
lifelesswgrant: which bug02:51
wgrantBug #65569002:51
lifelesswgrant: well, its a nonfunctional change, right?02:52
lifelesswgrant: or is it broken?02:52
wgrantlifeless: No, it's fine. Shouldn't be a problem, except it's happened in the past that a CP has been partially deployed, marked as Fix Released, something has broken, and then confusion abounds when you're looking at the wrong code.02:53
lifelesswell the rev is on the bug02:53
wgrantTrue.02:54
lifelessI'm not sure what we should do here.02:54
lifelessif it was a functional change, I wouldn't have toggled it.02:54
wgrantMerge Fix Committed and Fix Released into Fixed, like mpt has wanted to do forever?02:54
lifeless:)02:55
bacthumper, did you see hudson failed on your branch?02:57
bacthumper, well not just your branch...02:58
thumperno03:01
* thumper afk to collect car03:10
thumperbac: looks screwed up03:12
thumperbac: as in hudson looks screwed up, not the branch03:12
* StevenK prods at hudson before bed03:52
LPCIBotProject db-devel build (103): FAILURE in 3 hr 57 min: https://hudson.wedontsleep.org/job/db-devel/103/03:53
StevenKThat devel change is odd03:54
StevenKEr, s/change/test failure/03:54
StevenKThe test suite is run under sudo, so I am tempted to blame a recent landing03:55
thumperyes, yes it is03:55
thumperwallyworld_: skype?04:17
wallyworld_ok04:17
wallyworld_thumper: now?04:22
thumperwallyworld_: I can't hear you :)04:22
wallyworld_i can't hear you either04:22
wallyworld_!#@#@%@ pulse or whatever04:23
wallyworld_i may have to reboot :-(04:23
thumperack04:23
thumpercontains(@class, "js-action")05:00
lifelessthumper: you might like https://code.edge.launchpad.net/~lifeless/launchpad/zope.testing/+merge/3942305:36
lifelessjml: or you may like it.05:36
lifelessgnight05:36
LPCIBotProject devel build (157): STILL FAILING in 3 hr 32 min: https://hudson.wedontsleep.org/job/devel/157/06:03
LPCIBotLaunchpad Patch Queue Manager: [r=lifeless][ui=none][no-qa] Prevent the atexit warning that occurs06:03
LPCIBotwhen tests are run within the LibrarianLayer.06:03
adeuringgood morning08:54
mrevellHello09:03
bachello mrevell, adeuring09:12
wgrantSomeone is going to need to manually apply the permission changes from db-devel r9888, or we are going to have an awful lot of branch scan failures.09:17
wgrant(that was merged into devel later on, and has security.cfg changes, which can't be deployed directly without downtime)09:18
wgrant(but the revs that need the new perms were deployed earlier today)09:18
=== thekorn is now known as th3k0rn
mthaddonwgrant: interesting - this seems to be something of a failure in process... :/09:31
wgrantmthaddon: One that people have been warned about.09:32
wgrantI don't recall exactly where.09:32
wgrantBut it was brought up recently.09:32
mthaddonyeah09:34
mthaddonso allegedly qastaging should fix this, but it seems this wasn't exactly qa-ed there...09:35
wgrantqastaging may have been set up too late.09:36
wgrantSo it may have had the right perms from the start.09:36
mthaddonwell, and we're not running scripts on it yet...09:36
wgrantAh, that would also do it.09:36
mthaddonbut my point is the revno was blessed for rollout without having really been QA-ed09:36
wgrantIt's almost impossible to completely QA something like that.09:37
wgrantBut more could have been done.09:37
mthaddonanyway, thx for bringing it up09:37
wgrantIt's also possible that it was QA'd properly on db-devel, and then merged without properly being QA'd on devel.09:37
wgrantBut anyway.09:37
=== th3k0rn is now known as thekorn
henningejtv: yup, the main facet feigns ignorance about a series branch to non-privileged users.09:42
henningeif that branch is private.09:42
jtvhenninge: and ours does the same for the development branch but not for the export branch?  Or does it fail to feign and so feint when either is present?09:43
* jtv gets confused about spelling09:44
henningejtv: ;-) the latter.09:44
henningejtv: so, if translations would say somthing like "translations are imported from/exported to a private branch" it would already give away more information than the main page which claims "No revision control details recorded for ..."09:45
jtvRight.09:46
jtvWell, mystery solved I guess.  Good job.  :)09:46
henningeSo our page will have to look to non-priv users as if no branch sync had been set up.09:47
=== almaisan-away is now known as al-maisan
LPCIBotYippie, build fixed!10:05
LPCIBotProject devel build (158): FIXED in 3 hr 33 min: https://hudson.wedontsleep.org/job/devel/158/10:05
LPCIBotLaunchpad Patch Queue Manager: [testfix][rs=bac][ui=none][bug=54946, 496574, 497282, 611258,10:05
LPCIBot618955][rollback=11801]10:05
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
=== matsubara-afk is now known as matsubara
lifelessjml: oh hai13:11
jmllifeless: hello13:11
lifelessjml: I've fixed layers13:12
jmllifeless: glad to hear it.13:12
lifelessjml: it needs a review :)13:13
jmllifeless: cool. I'll look at it once I'm done w/ email13:13
lifeless-> food13:17
LPCIBotProject devel build (159): SUCCESS in 3 hr 34 min: https://hudson.wedontsleep.org/job/devel/159/13:39
LPCIBotLaunchpad Patch Queue Manager: [r=allenap][ui=none][bug=665407] Add invalid-link style to invalid lp13:39
LPCIBotbranch short links and prevent click through13:39
lifelessjml: have you picked up a key?13:47
jmllifeless: I don't think so.13:47
lifelessI'll go get one13:51
flacostelifeless, jml: around?14:02
lifelessjml: bony 314:04
lifelessflacoste: yes14:04
jmllifeless: I don't understand...14:04
StevenKIt sounds like a room title to me14:04
flacostelifeless, jml: call me when you are ready14:05
lifelessjml: all the meeting rooms are booked; marianna has put us in bonaire 314:06
lifelessflacoste: skype ?14:07
flacostelifeless: skype or POTS, whatever works best for you guys14:08
lifelessflacoste: rephrasing; please join skype14:08
flacostelifeless: i should be there already14:08
flacostelifeless: are you hearing me?%14:09
allenapjml: I have some grants for production that accompany a security.cfg change that has already landed in devel. Are you the person I should ask to review these?14:10
=== jtv is now known as jtv-afk
allenapIt's probably already in stable too, but I think all the grants are for script users so it hasn't caused problems so far.14:11
bigjoolsallenap: he's in a session14:14
allenapbigjools: Thanks. I'll email him (unless you happen to know who else I could/should contact?).14:15
bigjoolsallenap: I can review/grant for you if you want14:16
allenapbigjools: Awesome, thanks. http://paste.ubuntu.com/520757/14:17
bigjoolsallenap: how do you know you have all the necessary changes?14:18
allenapbigjools: Because you're reviewing it for me to check ;)14:19
bigjools!14:19
bigjoolsallenap: it's my job to ask probing questions :)14:19
allenapbigjools: Do you know if it's possible to get Postgres to puke up it's permissions so I can compare before and after?14:20
bigjoolsallenap: yeah I think I've seen something, can't remember what it is14:21
allenapbigjools: Okay, I'll investigate. Thank you for your probe.14:21
bigjoolsallenap: so assuming that you've already landed the changes with these then it looks ok - my only concern is that you've not missed anything and it would be nice to somehow verify that.14:22
bigjoolsallenap: FWIW, I also bow to your grep skillz14:22
StevenKIf you could get a permissions dump from a running development instance, that would probably help for comparion14:22
StevenK*comparsion14:23
allenapStevenK: Yeah, that's what I have in mind.14:23
bigjoolsjml: when you have a moment I could do with chatting about the new buildd-manager - the twistd process is hitting all of one core on mawson and strace is not helpful.14:24
bigjoolsderyck: did you see bug 667215? :)14:39
bigjoolsgary_poster: hi14:42
gary_posterhey on call but off soon bigjools14:42
bigjoolsgary_poster: np,  I am in a session soon though.  Just wanted to talk about bug 66718314:42
bigjoolsI'll comment on the bug14:44
gary_posterack14:45
deryckbigjools, yeah :-)  I haven't replied or un-security'ed it yet.  It's crying out for a clever response, and I don't want to disappoint. :-)14:48
* deryck kids obviously14:48
deryckI just haven't replied yet.14:48
bigjoolsderyck: seems ripe for "opinion" to me :)14:48
deryckheh14:49
=== adeuring1 is now known as adeuring
bigjoolsabuse of the security tag is annoying though14:49
deryckyeah14:51
derycklaunchpad session!14:53
jmlbigjools: will do.14:55
allenapbigjools: You were very right to ask that question: http://paste.ubuntu.com/520782/14:55
bigjoolsallenap: :)14:58
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
bacmars ping15:33
marsHi bac15:33
marsbac, regarding your earlier question, Ursinha would know15:33
bacoh, ok15:33
marsbac, and your EOD was 7:00am for me, I think? :)15:33
bacUrsinha: ping...15:33
rockstarsinzui, give me an example of your perfect pagetest story.15:34
bacmars: yeah15:34
bacmars: so you don't know which tools are supposed to set the bad-commit tags?15:34
bacUrsinha: do you ?  ^^15:34
bacif that could be documented on the the QAForContinuousRelease pages i think people would understand the process better15:35
marsbac, not off the top of my head, no.  Ursinha and lifeless worked that out, and I remember something on the list about it having the tags be manual(?)15:35
=== Ursinha is now known as Ursinha-afk
bacmars: really?  not what the wiki says at all.15:35
bacwell, i won't be getting my answer today, then.  :)15:36
jcsacketthey, bac, as long as your online did you see my comment on the bug(s) we were talking about yesterday?15:36
marsbac, that's why I did not reply.  I thoguht lp-land or ec2 land should have done everything for you15:36
bacmars: me too.  this branch was full of mysteries.15:36
bacbugs didn't get linked, diff didn't update, tags didn't update, MP didn't get set to 'merged'.  all very odd.15:37
bacsome of it may be to branch scanner weirdness today15:37
bacjcsackett: i did.  thanks for following through.15:37
jcsackettbac: no problem. were you able to qa your stuff?15:37
bacjcsackett: in the future, could you send me email?  sometimes my IRC client tells me i got pinged but i cannot find it in the scrollback15:37
bacjcsackett: i did15:38
jcsackettbac: oh, sure.15:38
jcsackettexcellent.15:38
bigjoolsbac: hello, would you mind testing a patch for me to fix that failing test of mine?15:46
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
lifelessflacoste: can you invite me to the ISO call tomorrow/today ?16:10
flacostelifeless: sure16:13
flacostelifeless: not sure, it it's going to happen though given that elmo is at UDS, but we can probably have the call with tom16:13
=== flacoste changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 1 of 10.11 | PQM is open | firefighting: - | https:/​/​dev.launchpad.net/​ | Get the code: https:/​/​dev.launchpad.net/​Getting
lifelessflacoste: I'd like to talk with you, charlie & tom about  some ops stuff from chatting with statik16:16
lifelessflacoste: that call seems ideally structured16:17
flacostelifeless: sure16:17
flacostelifeless: you should have the invite16:17
flacostelifeless: btw, you aware that converting daily builds to feature flag is a blocker for edge removal?16:18
lifelessflacoste: yes, I said so on the prereq bug16:18
flacostewhat bug is it?16:19
lifelessflacoste: bug 66653816:19
lifeless(was just looking)16:19
lifelessflacoste: we don't need to panic about removing edge - all due caution, and all due haste IMO16:19
lifelessflacoste: we're already better off16:19
lifelessmatsubara: ping16:20
flacostelifeless: agreed, but the daily build conversion, did you intend to take it, or do we need to hand this off to the code team?16:20
matsubarahi lifeless16:20
lifelessmatsubara: I'd like to interrupt you for a small but important thing.16:20
matsubarashoot16:20
lifelessmatsubara: could you fold the 'edge' OOPS report summaries into lpnet.16:20
lifelessmatsubara: they are now running the exact same code.16:20
lifelessmatsubara: so we don't benefit from a separate report.16:20
flacostelifeless: ok, i see that the bug is assigned to poolie16:21
matsubaralifeless, yes, are those instance not using the E* prefixes anymore?16:21
lifelessmatsubara: prefixes haven't changed16:21
flacostelifeless: so they are running the same code, but with a different config right?16:21
lifelessflacoste: -very- slightly different config; only practical change I know of is the recipe stuff being enabled.16:22
flacosteok16:22
lifelessflacoste: oh, and the timeout is 13000 not 15000 - but again, the oops /types/ and /causes/ should be identical.16:22
flacosteright16:23
flacosteshould we harmonize the timeouts?16:23
lifelessflacoste: on my todo :)16:23
lifelessflacoste: waiting for the 600 a day to reduce16:23
flacosteright, because of the 8.4 regressions16:23
lifelessflacoste: which will happen as more things are qad and deployed - we have several timeout fixes blocked on qa16:23
lifelessflacoste: right16:23
flacosteawesome16:23
flacostethis is really better16:24
lifelessStevenK: https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html - --please-- I know you're at UDS, but unqa'd code in trunk is a teamwide stall.16:24
StevenKlifeless: I'm trying!16:24
lifelessStevenK: what can I do to help?16:24
StevenKlifeless: Tell me why the function appears in the WADL but not in the actual API code16:25
lifelessflacoste: so the call is in 23.5 hours?16:26
flacosteyep16:26
lifelessStevenK: how do you mean? leonardr: we may need your help.16:26
lifelessflacoste: thanks, wicked.16:26
leonardrStevenK, give me a link?16:27
lifelessmatsubara: so, for clarity - you're folding the E prefix into the lpnet reports ?16:27
StevenKlifeless: I'm in a session that I'm talking in, so I don't want to walk out16:27
leonardrwhat do you mean by "the api code"? you can't access it from launchpadlib?16:27
matsubaralifeless, yep16:27
StevenKleonardr: Right. I'm looking at say dir(maverick)16:27
lifelessmatsubara: awesome, thank you very much. We can drop the edge-oops.html on lpqateam etc too, with this change.16:27
matsubaralifeless, I seem to remember you saying that the weekly summary is not useful, so I'll get rid of that as well16:29
matsubaraUrsinha, what do you think ^?16:30
lifelessmatsubara: yes please16:30
Ursinhareading16:31
Ursinhamatsubara, that's cool, want me to do that along with qastaging changes?16:31
matsubaraUrsinha, sure, getting you a diff, just a sec16:32
leonardrStevenK: i assume you're busy in the presentation, but when you get a minute, i need a link to the problematic branch (or maybe lifeless can give it)16:32
StevenKleonardr: rev 9303 or so in db-devel, I think16:34
StevenKhttp://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/990316:34
matsubaraUrsinha, merge from here: lp:~matsubara/oops-tools/edge-no-more16:35
Ursinhathanks matsubara, will do that right now16:36
matsubaraUrsinha, will go for lunch and post office errands. please add a MP and I'll take a look after lunch and will deploy this so we'll get the new reports tomorrow. thanks a lot!16:36
=== matsubara is now known as matsubara-lunch
Ursinhasure, thanks matsubara-lunch!16:37
lifelessmwhudson: https://bugs.edge.launchpad.net/launchpad-code/+bug/66732216:40
leonardrStevenK: ok, so you have some tests that use launchpadlib, and those tests pass, so it should be working. i'd like to eliminate the possibility that your client-side launchpadlib is using a cached wadl file16:46
leonardrcan you run your test script but set "httplib2.debuglevel = 1" before using Launchpad.login_with or equivalent?16:47
StevenKleonardr: Okay, doing16:47
mwhudsonlifeless: i think the port already comes from launchpad-lazr.conf16:48
mwhudsonlifeless: config.codebrowse.port16:48
StevenKleonardr: What do you need from that?16:49
leonardrStevenK: paste me the whole thing, but i especially need the first part16:49
* mwhudson comments on the bug16:49
StevenKleonardr: http://paste.ubuntu.com/520833/16:50
lifelessmwhudson: thanks, I'll make new configs16:50
leonardrStevenK: you are using a cached wadl file. go into ~/.launchpadlib/api.dogfoot.launchpad.net/cache/ and look at the file that starts api.dogfood.launchpad.net,beta,-application,vnd.sun.wadl+xml16:52
leonardrsee if derivedistroseries is in there16:53
StevenKleonardr: I don't have that directory, is: launchpad = Launchpad.login_with('qa-mawson', 'dogfood')16:53
StevenKleonardr: Is that right to to talk to dogfood?16:54
leonardryeah. i misspelled dogfood in my earlier msg as "dogfoot"16:54
leonardrdo you have a ~/.launchpadlib/api.dogfood.launchpad.net?16:54
StevenKNope16:54
StevenKWhich is why I'm questioning if my login call is right16:55
=== jcsackett_ is now known as jcsackett|aft
leonardryou're making calls to the web service16:55
leonardrdo you have .launchpadlib at all?16:56
lifelessmwhudson: whats 'secret_path' for ?16:56
mwhudsonlifeless: signing cookies16:56
lifelessis it sharable across processes ?16:56
StevenKleonardr: Sorry, I have .launchpadlib/api.dogfood.launchpad.net/ but not .launchpadlib/cache/api.dogfood...16:56
mwhudsonyeah, it's a path to a file that contains the secret16:56
lifelesslike, if we're running two codebrowsers16:56
mwhudsonlifeless: different processes _need_ to share the same file content16:57
leonardrdo you have cache *inside* api.dogfood?16:57
leonardrie. when i do `ls /home/leonardr/.launchpadlib/api.dogfood.launchpad.net/cache/`, i see a file16:58
mwhudsonlifeless: afk16:58
StevenKleonardr: Right16:58
StevenKleonardr: I do have that directory16:58
leonardrok, is there a wadl file inside it, and if so, does the wadl file mention derivedDistroSeries?16:59
StevenKleonardr: Let me delete everything in that directory16:59
leonardrStevenK: ok, that's another effective tactic16:59
StevenKleonardr: Before I deleted it, no, it doesn't17:00
StevenKLet me do the effective tactic17:00
StevenKleonardr: Ah ha! Now it shows up17:02
leonardrStevenK: ok, that is your problem. wadl files are cached for one week17:02
leonardrthis is fine for casual users, but when you do web service development, you need to make sure you clear them out17:02
StevenKleonardr: Why the two directories?17:03
mwhudsonlifeless: back again17:03
leonardrStevenK: which two directories?17:03
StevenKleonardr: .launchpadlib/<api...>/cache versus .launchpadlib/cache/<api...>17:05
leonardrStevenL: you should not have .launchpadlib/cache/17:05
leonardrit may have been created by a very old version17:06
leonardryou can delete it17:06
StevenKOkay17:06
lifelessmwhudson: is cachepath safe to share ?17:06
mwhudsonlifeless: yes17:06
mwhudsonit's sqlite & there's no real difference between sharing between threads and sharing between processes17:06
bigjoolsCan I get a vic^Wvolunteer to run a test on revno 11801 of devel for me please?17:08
lifelessmwhudson: so log_folder, error_dir and oops_prefix are the only unique things ?17:08
StevenKleonardr: http://paste.ubuntu.com/520844/17:09
lifelessmatsubara-lunch: when you return, can you add CB1 and CB2 oops prefixes?17:09
mwhudsonlifeless: well, and port17:09
mwhudsonlifeless: otherwise, yes17:09
leonardrStevenK: would it be easy for you to try to reproduce that error locally?17:10
leonardrjust start up a local launchpad and run launchpadlib against 'dev'17:10
StevenKleonardr: I can try, but I also have code access to dogfood directly17:11
lifelessmwhudson: lp:~lifeless/lp-production-configs/codebrowse17:12
leonardrStevenK: ok, the most likely problem is that your named operation takes an argument that is of a schema field type for which there is no unmarshaller17:13
leonardrlet me check your code17:13
leonardri don't know why the automated tests wouldn't have caught this17:13
lifelessleonardr: if thats the case, will deploying it break other APIs ?17:14
lifelessif not, then we can qa-ok this patch and move on with deployments; we can iterate on the feature17:14
leonardrlifeless: no, it only means that this particular named operation is broken17:14
lifelessleonardr: great, thanks.17:15
lifelessbigjools: ok, so bad-commit explanation.17:15
leonardrStevenK: yeah, i don't think you can have a named operation take a List17:15
StevenKleonardr: Oh, drat17:15
lifelessbigjools: bad-commit-XXXX will block deployments until either a) the tag is removed or b) a branch with [rollback=XXXX] is landed (even if its not a rollback, thats just the tag to use.17:15
StevenKleonardr: Is there anything else I can do?17:15
leonardrlet me look at the code/think17:16
leonardrbigjools or someone else who's been doing actual web service work might know17:16
lifelessthe qa-* tag doesn't override the bad-commit17:16
lifelessonce the rollback is present, then as long as the rollback rev will be deployed, it *unblocks* the bad-commit17:16
lifelessand at *that point* the qa-tag gets evaluated.17:16
bigjoolsStevenK, leonardr: nothing springs to mind but looking at IArchive might give inspiration.17:17
bigjoolslifeless: where is the link between the rollback rev and the bad rev so it knows to do that?17:18
leonardrStevenK: the automated tests passed because you never passed in a value for any of the List arguments17:18
bigjoolsand I'm not sure I am really following this17:18
jmlbigjools: StevenK: are you guys planning on going to https://blueprints.edge.launchpad.net/ubuntu/+spec/ubuntutheproject-foundations-n-releaseprocess ?17:18
lifelessbigjools: in the commit message for the rollback rev17:18
bigjoolsjml: yes17:18
lifelessbigjools: we need to iterate on this process support stuff too, to make it more dynamic.17:18
jmlbigjools: cool. I really want to go but something just came up. glad you guys are.17:18
StevenKbigjools: IArchive.getBuildSummariesForSourceIds takes a List17:19
bigjoolsjml: when is it?17:19
jml5:1017:19
bigjoolsStevenK: there's your inspiration then17:20
leonardrbigjools, StevenK, do we know that getBuildSummaries.. will actually work when passed a list?17:21
bigjoolslifeless: I am still confused, let's go through it after this session17:21
mwhudsonlifeless: i don't think you need the launchpad.conf & mail-configure-normal.zcml crap17:22
bigjoolsleonardr: yes. it's use in a UI page17:22
mwhudsonlifeless: otherwise +117:22
bigjoolsused17:22
leonardrStevenK: in that case, i think your problem is that you need to specify a value_type for the List17:22
leonardrotherwise, lazr.restful says "a list of what?" and can't validate the incoming json17:23
bigjoolssounds sane17:23
bigjoolshey jelmer, have you got time later today to talk about that task list?17:24
jmlbigjools: do you want me to run your patch through ec2 land?17:25
bigjoolsjml: it would be nice to re-create it on someone's box first, but yes, that would help, thanks.17:26
bigjoolsjml: how's this look? http://pastebin.ubuntu.com/520807/17:26
StevenKleonardr: And then regenerate the wadl and remove the cached wadl?17:26
leonardrStevenK: i don't think you even need to do that, but it wouldn't hurt. you should be able to write an automated test that fails pretty easily, and then make it stop failing17:27
jmlbigjools: you need to add a cleanup to revert the patch when the test is done17:27
jmlbigjools: otherwise, perfect.17:27
lifelessmwhudson: everything has it :( don't want to experiment offhand17:27
StevenKleonardr: Right17:27
bigjoolsjml: why? it doesn't hurt to leave it17:27
lifelessbigjools: ok17:27
bigjoolsgiven that is going to be the "fix"17:28
jmlbigjools: because you should only break test isolation when there's a very, very, very good reason17:28
bigjoolshmm17:28
mwhudsonlifeless: well, i'm pretty sure you don't need it, but fair enough i guess17:28
mwhudsonbigjools, jml: the other option is to install the monkey patch at import time i guess17:29
allenapderyck: I just trod on your toes wrt bug 667347.17:29
mwhudsondoing it in test setup and then not doing it in teardown is ick17:29
allenapderyck: Can you look at my comment in there and let me know if I should revert my change?17:29
deryckallenap, ah, no worries.  Thank thank thank you for triaging. ;) :)  It's never stepping on my toes. :-)17:31
=== matsubara-lunch is now known as matsubara
deryckallenap, the comment is fine and good.  I just wanted to have the bugs together about trac, since his bugs came out of a UDS session.17:31
matsubaralifeless, the CB prefix is already known by oops-tools.17:31
allenapderyck: Cool.17:31
lifelessmatsubara: so it will handle CB1 and CB2 automagically ?17:31
lifelessmatsubara: there are two new error dirs as well17:31
matsubarawell, CB1 and CB2 can't be prefixes17:32
matsubarayou can't use digits in the prefix17:32
lifelessoh grah17:32
lifelessso CBA abd CBB ? Why can't you use digits ?17:32
matsubarabecause an oops id is formed by <day-since-epoch><prefix><unique-digit-for-the-given-oops-on-that-day>17:33
matsubaraif you add a digit in the prefix, the regex will think that's part of the unique-digit part of the oops id17:33
StevenKlifeless: Ping17:34
lifelesshi17:34
lifelessmatsubara: what regex17:34
lifelessmatsubara: the OOPS is in a header in the file17:34
StevenKlifeless: Do you remember what you did on my laptop to make launchpad branches branch quicker?17:34
lifelessStevenK: we edited bzr to not use accelerator branches, didn't we?17:35
StevenKlifeless: It was somewhere in launchpad/.bzr ?17:35
lifelessStevenK: or was it making the source branch a lightweight branch?17:35
StevenKlifeless: It was lightweight17:35
lifelessbzr remove-tree on your devel/db-devel branches17:35
StevenKlifeless: I think it's interferring with pushing branches to lp and stacking17:35
lifelessStevenK: no17:35
matsubaralifeless, oops_re in models.py /me looking for a link17:36
lifelessmatsubara: can you file a bug on this, its an unnecessary constraint, as long as no prefix is a prefix of another prefix.17:37
bigjoolsmwhudson: normally I'd 100% agree but I'm poking in the upstream's fix.  I guess I will do it anway since in retrospect it's kinda nasty.17:37
matsubaralifeless, https://bazaar.launchpad.net/~launchpad-pqm/oops-tools/trunk/annotate/head%3A/src/oopstools/oops/models.py17:38
mwhudsonbigjools: either poke it in for the entire duration of the process or for an isolated controlled time, not "approximately half of the time"17:38
mwhudson:-)17:38
mwhudsonin this case it won't matter, apart from wtfs/min17:38
bigjoolsmwhudson: meh :)17:39
lifelessI need someone to land a branch for me.17:40
lifelessecho "star-merge bzr+ssh://bazaar.launchpad.net/~lifeless/lp-production-configs/codebrowse bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/lp-production-configs/trunk" | gpg -cl | mail launchpad@pqm.canonical.com -s "[r=mthaddon][ui=none] Reconfigure codebrowse to support HA: new log and error dirs needed."17:40
lifelesspreferrably someone not at UDS (mail queuing is odd here just now, for some reason)17:40
lifelessflacoste: ^17:40
bigjoolsjml: http://pastebin.ubuntu.com/520864/17:44
lifelessflacoste: nvm, got it to work17:44
jmlbigjools: +117:44
bigjoolsjml: if that looks ok then I'll push up a new builderslave-resume and you can poke ec2land it17:44
bigjoolsgreat17:44
bigjoolsone sec17:44
matsubaralifeless, I don't think it's unnecessary17:45
bigjoolsjml: ok lp:~julian-edwards/launchpad/builderslave-resume has that change, thanks.  Maybe I should get an ec2 account.... then again maybe not.17:45
lifelessmatsubara: ok, why is it necessary?17:46
jmlbigjools: give a man fish... give a man a fishing license...17:46
bigjoolsjml: I hate fish :)17:47
bigjoolscome to think of it, I hate fishing17:47
jmlbigjools: what was your commit message17:48
bigjoolsjml: [r=jml][ui=none][bug=54946, 496574, 497282, 611258, 618955] New almost-fully-asynchronous buildd-manager with lots of hot sexy bug fixes.17:48
matsubaralifeless, because it's used to find the actual prefix in the oops-id. it's useful to know the prefix to find the files in the filesystem and to query the Prefix table. and this already works as is and changing it just because isn't a good reason either17:49
lifelessmatsubara: we have more servers than letters coming up17:50
lifelessmatsubara: LPNETAA is rather ugly17:50
lifelessmatsubara: would LPNET1- work as a prefix ?17:50
matsubaraand we'll have to have something that supports the old oops-id anyway for backwards compatibility17:50
lifelessmatsubara: well the old is a strict subset of the new, right ?17:51
matsubarawell, let's change the oops format then17:51
lifelessmatsubara: thats already happening, but I don't see why its related to this17:51
matsubaraoops-wsgi already generates oops-ids in a different format17:51
lifelesswhat does it do?17:52
bigjoolssinzui: do you know if there is a way to disable custom_widgets based on a different widget's radio button selections?  Or do I need some custom JS?17:53
matsubaralifeless, not sure exactly but they changed it to include the id of the thread the oops was generated or something like that.17:55
lifelessok17:55
lifelessso I don't really care either way17:55
lifelesshere is what I would love to see us achieve:17:55
lifeless - use numbers for numbers.17:56
lifelessor better yet17:56
lifeless - stop manually assigning and managing this stuff17:56
lifelessits a terrible burden on deployment to have to care about this detail17:56
=== jcsackett|afk is now known as jcsackett
jmlbigjools: for your other issue, I'm free in the 16:00 session18:00
matsubaralifeless, https://bugs.edge.launchpad.net/oops-tools/+bug/66737318:08
matsubaralifeless, https://bugs.edge.launchpad.net/oops-tools/+bug/66737518:12
lifelessmatsubara: 667375 is a dupe18:39
lifelessmatsubara: 667373 is great, thanks.18:39
matsubaralifeless, do you think it's a dupe of bug #271411?18:40
lifelessabsolutely18:41
matsubaralifeless, that's fix release :-)18:41
matsubarareleased18:41
lifelessmatsubara: then why are we having to add things?18:41
matsubaraso, yeah, I fixed #271411 but the next step is to make everything automagically18:41
lifelessmatsubara: ok cool18:42
lifelessI see the difference, and the new bug does speak to the overall intent better18:42
matsubarabecause that's the first step. adding support to oops-tools to read the lp-production-config file and have a web ui to trigger that18:42
matsubaranow we want to automate it further18:42
matsubaraok, cool18:42
matsubara:-)18:42
lifelessalso18:43
lifeless65975218:43
lifelessmatsubara: and bug 65886318:44
matsubaralifeless, ah, thanks for the pointers, I'll cleanup  the mess18:48
lifelessmatsubara: thank you!18:48
lifelessflacoste: ping18:51
flacostehi lifeless18:51
lifelessflacoste: while you're doing PPR stuff, want to fold edge into lpnet ?18:51
flacostelifeless: sure18:52
lifelessawesome!18:53
=== al-maisan is now known as almaisan-away
lifelessjelmer: ping19:04
jelmerlifeless, hi19:04
lifelessbug 135610 -19:04
lifelessit was qad very quickly after landing; we're just checking that it really did get vettted for ok-to-deploy19:05
lifelessjelmer: ^19:05
lifelessUrsinha: I've filed another couple of qatagger bugs, I put them on lp-foundations from lack of thought - sorry.19:07
lifelessUrsinha: they are high return ones for folk doing deploys19:07
jelmerlifeless: I probably tested that one on dogfood while it was ec2ing19:07
lifelessok19:07
lifelessthanks19:07
lifelessUrsinha: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/66739019:08
lifelessand https://bugs.edge.launchpad.net/launchpad-foundations/+bug/66738919:08
Ursinhalifeless, will check now19:19
leonardrgeneral python question: what will happen if you try to use a unix-specific function like platform.linux_distribution on a non-unix platform? will linux_distribution raise an exception or will it not even be present?19:20
lifelessleonardr: case by case19:20
leonardrdoes anyone have a windows machine they can try this code on for me?19:21
lifelesssorry, no.19:25
lifelessbut you can use wine19:25
lifelessmatsubara: whats up with https://code.edge.launchpad.net/~ursinha/oops-tools/add-qastaging/+merge/39465 ?19:25
matsubaralifeless, tests failed, looks like postgres is not running in the oops-tools chroot19:27
matsubaralosas: ping19:27
lifelessmatsubara: -> #launchpad-ops as per flacostes email.19:28
matsubaraoops19:28
matsubarasorry19:28
lifelessde nada19:28
lifelessjml: are you free @ 3 or 4 ?19:44
lifelessjml: and @ 9 tomorrow?19:44
LPCIBotYippie, build fixed!19:44
LPCIBotProject db-devel build (104): FIXED in 4 hr 4 min: https://hudson.wedontsleep.org/job/db-devel/104/19:44
james_wlifeless, jml says 419:53
lifelessjames_w: thanks19:56
jcsackettsomeday i'm going to count how many times in a month "make" is the solution to a launchpadder's problem.20:00
flacostejml: are we having a meeting?20:02
lifelessflacoste: 4pm20:03
lifelessflacoste: and 9 tomorrow, I hope20:03
flacostelifeless: nope, another one20:03
LPCIBotProject devel build (160): SUCCESS in 4 hr 0 min: https://hudson.wedontsleep.org/job/devel/160/20:41
deryckrockstar, I've disabled the windmill tests I believe to be failing and sent off to ec2 again.21:11
deryckrockstar, just ec2 test to see if it works, and then you can land if so.21:11
rockstarderyck, wtf are you?21:11
deryckrockstar, in the A hallway.  Chair at the front.  Needed power and found it here :-)21:12
rockstarderyck, I gots the power here.  Just required some looking.21:12
deryckrockstar, where you at?21:12
rockstarderyck, in the arterial hallway, where all the other launchpadders were.21:12
deryckah21:13
rockstarlifeless and I found something nasty in feature flags and I are crying.21:13
deryckrockstar, I should come there then and look into gmb's issues too21:13
rockstarderyck, yeah, "with our powers combined" and all that.21:13
deryckindeed21:13
deryckheaded that way now21:14
* rockstar WINS!21:15
rockstarlifeless, are you around?21:15
rockstargary_poster or benji or other zope-y person: I has a questions.21:17
gary_posterrockstar: i has ability to pretend not here, but will not use this ability21:17
rockstargary_poster, so, we have a new item on request.features, right?  And we use this in the base-template to assign it to features in tal.21:18
gary_posterk21:18
rockstargary_poster, but this doesn't work if you use page fragments, since they are separate requests.21:19
gary_posteryou mean separate views, I think?21:20
gary_postershould be same request21:20
rockstargary_poster, it doesn't look to be.21:20
gary_posterew21:20
* rockstar digs for an example21:20
rockstargary_poster, lib/lp/code/template/branch-index.pt:11021:21
rockstargary_poster, I've exposed a page fragment, so that we have a different template file, because otherwise the branch page can get rather large.21:22
gary_posterFor line 110 on that pt I get21:23
gary_poster      <tal:branch-pending-merges21:23
gary_poster           replace="structure context/@@++branch-pending-merges" />21:23
rockstargary_poster, yeah, that one.21:23
gary_posterso, that's calling a separate view21:23
gary_posterbut it's the same request21:23
gary_postermaybe this is a terminology thing21:23
rockstargary_poster, maybe.21:23
rockstargary_poster, the problem is that branch-pending-merges has none of the defined scope of the "parent" template.21:24
gary_posteryes21:24
gary_posterthat I'd expect21:24
gary_postercourse, it should be able to get to it with request/features21:24
gary_posterso shouldn't be hard to find21:24
rockstargary_poster, but the request object also seems to be different, since I can't do tal:define="features request/features" like base-layout.pt does.21:25
gary_posterthen that would support your statement that they are different request objects.  That's not...how I'd expect things to be done, though21:25
gary_posterso IOW this is not zope-y21:25
gary_posterbut it may be launchpad-y21:26
gary_posterI hope not :-/21:26
wgrantgary_poster: With bug #662912, is it just that the librarian forwarder thing isn't handling restricted files?21:26
wgrantI can reproduce the same behaviour with private bug attachments.21:26
gary_posterwgrant: yes, that's what I just figured out21:26
gary_posterwgrant: do you happen to know if we only recently stopped copying files over?21:27
gary_posterin favor of the forwarder thing?21:27
* gary_poster was wondering if this has always been a problem and he just didn't notice before, or what21:27
wgrantgary_poster: The forward is almost as old as staging, TTBMK.21:27
gary_posterah ok21:28
gary_posterso MP and so on have been broken on staging forever?21:28
wgrantBut that's from before my time.21:28
gary_posterprobably before mine then too :-P21:28
rockstargary_poster, so, might you have any suggestions for me?21:28
wgrantI don't know. I don't recall using MPs on staging, but it seems unlikely that they've been broken forever.21:29
gary_posterthat's what I thought too wgrant.21:29
gary_posterrockstar: option 1) you give me super-easy steps to dupe and I'll try to pdb.  option 2) you do a pdb yourself.  option 3) we see if request/features is implemented in an odd way or something.  I'll look in on option 3 for a second...21:31
rockstargary_poster, lifeless and I just had a pretty epic pdb session, so I bet I have some answers for you already.21:31
gary_posterok21:31
rockstargary_poster, see http://pastebin.ubuntu.com/520979/ - It was in this debugging that I recognized that we're getting separate requests.21:33
rockstargary_poster, hit the branch page with that patch, and you'll see a few different requests being made.21:33
gary_posterok, will try, rockstar21:34
wgrantgary_poster: Note that the restricted librarian is brand new compared to staging. So it's quite possible it was missed, as for years it was only used by the publisher, and that doesn't run on staging.21:35
gary_posterah, wgrant, maybe so21:36
=== matsubara is now known as matsubara-afk
=== Ursinha is now known as Ursinha-bbl
gary_posterrockstar: not having any luck with something accessing features.  Going to https://code.launchpad.dev/~name12 and https://code.launchpad.dev/~name12/landscape/feature-x for instance.  what do you mean by branch page?  or perhaps is there something I need to add to a template?21:39
rockstargary_poster, the latter url is what I mean by "branch page"21:40
rockstargary_poster, it seems to be starting a separate request (or at least providing a different request object) to ++branch-pending-merges21:40
gary_posterrockstar: the pdb you gave me is not being hit, presumably because the associated templates do not yet refer to request/features?21:41
gary_posterI can dig out the various templates involved, but I was hoping you'd guide me into the necessary changes to dupe21:42
gary_posteras I suspect that will be faster and more efficient, and will enable me to be lazier21:42
rockstargary_poster, sorry, that pdb isn't going to help.  A type for if "features" in self.__dict__ was stopping at every get_features, and while dealing with every stop, we saw more requests popping through.21:43
rockstargary_poster, really I can't tell you exactly how we re-produced, other than to say "a new request is created after pdb gets to a certain point in rendering"21:44
gary_poster...21:44
rockstargary_poster, I guess I should say "this is the only explanation to deal with the various issues we're seeing, and so I'd like to investigate further."21:45
deryckrockstar, https://code.edge.launchpad.net/~deryck/launchpad/populate-trac-bug-filing-form-667342/+merge/3947921:49
gary_posterrockstar: ok.  My core response is "Zope is typically not supposed to have multiple request objects for the same web request.  You generally only do that when you are changing security interactions on the fly, which is an advanced use case, and likely to need special care.  I am not aware of LP needing to change security interactions on the fly, but it is conceivable."21:49
gary_posterbut pretty darn unlikely, especially with one view calling another from the page template21:50
gary_posterrockstar: I'm happy to debug something if you can give me instructions to dupe, but I'm not keen on trying to come up with abstract ways to provoke what you describe21:51
rockstargary_poster, okay, so why would request be different between +index and ++branch-pending-merges21:51
gary_posterthey are just strings to me.21:52
rockstargary_poster, so the best way to dupe the error I'm seeing is to add a tal:condition="features/foo" to any div in lib/lp/code/templates/branch-pending-merges.pt, and see the oops.21:52
gary_posterok cool, I'll try21:53
rockstargary_poster, and then try to define features as being request/features - this time it'll oops with KeyError on features.21:53
rockstargary_poster, I assume it works with any page fragment.21:55
jcsackettdoes anyone know some workarounds for ec2 test complaining about ssh agent? usually logout/login works for me (or failing that reboot) but nothing seems to do it now.21:59
jcsacketterror is: https://pastebin.canonical.com/39136/22:00
jcsackettit's not an uncommon one, but as i said it's not usually this persistent. :-/22:01
gary_posterrockstar: I have http://pastebin.ubuntu.com/521004/ .  When I go to https://code.launchpad.dev/~name12/landscape/feature-x I see HEEY GARYYY or whatever I wrote on the main template and no OOPS and no pdb22:01
thumperrockstar: ping22:02
rockstargary_poster, I seem to have gotten SOMETHING sorted, making me look like a crazy person.  Sorry for the noise.  I'll consult with lifeless before stirring up more trouble concerning my suspicions.22:02
rockstarthumper, pong22:03
gary_postercool rockstar22:03
thumperrockstar: you have three cards for merge queues needing qa22:03
thumperrockstar: I wasn't sure what was needed22:03
rockstarthumper, yeah, duplication of effort.  Nothing is needed, or I would have addressed it in the bug tracker.  :/22:04
thumperrockstar: want to move the cards then?22:05
wallyworldthumper: abentle: standup?22:07
rockstarthumper, moved them.22:07
thumperrockstar: ta22:07
thumperwallyworld: sure22:07
thumperabentley: ping22:10
abentleythumper: pong22:10
thumperabentley: skype?22:10
thumperwallyworld: https://bugs.qastaging.launchpad.net/launchpad-code/+bug/63414922:18
lifelessrockstar: yes, can be now22:21
rockstarlifeless, I sorted it a bit, but I bet you'd like to investigate it a little more.22:21
thumperhttps://code.edge.launchpad.net/~weechat-devs/+recipe/weechat-daily WTH?22:34
thumperUnauthorized: (<lp.code.model.sourcepackagerecipebuild.SourcePackageRecipeBuild object at 0x2b9aa96eb490>, 'status', 'launchpad.View')22:34
lifelesshmm22:35
lifelessno idea ;)22:35
lifelessits still deployed via the edge config22:35
thumperI can seem my wikkid one22:35
thumperhttps://code.edge.launchpad.net/~thumper/+recipe/wikkid-daily works22:35
lifelessthat woorks for me too22:36
lifelessjcsackett: https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html22:46
jcsackettlifeless: we switched it to inprogress.22:49
jcsacketti can mark it as qa-ok to unblock deployment; it just needs further work.22:50
lifelessI have done so22:50
jcsackettone sec.22:50
jcsackettlifeless: okay.22:50
lifelessqa-ok means 'ok to deploy' really ;) - but we need to tune our tools more still.22:50
lifelessjcsackett: (I grabbed curtis :))22:50
jcsackettoh, right; you two are in proximity. :-P22:50
jcsackettlifeless: how often does the deployment-stable report refresh?22:51
lifeless10 minutes or so22:51
lifelessOnce we catch up I'll ask urshina to meaure the duration and run high-frequency22:52
lifelessjcsackett: its refreshed22:54
lifelessleonardr: https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html22:55
lifelessleonardr: please be QAing22:55
lifelessgary_poster: in case leonardr has EOD'd, perhaps you could peek at this - its a lower commit # than the thing you're qaing.22:57
gary_posterlifeless: I have to run now I'm afraid22:57
leonardrlifeless, i'll start the qa process but it'll take about 2 hours for the request token to expire (since i'm testing that they now expire)22:57
lifelessgary_poster: kk22:57
leonardrif you want i can make sure that normal approval process works first22:57
lifelessleonardr: please do - and remember for all your landings that we need to qa as soon as possible22:58
leonardrok, what am i testing against, dogfood?22:58
lifelessleonardr: qastaging.l.n refreshes ~30 minutes after things get through buildbot to stable.22:58
lifelessleonardr: qastaging.l.n22:58
leonardrhm, that's a new one, we should add it to launchpadlib.uris22:58
leonardrlifeless: please humor me and send me url to doc telling me what tag names to use, etc?22:59
leonardri've verified that normal token validation still works, so that should be enough to unblock it?23:00
lifelessleonardr: qa-ok or qa-untestable if is ok to deploy23:01
lifelessleonardr: bad-commit-XXXX where XXXX is the revno in stable if it is not ok to deploy23:01
lifelessleonardr: reference material:23:01
lifelesshttps://dev.launchpad.net/MergeWorkflow23:01
leonardrlifeless: tagging it qa-ok. i'll come back in 2 hours and see if the tokens now expire23:01
leonardrthanks23:01
lifelessand23:01
lifelesshttps://dev.launchpad.net/QAProcessContinuousRollouts23:01
lifelessleonardr: ok, so its ok to deploy ?23:01
leonardrlifeless: yes, it doesn't break the existing workflow23:02
lifelessleonardr: even if it doesn't fix the bug23:02
leonardryeah23:02
lifelessgreat, exactly what we want.23:02
leonardrlifeless: one question, will my database entry still be *there* in two hours, or will qastaging have been wiped?23:02
lifelessqastaging is wiped once a week23:02
bigjoolsjml: so, the deal is that the new b-m just eats CPU.  I restarted it and it's no different.23:02
leonardrok, i'll come back in 223:02
bigjoolsI shall debug23:03
leonardrbookmarking those pages now23:03
lifelessleonardr: cool!23:04
lifelessUrsinha-bbl: deployment report has crashed23:08
lifelessUrsinha-bbl: its the unassigned bug thing, that we *fixed*23:11
thumperlifeless: where is qastaging documented?23:29
thumperlifeless: does it have an imap folder for outgoing email?23:29
thumperlifeless: if so, where is it?23:29
thumperlifeless: by the background I'm guessing it is a copy of the database, is this right?23:30

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!