=== Ursinha is now known as Ursula === jtv changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [09:53] hi adeuring! [09:54] got an oversized one for you I'm afraid. [09:55] It's really only two very simple changes, but the diff worked out rather large. [09:55] All context, very little actual change: 989 lines (+199/-169) 42 files modified [09:58] jtv: yeah, I've noticed that. Sorry for the dealy with this repsonse -- needed to make a cup of coffee [09:58] s/dealy/delay/ [10:17] jtv: r=me === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:19] adeuring: thanks! [11:46] adeuring: up for another one? https://code.launchpad.net/~jtv/launchpad/bug-668194-fix-api/+merge/39615 [11:46] jtv: sure [11:46] thanks === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === matsubara-afk is now known as matsubara [12:13] jtv: r=me [12:13] On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:14] adeuring: thanks once more! === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [14:05] adeuring: Hallo! ;) [14:05] moin henninge [14:06] adeuring: Wärst du so nett, bitte? https://code.edge.launchpad.net/~henninge/launchpad/devel-bug-638920-private-branch/+merge/39540 [14:06] ;-) [14:06] henninge: klar! [14:07] adeuring: I'll be switching locations now but will be back here soon. [14:07] henninge: ok [14:39] adeuring: Hi, I am back! [14:40] adeuring: Is the topic lying or are you still working on one of jtv's branches? [14:40] henninge: the topic is outdated [14:40] feel free to change it [14:40] henninge: ouch, I'm looking at your branch... === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: henninge || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [14:42] adeuring: cool ;-) [14:42] henninge: I've sent a comment about your branch [15:18] adeuring: did you accidentally post your comment on henninge's branch on my MP? [15:19] jtv: gaahhh, thanks for the head-up ...and sorry for the noise! === matsubara is now known as matsubara-lunch [15:54] adeuring: oh sorry, sound turned off and not paying attention. [15:55] adeuring: you are raising a basic question there that will need discussion on the mailing list, I think. [15:56] adeuring: Are you ok with the branch if I just add the comments as you requested and leave it to a future branch to reflect the outcome of that discusstion? [16:00] henninge: yes, that's fine, I think === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:01] adeuring: cool, thanks. [16:10] adeuring: Maybe for symmetrie I should turn has_exports_enabled and uses_bzr_sync into properties, too? [16:10] henninge: yes, that would be great! [16:21] adeuring: done. Thank you very much for the review. ;-) [16:21] henninge: welcome :) === matsubara-lunch is now known as matsubara === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [Edwin] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [17:12] adeuring: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-663861-product-series-timeout-part2/+merge/39638 [17:13] Edwinsure [17:13] EdwinGrubbs: sure === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: Edwin || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [17:20] EdwinGrubbs: can the strings that are soted contain caracters outside the usual ASCII set? (like 'ö')? [17:31] adeuring: I'll check, but I don't think the productseries.name is even allowed to contain those characters. [17:34] adeuring: the valid_name() constraint only allows a-z, 0-9, "+", ".", and "-". [17:34] EdwinGrubbs: ah, OK. That makes the sorting more robust :) [17:36] EdwinGrubbs: but I think your example sorting [devfocus, 1, c] doesn't work. I believe the sort order will be [devfocus, c, 1] [17:36] EdwinGrubbs: never mind... misunderstood "devfocus" [17:37] EdwinGrubbs: but how is the code in the file interfaces/branchmergeproposal.py related to the other changes? [17:41] adeuring: doh, I made the merge-proposal against devel, when it should be against db-devel. That's why you see branchmergeproposal.py, which I didn't touch. Let me redo the mp. [17:41] EdwinGrubbs: Ahh, ok :) [17:46] adeuring: here is the new mp: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-663861-product-series-timeout-part2/+merge/39643 [17:46] EdwinGrubbs: thanks! === benji is now known as benji-lunch [18:05] EdwinGrubbs: r=me; one minor suggestion === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:05] adeuring: thanks === benji-lunch is now known as benji === henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [20:00] Anybody up for a 25 lines review? [20:00] https://code.edge.launchpad.net/~henninge/launchpad/devel-bug-666660-poimport-oops/+merge/39653 [20:04] henninge: I've +1'd it, but I need to be mentored [20:04] StevenK: thanks ;) [20:04] StevenK: how is you mentor? [20:04] hang on [20:05] thumper, the problem is it's Saturday for him [20:05] nm [20:05] ;) === henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [20:12] StevenK: thanks for taking care of this. I will start my weekend now. Enjoy your Saturday! ;) [20:12] henninge: I'm at UDS, and it's 3pm :-) [20:13] So my Saturday will involve stacks of airports and I won't enjoy it. [20:13] StevenK: Oh, then enjoy Marks closing remarks and the last night out with the guys ... ;) [20:14] StevenK: say hello to Danilo for me ;) [20:14] henninge: I shall === matsubara is now known as matsubara-afk