[09:53] <jtv> hi adeuring!
[09:54] <jtv> got an oversized one for you I'm afraid.
[09:55] <jtv> It's really only two very simple changes, but the diff worked out rather large.
[09:55] <jtv> All context, very little actual change: 989 lines (+199/-169) 42 files modified
[09:58] <adeuring> jtv: yeah, I've noticed that. Sorry for the dealy with this repsonse -- needed to make a cup of coffee
[09:58] <adeuring> s/dealy/delay/
[10:17] <adeuring> jtv: r=me
[10:19] <jtv> adeuring: thanks!
[11:46] <jtv> adeuring: up for another one?   https://code.launchpad.net/~jtv/launchpad/bug-668194-fix-api/+merge/39615
[11:46] <adeuring> jtv: sure
[11:46] <jtv> thanks
[12:13] <adeuring> jtv: r=me
[12:13] <adeuring> On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:14] <jtv> adeuring: thanks once more!
[14:05] <henninge> adeuring: Hallo! ;)
[14:05] <adeuring> moin henninge
[14:06] <henninge> adeuring: Wärst du so nett, bitte? https://code.edge.launchpad.net/~henninge/launchpad/devel-bug-638920-private-branch/+merge/39540
[14:06] <henninge> ;-)
[14:06] <adeuring> henninge: klar!
[14:07] <henninge> adeuring: I'll be switching locations now but will be back here soon.
[14:07] <adeuring> henninge: ok
[14:39] <henninge> adeuring: Hi, I am back!
[14:40] <henninge> adeuring: Is the topic lying or are you still working on one of jtv's branches?
[14:40] <jtv> henninge: the topic is outdated
[14:40] <jtv> feel free to change it
[14:40] <adeuring> henninge: ouch, I'm looking at your branch...
[14:42] <henninge> adeuring: cool ;-)
[14:42] <adeuring> henninge: I've sent a comment about your  branch
[15:18] <jtv> adeuring: did you accidentally post your comment on henninge's branch on my MP?
[15:19] <adeuring> jtv: gaahhh, thanks for the head-up ...and sorry for the noise!
[15:54] <henninge> adeuring: oh sorry, sound turned off and not paying attention.
[15:55] <henninge> adeuring: you are raising a basic question there that will need discussion on the mailing list, I think.
[15:56] <henninge> adeuring: Are you ok with the branch if I just add the comments as you requested and leave it to a future branch to reflect the outcome of that discusstion?
[16:00] <adeuring> henninge: yes, that's fine, I think
[16:01] <henninge> adeuring: cool, thanks.
[16:10] <henninge> adeuring: Maybe for symmetrie I should turn has_exports_enabled and uses_bzr_sync into properties, too?
[16:10] <adeuring> henninge: yes, that would be great!
[16:21] <henninge> adeuring: done. Thank you very much for the review. ;-)
[16:21] <adeuring> henninge: welcome :)
[17:12] <EdwinGrubbs> adeuring: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-663861-product-series-timeout-part2/+merge/39638
[17:13] <adeuring> Edwinsure
[17:13] <adeuring> EdwinGrubbs: sure
[17:20] <adeuring> EdwinGrubbs: can the strings that are soted contain caracters outside the usual ASCII set? (like 'ö')?
[17:31] <EdwinGrubbs>  adeuring: I'll check, but I don't think the productseries.name is even allowed to contain those characters.
[17:34] <EdwinGrubbs> adeuring: the valid_name() constraint only allows a-z, 0-9, "+", ".",  and "-".
[17:34] <adeuring> EdwinGrubbs: ah, OK. That makes the sorting more robust :)
[17:36] <adeuring> EdwinGrubbs: but I think your example sorting [devfocus, 1, c] doesn't work. I believe the sort order will be [devfocus, c, 1]
[17:36] <adeuring> EdwinGrubbs: never mind... misunderstood "devfocus"
[17:37] <adeuring> EdwinGrubbs: but how is the code in the file interfaces/branchmergeproposal.py related to the other changes?
[17:41] <EdwinGrubbs> adeuring: doh, I made the merge-proposal against devel, when it should be against db-devel. That's why you see branchmergeproposal.py, which I didn't touch. Let me redo the mp.
[17:41] <adeuring> EdwinGrubbs: Ahh, ok :)
[17:46] <EdwinGrubbs> adeuring: here is the new mp: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-663861-product-series-timeout-part2/+merge/39643
[17:46] <adeuring> EdwinGrubbs: thanks!
[18:05] <adeuring> EdwinGrubbs: r=me; one minor suggestion
[18:05] <EdwinGrubbs> adeuring: thanks
[20:00] <henninge> Anybody up for a 25 lines review?
[20:00] <henninge> https://code.edge.launchpad.net/~henninge/launchpad/devel-bug-666660-poimport-oops/+merge/39653
[20:04] <StevenK> henninge: I've +1'd it, but I need to be mentored
[20:04] <henninge> StevenK: thanks ;)
[20:04] <henninge> StevenK: how is you mentor?
[20:04] <henninge> hang on
[20:05] <StevenK> thumper, the problem is it's Saturday for him
[20:05] <henninge> nm
[20:05] <henninge> ;)
[20:12] <henninge> StevenK: thanks for taking care of this. I will start my weekend now. Enjoy your Saturday! ;)
[20:12] <StevenK> henninge: I'm at UDS, and it's 3pm :-)
[20:13] <StevenK> So my Saturday will involve stacks of airports and I won't enjoy it.
[20:13] <henninge> StevenK: Oh, then enjoy Marks closing remarks and the last night out with the guys ... ;)
[20:14] <henninge> StevenK: say hello to Danilo for me ;)
[20:14] <StevenK> henninge: I shall