/srv/irclogs.ubuntu.com/2010/11/01/#launchpad-reviews.txt

thumperlifeless: https://code.launchpad.net/~thumper/launchpad/blueprint-enums/+merge/39726 ?04:08
=== EdwinGrubbs is now known as Edwin-zz
=== Edwin-zz is now known as Edwin-zzz
lifelessthumper: I will look tomorrow am. I am fucked ;)04:08
thumperlifeless: np, perhaps aaron will look on his am04:09
lifelessthumper: sorry, just have trouble staying awake even :)04:10
thumperlifeless: np04:10
thumperI understand04:10
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevell-lunch
=== deryck_ is now known as deryck
=== mrevell-lunch is now known as mrevell
mrevellHey henninge, care to review a help change for me?14:36
mrevellhenninge, https://code.launchpad.net/~matthew.revell/launchpad/also-affects-help-bug-117460/+merge/3975114:36
=== sinzui changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [sinzui, sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningemrevell: sure14:39
=== mrevell changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [sinzui, sinzui,mrevell] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
mrevelloh, thanks henninge14:40
henningemrevell: the "read more" link should probably not open in the pop-up window .... ;-)14:54
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: mrevell || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
mrevellhenninge, Oh! Damn. Yes.14:54
henningemrevell: what's the "invisible-link" span for?14:55
mrevellhenninge, Hmm. I'm not certain. I cargo-culted the HTML from the help link next to the "add tags" link below it. allenap, I think, implemented that, am I right allenap?14:56
henningeit may be about graceful degradation. Let me try that.14:57
allenapmrevell: I don't remember :-/14:58
=== stub1 is now known as stub
allenapIf I did, I probably cargo-culted it from somewhere else too.14:58
mrevellI think graceful degradation seems most likely14:59
henningeI could not reproduce it but I assume it triggers a context pop-up on the link.15:03
henningemrevell: with that "read more" link fixed, r=me ;-)15:04
mrevellthanks henninge.15:05
henningeMaybe it's a good idea to raise the ivisible links question somewhere (meeting, ml), to check if it really still serves a purpose.15:05
mrevellhenninge, Will do. I've actually just changed the branch slightly. I have now included a patch that Bryce attached to the bug report. It adds some explanatory text to the +choose-affected-product page. Would you please be able to take a look at the updated MP?15:11
henningemrevell: I just put it as an item on the reviewer's meeting agenda. I am sure we'll have an answer there.15:12
mrevellAh thanks henninge15:13
henningemrevell: r=me. Thank you for that addition15:18
mrevellthanks henninge15:18
henningemrevell: have fun landing that branch ... we have been in testfix for quite a long time now.15:19
mrevellhenninge, Yes, so I understand :(15:19
=== henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: mrevell || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji is now known as benji-lunch
=== deryck is now known as deryck[lunch]
henningesinzui: Hi!16:15
sinzuihi henninge16:15
henningesinzui: can you please check why your MP has such a large diff?16:15
henningehttps://code.edge.launchpad.net/~sinzui/launchpad/merge-karma-1/+merge/3962316:15
sinzuihenninge, oops16:17
sinzuihenninge, I will re-request that to the correct env16:17
henningesinzui: cool.16:18
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji-lunch is now known as benji
=== deryck[lunch] is now known as deryck
=== sinzui changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningesinzui: r=me coming in by mail ;-) Just some comments on comments and my usual multi-line if condition17:50
henningecomment ...17:51
=== henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
sinzuihenninge, thanks. I will clean up my branch17:51
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
abentleysinzui: why is all the DB manipulation in SQL rather than Storm expressions?18:04
sinzuiabentley, because we are by-passing caches and constraints to dismantle the object18:05
abentleysinzui: SQL can bypass constraints?18:05
sinzuiabentley, All this may change in a few months when merge itself is changed to a job and possibly a garbo18:06
sinzuiabentley, no mode contraints18:06
sinzuimodel18:06
abentleysinzui: are you bypassing model constraints in this patch, or just following the existing style?18:08
sinzuiabentley, I am following the existing style. It believe it is from 200618:09
abentleysinzui: on 33, is "if result" equivalent to "if result is not None"?  If so, please use the latter.18:10
sinzuiabentley, the merge code is funky, but we are reimplementing all of it in the next 3 months18:10
sinzuiabentley, I will fix all the merge code ``if result is None:``18:12
abentleysinzui: even better.  Thanks.18:13
abentleysinzui: I think it's actually "if len(result) > 0", though.18:13
abentleysinzui: no, my bad.18:14
abentleysinzui: Not used to reading direct SQL manipulation.18:14
sinzuime neither18:14
abentleysinzui: aside from that, everything looks good to me.18:16
sinzuifetchone is pretty ambiguous in the code. I see this as an example in the same module: ``bool(cur.fetchone()[0])``18:17
abentleysinzui: So that would evaluate the truth of the zeroth column.18:18
sinzuiyes, I see that now18:19
abentleysinzui: http://www.python.org/dev/peps/pep-0249/ says it returns None when no more data is available.18:20
sinzuiI found the DB-API  docs. yes None if there are no more rows in the resultset18:21
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
leonardrabentley: take a look at the exciting https://code.launchpad.net/~leonardr/launchpadlib/ask-for-desktop-integration/+merge/3977220:01
abentleyleonardr: ack20:01
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: leonardr || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
abentleyleonardr: Looks good.  I think you've added an unnecessary blank line at 287.  It's nice to see that big email thread actually produced results.20:08
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!