| wallyworld_ | StevenK: i've been told to ask you to review this pretty please https://code.edge.launchpad.net/~wallyworld/launchpad/person-mergequeue-listview/+merge/39745 | 02:05 |
|---|---|---|
| StevenK | wallyworld_: Let me guess, he shares an IRC nick with a character from Bambi | 02:06 |
| wallyworld_ | StevenK: yes, you are very clever today :-) | 02:06 |
| StevenK | Argh, 1500 lines | 02:20 |
| === mwhudson_ is now known as mwhudson | ||
| === bryceh changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [bryce] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: bryce || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === leonardr changed the topic of #launchpad-reviews to: On call: gmb, leonardr || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | jml: ReviewerSchedule shows that you're a ui* reviewer. Would you be able to review my branch? | 15:09 |
| jml | allenap: not today, sorry. | 15:09 |
| allenap | jml: Okay, thanks anyway. | 15:09 |
| leonardr | benji, i'm a tiny bit concerned about the level of detail in the examples in https://code.edge.launchpad.net/~benji/launchpad/add-launchpadlib-examples/+merge/39845 | 15:11 |
| leonardr | how serious were you about the "the docs should be testable" thing? | 15:11 |
| leonardr | i don't want to make the docs even easier to go out of sync with the code | 15:11 |
| benji | leonardr: I think tested docs are important. Which bit worries you? | 15:12 |
| leonardr | benji: like, the ten print statements for all the fields | 15:13 |
| leonardr | seems like you could just do one or two and let the user get the individual field names from the apidoc | 15:13 |
| benji | I think the reason he included those was that they aren't otherwise documented. | 15:15 |
| leonardr | oh, i see | 15:16 |
| leonardr | in that case, they're launchpadlib documentation | 15:16 |
| leonardr | they should go into lazr.restfulclient HostedFile doctest | 15:16 |
| leonardr | s/test/string/ | 15:16 |
| benji | although, some of them are a bit silly; very few people know what the softspace attribute is or why a file has it | 15:17 |
| benji | sounds good | 15:17 |
| leonardr | benji: also, in the IBugAttachment docstring, are you missing some :: that needs to be there? | 15:18 |
| benji | leonardr: nope; there is a double colon at the end of the text (which is rendered as a single colon and introduces a literally quoted block) | 15:19 |
| benji | the double colon all by itself is for when you want to make a literal quote without any proceeding text ending in a colon | 15:20 |
| === benji is now known as benji-lunch | ||
| leonardr | benji: wow, ok | 15:29 |
| leonardr | benji, both reviews are in | 15:48 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === Ursula is now known as Ursinha-afk | ||
| === benji-lunch is now known as benji | ||
| === leonardr is now known as leonardr-voting | ||
| === leonardr-voting is now known as leonardr | ||
| benji | leonardr: I replaced the bit with all the buffer.attr prints with a note to the user about finding information about the HostedFile object in the lazr.restfulclient documentation. | 20:10 |
| benji | the MP has the updated diff: https://code.edge.launchpad.net/~benji/launchpad/add-launchpadlib-examples/+merge/39845 | 20:11 |
| leonardr | ok, cool | 20:11 |
| leonardr | gmb or mars: https://code.launchpad.net/~leonardr/launchpad/reword-desktop-integration/+merge/39892 | 20:24 |
| mars | leonardr, I'll take it | 20:24 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: leonardr || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| leonardr | benji, r=me | 20:55 |
| benji | thanks | 20:55 |
| === mars changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === bryceh changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [bryce] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!