[02:05] <wallyworld_> StevenK: i've been told to ask you to review this pretty please https://code.edge.launchpad.net/~wallyworld/launchpad/person-mergequeue-listview/+merge/39745
[02:06] <StevenK> wallyworld_: Let me guess, he shares an IRC nick with a character from Bambi
[02:06] <wallyworld_> StevenK: yes, you are very clever today :-)
[02:20] <StevenK> Argh, 1500 lines
[15:09] <allenap> jml: ReviewerSchedule shows that you're a ui* reviewer. Would you be able to review my branch?
[15:09] <jml> allenap: not today, sorry.
[15:09] <allenap> jml: Okay, thanks anyway.
[15:11] <leonardr> benji, i'm a tiny bit concerned about the level of detail in the examples in https://code.edge.launchpad.net/~benji/launchpad/add-launchpadlib-examples/+merge/39845
[15:11] <leonardr> how serious were you about the "the docs should be testable" thing?
[15:11] <leonardr> i don't want to make the docs even easier to go out of sync with the code
[15:12] <benji> leonardr: I think tested docs are important.  Which bit worries you?
[15:13] <leonardr> benji: like, the ten print statements for all the fields
[15:13] <leonardr> seems like you could just do one or two and let the user get the individual field names from the apidoc
[15:15] <benji> I think the reason he included those was that they aren't otherwise documented.
[15:16] <leonardr> oh, i see
[15:16] <leonardr> in that case, they're launchpadlib documentation
[15:16] <leonardr> they should go into lazr.restfulclient HostedFile doctest
[15:16] <leonardr> s/test/string/
[15:17] <benji> although, some of them are a bit silly; very few people know what the softspace attribute is or why a file has it
[15:17] <benji> sounds good
[15:18] <leonardr> benji: also, in the IBugAttachment docstring, are you missing some :: that needs to be there?
[15:19] <benji> leonardr: nope; there is a double colon at the end of the text (which is rendered as a single colon and introduces a literally quoted block)
[15:20] <benji> the double colon all by itself is for when you want to make a literal quote without any proceeding text ending in a colon
[15:29] <leonardr> benji: wow, ok
[15:48] <leonardr> benji, both reviews are in
[20:10] <benji> leonardr: I replaced the bit with all the buffer.attr prints with a note to the user about finding information about the HostedFile object in the lazr.restfulclient documentation.
[20:11] <benji> the MP has the updated diff: https://code.edge.launchpad.net/~benji/launchpad/add-launchpadlib-examples/+merge/39845
[20:11] <leonardr> ok, cool
[20:24] <leonardr> gmb or mars: https://code.launchpad.net/~leonardr/launchpad/reword-desktop-integration/+merge/39892
[20:24] <mars> leonardr, I'll take it
[20:55] <leonardr> benji, r=me
[20:55] <benji> thanks