=== StevenK changed the topic of #launchpad-reviews to: On call: StevenK || Reviewing: bryce || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[03:47] <EdwinGrubbs> lifeless: thanks for the review
[03:50] <lifeless> de naga
[04:09] <wallyworld> StevenK: new a new mp. but the diff is still not quite right. diff says lib/lp/code/model/branchmergequeue.py is deleted but it's only been modified
[04:10] <wallyworld> doing a bzr merge --preview ..... locally shows the right diff. and i checked that everything has been pushed
[06:27] <jtv> StevenK: want to review a short and hopefully fun one?  https://code.launchpad.net/~jtv/launchpad/importqueue-test-cleanup/+merge/39931
[06:29] <jtv> 3 lines added, 18 removed
[06:31] <StevenK> wallyworld: The MP is against devel, the previous was against db-devel?
[06:32] <wallyworld> StevenK: bugger. should be against db-devel. i don't think we can edit that?
[06:32] <StevenK> Nope
[06:32] <jtv> Nope.
[06:32] <StevenK> Resubmit again
[06:33] <wallyworld> the world hates me today :-(
[06:33] <wallyworld> StevenK: should i delete the other ones?
[06:33]  * jtv does not hate wallyworld
[06:34] <StevenK> wallyworld: If you wish, delete the devel one at least
[06:34] <wallyworld> jtv: you haven't met me yet - give yourself time :-)
[06:34] <jtv> sure, sure, no worries
[06:34] <jtv> Meanwhile, there's reviews.  :)
[06:35] <wallyworld> StevenK: i was thinking about copying the comments from the 1st one across and then deleting
[06:35] <StevenK> That sounds good, do that
[06:35] <wallyworld> ack
[06:36] <jtv> StevenK, lifeless: thanks for the near-instantaneous review
[06:36] <jtv> s
[06:37] <lifeless> third most important thing we can do
[06:37] <StevenK> jtv: We aim to please.
=== StevenK changed the topic of #launchpad-reviews to: On call: StevenK || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[06:41] <jtv> Oh well, one of the reasons for review is to ensure that there are witnesses.
[06:42] <lifeless> jtv: errrrr
[06:42] <jtv> Never mind, middle of a rambling thought.  I'm actually sick.
[06:45] <wallyworld> StevenK: 3rd time lucky https://code.edge.launchpad.net/~wallyworld/launchpad/person-mergequeue-listview/+merge/39933
[06:46]  * wallyworld runs away for doctor appt
[07:12] <lifeless> https://code.launchpad.net/~lifeless/launchpad/soyuz/+merge/39934
[07:12] <lifeless> StevenK: ^
[07:14] <StevenK> lifeless: Why are you looping twice?
[07:18] <lifeless> partition
[07:18] <lifeless> grab source package names
[07:18] <lifeless> query
[07:18] <lifeless> process
[07:21] <lifeless> you can see this if you look at what is being passed into each function
[07:22] <StevenK> lifeless: apt_pkg.VersionCompare is horribly slow
[07:23] <StevenK> I thought we had an internal function for it
[07:23] <lifeless> StevenK: we can iterate further
[07:23] <StevenK> lifeless: That's my only concern then -- I thought we had something that meant we didn't need to use apt_pkg
[07:24] <lifeless> StevenK: theres lots more to do here :)
[07:24] <lifeless> StevenK: I haven't added new uses :>
[07:25] <StevenK> The only code that uses apt_pkg are the ftpmaster scripts, I'm a little retiscent to rubber-stamp usage somewhere else, given my opinion of it
[07:25] <lifeless> StevenK: lies!
[07:25] <lifeless> StevenK: look at the diff
[07:26] <StevenK> Rargh
[07:26]  * StevenK shakes his fist at the publisher
[07:27] <lifeless> StevenK: I've moved from A to B and refactored; I've not added any new calls to existing functions : I've reduce the total call count by grouping things for an existing multiple-object interface.
[08:22] <stub> lifeless: https://code.launchpad.net/~stub/launchpad/trivial/+merge/39935
[08:23] <stub> or StevenK since you are oncall
[08:24] <StevenK> I just read through it, +1
[08:25] <StevenK> But lifeless has already reviewed it
[08:29] <stub> Ta
[08:32] <lifeless> thumper: if you have a minute, https://code.launchpad.net/~lifeless/launchpad/soyuz/+merge/39934 is +1 from StevenK but needs the mentor stamp
[08:32] <lifeless> thumper: its just moved for efficiency code
[08:32]  * thumper takes a quick look
=== matsubara-afk is now known as matsubara
[12:22] <jelmer> StevenK: Hi
[12:22] <jelmer> StevenK: Are you still on call?
=== jelmer changed the topic of #launchpad-reviews to: On call: StevenK, jelmer(lunch)  || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== StevenK changed the topic of #launchpad-reviews to: On call: jelmer(lunch)  || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha-afk is now known as Ursinha
=== mrevell is now known as mrevell-lunch
[14:05] <gmb> jelmer: I have a branch for review if you've got the time.
=== mrevell-lunch is now known as mrevell
=== matsubara is now known as matsubara-lunch
[15:44] <henninge> jelmer: Hi! I have a mechanic renaming branch coming up.
=== salgado is now known as salgado-lunch
[15:45] <henninge> Not much to see, should be quick. ;-)
[15:47] <jelmer> henninge: no problemo
[15:47] <henninge> jelmer: https://code.edge.launchpad.net/~henninge/launchpad/recife-rename-from-upstream/+merge/39980
[15:47] <henninge> thanks
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: jelmer, Edwin || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-lunch is now known as matsubara
=== benji is now known as benji-lunch
=== salgado-lunch is now known as salgado
[17:01] <henninge> EdwinGrubbs: Are you you, or are you Edwin-afk?
[17:01] <henninge> ;)
[17:12] <EdwinGrubbs> henninge: I'm back now
[17:13] <henninge> EdwinGrubbs: Cool ;)
=== benji-lunch is now known as benji
[18:19] <jelmer> EdwinGrubbs, Hi!
[18:19] <EdwinGrubbs> jelmer: hi
[18:20] <jelmer> EdwinGrubbs: Can I add a branch to your review queue?
[18:21] <jelmer> EdwinGrubbs: It's a private one, https://code.launchpad.net/~jelmer/launchpad/669676/+merge/39955
[18:21] <EdwinGrubbs> jelmer: sure
[18:32] <EdwinGrubbs> jelmer: I can't view your branch. You may have to change the owner of it to a team.
[18:34] <jelmer> EdwinGrubbs: I've subscribed canonical-launchpad-reviewers, can you try again?
[18:36] <EdwinGrubbs> jelmer: ok, it works now.
[18:36] <lifeless> jelmer: that doesn't need to be private
[18:37] <lifeless> jelmer: because we've a cowboyed fix in place.
=== Ursinha-afk is now known as Ursinha
[18:55] <benji> On call: jelmer, Edwin || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji changed the topic of #launchpad-reviews to: On call: jelmer, Edwin || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[18:55] <benji> heh
[18:56] <benji> here's the MP: https://code.launchpad.net/~benji/lazr.restful/bug-539070/+merge/40003
[18:56] <benji> it's a small change to lazr.restful
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: jelmer, Edwin || Reviewing: jelmer || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[18:58] <EdwinGrubbs> benji: I'll get to it in a little while.
[18:58] <benji> cool
[19:05] <EdwinGrubbs> jelmer: since deactivateTokens() gets the Archive for every single token the query returns, it should be more efficient to load it in a single query, for example: store.find((ArchiveAuthToken, Archive), ...)
[19:06] <jelmer> EdwinGrubbs: Ah, that's a good point.
[19:07] <EdwinGrubbs> jelmer: that's my only suggestion. r=me
[19:13] <jelmer> EdwinGrubbs, thanks!
[19:21] <bdmurray> Could I get https://code.edge.launchpad.net/~brian-murray/launchpad/bug-supervisor-bug-expiry-submit/+merge/39900 added to the review queue?
[19:25] <EdwinGrubbs> benji: It seems to me that the bug is asking to be told that SomeClass.gpg_keys is trying to return an IGPGKeySet, which doesn't have an IEntry adapter, but your code appears to just tell the user where IGPGKeySet is defined.
[19:26] <benji> hmm, I'll double check
[19:28] <benji> EdwinGrubbs: you are correct!  Thanks for the catch.  I'll fix that.
=== matsubara is now known as matsubara-afk
[20:53] <jcsackett> EdwingGrubbs, jelmer: room for one more in the queue? https://code.edge.launchpad.net/~jcsackett/launchpad/convert-sql-627631/+merge/40021
=== jcsackett changed the topic of #launchpad-reviews to: On call: jelmer, Edwin || Reviewing: jelmer || queue: [benji, jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:22] <jcsackett> EdwinGrubbs: i munged your name earlier. link to the MP is above, if you have time--it's not very long. ^
[21:25] <EdwinGrubbs> jcsackett: I'll take a look at it.
[21:30] <jcsackett> EdwinGrubbs: cool, thansk.
[21:30]  * jcsackett cannot type today...
[21:55] <EdwinGrubbs> jcsackett: review sent
[21:55] <jcsackett> EdwinGrubbs: thanks!
[22:20] <bdmurray> EdwinGrubbs: do you have time for another review?
[22:20] <EdwinGrubbs> bdmurray: if it's small
[22:21] <bdmurray> EdwinGrubbs: yes, rather small. https://code.edge.launchpad.net/~brian-murray/launchpad/bug-supervisor-bug-expiry-submit/+merge/39900
[22:29] <EdwinGrubbs> bdmurray: review sent
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[22:50] <thumper> rockstar, and other? : https://code.launchpad.net/~thumper/launchpad/recipe-help/+merge/39922
[23:04] <rockstar> thumper, looking
[23:05] <thumper> rockstar: thanks
=== salgado is now known as salgado-afk