| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | good morning LP | 00:44 |
|---|---|---|
| bac | bring out reviews if you need them | 00:44 |
| === benji changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | thumper: for a mentored review use "code" as the type. i don't think our tools understand "mentor". let me know if i'm wrong. | 04:15 |
| thumper | bac: ah, ok | 04:16 |
| lifeless | bac: Do they understand mentoring at all ? | 04:33 |
| bac | lifeless: the last time i looked they knew about code and code*, converting them to [r=mentat,mentor] | 04:35 |
| bac | i don't think they will reject a code* with no code | 04:35 |
| lifeless | interesting | 04:35 |
| lifeless | thanks | 04:35 |
| jtv1 | hi bac! Got one coming up for ya | 08:46 |
| jtv1 | Nice, simple one. | 08:46 |
| jtv1 | What could go wrong, right? :-) | 08:46 |
| === jtv1 is now known as jtv | ||
| bac | ok, jtv | 08:46 |
| jtv | (still generating diff) | 08:46 |
| jtv | bac: there it is! https://code.launchpad.net/~jtv/launchpad/recife-translationpolicy/+merge/40165 | 08:47 |
| jtv | Gave it a nice political twist. | 08:47 |
| === adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | hi adeuring! | 09:14 |
| === jtv changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: jtv, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | (more accurate I believe) | 09:15 |
| === bac changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | adeuring: i'm going to leave the reviewing to you for the day. | 10:04 |
| adeuring | bac: have a nice weekend! | 10:04 |
| === bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | you too, abel. | 10:04 |
| adeuring | thanks! | 10:04 |
| === Guest26427 is now known as jelmer | ||
| jelmer | adeuring: Hi! | 11:15 |
| jelmer | adeuring: Can I add a MP to your queue? | 11:15 |
| adeuring | jelmer: sure | 11:15 |
| jelmer | The MP is at https://code.launchpad.net/~jelmer/launchpad/syncpackagejob-1/+merge/40169 | 11:15 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| adeuring | jelmer: your TODO comment in getctiveJobs() says that you don't expect a larger result set for the find() call. What about logging a warning if the result set is greater than a reasonable threshold? | 11:48 |
| jelmer | adeuring: That makes sense. | 11:48 |
| adeuring | jelmer: great, so, r=me. | 11:49 |
| jelmer | adeuring: Thanks! | 11:49 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === Ursinha is now known as Ursinha-lunch | ||
| jtv | adeuring: got a simple one for you… https://code.launchpad.net/~jtv/launchpad/enum-translationpermission/+merge/40192 | 15:19 |
| jtv | Whoops, and just like that I spot an __all__ line I forgot to clean up. Pushing change now. | 15:21 |
| === matsubara is now known as matsubara-lunch | ||
| adeuring | jtv: I'll look | 15:26 |
| jtv | thanks! | 15:27 |
| adeuring | jtv: approved | 15:40 |
| abentley | rockstar: I can has review? https://code.launchpad.net/~abentley/launchpad/resubmit-change-branch/+merge/40126 | 15:50 |
| rockstar | abentley, looking | 16:11 |
| jtv | thanks adeuring | 16:13 |
| === matsubara-lunch is now known as matsubara | ||
| === benji is now known as benji-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| === benji-lunch is now known as benji | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer | jml: is there a bug for the mp you just submitted? I'm just curious about the reasoning behind it. | 18:30 |
| jml | jelmer: I couldn't find one | 18:30 |
| jml | jelmer: we don't need to have a coc signed before allowing uploads. | 18:30 |
| jml | jelmer: ergo, the code can be deleted | 18:30 |
| jelmer | jml: I guess that's what I'm curious about, why is having the coc signed not necessary? | 18:32 |
| jml | jelmer: why is it necessary? | 18:32 |
| jelmer | jml: PPA's are specific to Ubuntu, and as such I think the CoC is relevant. | 18:34 |
| jelmer | jml: people who create and maintain PPA's are ubuntu community members | 18:34 |
| jml | jelmer: some of them are | 18:34 |
| jelmer | jml: Hmm | 18:37 |
| jml | jelmer: anyway, I plan on talking about it w/ you & bigjools next week | 18:38 |
| jelmer | jml: ah, ok. I can wait :-) | 18:38 |
| jml | jelmer: I just figured I'd put the patch up since it's fairly simple, and if I talked first it would have ended up on a queue of bugs rather than a queue of patches | 18:38 |
| jelmer | jml: Makes sense. | 18:39 |
| jelmer | jml: Enjoy your weekend! talk to you next week. | 18:40 |
| === matsubara is now known as matsubara-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!