| === _mup__ is now known as _mup_ | ||
| stub | lifeless: Does https://code.launchpad.net/~stub/launchpad/update-storm/+merge/40264 need to go through review? | 06:46 |
|---|---|---|
| stub | 2.4k of pretty much mechanical changes and delintings | 06:46 |
| lifeless | stub: hi | 06:55 |
| lifeless | uhm, I wouldn't, but I would get the *approach* discussed | 06:57 |
| lifeless | stub: e.g. the cast in the core is a little concerning in general | 06:57 |
| stub | lifeless: Didn't really seem to be any other sane way of doing it. I could have fixed the tests feeding raw strings in, but that could create too many brush fires on production with all our untested code paths (or even fixing some of our tests - gina.txt is utterly inscrutable). | 07:06 |
| StevenK | gina.txt is a horrid test | 07:07 |
| lifeless | sure | 07:07 |
| lifeless | I guess the main thing to do is to behave sanely if a non-ascii str is passed in | 07:07 |
| === bac changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: allenap, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| lifeless | as well as have some way to let us incrementally report and fix things | 07:08 |
| === bac changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| lifeless | the former should be done before landing for safety IMO | 07:08 |
| lifeless | the latter whenever | 07:08 |
| stub | lifeless: Where I have a unicode() cast, I could change that to something else that raises a warning, but I suspect that would be YAGNI. | 07:08 |
| lifeless | I suggest this: | 07:09 |
| lifeless | if type(thing) is not unicode: | 07:09 |
| lifeless | try: | 07:09 |
| lifeless | thing = thing.decode('utf8') | 07:09 |
| lifeless | except UnicodeDecodeError: | 07:09 |
| lifeless | bail | 07:09 |
| lifeless | shove that in a helper | 07:10 |
| stub | Oh - nothing should be getting UTF8 that I changed. We do want it to explode if we get non-ascii. | 07:10 |
| lifeless | just doing a plain cast to unicode is a problem because it can do nuts things | 07:10 |
| lifeless | stub: sure, s/utf8/ascii/ there | 07:10 |
| * stub wonders if there is an easy way to s/unicode/ensure_unicode/g in the lines changed in my branch | 07:17 | |
| lifeless | grep + interdiff might be able to do something | 07:26 |
| stub | interdiff does the magic | 08:01 |
| === henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| henninge | bigjools, jtv: if either of you would be so kind (maybe a revie is optional here ... ;) | 11:33 |
| henninge | https://code.edge.launchpad.net/~henninge/launchpad/devel-difftacular/+merge/40419 | 11:33 |
| bigjools | henninge: sounds like a perfect no-review branch to me | 11:34 |
| bigjools | (without looking that is) | 11:34 |
| henninge | what is the tag | 11:34 |
| henninge | ? | 11:34 |
| henninge | [rs=henninge] ? | 11:34 |
| bigjools | no idea, I'm waaaay behind on email | 11:34 |
| henninge | ;) | 11:34 |
| jtv | Something like r=noreview, but probably not that | 11:34 |
| bigjools | rs=me ? | 11:35 |
| bigjools | do the tools work with this brave new world? | 11:35 |
| jtv | henninge: too late, I've already approved it | 11:35 |
| henninge | w00t! | 11:35 |
| henninge | jtv: thanks | 11:35 |
| StevenK | gmb: Hai! If you're still reviewing, I have a small branch ready for you | 12:24 |
| === Ursinha-afk is now known as Ursinha | ||
| gmb | StevenK: Sure. Link me | 13:02 |
| === mrevell is now known as mrevell-lunch | ||
| StevenK | gmb: https://code.edge.launchpad.net/~stevenk/launchpad/move-ppaexception/+merge/40408 | 13:06 |
| * gmb looks | 13:06 | |
| gmb | StevenK: 81 lines. My kinda branch. | 13:07 |
| StevenK | Haha | 13:07 |
| gmb | StevenK: r=me | 13:07 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| mars | StevenK, hi | 13:10 |
| mars | morning gmb | 13:11 |
| gmb | Hi mars | 13:11 |
| StevenK | mars: Hi | 13:14 |
| mars | gmb, have you started into the activereviews pile? | 13:14 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | mars: No, I haven't yet. | 13:19 |
| gmb | I will be doing shortly, though. | 13:20 |
| gmb | mars: Feel free to make a start and I'll pick up whatever you're not working on. | 13:20 |
| mars | gmb, ok, I'll update the topic as I go | 13:20 |
| gmb | Cool | 13:20 |
| gmb | mars: Also, using "Claim review" takes it out of the list for the review team. | 13:21 |
| mars | gmb, ah! thanks | 13:22 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell-lunch is now known as mrevell | ||
| jtv | gmb: care for a small one? The funny bits are in the larger follow-up branch though. https://code.launchpad.net/~jtv/launchpad/recife-pre-cleanups/+merge/40434 | 14:55 |
| gmb | jtv: Sure. | 14:56 |
| jtv | thx | 14:56 |
| gmb | jtv: r=me | 15:01 |
| jtv | gmb: thanks | 15:01 |
| * gmb goes off call for to do some hackering | 15:09 | |
| === gmb changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | mars: can you take my big one? | 15:15 |
| jtv | After some wild swings, it came out at a neat 799 lines. | 15:15 |
| jtv | https://code.launchpad.net/~jtv/launchpad/recife-policy-invites-allows/+merge/40438 | 15:15 |
| mars | jtv, I can, I'm helping deryck with something though, so it may be a bit before I can start it | 15:17 |
| mars | first on the queue though | 15:17 |
| jtv | mars: great, thanks. I'll wander in and out for the coming few hours. | 15:17 |
| === matsubara is now known as matsubara-lunch | ||
| === jtv changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | (as agreed) | 15:38 |
| === Ursinha is now known as Ursinha-doctor | ||
| === matsubara-lunch is now known as matsubara | ||
| === benji is now known as benji-lunch | ||
| === Ursinha-doctor is now known as Ursinha | ||
| === benji-lunch is now known as benji | ||
| === benji changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [jtv, benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| benji | mars: when you get a chance, here's a small MP for your perusal: https://code.launchpad.net/~benji/launchpad/bug-621090/+merge/40474 | 19:16 |
| mars | thanks benji | 19:17 |
| salgado | sinzui, I haven't been getting any UI reviews lately. is it just me or are devs not working on UI lately? | 19:22 |
| sinzui | I have had only one request in 3 weeks, and I could not do it | 19:23 |
| sinzui | salgado, I think lose of edge is causing us to rethink ui. | 19:24 |
| salgado | sinzui, why's that? | 19:25 |
| sinzui | I think people are learning feature flags. | 19:26 |
| sinzui | I think weeks 4 and 1 were busiest for UI because we need to get UI changes on edge. | 19:26 |
| sinzui | Since UDS was on a week 1, we may have had a natural decline in UI requests | 19:27 |
| salgado | yeah, that's possible | 19:28 |
| sinzui | salgado, my team is at the end of a feature. so we have less UI work, but expect a lot in a few weeks | 19:28 |
| sinzui | the code team will get a lot in a few weeks too because they will hack on blueprints | 19:29 |
| salgado | sinzui, cool, I'm looking forward to some UI reviews. | 19:31 |
| sinzui | You will get lots. henninge, you, and myself are the UI reviewers | 19:33 |
| jtv | mars: hope you'll be able to get to my branch, because the next OCR shift is probably yours truly! | 19:42 |
| mars | jtv, :) | 19:44 |
| mars | jtv, I was just looking at it | 19:44 |
| mars | jtv, isn't it three in the morning for you right now? | 19:44 |
| jtv | mars: just about :) | 19:49 |
| === Ursinha is now known as Ursinha-brb | ||
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| === mars changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [jtv, benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| thumper | https://code.launchpad.net/~thumper/launchpad/recipe-builds/+merge/40489 anyone? | 23:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!