| thumper | lifeless: thanks | 01:27 |
|---|---|---|
| lifeless | hmm? | 01:27 |
| lifeless | oh, de nada | 01:27 |
| lifeless | stub: hi | 04:27 |
| stub | yo | 04:28 |
| lifeless | https://code.launchpad.net/~lifeless/launchpad/soyuz/+merge/40499 | 04:28 |
| lifeless | I fucked ppa/+packages | 04:28 |
| lifeless | this should fix it | 04:28 |
| jtv | such a marvelous language, Strine… | 04:33 |
| StevenK | lifeless: You removed a XXX, did you address it? | 04:38 |
| lifeless | StevenK: look up the bug :) | 04:47 |
| StevenK | lifeless: Which is Invalid, and filed against lazr.delegates ... | 04:49 |
| lifeless | right | 04:49 |
| StevenK | lifeless: Commented. | 05:16 |
| lifeless | stub: are you up to do a review on this? | 05:57 |
| stub | yo | 07:02 |
| stub | Ahh... steve beat me so I don't have to pretend to understand soyuz | 07:03 |
| lifeless | stub: StevenK isn't a full reviewer yet | 07:22 |
| stub | Well he did a better job than I would have done ;) | 07:22 |
| lifeless | stub: so rs it :) | 07:22 |
| stub | Yer. Looks fine. My eyes glazed over a little during the tests but she'll be right. | 07:23 |
| stub | Need more coffee | 07:24 |
| lifeless | thanks - can you clicky clicky on approved then ? | 07:25 |
| lifeless | [as a review I mean] | 07:25 |
| allenap | gmb: Would you have 5 minutes to take a look at https://code.launchpad.net/~allenap/launchpad/trac-fixreleased-bug-667340/+merge/40507? It's a very simple externalbugtracker branch. | 09:35 |
| gmb | allenap: Sure | 09:41 |
| gmb | allenap: You need to update the commit message (the remote status is 'fixverified' rather than 'fixreleased'). r=me on the code, though. | 09:43 |
| allenap | gmb: Good spot, and thank you :) | 09:53 |
| === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | jelmer_: Hi, I've got a branch for you if you'd be so kind: https://code.launchpad.net/~gmb/launchpad/add-bnl-to-structsubs-bug-672507/+merge/40522 | 12:04 |
| * jelmer_ is in a kind mood today | 12:06 | |
| gmb | :) | 12:06 |
| === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer_ | gmb: hi again | 13:13 |
| bigjools | jml: https://code.launchpad.net/~julian-edwards/launchpad/buildd-manager-fixes | 13:14 |
| bigjools | when the email hits the MP will get created | 13:14 |
| gmb | jelmer_: Hi | 13:15 |
| bigjools | jml: ok MP got created, it's all yours. I need to eat before I faint now. | 13:18 |
| jelmer_ | gmb: r=me, I just have one comment. It seems like it would be useful to have some infrastructure for running tests against all things that support structural subscription. I reviewed another branch a while back that also did it manually using a seperate TestCase subclass for each. | 13:18 |
| gmb | jelmer_: I agree with you wholeheartedly, but I think fixing that here is out of scope. I'll be happy to file a bug to follow up at a later date, though (we're doing lots of work around structural subs, so it should get dealt with rather than just being ignored). | 13:20 |
| jml | bigjools: done | 13:20 |
| jml | bigjools: although, irritatingly this makes more work in my testtools-experiment branch. | 13:21 |
| jelmer_ | gmb: It'd be great if you could file a tech-debt bug about it. Anyway, just a thought. | 13:21 |
| bigjools | jml: thanks - and why? | 13:21 |
| jml | (that's what I deserve for a large branch unlanded over a course of weeks) | 13:21 |
| === danilo_ is now known as danilos | ||
| gmb | jelmer_: Agreed. Will do. | 13:21 |
| bigjools | jml: oh I know nothing about large unlanded branches :) | 13:21 |
| jml | bigjools: it changes all of the Trial tests to use testtools. You're changing the test class structure, so I have to merge in & fix | 13:21 |
| bigjools | jml: ah right - yeah I had to do that because the old structure was running tests twice | 13:22 |
| jml | bigjools: yeah, it's the right thing to do. | 13:22 |
| jml | I just wish I had more time to hack, and that easy things were easy | 13:22 |
| jml | and that there was peace on earth, and ponies for all | 13:23 |
| bigjools | you didn't spot the obvious fsckup tho :) | 13:23 |
| jml | bigjools: oh? | 13:23 |
| bigjools | super(TestBuilderWithTrial, self) | 13:23 |
| bigjools | wrong class name now | 13:23 |
| bigjools | my bad for not running the whole test file before submitting | 13:23 |
| === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jml | bigjools: ahh, right. | 13:23 |
| === Ursinha-brb is now known as Ursinha | ||
| jml | bigjools: well, no point humans spending energy doing things machines can do :) | 13:24 |
| bigjools | :-| | 13:24 |
| bigjools | I wonder what else this change broke - lunch comes at a good time to find out :) | 13:25 |
| === jelmer_ is now known as jelmer | ||
| === adeuring1 is now known as adeuring | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| === benji is now known as benji-lunch | ||
| abentley | jelmer: could you please review https://code.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ? | 17:28 |
| abentley | sinzui: Would you mind doing a UI review of https://code.launchpad.net/~abentley/launchpad/select-owner ? | 17:29 |
| * sinzui looks | 17:35 | |
| sinzui | salgado, do you have time to do a UI review of https://code.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ? | 17:38 |
| salgado | sinzui, sure | 17:39 |
| salgado | abentley, can you get a screenshot of a page which shows the UI changes you've done? | 17:40 |
| abentley | salgado: already did, it's linked in the merge proposal. | 17:40 |
| salgado | abentley, really? I don't see it there | 17:41 |
| * salgado refreshes the page | 17:41 | |
| salgado | See: https://code.launchpad.net/~abentley/launchpad/select-owner | 17:42 |
| abentley | salgado: my bad, pasted the wrong link. | 17:42 |
| salgado | abentley, was that supposed to be it? | 17:42 |
| abentley | salgado: http://people.canonical.com/~abentley/suggest-owner.png | 17:42 |
| === benji-lunch is now known as benji | ||
| === matsubara is now known as matsubara-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === salgado is now known as salgado-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
