[01:27] lifeless: thanks [01:27] hmm? [01:27] oh, de nada [04:27] stub: hi [04:28] yo [04:28] https://code.launchpad.net/~lifeless/launchpad/soyuz/+merge/40499 [04:28] I fucked ppa/+packages [04:28] this should fix it [04:33] such a marvelous language, Strineā€¦ [04:38] lifeless: You removed a XXX, did you address it? [04:47] StevenK: look up the bug :) [04:49] lifeless: Which is Invalid, and filed against lazr.delegates ... [04:49] right [05:16] lifeless: Commented. [05:57] stub: are you up to do a review on this? [07:02] yo [07:03] Ahh... steve beat me so I don't have to pretend to understand soyuz [07:22] stub: StevenK isn't a full reviewer yet [07:22] Well he did a better job than I would have done ;) [07:22] stub: so rs it :) [07:23] Yer. Looks fine. My eyes glazed over a little during the tests but she'll be right. [07:24] Need more coffee [07:25] thanks - can you clicky clicky on approved then ? [07:25] [as a review I mean] [09:35] gmb: Would you have 5 minutes to take a look at https://code.launchpad.net/~allenap/launchpad/trac-fixreleased-bug-667340/+merge/40507? It's a very simple externalbugtracker branch. [09:41] allenap: Sure [09:43] allenap: You need to update the commit message (the remote status is 'fixverified' rather than 'fixreleased'). r=me on the code, though. [09:53] gmb: Good spot, and thank you :) === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:04] jelmer_: Hi, I've got a branch for you if you'd be so kind: https://code.launchpad.net/~gmb/launchpad/add-bnl-to-structsubs-bug-672507/+merge/40522 [12:06] * jelmer_ is in a kind mood today [12:06] :) === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:13] gmb: hi again [13:14] jml: https://code.launchpad.net/~julian-edwards/launchpad/buildd-manager-fixes [13:14] when the email hits the MP will get created [13:15] jelmer_: Hi [13:18] jml: ok MP got created, it's all yours. I need to eat before I faint now. [13:18] gmb: r=me, I just have one comment. It seems like it would be useful to have some infrastructure for running tests against all things that support structural subscription. I reviewed another branch a while back that also did it manually using a seperate TestCase subclass for each. [13:20] jelmer_: I agree with you wholeheartedly, but I think fixing that here is out of scope. I'll be happy to file a bug to follow up at a later date, though (we're doing lots of work around structural subs, so it should get dealt with rather than just being ignored). [13:20] bigjools: done [13:21] bigjools: although, irritatingly this makes more work in my testtools-experiment branch. [13:21] gmb: It'd be great if you could file a tech-debt bug about it. Anyway, just a thought. [13:21] jml: thanks - and why? [13:21] (that's what I deserve for a large branch unlanded over a course of weeks) === danilo_ is now known as danilos [13:21] jelmer_: Agreed. Will do. [13:21] jml: oh I know nothing about large unlanded branches :) [13:21] bigjools: it changes all of the Trial tests to use testtools. You're changing the test class structure, so I have to merge in & fix [13:22] jml: ah right - yeah I had to do that because the old structure was running tests twice [13:22] bigjools: yeah, it's the right thing to do. [13:22] I just wish I had more time to hack, and that easy things were easy [13:23] and that there was peace on earth, and ponies for all [13:23] you didn't spot the obvious fsckup tho :) [13:23] bigjools: oh? [13:23] super(TestBuilderWithTrial, self) [13:23] wrong class name now [13:23] my bad for not running the whole test file before submitting === jelmer_ changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:23] bigjools: ahh, right. === Ursinha-brb is now known as Ursinha [13:24] bigjools: well, no point humans spending energy doing things machines can do :) [13:24] :-| [13:25] I wonder what else this change broke - lunch comes at a good time to find out :) === jelmer_ is now known as jelmer === adeuring1 is now known as adeuring === matsubara is now known as matsubara-lunch === salgado is now known as salgado-lunch === matsubara-lunch is now known as matsubara === salgado-lunch is now known as salgado === benji is now known as benji-lunch [17:28] jelmer: could you please review https://code.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ? [17:29] sinzui: Would you mind doing a UI review of https://code.launchpad.net/~abentley/launchpad/select-owner ? [17:35] * sinzui looks [17:38] salgado, do you have time to do a UI review of https://code.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ? [17:39] sinzui, sure [17:40] abentley, can you get a screenshot of a page which shows the UI changes you've done? [17:40] salgado: already did, it's linked in the merge proposal. [17:41] abentley, really? I don't see it there [17:41] * salgado refreshes the page [17:42] See: https://code.launchpad.net/~abentley/launchpad/select-owner [17:42] salgado: my bad, pasted the wrong link. [17:42] abentley, was that supposed to be it? [17:42] salgado: http://people.canonical.com/~abentley/suggest-owner.png === benji-lunch is now known as benji === matsubara is now known as matsubara-afk === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === salgado is now known as salgado-afk