| === jelmer changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === Ursinha is now known as Ursinha-afk | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| === matsubara is now known as matsubara-doctor | ||
| allenap | soyuz: Could you review https://code.launchpad.net/~lamont/launchpad/sigill/+merge/40569? It's very short, but I think it could do with your seasoned eyes :) | 11:17 |
|---|---|---|
| bigjools | looking | 11:17 |
| bigjools | approved | 11:18 |
| allenap | bigjools: Cheers. | 11:24 |
| bigjools | allenap: I can explain what's going on if you want | 11:28 |
| danilos | allenap, in an effort to stop you from being bored on your OCR day, I've prepared a branch just for you: https://code.launchpad.net/~danilo/launchpad/bug-662552-fast-pofile-selection/+merge/40615 | 11:51 |
| danilos | allenap, I hope you can find some place in your heart for this branch :) | 11:52 |
| === danilos changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [danilo] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | allenap, it's measly 89 lines of diff, there must be room for that :) | 11:58 |
| allenap | danilos: There certainly is. But first lunch. | 12:01 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: lunch || queue: [danilo] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | bigjools: Thank you for the kind offer, but the pub beckons. | 12:02 |
| jml | phwoar | 12:03 |
| jml | pub lunch | 12:03 |
| * jml wants one | 12:03 | |
| bigjools | what an awesome idea | 12:10 |
| bigjools | damn you guys for seeding that idea in my head | 12:10 |
| === Ursinha-afk is now known as Ursinha | ||
| jml | no pub lunch for me. | 12:35 |
| jml | eating Tuesday's dinner instead. | 12:35 |
| === matsubara-doctor is now known as matsubara | ||
| === mrevell is now known as mrevell-lunch | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: danilo || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell-lunch is now known as mrevell | ||
| === Ursinha is now known as Ursinha-afk | ||
| jelmer | Hi allenap | 14:45 |
| jelmer | allenap: Are you up for some more Soyuz reviewing? | 14:45 |
| allenap | jelmer: Oh, yes please :) | 14:47 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer | :-) | 14:48 |
| jelmer | allenap: The MP is https://code.launchpad.net/~jelmer/launchpad/cronjob/+merge/40629 | 14:48 |
| gmb | allenap: I've got another one for your queue: https://code.launchpad.net/~gmb/launchpad/fix-advanced-bug-sub-ui-bug-673288/+merge/40631 | 14:49 |
| === gmb changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: jelmer || queue: [gmb] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | gmb: Tip-top. | 15:11 |
| allenap | gmb: The merge proposal is ejecting toys: Text conflict in lib/lp/bugs/browser/tests/test_bugsubscription_views.py | 15:18 |
| gmb | allenap: The mp says it has conflicts. This is a lie. | 15:18 |
| gmb | I'll re-merge devel, but I've already fixed those. | 15:18 |
| gmb | allenap: Hang on; let me re-merge and get you a clean diff.] | 15:19 |
| gmb | allenap: Oh, bottom. I forgot to push the conflict fixage. Doing so now. | 15:20 |
| * gmb doesn't know how the voodoo with updating MP diffs works. | 15:20 | |
| gmb | allenap: I've pasted a diff into a comment on the MP. | 15:21 |
| allenap | gmb: The diff should be regenerated once the branch scanner has done its thing, I believe. | 15:22 |
| gmb | allenap: Yep, it's cleared up now. | 15:22 |
| allenap | gmb: But there's no indication of branch scanning in merge proposals, only on branch pages. | 15:23 |
| gmb | Yeah. That's an annoyance. | 15:23 |
| === matsubara is now known as matsubara-lunch | ||
| jelmer | allenap: Thanks for the review. | 15:42 |
| jelmer | allenap: I think underscores are much fashionable than dashes, but I'll bow to the masses. | 15:43 |
| jelmer | *much more | 15:43 |
| === Ursinha-afk is now known as Ursinha | ||
| abentley | salgado: who is your mentor? | 16:20 |
| salgado | abentley, sinzui | 16:20 |
| abentley | sinzui: Could you please mentor salgado's review of https://code.edge.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ? | 16:20 |
| * sinzui looks | 16:20 | |
| abentley | allenap: could you please review https://code.edge.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 | 16:20 |
| sinzui | abentley, is the menu subordinate to (*) Other? | 16:22 |
| abentley | sinzui: the drop-down is the "other" option. | 16:23 |
| sinzui | I wonder if we can show it aligned with the option then | 16:23 |
| * sinzui looks for css class | 16:24 | |
| === matsubara-lunch is now known as matsubara | ||
| === salgado is now known as salgado-brb | ||
| sinzui | abentley, I think other_selection_widget should have the "subordinate" css class like the radio buttons. I think we need to pass cssClass='subordinate', but I do not see exactly where to do it in the diff | 16:30 |
| abentley | sinzui: does this need to be passed to the widget constructor, or can we just set it later? What is its effect? | 16:32 |
| abentley | sinzui: should it also be applied to the target branch selector? | 16:33 |
| allenap | jelmer: Hehe :) | 16:33 |
| sinzui | I see it in the constructor. I think I have set it afterwards recently. the subordinate class will indent the menu to align it with the radio button that controls it | 16:33 |
| allenap | abentley: Sure. | 16:33 |
| sinzui | abentley, I will only ask you to do this if I can remember how I did it | 16:33 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | allenap, thanks. | 16:34 |
| sinzui | abentley, I think cssClass is only used on render. I think we can set it after __init__. | 16:46 |
| sinzui | so after line 49: self.other_selection_widget = getMultiAdapter( | 16:46 |
| sinzui | we add | 16:46 |
| sinzui | self.other_selection_widget.cssClass = 'subordinate' | 16:46 |
| === salgado-brb is now known as salgado | ||
| abentley | sinzui: okay, I'll give it a shot. | 16:55 |
| abentley | sinzui: doing it there screws up the target branch widget, but it looks like this: http://people.canonical.com/~abentley/suggest-owner-2.png | 17:07 |
| sinzui | :( | 17:07 |
| abentley | the target branch widget has the subordinate widget on the same line, so the extra indenting doesn't make sense. | 17:08 |
| sinzui | abentley, I think then this is a bigger css form issue. I now recall I had to write a template to solve that. | 17:08 |
| sinzui | abentley, r=me for your original effort | 17:09 |
| abentley | sinzui: I can do it for the RecipeOwnerWidget only, by providing a constructor. | 17:09 |
| === deryck is now known as deryck[lunch] | ||
| abentley | sinzui: This patch doesn't break TargetBranchWidget: http://pastebin.ubuntu.com/530114/ | 17:17 |
| === salgado is now known as salgado-physio | ||
| === allenap changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | allenap: what are the line-wrapping conventions for list comprehensions? | 17:40 |
| === benji is now known as benji-lunch | ||
| allenap | abentley: Same as for braces? | 17:44 |
| abentley | sinzui: I've discovered that the items in the dropdown get indented even further, so I'll revert that change. | 18:11 |
| === benji-lunch is now known as benji | ||
| === deryck[lunch] is now known as deryck | ||
| === salgado-physio is now known as salgado | ||
| sinzui | abentley, thanks for trying. I think we want create some contextual CSS rule that solves this layout for us. Your branch is good to land | 19:50 |
| abentley | sinzui: Cool. | 19:53 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| wallyworld | thumper: oops fix. pretty please: https://code.launchpad.net/~wallyworld/launchpad/link-checker-oops/+merge/40680 | 23:53 |
| === maxb_ is now known as maxb | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
