=== jelmer changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha is now known as Ursinha-afk
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
=== matsubara is now known as matsubara-doctor
[11:17] <allenap> soyuz: Could you review https://code.launchpad.net/~lamont/launchpad/sigill/+merge/40569? It's very short, but I think it could do with your seasoned eyes :)
[11:17] <bigjools> looking
[11:18] <bigjools> approved
[11:24] <allenap> bigjools: Cheers.
[11:28] <bigjools> allenap: I can explain what's going on if you want
[11:51] <danilos> allenap, in an effort to stop you from being bored on your OCR day, I've prepared a branch just for you: https://code.launchpad.net/~danilo/launchpad/bug-662552-fast-pofile-selection/+merge/40615
[11:52] <danilos> allenap, I hope you can find some place in your heart for this branch :)
=== danilos changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: - || queue: [danilo] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[11:58] <danilos> allenap, it's measly 89 lines of diff, there must be room for that :)
[12:01] <allenap> danilos: There certainly is. But first lunch.
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: lunch || queue: [danilo] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:02] <allenap> bigjools: Thank you for the kind offer, but the pub beckons.
[12:03] <jml> phwoar
[12:03] <jml> pub lunch
[12:03]  * jml wants one
[12:10] <bigjools> what an awesome idea
[12:10] <bigjools> damn you guys for seeding that idea in my head
=== Ursinha-afk is now known as Ursinha
[12:35] <jml> no pub lunch for me.
[12:35] <jml> eating Tuesday's dinner instead.
=== matsubara-doctor is now known as matsubara
=== mrevell is now known as mrevell-lunch
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: danilo || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mrevell-lunch is now known as mrevell
=== Ursinha is now known as Ursinha-afk
[14:45] <jelmer> Hi allenap
[14:45] <jelmer> allenap: Are you up for some more Soyuz reviewing?
[14:47] <allenap> jelmer: Oh, yes please :)
=== allenap changed the topic of #launchpad-reviews to: On call: allenap || Reviewing: jelmer || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:48] <jelmer> :-)
[14:48] <jelmer> allenap: The MP is https://code.launchpad.net/~jelmer/launchpad/cronjob/+merge/40629
[14:49] <gmb> allenap: I've got another one for your queue: https://code.launchpad.net/~gmb/launchpad/fix-advanced-bug-sub-ui-bug-673288/+merge/40631
=== gmb changed the topic of #launchpad-reviews to:  On call: allenap || Reviewing: jelmer || queue: [gmb] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:11] <allenap> gmb: Tip-top.
[15:18] <allenap> gmb: The merge proposal is ejecting toys: Text conflict in lib/lp/bugs/browser/tests/test_bugsubscription_views.py
[15:18] <gmb> allenap: The mp says it has conflicts. This is a lie.
[15:18] <gmb> I'll re-merge devel, but I've already fixed those.
[15:19] <gmb> allenap: Hang on; let me re-merge and get you a clean diff.]
[15:20] <gmb> allenap: Oh, bottom. I forgot to push the conflict fixage. Doing so now.
[15:20]  * gmb doesn't know how the voodoo with updating MP diffs works.
[15:21] <gmb> allenap: I've pasted a diff into a comment on the MP.
[15:22] <allenap> gmb: The diff should be regenerated once the branch scanner has done its thing, I believe.
[15:22] <gmb> allenap: Yep, it's cleared up now.
[15:23] <allenap> gmb: But there's no indication of branch scanning in merge proposals, only on branch pages.
[15:23] <gmb> Yeah. That's an annoyance.
=== matsubara is now known as matsubara-lunch
[15:42] <jelmer> allenap: Thanks for the review.
[15:43] <jelmer> allenap: I think underscores are much fashionable than dashes, but I'll bow to the masses.
[15:43] <jelmer> *much more
=== Ursinha-afk is now known as Ursinha
[16:20] <abentley> salgado: who is your mentor?
[16:20] <salgado> abentley, sinzui
[16:20] <abentley> sinzui: Could you please mentor salgado's review of https://code.edge.launchpad.net/~abentley/launchpad/select-owner/+merge/40556 ?
[16:20]  * sinzui looks
[16:20] <abentley> allenap: could you please review https://code.edge.launchpad.net/~abentley/launchpad/select-owner/+merge/40556
[16:22] <sinzui> abentley, is the menu subordinate to (*) Other?
[16:23] <abentley> sinzui: the drop-down is the "other" option.
[16:23] <sinzui> I wonder if we can show it aligned with the option then
[16:24]  * sinzui looks for css class
=== matsubara-lunch is now known as matsubara
=== salgado is now known as salgado-brb
[16:30] <sinzui> abentley, I think other_selection_widget should have the "subordinate" css class like the radio buttons. I think we need to pass cssClass='subordinate', but I do not see exactly where to do it in the diff
[16:32] <abentley> sinzui: does this need to be passed to the widget constructor, or can we just set it later?  What is its effect?
[16:33] <abentley> sinzui: should it also be applied to the target branch selector?
[16:33] <allenap> jelmer: Hehe :)
[16:33] <sinzui> I see it in the constructor. I think I have set it afterwards recently. the subordinate class will indent the menu to align it with the radio button that controls it
[16:33] <allenap> abentley: Sure.
[16:33] <sinzui> abentley, I will only ask you to do this if I can remember how I did it
=== allenap changed the topic of #launchpad-reviews to:  On call: allenap || Reviewing: abentley || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:34] <abentley> allenap, thanks.
[16:46] <sinzui> abentley, I think cssClass is only used on render. I think we can set it after __init__.
[16:46] <sinzui> so after line 49: self.other_selection_widget = getMultiAdapter(
[16:46] <sinzui> we add
[16:46] <sinzui> self.other_selection_widget.cssClass = 'subordinate'
=== salgado-brb is now known as salgado
[16:55] <abentley> sinzui: okay, I'll give it a shot.
[17:07] <abentley> sinzui: doing it there screws up the target branch widget, but it looks like this: http://people.canonical.com/~abentley/suggest-owner-2.png
[17:07] <sinzui> :(
[17:08] <abentley> the target branch widget has the subordinate widget on the same line, so the extra indenting doesn't make sense.
[17:08] <sinzui> abentley, I think then this is a bigger css form issue. I now recall I had to write a template to solve that.
[17:09] <sinzui> abentley, r=me for your original effort
[17:09] <abentley> sinzui: I can do it for the RecipeOwnerWidget only, by providing a constructor.
=== deryck is now known as deryck[lunch]
[17:17] <abentley> sinzui: This patch doesn't break TargetBranchWidget: http://pastebin.ubuntu.com/530114/
=== salgado is now known as salgado-physio
=== allenap changed the topic of #launchpad-reviews to:  On call: - || Reviewing: - || queue: [] ||  This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[17:40] <abentley> allenap: what are the line-wrapping conventions for list comprehensions?
=== benji is now known as benji-lunch
[17:44] <allenap> abentley: Same as for braces?
[18:11] <abentley> sinzui: I've discovered that the items in the dropdown get indented even further, so I'll revert that change.
=== benji-lunch is now known as benji
=== deryck[lunch] is now known as deryck
=== salgado-physio is now known as salgado
[19:50] <sinzui> abentley, thanks for trying. I think we want create some contextual CSS rule that solves this layout for us. Your branch is good to land
[19:53] <abentley> sinzui: Cool.
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
[23:53] <wallyworld> thumper: oops fix. pretty please: https://code.launchpad.net/~wallyworld/launchpad/link-checker-oops/+merge/40680
=== maxb_ is now known as maxb