/srv/irclogs.ubuntu.com/2010/11/12/#launchpad-reviews.txt

thumperwallyworld: looking00:45
wallyworldta00:46
thumperwallyworld: there is no diff00:46
wallyworld? i pushed the branch00:46
wallyworldthumper: https://code.launchpad.net/~wallyworld/launchpad/link-checker-oops00:47
thumperwallyworld: yeah, I can see that00:47
wallyworldthumper: i should have looked more carefully at the console when i bzr pushed00:48
wallyworldthumper: there was a zope error xmlrpclib.Fault: <Fault -1: 'Unexpected Zope exception: AssertionError: '>00:48
wallyworldwhat's the best way to fix it - repush or delete and start again?00:49
* thumper tries something00:49
thumperwallyworld: here is where we need the regenerate diff button00:55
wallyworldyep :-)00:55
wallyworldso are you going to invoke the scan job again manually?00:55
thumperwallyworld: done01:06
wallyworldthanks01:06
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
gmballenap: Thanks for your review; I've replied.11:06
=== matsubara_ is now known as matsubara
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
allenapgmb: I'll go and take a look now.13:53
gmbTa13:56
=== matsubara is now known as matsubara-lunch
=== Ursinha is now known as Ursinha-lunch
=== sinzui changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
sinzuiadeuring, I have a branch that fixes 4 trivial bugs14:43
sinzuiadeuring, do you have time to review https://code.launchpad.net/~sinzui/launchpad/headings-and-words-0/+merge/4067714:46
adeuringsinzui: I'll look14:47
sinzuithanks14:47
=== Ursinha-lunch is now known as Ursinha
adeuringsinzui: approved15:15
sinzuithank you very much15:16
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-lunch is now known as matsubara
danilosadeuring, hey, still around? I've got a branch up for review but it also needs a DB review that I am probably not getting before Monday, so it's not urgent, but I don't mind getting a code review for now :)16:27
adeuringdanilos: sure, I'll look16:27
danilosadeuring, https://code.launchpad.net/~danilo/launchpad/drop-variants/+merge/4073516:27
danilosadeuring, thanks16:27
danilosadeuring, it should be very simple, mostly removals16:28
adeuringdanilos: ok, that sounds good ;)16:28
adeuringdanilos: r=me16:57
danilosadeuring, thank you very much16:57
danilosadeuring, thanks for grepping yourself, I did miss a case ;)16:59
adeuringdanilos: well that's what reviews are for, aren't they ;)?17:00
danilosadeuring, totally :)17:00
=== adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
sinzuiEdwinGrubbs, about your branch, the comment is included in rendered markup. It looks like the table will be show to everyone. Is that not so? does "view/configuration_links" always do the right thing; it was the progress bar table that was the problem?20:13
EdwinGrubbssinzui: good point. I need to add a method in the view to loop through view/configuration_links to see if any of the links are enabled, so that the table can be removed.20:15
sinzuiEdwinGrubbs, brian added the permission launchpad.BugSupervisor maybe we only need to change a launchpad.Edit20:16
EdwinGrubbssinzui: sure, I was making it re-usable in case there was another group of people that only got to see some subsection of the links, but there will probably never be anyone else besides the BugSupervisor.20:17
EdwinGrubbssinzui: I pushed up the suggested changes.20:20
sinzuiEdwinGrubbs, can you look at https://code.edge.launchpad.net/~sinzui/launchpad/ds-getcurrentreleases/+merge/4075620:23
=== matsubara is now known as matsubara-afk
sinzuiEdwinGrubbs, r=me20:24
EdwinGrubbsthanks20:24
EdwinGrubbslooking at your branch now20:24
EdwinGrubbssinzui: r=me20:38
sinzuithanks edwin.21:01
henningeSo, how is everybody?21:50
henningeAnybody in need of r-c approval before PQM closes? ;-)21:51
lifelesshttps://code.edge.launchpad.net/~sinzui/launchpad/ds-getcurrentreleases/+merge/4075621:57
lifelesshmm, thats an edfe url21:57
lifelesssinzui: how come you're still using edge? :)21:57
lifelesshenninge: ^21:57
sinzuilifeless, I seem to have some bookmarks. I am not every trying to use edge21:57
sinzuiIt might be more email since I purged browser history and update bookmarks21:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!