[00:45] <thumper> wallyworld: looking
[00:46] <wallyworld> ta
[00:46] <thumper> wallyworld: there is no diff
[00:46] <wallyworld> ? i pushed the branch
[00:47] <wallyworld> thumper: https://code.launchpad.net/~wallyworld/launchpad/link-checker-oops
[00:47] <thumper> wallyworld: yeah, I can see that
[00:48] <wallyworld> thumper: i should have looked more carefully at the console when i bzr pushed
[00:48] <wallyworld> thumper: there was a zope error xmlrpclib.Fault: <Fault -1: 'Unexpected Zope exception: AssertionError: '>
[00:49] <wallyworld> what's the best way to fix it - repush or delete and start again?
[00:49]  * thumper tries something
[00:55] <thumper> wallyworld: here is where we need the regenerate diff button
[00:55] <wallyworld> yep :-)
[00:55] <wallyworld> so are you going to invoke the scan job again manually?
[01:06] <thumper> wallyworld: done
[01:06] <wallyworld> thanks
[11:06] <gmb> allenap: Thanks for your review; I've replied.
[13:53] <allenap> gmb: I'll go and take a look now.
[13:56] <gmb> Ta
[14:43] <sinzui> adeuring, I have a branch that fixes 4 trivial bugs
[14:46] <sinzui> adeuring, do you have time to review https://code.launchpad.net/~sinzui/launchpad/headings-and-words-0/+merge/40677
[14:47] <adeuring> sinzui: I'll look
[14:47] <sinzui> thanks
[15:15] <adeuring> sinzui: approved
[15:16] <sinzui> thank you very much
[16:27] <danilos> adeuring, hey, still around? I've got a branch up for review but it also needs a DB review that I am probably not getting before Monday, so it's not urgent, but I don't mind getting a code review for now :)
[16:27] <adeuring> danilos: sure, I'll look
[16:27] <danilos> adeuring, https://code.launchpad.net/~danilo/launchpad/drop-variants/+merge/40735
[16:27] <danilos> adeuring, thanks
[16:28] <danilos> adeuring, it should be very simple, mostly removals
[16:28] <adeuring> danilos: ok, that sounds good ;)
[16:57] <adeuring> danilos: r=me
[16:57] <danilos> adeuring, thank you very much
[16:59] <danilos> adeuring, thanks for grepping yourself, I did miss a case ;)
[17:00] <adeuring> danilos: well that's what reviews are for, aren't they ;)?
[17:00] <danilos> adeuring, totally :)
[20:13] <sinzui> EdwinGrubbs, about your branch, the comment is included in rendered markup. It looks like the table will be show to everyone. Is that not so? does "view/configuration_links" always do the right thing; it was the progress bar table that was the problem?
[20:15] <EdwinGrubbs> sinzui: good point. I need to add a method in the view to loop through view/configuration_links to see if any of the links are enabled, so that the table can be removed.
[20:16] <sinzui> EdwinGrubbs, brian added the permission launchpad.BugSupervisor maybe we only need to change a launchpad.Edit
[20:17] <EdwinGrubbs> sinzui: sure, I was making it re-usable in case there was another group of people that only got to see some subsection of the links, but there will probably never be anyone else besides the BugSupervisor.
[20:20] <EdwinGrubbs> sinzui: I pushed up the suggested changes.
[20:23] <sinzui> EdwinGrubbs, can you look at https://code.edge.launchpad.net/~sinzui/launchpad/ds-getcurrentreleases/+merge/40756
[20:24] <sinzui> EdwinGrubbs, r=me
[20:24] <EdwinGrubbs> thanks
[20:24] <EdwinGrubbs> looking at your branch now
[20:38] <EdwinGrubbs> sinzui: r=me
[21:01] <sinzui> thanks edwin.
[21:50] <henninge> So, how is everybody?
[21:51] <henninge> Anybody in need of r-c approval before PQM closes? ;-)
[21:57] <lifeless> https://code.edge.launchpad.net/~sinzui/launchpad/ds-getcurrentreleases/+merge/40756
[21:57] <lifeless> hmm, thats an edfe url
[21:57] <lifeless> sinzui: how come you're still using edge? :)
[21:57] <lifeless> henninge: ^
[21:57] <sinzui> lifeless, I seem to have some bookmarks. I am not every trying to use edge
[21:58] <sinzui> It might be more email since I purged browser history and update bookmarks