=== danilo_ is now known as danilos === salgado is now known as salgado-physio === mrevell is now known as mrevell-lunch === Ursinha-dinner is now known as Ursinha [13:51] Launchpad Reviewers meeting now at 1500UTC -- one hour later === salgado-physio is now known as salgado === mrevell-lunch is now known as mrevell [14:59] apologies, bac, at sprint [15:00] or training, or whatever it is [15:00] #startmeeting [15:00] bac, I am only going to lurk, sorry [15:00] bac, There is already a meeting in progress. [15:00] gah [15:00] * gary_poster chuckles [15:00] Who is here today at our new Bat Time? [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:01] I [15:01] me [15:01] me, but I'm also browsing through my dictionary to find out what "Bat Time" means :-) [15:01] jelmer: Reference to 60's batman show. [15:01] me [15:01] jelmer: http://www.urbandictionary.com/define.php?term=same%20bat-time%2C%20same%20bat-channel [15:02] :) [15:02] abentley, abentley: ah, heh :-) Thanks [15:02] * deryck sings nah nah nah nah Bat----man! [15:02] deryck: ha! [15:02] topic - Agenda [15:02] The Green Hornet was cooler [15:02] * Roll call [15:02] * Agenda [15:02] * Outstanding actions [15:02] * Mentat update. [15:02] * Salgado (ui) [15:02] * StevenK (code) [15:02] * New items [15:02] * Benji joins code review team mentored by EdwinGrubbs. [15:02] * jcsackett becomes a mentat (sinzui) [15:02] * Peanut gallery [15:03] * Sinzui to investigate making lint check for the Storm 'in' gotcha [15:03] sinzui: progress? [15:03] No, fix, but I did make progress. I removed two of the false reports in our code [15:04] cool [15:04] oh, pocket-lint will be in natty [15:04] me [15:04] that's good sinzui [15:04] * bac to work with mars regarding a slow introduction of new reviewer points regarding the ArchitectureGuide. (undone) [15:05] as it says, i've not done this. i'll try to get up with mars and get action on that one. [15:05] topic - time change [15:05] me [15:05] glad everyone got the email. i hope this time works. i heard no complaints. [15:06] * Mentat update. [15:06] * Salgado (ui) [15:06] * StevenK (code) [15:06] me [15:06] how's it going salgado? [15:06] after some time without any UI reviews, last week I did some [15:06] it's going fine with me [15:08] the last time i checked with stevenk he was still having a hard time getting enough reviews to do. i'll find out later if that is still the case. [15:08] New items [15:08] * Benji joins code review team mentored by EdwinGrubbs. [15:09] thanks for starting the process benji. and thanks EdwinGrubbs for mentoring [15:09] * jcsackett becomes a mentat (sinzui) [15:10] jcsackett: do you have a mentor? [15:10] sinzui, i believe. [15:10] I will mentor [15:10] yay [15:11] so when these guys finish up we'll have all canonical lp devs as mentors again [15:11] er, reviewers [15:11] no [15:11] well [15:12] I think mister wgrant could start reviewer training when he starts [15:12] +1 [15:12] me [15:12] perhaps we should give him a week to get settled [15:12] Then I will have some small satisfaction that my nomination was accepted, though it took almost a year [15:12] he's already been doing some very good post-merge reviews :-) [15:13] bac: why? he already has rf setup [15:13] topic - other stuff. anyone have anything? [15:13] I have an apology to make to the bugs team [15:14] * allenap is puzzled [15:14] I thought the death to all doctests mantra at Prague was crazy, but I just read the bug stories and doctests yesterday I now understand you need to kill kill kill [15:15] heh [15:15] and theirs are even better than soyuz... go figure [15:15] thanks for saying so sinzui! I've felt I must be crazy that no one sees the insanity I see. [15:15] Yeah, don't read those doctests. [15:16] * jtv reviewed doctest changes today and is still trying to stem the bleeding [15:16] bigjools, soyuz has lots of unittests I can extend. I just delete the contradicting doctest. [15:16] we've made some good progress in the last few months converting to unit tests, but it's taking some time. [15:16] still much to do [15:16] but the hideousness runs deep [15:17] I did get rid of my most hated doctest recently. It felt reeeeeal good. [15:18] If I report 50 bugs about doctests, do we get to close them during the bugjam [15:18] anything else but kvetching about doctests (which is a fine thing to do)? [15:18] Well one thing here [15:19] the chair recognizes the gentleman from BKK [15:19] I see lots and lots of code slip by reviewers that shouldn't. [15:19] Are we still instilling and reinforcing the habits that we expect everyone to stick to by themselves? [15:20] Coding standards mostly. Today I saw an import in the wrong place for no reason, an empty docstring, etc.—and that's without looking at very much. [15:21] jtv: I am close to being able to track a line of code back to the review where it was approved. [15:22] Well I'm not _really_ looking to hunt down & beat up the reviewers; I just say that. [15:22] Although that is a cool capability, I must say. [15:22] jtv: you found these problems in the tree or in a review? [15:22] Both, for today's cases. [15:23] Of course there were dozens of other little gotchas in the tree. [15:23] I think automated changes cause these issues. I have seen a lot bad style in our modules that I attribute to changes made after the review, such as requests to clean up a name in the whole tree. [15:23] What stings is that most of them are recent. [15:23] Some of that, too, yes. [15:24] Also I think "make lint" no longer tracks down committed-but-unlanded changes? [15:25] jtv: IME it does. [15:25] if all changes are committed 'make lint' does the right thing, i think. [15:25] * jtv will watch it more closely [15:25] jtv: If there are any uncommitted changes, it just lints those. [15:25] That's what it used to do; I just noticed an unexpected "no changes detected." [15:25] On a branch that was unlanded and full of goodies, of course. [15:26] jtv: But if all changes are committed make lint should lint all changes. [15:26] Yes, that's what I thought. I'll keep an eye out. [15:26] jtv, make lint does commit changes that differ from parent [15:27] The parent in this case was not one of the usual ones, I think. Maybe that caused it. [15:27] jtv: if you find code that has been landed that is clearly a problem i think we should discuss it with the reviewer, just so he'll be aware of what was missed or to determine if it happened post review. [15:28] if you'd rather not have that conversation i'll be glad to do it. [15:28] Fair enough. I just got the impression that there's a gap between the speed/thoroughness tradeoffs I like and the ones the team as a whole has evolved to. [15:28] not finger pointing but for learning. [15:28] Yes, that's important—the baseball bat was just a joke. [15:29] is there anything else to discuss today? [15:30] * jtv sits down [15:30] thanks for coming [15:30] #endmeeting [15:30] Meeting finished at 09:30. [15:31] jtv: FYI bzr log -r mainline:annotate:$FILENAME:$LINENO will find the revision where the line was merged into trunk. [15:31] thanks bac [15:31] abentley: cool! Thanks. [15:31] jtv: Now we just need to be able to find merge proposals according to revision id. [15:32] abentley: can't find "annotate" in "bzr help revisionspec"… where do I read more about it? [15:33] jtv: it was added recently. You'll need a newer bzr. [15:33] ah, the ol' rat race [15:33] * jtv used to watch version numbers avidly, once upon a time === benji is now known as benji-lunch === benji-lunch is now known as benji === EdwinGrubbs is now known as Edwin-lunch === Edwin-lunch is now known as EdwinGrubbs === salgado is now known as salgado-afk === Ursinha is now known as Ursinha-bbk === Ursinha-bbk is now known as Ursinha-bbl