/srv/irclogs.ubuntu.com/2010/11/18/#ubuntuone.txt

=== didrocks1 is now known as didrocks
JanCI think somebody found a bug in U1's music streaming: http://askubuntu.com/questions/13790/does-ubuntu-one-mobile-support-ogg-vorbis09:57
duanedesignmorning JanC10:11
duanedesigni keep f/510:13
duanedesignugh10:13
duanedesigni keep forgetting to check askubuntu for Ubuntu One questions10:14
=== mandel__ is now known as mandel
Chipaca`nessita: buenos días su señoría mantantirulirulá!12:07
nessitahola hola!12:08
nessitaI need reviews!!! (please) https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/add-syncdaemon-backend/+merge/4111012:49
nessitaChipaca`: you available for a non trivial review?13:46
=== Chipaca` is now known as Chipaca
vbabiyHey guys I when I try to start ubuntu one 1.2.2 I get this:   File "/usr/lib/python2.6/dist-packages/ubuntuone/syncdaemon/config.py", line 28, in <module>13:57
vbabiy    from configglue import TypedConfigParser, glue13:57
nessitavbabiy: and what's the error? can you paste it on a pastebin?14:00
vbabiysure14:00
vbabiyhttp://pastebin.com/Q3JGKu6K14:01
nessitaalecu, mandel, dobey, vds, thisfred, Chipaca: stand up everybody!14:01
mandelme14:01
vdsme14:01
nessitame14:01
dobeyme14:01
thisfredoh here14:02
thisfredme14:02
nessitavbabiy: looks like a version mismatch between ubuntu one and configglue14:02
nessitaChipaca: any ideas how to solve http://pastebin.com/Q3JGKu6K ?14:02
dobeyvbabiy: why are you using 1.2.2?14:03
alecume14:03
nessitaalecu: here!14:03
alecuhere!14:03
vbabiyI was using the nighly but it broke, and now I its broken again14:03
vbabiyI think I should just upgrade to 10.1014:03
vbabiyand this will fix my issues14:03
dobeyvbabiy: if you want to downgrade from nightlies, you need to downgrade python-configglue also14:04
dobeyback to the version in lucid14:04
vbabiydobey: thanks that fixed it14:04
nessitamandel: go!14:04
mandelDONE: paper work. Merged fixes for #675335, #675366, #67537 and etc.. to meny too list. Cleaned the state of the bug reports on windows port. Worked on 67584214:04
mandelTODO: finish encoding14:04
mandelBLOCKED: No14:04
* mandel looks at vds14:04
vdsDONE:  branch for migration infrastructure #675590,  code reviews, branch to port to a newer python-couchdb version proposed #675551, filed bug #67698614:04
vdsTODO: either refactor the attachment tests or python-couchdb to support oauth14:04
vdsBLOCKED: not at all14:04
vdsnessita: prego14:04
ubot4Launchpad bug 676986 in desktopcouch "Attachment test need refactoring (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/67698614:04
nessitaDONE: code reviews, IRL testing for new approach in ussoc to access the keyring thru DBus, found bug #676679, debugged bug #674876, more work on branch to resolve bug #673670 (branch proposed)14:05
nessitaTODO: fix bug #676679, chase reviews for bug #67367014:05
nessitaBLOCKED: nopes (though we're suffering a bit lack of reviews)14:05
nessitaNEXT: dobey14:05
ubot4Launchpad bug 676679 in ubuntu-sso-client "credentials should not be cleared if ping wasn't made due to empty ping url (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/67667914:05
ubot4Launchpad bug 674876 in ubuntuone-client (Ubuntu) (and 1 other project) "Nautilus keeps opening when ubuntu one plugin is installed (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/67487614:05
dobeyλ DONE: attempted to debug #674876 (awaiting more info now), Fixed #67664814:05
dobeyλ TODO: help eric with desktopcouch splitup, client release, banshee nightlies, music store tests14:05
ubot4Launchpad bug 673670 in ubuntuone-control-panel "Contact syncdaemon dbus service from backend (affects: 1) (heat: 14)" [High,In progress] https://launchpad.net/bugs/67367014:05
dobeyλ BLCK: None.14:05
dobeythisfred: your roll14:05
thisfredDONE: Worked on #510159 TODO: Finish #510159 BLOCKED: No14:05
thisfredalecu: yo!14:05
alecuDONE: got #656545 fixed and merged. started looking into #66336114:06
alecuTODO: finish that bug, finally get to zg14:06
alecuBLOCKED: no14:06
dobeynessita: meet CardinalFang (chad)14:07
alecuCardinalFang, go!14:07
nessitaah!14:07
nessitadobey: thanks :-)14:07
nessitaCardinalFang: go?14:07
CardinalFangDONE: Talking about #670054. Landed minor fix for #676709.14:08
CardinalFangTODO: Land fix for #519028.  Finish #59103914:08
CardinalFangBLOCKED: No14:08
thisfredubot4 seems to have died under the load14:08
ubot4thisfred: Error: I am only a bot, please don't think I'm intelligent :)14:08
nessitain the man time: the bug has to have the work "bug" (seems like it)14:08
nessitabug #100014:08
ubot4Launchpad bug 1000 in ubuntu (and 1 other project) "There are too many bug reports in Malone (heat: 1)" [Medium,Invalid] https://launchpad.net/bugs/100014:08
nessita#100014:08
nessitaright14:08
thisfredah14:08
nessitaany closing comments?14:08
nessitamean*, word*14:09
CardinalFangDONE: Talking about bug #670054. Landed minor fix for bug #676709.14:09
CardinalFangTODO: Land fix for bug #519028.  Finish bug #59103914:09
CardinalFangBLOCKED: No14:09
ubot4Launchpad bug 670054 in desktopcouch "spawn microproxy to cover for crashy couchdb (affects: 1) (heat: 8)" [Wishlist,In progress] https://launchpad.net/bugs/67005414:09
ubot4CardinalFang: Bug 676709 on http://launchpad.net/bugs/676709 is private14:09
ubot4Launchpad bug 519028 in ubuntuone-client (Ubuntu) (and 2 other projects) "desktopcouch replication and org.desktopcouch.CouchDB.service are NOT started on desktopcouch.records calls (affects: 3) (dups: 1) (heat: 27)" [Undecided,Triaged] https://launchpad.net/bugs/51902814:09
ubot4Launchpad bug 591039 in desktopcouch "Cannot import desktopcouch in server environment (affects: 2) (heat: 11)" [Medium,Confirmed] https://launchpad.net/bugs/59103914:09
nessitaawesome!14:09
nessitaso, seems like #desktop+ is a no more, so, stand up will be held in this channel14:09
* dobey makes a note to not use # to denote bug numbers in future standups14:09
CardinalFangGood.14:09
nessitasame time, stay tunned!14:10
nessitaeom?14:10
mandeleom eom eom!14:10
alecunessita, is this channel logged as desktop+ was?14:10
nessitaalecu: no idea, I hope so.14:11
nessitadobey: would you know? ^14:11
dobeyi don't believe it is14:15
dobeyah it is14:15
vdsthisfred CardinalFang mandel what about a review? https://code.launchpad.net/~vds/desktopcouch/again_python_couchdb/+merge/4117014:15
dobeyor at least, ubuntulog bot is in here14:15
dobeyalecu, nessita: http://irclogs.ubuntu.com/2010/11/18/%23ubuntuone.html14:16
CardinalFangvds, I'14:16
CardinalFangll look.14:16
vdsCardinalFang: thx!14:16
nessitaawesome14:17
alecudobey, nice, thanks14:17
CardinalFangvds, needs a merge with trunk.14:17
vdsCardinalFang: on it14:18
thisfredvds, I'll take one too14:31
vdsCardinalFang thisfred I need to fix something, python-couchdb doesn't allow to access urls starting with _14:32
vdswhich for us is kind of bad thing14:32
Chipacadobey: thanks for fixing vbabiy :)14:32
dobeysure14:32
thisfredvds, really? Not even with db.resource.get?14:32
vdsthisfred: not tested that yet14:32
thisfredvds, I think that works, but you'll have to untangle the json response a bit14:33
vdsthisfred: I'll take a look thanks14:33
thisfredvds: I know it works in the current python-couchdb, and I doubt they changed it. It's what we use for _changes14:34
CardinalFangvds, we shouldn't need to, I think.  python-couchdb should provide a method for whatever it is.14:35
thisfredYeah, if it isn't there, we should totally send a patch14:35
nessitamandel: you owe me a bug report with a patch, I think14:38
mandelnessita, true, bug on the way, patch during CET night when I stop with windows14:40
mandelnessita, if that is ok14:40
nessitamandel: sure!14:40
mandelnessita, bux #677012 patch will be there tom night, although I'm curious of the installation, I know how to do it wth distutils, no idea how would it be done in the client project14:44
nessitamandel: I guess you need to ask/coordinate with dobey about that14:44
nessitamandel: what is needed at installation time?14:44
Chipacamandel_, ping (yeah, better here)14:46
mandel_Chipaca, pong14:46
Chipacamandel_: in windows, the sso client/login thing's foucs handling makes me want to throw things :-/  how hard is it to fix?14:47
mandel_Chipaca, haha14:47
mandel_Chipaca, how do you want it too work?14:47
mandel_Chipaca, by the way, the answer is dooable14:48
Chipacaof course it's *doable*14:48
Chipacahow much time?14:48
mandel_Chipaca, how do you want it too work? if you tell me, I'llbe more precise :)14:49
* mandel_ is trying to be conservative 14:49
Chipacamandel_: there are degrees14:50
Chipacamandel_: when the dialog opens, focus should be in the email thing14:50
Chipacamandel_: after entering the password, hitting enter should submit14:50
Chipacamandel_: that's the basicest thing14:50
Chipacamandel_: next up, disable enter-is-submit and the submit button itself until email and password are entered14:51
Chipaca__mandel__, lost track of which one is you14:51
=== mandel__ is now known as mandel
mandel /msg NickServ identify Rfvtgb14:52
mandelhaha14:52
* mandel changes password14:52
dobeyhrmm14:54
mandel__Chipaca, can you add it as a bug, will be ready for tomm morning14:55
=== mandel__ is now known as mandel
bachi beuno14:58
=== mandel__ is now known as mandel
Chipacamandel: you want to do /msg NickServ ghost mandel <your nickserv password> when these things happen14:59
bachi, my contacts got all messed up and now i have duplicates for them all.  is there an easy way to delete them all and re-syncy a fresh set?15:00
Chipacabeuno: ^15:01
mandelChipaca, sorry, in case you missed it, can you file a bug, it will be solved by tom morning15:04
* mandel wonders why the network is so shit today...15:04
* beuno votes15:16
beunohiya bac!15:17
beunobac, well15:17
beunoaquarius may know how to delete your contacts db on the server15:17
helomandel: its just a rearrangement of green day, can't be that bad15:17
bachey beuno.  you have all your friends in BsAs this week?15:17
aquariusbeuno, I do15:17
aquariusbeuno, you'll need ubuntuone-couchdb-query, though15:17
beunoaquarius, it didn't work for me because of the new oauth world order15:18
beunobac, I do!15:18
beunoit's a lot of fun15:18
aquariusbeuno, you need the *new* ubuntuone-couchdb-query :)15:18
mandelhelo, what do you mean?15:18
bacbeuno: just be sure to pick the restaurant yourself!  :)15:18
beunoaquarius, aha!  I wants!15:19
helosorry, bad joke... 'the network' is a band made up of green day's members15:19
aquariusbeuno, http://ubuntuone.com/p/Gyx/ is the new ubuntuone-couchdb-query; then just do: ubuntuone-couchdb-query --http-method=DELETE contacts15:19
aquariusbeuno, note that this will just blow away the whole database without asking or anything, so be careful.15:19
beunobac, ^15:19
mandelhelo, he, I clearly did not get it :)15:23
bacbeuno: /home/bac/Downloads> ./ubuntuone-couchdb-query --http-method=DELETE contacts15:25
bac{'ok': True}15:25
bac0 contacts!  woot.  thanks.15:25
beunobac, now you have no friends15:26
bacbeuno: i'm ok with that15:26
lalejandHi all, does someone have an idea of what I can do about this bug : https://bugs.launchpad.net/ubuntu/+source/ubuntuone-client/+bug/675796 ?15:33
ubot4Launchpad bug 675796 in ubuntuone-client (Ubuntu) "can't delete contacts in the couchDB adressbook in evolution (affects: 1) (heat: 6)" [Undecided,New]15:33
lalejandI subscribed to the mobile plan, and I would like to sync my contacts if possible15:34
mandellalejand, ask rodrigo_ about evolution, he knows the most about it15:42
rodrigo_lalejand, I guess there are invalid chars coming from the u1 couchdb database, not sure15:43
lalejandrodrigo_ : ok, if I can do some tests, just tell me.15:43
lalejandrodrigo_ : is there a way to erase all contacts on the U1 server ?15:44
rodrigo_lalejand, can you open ~/.local/share/desktop-couch/couchdb.html and get to the contacts you can't remove and paste the JSON in the bug?15:45
rodrigo_lalejand, hmm, not sure, I think so, let me see15:45
lalejandrodrigo_ : check this one also : https://bugs.launchpad.net/ubuntuone-servers/+bug/67629715:46
ubot4Launchpad bug 676297 in ubuntuone-servers "Can't delete some contacts beginning with "." or "/" (affects: 1) (heat: 8)" [Undecided,New]15:46
lalejandrodrigo_ : what is the JSON ?15:47
rodrigo_lalejand, the format the contacts are stored in in couchdb15:47
rodrigo_lalejand, yeah, seems to be similar15:48
lalejandrodrigo_ : a JSON is something like this ? pas-id-49735391000003BB15:53
rodrigo_no, run on a terminal -> gnome-open ~/.local/share/desktop-couch/couchdb.html15:54
rodrigo_this will open a web interface to your local couchdbv15:54
rodrigo_so go to the contacts database, and try finding the problematic contacts15:54
rodrigo_then you have a JSON link (or button, don't remember and can't run it here right now)15:55
hallynso I've got two laptops on maverick, both happily syncing tomboy and files, and claiming to be syncing bookmarks.  Butbookmarks are not being synced.  Expected?15:55
rodrigo_just go there and copy the string (in the form of { "name": "....", ... }) to the bug15:55
lalejandrodrigo_ : the problem is that I can't even enter on my couchDB adressbook on evolution. When I try, the adressBook crashes15:57
rodrigo_lalejand, right, so try with the web interface15:57
lalejandrodrigo_ : is that what you want me to copy to the bug ? http://pastebin.com/H62SQ2Ye15:59
duanedesignlalejand: yes16:00
lalejandduanedesign, rodrigo_ : ok16:01
rodrigo_lalejand, yes16:02
rodrigo_lalejand, is that the problematic one?16:02
lalejandrodrigo_ : this is one I can't access via my U1 web account. The one with a "." as a name described here https://bugs.launchpad.net/ubuntuone-servers/+bug/676297?comments=all16:03
ubot4Launchpad bug 676297 in ubuntuone-servers "Can't delete some contacts beginning with "." or "/" (affects: 1) (heat: 8)" [Undecided,New]16:03
lalejandrodrigo_ : there is another one with "/" for name, and I can't get his ID because I get a 404 error when I click on it in my U1 web interface account16:04
duanedesigni have a contact that starts with a question mark that has a similar behavior16:06
rodrigo_but that doesn't explain the evo crash16:06
nessitaalecu: ping16:11
alecunessita, pong16:11
nessitaalecu: how are you going with the /tmp thingy?16:12
alecunessita, I'm testing a really small fix16:12
duanedesignrodrigo_: right. My evo does not crash. I can only confirm that contacts starting with 'odd' characters do not work as expected in the web interface16:16
duanedesignlalejand: i confirmed bug 676297 and added my info16:17
ubot4Launchpad bug 676297 in ubuntuone-servers "Can't delete some contacts beginning with "." or "/" (affects: 1) (heat: 8)" [Undecided,Confirmed] https://launchpad.net/bugs/67629716:17
lalejandrodrigo_ : I think the best thing to do for me is to erase the contacts on U1 server and on my couchDB adressBook. Is that possible ?16:23
rodrigo_lalejand, one by one on the web, evo should be able to let you select all and remove the, but since it crashes for you :(16:24
rodrigo_lalejand, so try removing them on your local couchdb web interface16:24
dobeybbiab; lunch time16:25
lalejandrodrigo_ : argh, I have some 2700 contacts16:27
duanedesignhallyn: you have Bookmarks checked under the 'Services' Tab in the Ubuntu One Preferences?16:28
lalejandrodrigo_ : I can do "delete database" on the http://localhost:45314/_utils/database.html?contacts page ?16:28
rodrigo_lalejand, :(16:28
rodrigo_lalejand, try removing the problematic ones from the local web interface, and then the rest with evolution16:28
duanedesignhallyn: you might try the steps under 'Killing and Restarting Desktopcouch' http://www.freedesktop.org/wiki/Specifications/desktopcouch/Documentation/Troubleshooting16:30
duanedesignhallyn: step 4 is not really necessary other then to verify that desktopcouch is running. You might check and see if the 'bookmarks' database exists though while looking at the desktopcouch web interface.16:31
duanedesignoff to lunch, brb16:32
lalejandrodrigo_ : I deleted the "." and the "/" in my database, restarted evo, clicked on the adressbook tab in evo, evo displayed the couchDb adressbook by default writting that there was no contact, I clicked on my personal adressbook, clicked again on my couchDb adressbook, and adressbook crashed16:37
rodrigo_lalejand, so the problematic for evo contact is another one16:39
lalejandrodrigo_ : and evo freezes16:43
lalejandrodrigo_ : is there a way to reset the couchDB adressbook ?16:43
rodrigo_lalejand, no, just removing it, but that will get the contacts from the remote couchdb in the next replication16:44
lalejandrodrigo_ : so I would have to resolve the "." and "/" contact names on U1 server first16:45
lalejandrodrigo_ : how do I remove it ? Just doing delete adressbook in evo ?16:46
rodrigo_lalejand, no, in the local couchdb web interface16:46
lalejandrodrigo_ : with the "delete database" button ?16:47
rodrigo_yes16:47
lalejandrodrigo_ : ok, I will try16:48
lalejandrodrigo_ : once I deleted the database, I just have to reactivate the couchdb in the cnotact pref in evo ?16:58
rodrigo_lalejand, no, it's activated automatically16:58
lalejandok, so I just restart evo ?16:59
lalejandrodrigo_ : ok, so I just restart evo ?16:59
rodrigo_yes16:59
hallynduanedesign: yes, bookmarkes checked on both17:00
hallynand like i say notes andn files are being shared17:00
hallyni did just follow the steps in the faq, waiting to see what happens, but wouldn't expec thtat to work17:01
lalejandrodrigo_ : ok restarted evo, clicked on contacts tab, displayed couchdb adressbook by default : no contact. Do I have to wait ?17:04
rodrigo_lalejand, yes, until they replicate from the server17:04
rodrigo_lalejand, check ~/.cache/desktop-couch/log/desktop-couch-replication.log17:04
lalejandrodrigo_ : last line is : 2010-11-18 17:58:00,785 DEBUG    finished replicating17:06
rodrigo_and no errors?17:06
lalejandrodrigo_ : still no contacts displayed and replication did that : http://pastebin.com/knDA3Kqw17:08
rodrigo_ok, replication failed17:09
rodrigo_ask thisfred about it17:09
rodrigo_or vds17:09
thisfredor CardinalFang. lalejand: Is this on lucid, or maverick?17:10
vdsreconnection issues17:10
lalejandthisfred : maverick17:10
thisfredvds, yeah, I thought that one was fixed though17:11
lalejandthisfred : new replication info : http://pastebin.com/x0D0xG5g (I didn't click anything)17:11
vdsthisfred: they should, it depends on the version lalejand is using17:11
CardinalFanglalejand, thisfred, rodrigo_, ah, couchdb died and the replication service is confused.17:13
thisfredlalejand, what does this tell you: apt-cache show desktopcouch17:13
CardinalFanglalejand, are you comfortable with killing a process?  "desktopcouch-service" in particular.17:14
lalejandCardinalFang : apt-cache show desktopcouch : http://pastebin.com/eMEspG1817:15
CardinalFangI can tell you how, if you want.  I don't know how much to say.17:15
lalejandCardinalFang : I can kill it yes17:15
CardinalFanglalejand, after that, start it up again.  At a terminal,    $   dbus-send --session --dest=org.desktopcouch.CouchDB --print-reply --type=method_call / org.desktopcouch.CouchDB.getPort17:16
lalejandCardinalFang : ps -A | grep desktop --> 2 processes : 2163 ?        00:01:59 desktopcouch-se & 2329 ?        00:02:08 desktopcouch-se17:17
CardinalFanglalejand, both or the lower one.  $ kill 216317:17
lalejandCardinalFang : ok, I will kill both17:18
lalejandCardinalFang : I start it by doing $desktopcouch-service or doing what you said ($dbus-send...) ?17:20
CardinalFanglalejand, that's the fastest way, yes.17:20
lalejandCardinalFand : which one ? Yours ?17:21
CardinalFangWhat?  Oh, mine is better.17:22
lalejandCardinalFang : ok, started. What do I do now ?17:23
CardinalFanglalejand, it should be replicating now.17:24
CardinalFanglalejand,  file  ~/.cache/desktop-couch/log/desktop-couch-replication.log  should have a mind-numbing amount of detail, if you want to look.17:26
nessitaguys, I need reviews for 2 branches:17:28
nessitahttps://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/add-syncdaemon-backend/+merge/4111017:28
nessitahttps://code.launchpad.net/~nataliabidart/ubuntu-sso-client/ping-url-can-be-none/+merge/4117717:28
lalejandCardinalFang : 2010-11-18 18:26:24,464 ERROR    can't replicate 'gwibber_messages'  'http://localhost:36886/' <== {'source': 'gwibber_messages', 'target': {'url': 'https://couchdb.one.ubuntu.com/u%2F94a%2Fb54%2F543934%2Fgwibber_messages', 'auth': {'oauth': {dbus.String(u'consumer_secret'): 'HiddenHidd', dbus.String(u'token'): dbus.String(u'RxKklcmQ50QQNWDD8jhn'), dbus.String(u'consumer_key'): dbus.String(u'ubuntuone'), dbus.Stri17:31
lalejandCardinalFang : do you understand the problem ?17:31
lalejandCardinalFang : several errors. Here is another one : ERROR    can't create/verify 'u/94a/b54/543934/bookmarks' couchdb.one.ubuntu.com:443  oauth={dbus.String(u'consumer_secret'): 'HiddenHidd', dbus.String(u'token'): dbus.String(u'RxKklcmQ50QQNWDD8jhn'), dbus.String(u'consumer_key'): dbus.String(u'ubuntuone'), dbus.String(u'name'): dbus.String(u'UbuntuOne token for https://ubuntuone.com'), dbus.String(u'token_secret'): 'HiddenHid17:33
CardinalFanglalejand, I understand that first one.  It probably is so large that it takes too long to open it.  But, it's a DB you probably don't care about.17:34
CardinalFanglalejand, the second one is interesting, but not a grave problem.17:35
CardinalFanglalejand, what's immediately after that?17:35
lalejandTraceback (most recent call last):17:35
lalejandFile "/usr/lib/python2.6/dist-packages/desktopcouch/pair/couchdb_pairing/couchdb_io.py", line 247, in replicate17:35
CardinalFanglalejand, pastebin the next 20 lines.17:36
lalejandCardinalFang : I lost it, I updated the file17:37
lalejandCardinalFang : here is another one : http://pastebin.com/LUP9VdGx17:38
CardinalFanglalejand, Hrm, timeout on server.  That usually means the DB is huge.  We'll look to figure that one out.17:38
lalejandCardinalFang : 2700 contacts :/17:39
CardinalFangWow.  You're very popular.  :)17:40
thisfredI wish we could tell haproxy to either block all or none of the requests for a single replication session17:41
lalejandCardinalFang : well I would like to. But I think what happened is that I installed one day a kind of plugin that adds the chat contacts to the evo contacts. And it was not a good idea :(17:42
lalejandCardinalFang : so I have plenty of contact kind of "0009878775565665", and contacts in double, ...17:43
CardinalFanglalejand, well, there's nothing *wrong* with having that many.  We have something to fix.17:46
lalejandCardinalFang : Can I do something ?17:49
CardinalFanglalejand, I don't think so, but thanks.17:53
lalejandCardinalFang : so for me for the moment, the only solution is to delete one by one the contacts on U1 server ?17:54
CardinalFanglalejand, Hrm, without some programming, yes.18:05
nessitaalecu, Chipaca: would you please perform a few reviews for me?19:31
alecunessita, I can19:31
Chipacanessita: I'm three levels of abstraction away from your things... can they wait?19:32
Chipacanessita: also: you need to start pinging CardinalFang and thisfred and vds and mandel for reviews more (start with small reviews) :)19:32
nessitaChipaca: yes, of course. PLease let me know when you have s lot.19:32
nessitaChipaca: yes, I agree. Thing is that right now, for control panel, the branches are huge, and not easible breakable19:33
nessitaI've asked for reviews in the channel since this morning19:33
Chipacanessita: ok19:33
nessitaalecu: easy and quick: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/ping-url-can-be-none/+merge/4117719:33
nessitaalecu: easy but not quick (the diff is big but is mainly refactor of dbus_client tests): https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/add-syncdaemon-backend/+merge/4111019:34
alecuon them19:34
nessitaalecu: I'm not in a hurry, but if possible, it would rock to have those ready for tomorrow morning. I've pinged you directly because no one else offered. Thanks!19:36
alecunessita, no problem.19:36
nessitaChipaca: the fact that I will be working mainly by myself on control panel makes the review process a bit more difficult. I guess the same will happen for alecu. I know we should be aware of each others work, but doing reviews of unfamiliar code is not easy nor appealing... :-)19:38
Chipacanessita: we'll all be working on things in relative isolation, and unless we pay attention during standups and the weekly meet, and do eachother reviews, we'll only make things worse. I worry about this -- we'll be in silos before we know it. The whole team has gotten worse at doing reviews on things we aren't familiar with, and we need to work to get that back...19:40
Chipacanessita: ... this is something I need to bring up tomorrow19:41
* Chipaca changes hat19:41
Chipacaand I probably need to send it to the mailing list also19:41
* Chipaca puts on another hat19:41
* Chipaca goes back to the code19:41
nessitaChipaca: I agree. Are you thinking on bringing back review days again? mauinly19:42
nessitaoops19:42
nessitamainly in a per team basis?19:42
Chipacanessita: no19:43
Chipacanessita: not yet anyway19:43
Chipacanessita: if explaining why it's important to review code you're not familiar with isn't enough, I might. We'll see.19:44
nessitaok19:44
alecunessita, if ping_url is None, why are we calling self._ping_url() at all?19:55
nessitaalecu: what a great question19:57
nessitaalecu: I'll fix!19:57
alecuthanks!19:57
nessitaalecu: since we have a duplicated if within _ping_url :-/19:57
nessitaand by we I mean silly me :-D19:57
nessitaalecu: fixed, tested and pushed20:08
alecunessita, thanks20:09
nessitathank you! really20:09
* nessita is gone21:17
nessitabye all!21:17

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!