| === Ursinha-afk is now known as Ursinha | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | hi henninge! | 08:25 |
|---|---|---|
| henninge | Hey jtv! | 08:26 |
| === adeuring1 is now known as adeuring | ||
| === adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === Guest77235 is now known as jelmer | ||
| jtv | adeuring, got one for ya :) https://code.launchpad.net/~jtv/launchpad/buildfail-recipebuilder/+merge/41280 | 10:41 |
| adeuring | jtv: I'll look | 10:41 |
| jtv | thanks | 10:41 |
| === adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: -, jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| adeuring | jtv: the diff is huge... | 10:46 |
| jtv | adeuring: then I MP'ed to db-devel by mistake—hang on | 10:47 |
| adeuring | jtv: it is even another branch ;) | 10:47 |
| jtv | oh | 10:47 |
| jtv | adeuring: https://code.launchpad.net/~jtv/launchpad/buildfail-recipebuilder/+merge/41282 | 10:49 |
| === bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: -, jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| adeuring | jtv: you mention the method becomeDbUser() in the MP, but II don't see it in the diff... | 10:59 |
| jtv | arr | 10:59 |
| jtv | hang on | 10:59 |
| jtv | adeuring: I pushed the update some time ago, but the diff hasn't updated yet. :-( | 11:04 |
| adeuring | jtv: Ah, I see. I'll use a local "bzr diff --old=<devel>" | 11:05 |
| jtv | thanks | 11:08 |
| adeuring | jtv: that diff is odd in other ways: contains changes in lib/lp/bugs/browser/bugsubscription.py, for example. But I can't find becomeDbUser()... It also doesn't appear in "bzr diff -r 11943" for the branch. Could it be that a commit is missing? | 11:12 |
| adeuring | jtv: gahhh. "bzr pull" | 11:12 |
| adeuring | that seems to help... | 11:12 |
| jtv | :) | 11:12 |
| adeuring | jtv: r=me | 11:16 |
| jtv | adeuring: dankeschön | 11:17 |
| adeuring | welcome :) | 11:17 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === Guest54849 is now known as jelmer | ||
| === matsubara-afk is now known as matsubara | ||
| allenap | adeuring: Fancy doing a mentor review? https://code.launchpad.net/~allenap/launchpad/subscribe-to-tag-bug-151129-2/+merge/41186. I'd value your opinion on the SQL bits especially. | 13:22 |
| adeuring | allenap: sure, I'll look at the branch. | 13:23 |
| allenap | Cheers. | 13:23 |
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === jaycee is now known as jcsackett | ||
| adeuring | allenap: r=me | 14:19 |
| === matsubara is now known as matsubara-lunch | ||
| allenap | adeuring: Thank you, I'll sort out that docstring now. | 14:24 |
| adeuring | allenap: thanks! | 14:24 |
| === benji changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| benji | hi adeuring, I have a small branch that speeds up the WADL generation script ready for review: https://code.edge.launchpad.net/~benji/launchpad/faster-wadl/+merge/41315 | 14:42 |
| adeuring | benji: I'll look | 14:42 |
| benji | thanks | 14:43 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: benji || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jcsackett | sinzui: adeuring followed up on the review i did for allenap (https://code.edge.launchpad.net/~allenap/launchpad/subscribe-to-tag-bug-151129-2/+merge/41186). do you still want to follow up for mentor process? allenap has dealt with my quibbles. :-) | 14:48 |
| sinzui | jcsackett, no. all it well | 14:49 |
| jcsackett | cool beans. | 14:49 |
| === Ursinha is now known as Ursinha-lunch | ||
| adeuring | benji: yay for faster "make build", r=me :) | 14:57 |
| benji | :) | 14:57 |
| === matsubara-lunch is now known as matsubara | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === benji is now known as benji-lunch | ||
| === adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === benji-lunch is now known as benji | ||
| === Ursinha is now known as Ursinha-afk | ||
| abentley | flacoste: could you give me an RS on downgrading bzr to 2.2.0? https://code.launchpad.net/~abentley/launchpad/downgrade-bzr/+merge/41356 | 19:39 |
| === Ursinha-afk is now known as Ursinha | ||
| flacoste | abentley: done already | 20:15 |
| flacoste | abentley: in case, you didn't saw it | 20:16 |
| abentley | flacoste: thanks. | 20:16 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === matsubara is now known as matsubara-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!