=== Ursinha-afk is now known as Ursinha
=== bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[08:25] <jtv> hi henninge!
[08:26] <henninge> Hey jtv!
=== adeuring1 is now known as adeuring
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Guest77235 is now known as jelmer
[10:41] <jtv> adeuring, got one for ya :)  https://code.launchpad.net/~jtv/launchpad/buildfail-recipebuilder/+merge/41280
[10:41] <adeuring> jtv: I'll look
[10:41] <jtv> thanks
=== adeuring changed the topic of #launchpad-reviews to: On call: bac, adeuring || Reviewing: -, jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:46] <adeuring> jtv: the diff is huge...
[10:47] <jtv> adeuring: then I MP'ed to db-devel by mistake—hang on
[10:47] <adeuring> jtv: it is even another branch ;)
[10:47] <jtv> oh
[10:49] <jtv> adeuring: https://code.launchpad.net/~jtv/launchpad/buildfail-recipebuilder/+merge/41282
=== bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: -, jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:59] <adeuring> jtv: you mention the method becomeDbUser() in the MP, but II don't see it in the diff...
[10:59] <jtv> arr
[10:59] <jtv> hang on
[11:04] <jtv> adeuring: I pushed the update some time ago, but the diff hasn't updated yet.  :-(
[11:05] <adeuring> jtv: Ah, I see. I'll use a local "bzr diff --old=<devel>"
[11:08] <jtv> thanks
[11:12] <adeuring> jtv: that diff is odd in other ways: contains changes in lib/lp/bugs/browser/bugsubscription.py, for example. But I can't find becomeDbUser()... It also doesn't appear in "bzr diff -r 11943" for the branch. Could it be that a commit is missing?
[11:12] <adeuring> jtv: gahhh. "bzr pull"
[11:12] <adeuring> that seems to help...
[11:12] <jtv> :)
[11:16] <adeuring> jtv: r=me
[11:17] <jtv> adeuring: dankeschön
[11:17] <adeuring> welcome :)
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Guest54849 is now known as jelmer
=== matsubara-afk is now known as matsubara
[13:22] <allenap> adeuring: Fancy doing a mentor review? https://code.launchpad.net/~allenap/launchpad/subscribe-to-tag-bug-151129-2/+merge/41186. I'd value your opinion on the SQL bits especially.
[13:23] <adeuring> allenap: sure, I'll look at the branch.
[13:23] <allenap> Cheers.
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== jaycee is now known as jcsackett
[14:19] <adeuring> allenap: r=me
=== matsubara is now known as matsubara-lunch
[14:24] <allenap> adeuring: Thank you, I'll sort out that docstring now.
[14:24] <adeuring> allenap: thanks!
=== benji changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [benji] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:42] <benji> hi adeuring, I have a small branch that speeds up the WADL generation script ready for review: https://code.edge.launchpad.net/~benji/launchpad/faster-wadl/+merge/41315
[14:42] <adeuring> benji: I'll look
[14:43] <benji> thanks
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: benji || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:48] <jcsackett> sinzui: adeuring followed up on the review i did for allenap (https://code.edge.launchpad.net/~allenap/launchpad/subscribe-to-tag-bug-151129-2/+merge/41186). do you still want to follow up for mentor process? allenap has dealt with my quibbles. :-)
[14:49] <sinzui> jcsackett, no. all it well
[14:49] <jcsackett> cool beans.
=== Ursinha is now known as Ursinha-lunch
[14:57] <adeuring> benji: yay for faster "make build", r=me :)
[14:57] <benji> :)
=== matsubara-lunch is now known as matsubara
=== Ursinha-lunch is now known as Ursinha
=== benji is now known as benji-lunch
=== adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing:  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji-lunch is now known as benji
=== Ursinha is now known as Ursinha-afk
[19:39] <abentley> flacoste: could you give me an RS on downgrading bzr to 2.2.0? https://code.launchpad.net/~abentley/launchpad/downgrade-bzr/+merge/41356
=== Ursinha-afk is now known as Ursinha
[20:15] <flacoste> abentley: done already
[20:16] <flacoste> abentley: in case, you didn't saw it
[20:16] <abentley> flacoste: thanks.
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== matsubara is now known as matsubara-afk
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk