| wallyworld_ | StevenK: bambi's b1tch asked me to flick a couple of reviews your way. you should see them in your email. thanks in advance :-) | 02:07 |
|---|---|---|
| thumper | wallyworld_: my headset isn't working | 03:18 |
| wallyworld_ | thumper: ok, talk later then i guess :-) | 03:18 |
| thumper | I can hear you | 03:18 |
| thumper | but mumble can't hear me :( | 03:18 |
| henninge | jtv:Hi! | 07:56 |
| henninge | jtv: I am surprised this works: http://paste.ubuntu.com/535469/ | 07:56 |
| jtv | hi henninge! | 07:56 |
| jtv | Q about my MP? | 07:56 |
| henninge | yes | 07:56 |
| jtv | It doesn't for me. | 07:56 |
| jtv | But give my http connection a bit more time. | 07:57 |
| jtv | Ahhh there it is. | 07:57 |
| henninge | makeSourcePackage makes an *Ubuntu* source package? | 07:57 |
| jtv | What's the surprise? | 07:57 |
| === StevenK changed the topic of #launchpad-reviews to: On call: - || Reviewing: || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | Heh, I hadn't thought of that. But we now basically assume that all source packages are Ubuntu, don't we? | 07:58 |
| StevenK | We shouldn't | 07:58 |
| jtv | Because I think you're right: it creates a new distro AFAIK. | 07:58 |
| jtv | StevenK: this is Translations, it's special. :) | 07:58 |
| henninge | jtv: we do??? | 07:59 |
| henninge | oh, right, we do .. we are Translations .... | 07:59 |
| henninge | ;-) | 07:59 |
| jtv | We are special. | 07:59 |
| jtv | Our new data model accommodates only one family of distributions. Once we have the sharing working, we can worry about shoehorning in more—if required. | 08:00 |
| henninge | So it's our checking if productseries is None -> it's ubuntu | 08:00 |
| henninge | but it wasn't in focus ;) | 08:00 |
| jtv | 'zacly | 08:01 |
| henninge | jtv: but still, I always use the "ubuntu" celebrity, I think. | 08:01 |
| henninge | to be explicit | 08:01 |
| jtv | That's perfectly correct, just very verbose. My personal feeling is we'll want a makeUbuntuSourcePackage at some point. | 08:02 |
| jtv | Or maybe even a makePOFile/makePOTemplate option for_ubuntu. | 08:02 |
| henninge | yes, our dear Ubuntu. :-) | 08:02 |
| jtv | Or in this case, our ubiquitous ubuntu. | 08:03 |
| henninge | jtv: so can you please be verbose in this test and use ubuntu? | 08:03 |
| jtv | Our user-friendly but undeniably un-upstream ubiquitous ubuntu. | 08:03 |
| henninge | "un-upstream" as in "not is_current_upstream! | 08:04 |
| henninge | " | 08:04 |
| henninge | ? | 08:04 |
| jtv | Why? We're assuming that it'll always be either Ubuntu or a derivative. There's no easy way for the code to discover the difference. If this ever becomes not what we want, we'll have more places to change and that would be a good time to come up with something more convenient. | 08:04 |
| jtv | Exactly. | 08:07 |
| henninge | ok, ok ... | 08:07 |
| jtv | It's really über-un-upstream. | 08:07 |
| henninge | jtv: template.getTranslationPolicy | 08:08 |
| jtv | uh-huh | 08:08 |
| henninge | I guess you added that in a recent branch? | 08:08 |
| jtv | Yes. It gets the ITranslationPolicy implementation that applies to the template. | 08:08 |
| jtv | (Which is either a Project or a Distribution, though a Project may also inherit part of its policy from a ProjectGroup) | 08:09 |
| jtv | I considered calling it getPillar, but we (including yours truly) have been overusing that a bit, and it's not quite right here. | 08:10 |
| jtv | This also gives us the option to break out the repetitive policy data into its own ORM-backed class in the future. | 08:11 |
| henninge | cool | 08:12 |
| henninge | jtv: two more things | 08:13 |
| jtv | (I'm sitting here facing a lady reading a house-and-garden magazine. The rear cover shows either a palace or a stately mansion with an elephant either grazing in the massive land around it, or carrying the house on its back. The perspective makes it unclear. The front cover says "Humble Living.") | 08:14 |
| jtv | Shoot. | 08:14 |
| henninge | It feels to me like there should be more test_revert_unselected_translations where plural_indices_to_store has a value other than [] | 08:14 |
| henninge | there is only one so far | 08:15 |
| henninge | only a feeling, though. I did not check test coverage very closely. | 08:15 |
| henninge | jtv: also, I think it would be cool to implement contains_translations using "any" ;-) | 08:16 |
| jtv | I considered both, believe it or not. | 08:16 |
| henninge | any([text is not None and len(text) != 0 for text in translations.itervalues()]) | 08:17 |
| henninge | ok | 08:17 |
| henninge | then we are done, I guess | 08:17 |
| * henninge knows that jtv always considers thoroughly. | 08:17 | |
| henninge | oh, i thing the [...] are not even needed in 2.6 | 08:18 |
| henninge | s/thing/think/ | 08:18 |
| jtv | :-) Thanks. Two reasons I didn't use any(): call it micro-optimization but I didn't feel like constructing a list for something this small; and to make it look really _nice_ I'd have to evaluate text as a boolean, which we're not really supposed to do. | 08:19 |
| jtv | Oh, without the [] we'd probably avoid the list… | 08:19 |
| jtv | …but that wasn't the main thing. :) | 08:19 |
| jtv | About the tests: I could add test for various set relationships, but it seemed a bit redundant. As they say, one needs to test the zero case and the one case, and all else just follows. | 08:20 |
| henninge | yes but I was just thinking of more conditions around [0] | 08:21 |
| jtv | OK, I'll spend a bit more time (not too much :) thinking about things I could test for. It's a valid concern. | 08:21 |
| jtv | But now I need to run to a place where I can't conveniently use wifi. | 08:22 |
| henninge | although I had not heard "them" say that yet. Sounds sound, though. | 08:22 |
| henninge | run! | 08:22 |
| jtv | Assuming I want to keep this laptop dry. | 08:22 |
| jtv | Well, "hop" is more accurate at this stage. | 08:22 |
| jtv | Limp. | 08:22 |
| jtv | Scurry. | 08:22 |
| StevenK | gmb: O hai, you're free to do some reviews? | 09:17 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | StevenK: I am now. | 10:03 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| StevenK | gmb: That SHA1 comes from sampledata | 10:27 |
| StevenK | It actually comes from the gina_archive in the source tree | 10:28 |
| gmb | StevenK: So, can we update the source so that it's obviously manufactured? | 10:29 |
| StevenK | gmb: I can update the test to extract the same changelog, run sha1 over it, and then compare them if that would please you more? | 10:30 |
| gmb | StevenK: That would work, yes. Please do it. | 10:33 |
| StevenK | gmb: I could change it to do .read() and check the output, if you don't like the sha1 | 10:46 |
| gmb | StevenK: Even better. | 10:47 |
| StevenK | gmb: Changed pushed, diff updated | 10:59 |
| === matsubara-afk is now known as matsubara | ||
| adeuring | gmb: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-675595/+merge/41595? | 13:39 |
| gmb | adeuring: Sure | 13:40 |
| adeuring | thanks! | 13:40 |
| gmb | adeuring: r=me. Nice work. | 13:50 |
| adeuring | gmb: thanks! | 13:50 |
| === matsubara is now known as matsubara-lunch | ||
| === mars changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | adeuring: I'm heading out for a run, so just put whatever you need reviewing on the queue and I'll attend to it when I return. | 14:17 |
| gmb | Oh, or maybe mars will look first :). Hi mars. | 14:17 |
| mars | Hi gmb | 14:17 |
| adeuring | gmb: ok, thanks for the notice | 14:17 |
| adeuring | gmb, mars: could one of you please have a look at https://code.edge.launchpad.net/~adeuring/launchpad/bug-675595-2/+merge/41604 ? | 14:46 |
| mars | adeuring, sure | 14:49 |
| adeuring | mars: thanks! | 14:49 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: -,adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: -,adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | salgado can you review https://code.launchpad.net/~sinzui/launchpad/upstream-downstream-bug-links-0/+merge/41371 | 14:58 |
| salgado | sinzui, sure, but I may not be able to get to it today. can it wait until tomorrow? | 14:58 |
| sinzui | okay | 14:58 |
| salgado | cool | 14:59 |
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === mars changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| adeuring | mars: thanks for the review! | 15:23 |
| === sinzui changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: -,- || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | gmb, mars: I have a small branch that needs review: https://code.launchpad.net/~sinzui/launchpad/private-persontransferjob-0/+merge/41614 | 15:54 |
| gmb | sinzui: I'll take it. | 15:54 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb,mars || Reviewing: sinzui,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | sinzui: Please add a comment / docstring to test_no_warning_for_PersonTransferJob() explaining the expected behaviour. Otherwise, r=me. | 15:57 |
| sinzui | gmb: thanks. I will update the test | 15:58 |
| gmb | Cool. | 15:59 |
| === gmb changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| * gmb calls it a day for reviewing | 15:59 | |
| === deryck is now known as deryck[lunch] | ||
| abentley | mars: could you please review https://code.edge.launchpad.net/~abentley/launchpad/more-harness/+merge/41619 ? It's tiny. | 16:23 |
| mars | abentley, about to go on a call, but I will as soon as possible afterwards | 16:29 |
| abentley | mars: also: https://code.edge.launchpad.net/~abentley/bzr-builder/launchpad/+merge/41623 | 17:09 |
| === abentley changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [abentley, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado-lunch is now known as salgado | ||
| === deryck[lunch] is now known as deryck | ||
| === benji is now known as benji-lunch | ||
| === maxb_ is now known as maxb | ||
| === benji-lunch is now known as benji | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| === sinzui changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | mars, do you have time for a short branch? https://code.launchpad.net/~sinzui/launchpad/prefill-homepageurl-0/+merge/41652 | 21:00 |
| mars | sinzui, sure | 21:14 |
| === mars changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | thanks | 21:14 |
| thumper | abentley: https://code.edge.launchpad.net/~thumper/launchpad/recipe-binary-builds/+merge/40686 | 22:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!