| jtv | StevenK: we're on a very intense deadline today, and a critical branch hasn't been reviewed… could you help henninge out? | 07:41 |
|---|---|---|
| StevenK | jtv: I sure can, link me? | 07:41 |
| henninge | StevenK: hang on | 07:41 |
| jtv | thanks guys :) | 07:41 |
| StevenK | henninge: Still hanging on :-) | 08:01 |
| henninge | StevenK: thanks for hanging on ;-) | 08:02 |
| henninge | https://code.edge.launchpad.net/~henninge/launchpad/recife-current-tm-view-1/+merge/41690 | 08:02 |
| henninge | StevenK: stop! | 08:08 |
| henninge | StevenK: requisite branch missing ... | 08:08 |
| henninge | pre | 08:08 |
| StevenK | Hah | 08:08 |
| henninge | I think | 08:08 |
| StevenK | You say, after I've read through the entire diff | 08:08 |
| henninge | StevenK: well, actually, that part needs review, too. | 08:09 |
| henninge | ;-) | 08:09 |
| henninge | StevenK: mp updated with a comment. Sorry again. | 08:17 |
| StevenK | henninge: +1'd, I just need a mentor review | 08:20 |
| StevenK | Sadly, my mentor EOD'd about 3 hours ago | 08:20 |
| henninge | StevenK: there'll be others waking up ... ;) Thank you very much! | 08:22 |
| henninge | StevenK: Your review is for all files in the diff, right? | 08:22 |
| StevenK | Right | 08:23 |
| henninge | cool, thanks ;) | 08:27 |
| henninge | StevenK: "other" is short for "other side" which term is used in other places in the recife branch. | 08:28 |
| StevenK | henninge: The UI displays which of those two terms? | 08:35 |
| henninge | The UI currently just says "Other:" but the next branch changes that to "In Upstream:" and "In Ubuntu:" respectively. | 08:36 |
| henninge | The term "other" or "other side" will not appear in the UI. | 08:36 |
| henninge | "next branch" == work in progress | 08:36 |
| StevenK | henninge: Then feel free to ignore that bit | 08:38 |
| === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| === mrevell is now known as mrevell-lunch | ||
| stub | jelmer: https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/41691 is pretty trivial, almost self reviewable. | 12:04 |
| jelmer | hi stub | 12:05 |
| jelmer | I'll have a look | 12:05 |
| === henninge changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| salgado | sinzui, I went to UI review your branch but noticed that rockstar has done so already. if you'd like a second review just let me know and I'll be glad to do it | 12:26 |
| salgado | hi jelmer. can I add another one to the queue? | 12:27 |
| jelmer | salgado: Hi Salgado. Of course :-) | 12:28 |
| === salgado changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: - || queue: [henninge,salgado] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer | stub: r=me | 12:30 |
| stub | ta | 12:32 |
| === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: henninge || queue: [salgado] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer | henninge: the branch that needs review is lp:~henninge/launchpad/recife-current-tm-view-1 ? | 12:38 |
| henninge | jelmer: yes! | 12:38 |
| henninge | jelmer: Steven already had a look at it but it needs a second review. | 12:38 |
| henninge | jelmer: thanks a lot. I'll be off to lunch soon but would be happy to reply after it, if needed. | 12:41 |
| jelmer | henninge: np | 12:42 |
| === mrevell-lunch is now known as mrevell | ||
| === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: salgado || len(queue) == 0 || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === henninge changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: salgado || [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | jelmer: got another one. ;-) | 15:58 |
| henninge | jelmer: but only if you can finish it before your EOD ;-) | 15:59 |
| jelmer | henninge: Yeah, that should be doable.. I'm here for at least another hour. | 16:00 |
| henninge | cool, it's not very big either .. | 16:00 |
| jelmer | yeah, I just had a quick look | 16:03 |
| === salgado-lunch is now known as salgado | ||
| jelmer | henninge: r=me | 16:26 |
| * jelmer dives back into the {s,blue}prints code | 16:27 | |
| henninge | jelmer: thank you! | 16:27 |
| === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: salgado || queue == [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === jelmer changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue == [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| salgado | sinzui, did you see my comment on https://code.launchpad.net/~james-w/launchpad/expose-blueprints/+merge/30026? | 17:38 |
| sinzui | I did | 17:38 |
| sinzui | I set the bug you are working on as high since it is now linked to a branch | 17:38 |
| salgado | sinzui, yeah, saw that. did you also see my branch which addresses your comments? If I'm not missing anything, it looks like the two remaining issues are the removal of updateLifecycleStatus() from browser code and unexporting of .distribution/.product/.productseries/.distroseries, with setTarget() and proposeForGoal() exported instead of them? | 17:52 |
| salgado | jelmer, thanks for the review! I'll add the docstrings you suggested. btw, I guess you didn't notice the XXX I left in personHasDriverRights() as I don't quite like that name? | 17:56 |
| jelmer | salgado: Yeah, but I don't really have any better suggestions (other than personHasDriversLicense :-P) | 17:59 |
| sinzui | salgado, I will look at the branch after my meeting | 18:00 |
| salgado | jelmer, heh, ok, I'll remove the XXX then | 18:00 |
| salgado | thanks sinzui | 18:02 |
| salgado | jelmer, AFAICT, there's nothing on my branch that requires it to land on db-devel rather than devel. do you agree? | 18:07 |
| jelmer | salgado: Yes. | 18:08 |
| jelmer | salgado: IIRC you also proposed it against devel, no? | 18:08 |
| salgado | I did, just wanted to make sure | 18:09 |
| salgado | jelmer, also, do you know if there's a wiki page describing the tags that one should include in the PQM request? I guess I need the qa-untestable one? | 18:09 |
| salgado | or similar | 18:09 |
| jelmer | salgado: There is a bug associated with your branch so you don't need the no-qa tag in the commit. You should remove the needs-testing tag on the bug after the branch has landed and add qa-untestable | 18:11 |
| jelmer | salgado: I'm not sure if there's a wiki page, it would indeed be useful to have one. | 18:11 |
| salgado | ok, cool | 18:11 |
| salgado | jelmer, found this: https://dev.launchpad.net/PQMCommitMessages | 18:11 |
| salgado | doesn't mention QA tags but as you pointed they're not needed on commit messages anymore. :) | 18:12 |
| === benji is now known as benji-lunch | ||
| jcsackett | back | 18:27 |
| === henninge changed the topic of #launchpad-reviews to: On call: - || Reviewing: None || queue = [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | Hi! If somebody would look at my latest branch I would be thrilled. ;-) | 18:42 |
| === benji-lunch is now known as benji | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| thumper | abentley: ping | 21:11 |
| abentley | thumper: pong | 21:11 |
| thumper | abentley: https://code.edge.launchpad.net/~thumper/launchpad/recipe-binary-builds/+merge/40686 | 21:49 |
| abentley | thumper: https://code.launchpad.net/~abentley/launchpad/better-recipe-errors/+merge/41780 | 21:58 |
| thumper | abentley: done | 22:01 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!