| === Brownout_ is now known as Guest55652 | ||
| === debfx_ is now known as debfx | ||
| === Guest55652 is now known as Brownout | ||
| === JanC_ is now known as JanC | ||
| magcius | uh | 16:49 |
|---|---|---|
| micahg | magcius: ? | 18:22 |
| chrisccoulson | micahg - i did a debug build of xulrunner, and this is the error i get with conkeror: "Couldn't convert chrome URL: chrome://branding/locale/brand.properties" | 19:47 |
| chrisccoulson | at least, i think that's the fatal one. there's also some warnings about the default preferences too | 19:47 |
| micahg | chrisccoulson: maybe issues with the omnijar or should that be transparent? | 19:48 |
| chrisccoulson | micahg - we don't use omnijar for xulrunner | 19:48 |
| chrisccoulson | there is definately no branding chrome in xulrunner - that's part of firefox, so i guess that's the bug | 19:49 |
| chrisccoulson | something expects there to be branding provided | 19:49 |
| chrisccoulson | hmm, i'm guessing it's because i dropped bz466923_att350251_password_prompt_branding_fallback.patch | 19:51 |
| chrisccoulson | but upstream seem to strongly disagree with that patch | 19:51 |
| chrisccoulson | so i dropped it ;) | 19:51 |
| chrisccoulson | but it seems i might need to bring it back :( | 19:51 |
| micahg | chrisccoulson: well, it's xulrunner, so we have more leeway, but maybe we can talk to the conkeror devs | 19:52 |
| chrisccoulson | yeah, i don't mind reapplying the patch again, i just wanted to avoid carrying patches that upstream think are wrong | 19:52 |
| micahg | chrisccoulson: well, it does seem wrong, but it probably needs more digging in the conkeror code to figure out why it's using that | 19:53 |
| chrisccoulson | the conkeror case can be fixed by shipping the brand.properties, that's pretty trivial | 19:54 |
| chrisccoulson | in fact, i might just do that for now, and we'll see if this issue causes problems with any other applications before we resurrect that patch | 19:54 |
| === yofel_ is now known as yofel | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!