/srv/irclogs.ubuntu.com/2010/11/30/#ubuntu-kernel.txt

=== bjf is now known as bjf[afk]
chrismsnzhey guys - just dropping in to ask about a bug00:01
chrismsnzhttps://bugs.launchpad.net/ubuntu/+source/linux/+bug/58689700:01
ubot2Launchpad bug 586897 in linux-2.6 (Debian) (and 2 other projects) "stex driver (Promise SuperTrak 8350/4650,etc) produces drastic I/O errors/corruption with 10.04 or later (affects: 3) (heat: 18)" [Unknown,Unknown]00:01
chrismsnzthere has been a fix committed to the kernel tree apparently - it's a fairly serious bug (as it's a fairly common card) and I'd just like to pass on the fact that it's fix now for possible backport to the lucid kernel and inclusion on new installation media for lucid(10.04.2) and natty00:02
JFochrismsnz, do you have a link to the discussion or a SHA1 I can use?00:11
chrismsnzthe kernel discussion?00:12
JFowhere they discussed the issue on the LKML00:12
chrismsnzthis was in linux-scsi: http://marc.info/?l=linux-scsi&m=129021716922966&w=200:12
JFoor a SHA1 of the fix as it exists in the kernel tree00:12
chrismsnzi may have another one, stand by00:13
chrismsnzhere is lkml: http://www.linux-archive.org/device-mapper-development/459117-data-corruption-stex-promise-hw-raid-driver-device-mapper.html00:14
chrismsnzah, that actually looks like dm-devel D:00:14
JFochrismsnz, looks like that is still an ongoing discussion00:14
JFoyeah00:15
JFofrom the rest of the thread, this is still being discussed00:15
chrismsnzsorry JFo: here is the actuall diff: http://marc.info/?l=dm-devel&m=129070330506836&w=200:15
JFok00:15
JFoyeah, that is his proposed change00:16
JFothe conversation looks like they are trying still to determine the best way to address the problem00:16
JFohmm00:16
JFowait a sec...00:16
JFonevermind00:17
JFoI read the patch wrong00:17
JFo:)00:17
* JFo is tired00:17
* jjohansen steps away for a bit00:17
=== jjohansen is now known as jj-afk
JFochrismsnz, let me have a look at this tomorrow and I will see where it stands and talk to the team about its possible inclusion based on the current state00:18
chrismsnzi can't see where it was committed :\00:18
chrismsnzokidoki - feel free to drop in on/update the bug  there were a couple others watching it too00:18
JFoyeah, the last message in the thread seems to indicate it is still in flux00:18
chrismsnzwhen you have some answers, I mean :)00:18
JFohttp://marc.info/?t=129070303200002&r=1&w=200:19
JFolooking there ^00:19
JFook00:19
JFowill do00:19
firewaveHi everybody !05:20
firewaveI've just received a new kernel update on my server05:20
firewaveSomeone could tell me how to print the changelog in a terminal ?05:21
firewaveLOL... yeah ok.. aptitude changelog... I'm a bit a looser this night05:23
firewavesorry05:23
=== LibertyZero is now known as _LibertyZero_
=== smb` is now known as smb
* apw marvels at the funny white stuff falling from the sky08:50
smbapw, Has it made its way to your place then? :)08:51
* smb waits for messages of chaos from the island08:51
=== jj-afk is now known as jjohansen
apwsmb, yep, i expect we'll be closed before long08:55
jjohansensnow again, but they just had some last year08:55
apwat least fibre works under water08:55
apwjjohansen, this is _settling_ thoug08:56
smbapw, The bits could freeze08:56
apwheheh08:56
smbapw, And did you not have the settling last year too?08:56
apwmy bits could freeze08:56
apwsmb, yeah we did, but this is the very first we've seen and its settling08:56
smbAh you mean with an inserted "this year" ;908:57
smb:)08:57
smbThough I try to remember when it was that I barely made it there in between strike and snow...08:58
* smb remembers walking in the snow in London and he usually does not remember that long08:59
* smb wonders whether cking can hear him through all that snow09:04
apwsmb, heh yea, /me goes out to see how deep it is09:05
smbapw, Hope we see you again09:06
cking1 cm of snow here09:12
smbcking, Wasn't it 1 inch a minute ago? :)09:12
ckingheh, my initial guess was inaccurate and based on defunct non-metric measurements09:16
smbcking, Interesting question: do you think metric and convert or the other way round?09:17
ckingsmb, I was educated in metric but I think in both imperial and metric and select the one that gives me best 1 unit measurements, e.g. if it's ~2.5cm, I call it an inch, if it's ~30cm I call it a foot,  but if it's ~3 foot I call it a meter09:20
RAOFapw: I'm looking at the kernel delta assigned to me - the nouveau noaccel quirking patches.  We should drop those and see if anything breaks.09:24
smbRAOF, He may still have some fun in the snow at the moment09:25
RAOFMmm, snow.09:26
smbYou know that strange pieces of fluffly frozen water09:27
RAOFNot *all* of Australia is tropical or sub-tropical :P09:28
RAOFWe have such wonders in Tasmania, also.09:29
ckingsmb, http://www.amd64.org/support/microcode.html09:30
smbcking, ta09:31
smbRAOF, Yeah, probably we always think of AUS as far far south. Must be hot there. :)09:32
RAOFHeh.09:32
* smb looks around for apw09:52
apwRAOF, heh, i was going to ask you abut those tosay10:04
apwhad to pop to pick something up, which took longer than i imagined10:04
apwseems its is slippy slidey out there under foot10:05
smbapw, We were about to send the rescue team. :-P10:05
apwsmb, thanks :)10:06
RAOF:)10:08
apwRAOF, ok those are gone from the next upload10:08
apwRAOF, we also have this one: UBUNTU: SAUCE: i915 -- disable powersave by default10:09
apwi seem to remember that one was to stop some odd screen quivering we were seeing10:09
RAOFYeah.10:09
apwwant to think about that one with your X buddies and make a recommendation on it?10:11
RAOFSarvatt knows more about that;  I'll ping him tomorrow.10:11
apwRAOF, i have marked your task done for the ubuntu delta :)10:12
RAOFTa.10:12
smbapw, Is there any way to get from the generic release status to the personal item summary? I fail to see it if there is10:23
apwsmb, there is not, i know of now way to get there.  i tend to use the personal _bit_ of the overall burndown myself10:23
apwsmb, http://people.canonical.com/~platform/workitems/natty/canonical-kernel-team.html10:24
apwand scroll down to your name (the second occurance)10:24
smbapw, Cool. Actually, couldn't we just add that link to the natty links?10:24
apwwe might be able to i guess10:25
smbapw, I can do that if it is ok with you10:25
apwsmb, i am not sure there is an overall cycle personal version, which seems wrong10:25
smbapw, Oh actually it is there10:27
apwsmb, hmmm where ?10:27
smbJust called "overall burndown chart"10:27
smbUnder milestonded features10:27
smbstoned10:27
apwoh that link is there yes, but i pointed you tot 10:28
apwto that one earlier ...10:28
smbapw, Like a few minutes ago. :) But I could not even guess from the title that this is the team based list. And yes, you seem to have sent me a link to a personal burndown page as well which seems to be produced by the same stuff. now I just need to find how to get there10:31
apwthere are no links to the u/ prefixes as far as i know yet, i wonder why the names in the main pages do not go there10:33
apwi may propose changing those links to that10:33
smbYeah, that would be more helpful than the launchpad blueprint assignment page10:33
smbapw, One thing to improve imo would be to include the previous tasks at least in the overall page (which is naturally named ubuntu-11.04 instead of natty *grrr*)10:38
apwubuntu-11.04 is not overall, it is the stuff for the release milestone10:39
apwstuff milestoned after the beta10:39
apwthere seems to be a missing global one under just your name which there in the other views10:39
apwthe u/ stuff is very new, and a little broken i think10:39
smbAh ok. 10:40
=== ogra_ac_ is now known as ogra_ac
ogra_acapw, i guess you have seen cooloney's mail 10:51
cooloneyogra_ac: i've talked with apw already, heh10:52
ogra_ac(i dont expect any other outcome from our tests to be honest)10:52
ogra_acah cool10:52
ogra_aci just want to know whats the way forward now that we have positive results10:52
cooloneyogra_ac: i might need a xM machine for testing.10:52
apwogra_ac, indeed10:52
cooloneyogra_ac: i just have a beagle c310:52
apwogra_ac, i really have little idea of the scope of omap3, ie what boards you expect it to work on other than beagle10:53
ogra_accooloney, i actually expect their kernel to run better on XM 10:53
apwogra_ac, to put it another way i am not sure what our acceptance criteria will be10:53
ogra_acapw, well, we can only put one bootloader into the images by default anyway10:53
ogra_acso i would expect beagle to be the default and for others we might provide u-boot binaries that you can easil exchange on the created SD card10:54
ogra_acapw, i would keep the supported set of boards as narrow as we can, everything you can do additionally through replacing bootloaders would be optional and unsupported (also untested) by us10:55
apwogra_ac, so it is fair to say that 'works on beagle satisfactorly' is the criteria10:55
ogra_acyes10:55
apwogra_ac, ok cool, is someone from your side going to try the swapping in of this kernle into the CD image and give it a test ?10:55
ogra_acthere are requirements for IGEP2 boards, buit imho thats really up to linaro (i.e. if it works at release time its fine, i wouldnt do SRUs for them)10:56
ogra_acapw, as soon as we a) have images again and b) gruemaster has his setup ready 10:56
ogra_aci'll bring it up in the arm IRC meeting today10:56
apwogra_ac, excellent, did the meta shenaegens sort you out image wise10:56
ogra_acpartially10:57
ogra_acthere are other packages blocking atm10:57
ogra_acwe have a bunch of dektop packages that depend on kde which currently doesnt build at all on arm 10:57
ogra_acs/depend/build depend/10:57
ogra_acwe're sorting that remaining stuff this week10:58
apwogra_ac, thats a little annoying, i wonder why we'd want to install kde requiring apps by default on the gnome images10:58
apwogra_ac, but the kernel is out of your way10:58
ogra_ac*build depend* ... we dont install any kde stuff10:58
ogra_acbut i.e. transmission builds a kde client from the same source 10:59
apwogra_ac, ahh i see, now that does make sense10:59
ogra_acso it is ftbfs currently because kdelibs doesnt exist10:59
ogra_aci will unseed it from our image for A110:59
ogra_acsimilar stuff happens to ubuntuone 10:59
apwsuch is the life of an A1 CD11:00
ogra_acheh, yeah11:00
tseliotapw: how can I get the source for this kernel? (the source package is empty): http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.11-lucid/11:07
apwtseliot, that is not easy, back there the source packages were broken, later we have included the patches so you can recreate it more easily11:08
apwi may have the branch in the repository though11:09
apwthe master source for it would be v2.6.32.11 from the stable tree of course11:09
apwtseliot, what do you need to use it for, so i can work out what the best way to help you is11:09
tseliotapw: a friend of mine needs the sources for that vanilla kernel with the ubuntu packaging scripts11:10
apwtseliot, ok i've pushed the patches that are on that branch into the result directory like the later versions11:13
apwso he'd need v2.6.32.11 and then apply the 4 patches there11:13
tseliotapw: what branch is that?11:14
apwtseliot, ignore the branch, the builder leaves some mess arround for debugging which i looked at is all11:15
apwi've pushed the delta to the results directory11:15
tseliotapw: ah, ok, so he should get the vanilla kernel from upstream and apply those patches. Thanks11:17
apwtseliot, yes that is exactly what the build system does, well it generates the patches but you get the idea11:19
tseliotapw: I've learnt something new :)11:19
apwtseliot, some of the older ones are missing the patches cause we thought the source packages were useful, but they arn't and actually the patches are simpler so we switched over relativly recently11:20
apwif i have the build branches i can convert an old result, as i have for this one, but its not worth the effort unless someone whines11:21
tseliotapw: yes, I agree11:22
rsalvetiapw: cooloney: ogra_ac: I have a beagle-xm and can test if everything works fine11:54
rsalvetibut it should, as it's already being used by linaro's image11:54
ogra_acrsalveti, that would be helpful11:54
cooloneyrsalveti: great, man11:54
ogra_acwe need to know if jasper behaves etc11:54
rsalvetiif they are merging the ubuntu sauce on top of the tree, it should work basically the way we're expecting 11:54
ogra_acthats a part that cooloney cant test with rootstock images11:54
cooloneyrsalveti: yeah i think so.11:54
rsalveticooloney: did you change the config or used the default one?11:55
cooloneyrsalveti: it contains all the ubuntu delta sauce patches11:55
cooloneyrsalveti: i didn't change any code in there tree.11:55
cooloneyrsalveti: it just works11:55
rsalvetiogra_ac: we can easily test with jasper at the moment we have any image around11:55
rsalvetithen we can just replace the important pieces and we're ok11:55
cooloneyrsalveti: you can build it from their source code.11:55
rsalveticooloney: cool11:55
rsalveticooloney: sure11:56
ogra_acrsalveti, there are images from the 19th11:56
rsalveticooloney: would be good to compare the config options with our omap3 debs11:56
ogra_acfor jasper testing that should suffice11:56
ogra_ac(i think X wont start on these though)11:56
rsalvetiogra_ac: cool, if nothing that important changed since then, I think we're ok11:56
rsalvetiok, np11:57
cooloneyrsalveti: yeah, will do it soon. 11:57
rsalvetibut it should work basically the same way, don't expect much of new features, but new bugs could be around :-)11:57
rsalvetithey merged most of our omap specific patches and ubuntu sauce11:57
rsalvetiogra_ac: and for now let's just produce beagle compatible images, should be enough for most omap 3 boards around11:59
rsalvetibeagle and beagle xm should work with same kernel and boot loader11:59
rsalvetithen for igep we just build instructions, should be fine11:59
ogra_acyes12:00
ogra_acthats what i said above12:00
ogra_acwith beagle being the QAed and officially supported platform 12:00
rsalvetiyeah12:02
ogra_acwhat we need to make sure is that john doesnt cut down the config 12:03
ogra_ac(i know he planned to)12:03
rsalvetiotherwise we need our own config12:04
ogra_aci.e. we want all usb dvb drivers, all usb wlan drivers etc etc12:04
ogra_aceverything you could potentially plug in12:04
DabianDarn, channel is logged?  Where is my privacy? :P12:13
DabianOK .. joke aside ...12:14
DabianI'm on Ubuntu GNU/Linux.  Today my updatemanager tells me to upgrade kernel for security reasons. CVE-2010-3848,  CVE-2010-3849 and  CVE-2010-3850 ... but these are only proposed .. and secret (reserved) .. anyone know about those?12:15
ubot2Dabian: ** RESERVED ** This candidate has been reserved by an organization or individual that will use it when announcing a new security problem.  When the candidate has been publicized, the details for this candidate will be provided. (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-3848)12:15
ubot2Dabian: ** RESERVED ** This candidate has been reserved by an organization or individual that will use it when announcing a new security problem.  When the candidate has been publicized, the details for this candidate will be provided. (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-3849)12:15
ubot2Dabian: ** RESERVED ** This candidate has been reserved by an organization or individual that will use it when announcing a new security problem.  When the candidate has been publicized, the details for this candidate will be provided. (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-3850)12:15
Dabianubot2: Thats what I am say'in, d'oh!12:15
ubot2Dabian: Error: I am only a bot, please don't think I'm intelligent :)12:15
DabianI dont, lol. :)12:15
macobetter patched than vulnerable?12:16
Dabianmaco: Question is .. vunerable to what?12:16
DabianUsually I like to know what kinda patches I'm installing. :)12:16
macoyou could view the source12:16
macoget the current and previous source packages off of launchpad and diff them12:17
DabianCan I apt-source a vunerable package?12:17
macoor look at the git trees on kernel.ubuntu.com12:17
macoapt-get source package=version12:17
Dabianthe latter looks more convenient, I guess git trees have diff?12:17
macoyep12:18
Dabianmaco: Do you know where I find the main branch?12:20
macothe one thats named ubuntu.maverick or ubuntu.lucid (whatever you're on) would be it12:20
Dabianmaverick is the perfect ten, right?12:20
macowith no developers' names attached12:21
macoyeah12:21
DabianThere is no developer named "ubuntu"?12:22
macohttp://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=summary12:22
Dabianright just found it12:22
DabianLeann is also mentioned as the last comitter.12:22
Dabianhmm .. bad Leann .. using goto :P12:23
Dabian:D12:24
DabianHmm .. I dont understand why he doesn't make the check earlier in the code?12:25
macohe who what?12:26
DabianLeann .. when he patch this.12:26
DabianHe might have a good reason, I'm not expirienced kernel developer.12:26
macoer..."leann" is a woman's name12:26
DabianIn russia?12:27
macono, she's not russian12:27
DabianOH ..  cool, we have female kernel-devs now? B)12:27
macoyeah...theyve existed for a long while...12:27
DabianCool12:28
macoim a lady with a patch in the kernel too :P12:28
DabianNeat :)12:28
DabianAhh .. Mackenzie :)12:28
DabianI think I recognice your name from Ubuntu-Women? :)12:29
macoyes12:29
macoi imagine she checks it there in order to keep the check near the reason its needed... ie, the fact that saddr is about to show up on the right side of an =12:29
DabianIts been a while since I have been active there.  (As if I were ever active there, but I used to follow the mailing-list some)12:29
Dabianmaco: Yeah .. the code seems a bit bit complicated though .. I think I'll copy it to emacs to get a better view.12:30
Dabianmaco: Funni thing is ... there is already a check in the code for saddr.12:34
DabianOh .. now I get it .. its legal to call this with saddr that is NULL. 12:34
DabianThats probably why she doesn't check earlier.12:36
macothe other time in that struct that saddr shows up to the right of a = is inside a if (saddr == NULL) {} else {  /* right here */ } -- so that one is checked12:39
macos/struct/function/ cant read12:39
macohm though line 506...12:41
Dabianyeah12:42
macoogasawara: when you're around, is there a possibility of a null-pointer dereference down at line 506 on [ubuntu/ubuntu-maverick.git] / net / econet / af_econet.c like the one you fixed up above it?12:43
=== jjohansen is now known as jj-afk
Dabianmaco: I fear you might be right, if CONFIG_ECONET_NATIVE is not defined, then Leanns check is never passed.12:48
Dabianmaco: (Otherwise we return in line 414)12:50
macoher check takes place inside an if() anyway12:50
DabianYeah .. if the that if is false, then CONFIG_ECONET_NATIVE wont be defined.12:50
DabianI am babling.12:51
apwCONFIG_* comes from outside12:51
DabianIts the if that is deciding, you're right.12:51
macohmm? the define takes place elsewhere12:51
DabianBut if the if is false, her check is skipped.12:51
macoim referring to this:    if (dev->type == ARPHRD_ECONET)12:51
Dabianmaco: Exactly .. thats the culpit. :)12:51
macothe null pointer dereference she catches is inside that if. there's another case of that pointer being used after the if ends. thats teh one im worried about12:52
Dabianmaco: just before the #if.12:52
Dabian(Which is not significant here)12:52
Dabianmaco: Right.12:52
macoi dont know where youre looking now...12:52
Dabianmaco: I just confused both of us, I agree with you. :)12:52
macohah ok12:53
macoapw: down at line 506...is that one ok?12:53
macoapw: or were you just interjecting about the macros without looking at what we are?12:53
Dabianmaco: He was just pointing out that I was babbling, I think. :)12:54
Dabianze :)12:54
macoyou got it right this time12:54
Dabianlol12:54
apwDabian's statement was that the CONFIG_ would change based on an if, which doesn't sound right, not looked at the code no12:54
DabianI have no idea what ARPHRD is. :)12:55
macoapw: oh ok. i think Dabian just mixed up #ifdef and #define12:55
Dabianapw: You're right.  I confused the #if with the "if".12:55
macoah12:55
DabianWell, actualy I assumed that both if and #if would act the same, which is even worse, lol.12:56
DabianIf the #if is false12:59
Dabianahh never mind.13:00
Dabianmaco: I think you found a problem, unless we know that if saddr == NULL then udpsock == NULL.13:02
macoDabian: the line im pointing to is not inside an if statement at all13:02
Dabianmaco .. no13:03
Dabianmaco but look at line 42013:03
Dabianmaco: I assume that line has to be passed before you reach line 50613:03
macoah because it returns13:03
Dabian:)13:03
DabianBut I am not sure we know that udpsock is NULL, if saddr is NULL.13:04
DabianI'm not a kernel developer.13:04
DabianI just find it interesting to look at the code sometimes. :)13:05
Dabianmaco: In any case, I would probably do something like:13:08
Dabian        eb = (struct ec_cb *)&skb->cb;13:08
Dabianif(saddr == NULL)13:08
Dabian  kernel_panick("Line 506, af_econet - saddr == NULL");13:08
Dabian 13:08
Dabianbefore "eb->cookie = saddr->cookie;", just to be sure.13:08
Dabian(Not sure of the syntax for kernel_panic).13:08
Dabianmaco: To me it looks like udpsock comes from outside the function, so I am guessing you found a real problem.13:14
Dabiansaddr, on the other hand, comes from "msg->msg_name" which is passed as argument to the function, in line 266.13:16
apwsconklin, you might want to review this above conv as it may indicate a further issue with one of our CVEs13:26
Dabianapw: Nice that ARM is better secured than other platforms for once though, right? :)13:28
smbapw, ogasawara was driving those. But yes, all of those did touch econet13:28
smbBut no arm release was done13:28
apwDabian, heh yeah by mostly being unbootable on any actual h/w :)13:28
Dabianlol13:28
smbDabian, The whole conversation is too big to quickly read. Is what you see on arm or something else?13:29
Dabiansmb: It was maco that pointed out that line ... (lemme check) might lead to null-pointer problem.13:30
macosmb: line 506 on http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=blob;f=net/econet/af_econet.c;h=174c106ec95ac04a0c46a3cf8cf5d499bdfe390a;hb=00a70d00666bbe8e7035f582ac5674827e35187013:30
DabianThanks :)13:30
macosmb: further up at 357 ogasawara checked for null before dereferencing that saddr pointer. at 506 it's dereferenced again without a null check. the first null check took place inside an if though, so may not have been run when 506 is reached13:31
Dabian(And 506 is apparently reached, unless udpsock is NULL).13:32
smbmaco, Sounds about right. I just need a minute to grab the changes to have the whole picture13:32
Dabian(udpsock seems to be external)13:32
smbI was just wondering about the arm statement13:33
macosmb: i think Dabian is watching -meeting13:33
macoand my brain refuses to keep the two smb's straight -_-13:33
smbThere is only one on my side. :)13:33
Dabiansmb: The first check, which is committed, only concerns platforms with ARM hardware, I guses, according to the "#IF".13:34
DabianWhat is -meeting?13:34
macodifferent channel13:34
macoDabian: can you use line numbers?13:34
smbDabian, Ah, well arm was those topic branches not released (at least for Lucid, but there is Maverick with at least one arm inside the master)13:34
DabianSure.13:35
=== doko_ is now known as doko
Dabiansmb: But the problem maco points out, applies to all platforms, as far as I can tell.13:35
macothere are 3 places saddr is used. 315, 362, 50613:35
macowhat makes you think any of them are arm-specific?13:36
Dabianmaco: Lemme find the line number.  I might be wrong though. :)13:36
Dabianline 341: #ifdef CONFIG_ECONET_NATIVE13:37
Dabian 13:37
DabianI think only ARM has native econet?13:37
macooh. no idea about that13:37
DabianI am just guessing.13:37
Dabianmaco: Line 506 is outside that "if" though.13:38
Dabian(#if, even)13:38
macoyes13:38
DabianSo while Leanns fix maybe applies to ARM only, yours is general.13:39
DabianIts inside the line 417: #ifdef CONFIG_ECONET_AUNUDP13:39
Dabian 13:39
smbActually I do not really see that line which does not check for NULL getting added. Rather seemed to be there before13:41
Dabiansmb: 50613:41
smbBut its a bit hard from the patch and a function that stretches on for miles13:41
macosmb: yes it was thre before. she added a check for near line 357, and im worried that she should also have added one to 0613:41
maco*50613:41
Dabiansmb: Yeah .. the code is pretty long, I wonder if the function could be refactored.13:42
smbmaco, Maybe. I am not that good to understand the flow that quickly. :)13:43
smbGive me a minute13:43
apwDabian, not for a backported fix, minimum changes only13:44
Dabiansmb: Its actually not as hard as you think.  The problem is if the "if" at line 339 is false (dev->type != ARPHRD_ECONET), then code-flow skips Leanns check in line 358, and if udpsock != NULL (checked in line 420), the code will hit line 506, with a possible null-value in saddr.13:45
Dabian(Assuming the "#ifdef"'s allow it).13:46
macoits just a single C function thats got as many lines as my senior project did of python :P13:46
Dabianapw: Right .. but maybe an idea for development branch. :)13:48
smbSo ok, yes, for that other case /#ifdef it seems missing13:48
smbBut has so before13:49
Dabiansmb: Which doesn't make it right, though. :)13:49
smbNope13:49
smbThe question is just whether it is in the class of security oh my god13:49
DabianI think maco found a new problem, of same natuer.13:49
smbor just "normal" it crashes13:49
macosmb: from leann's commit message on her change it seems like a normal-it-crashes with unknown security implications13:50
smbmaco, The thing is that all three were passed down as a bundle of sorts13:50
Dabian3 cve's though?13:51
smbmaco, You found a true other case of brokeness. I just would avoid a security update for it if possible13:51
macook13:51
smbWhich would be required if we broke something new13:51
macoso how to handle discovery of brokenness?13:52
Dabiansmb: When crashing and network is involved .. I'd say we're close to a security issue.  Question is if its remotely exploidable, I guses?13:52
smbDabian, Right. I would not be sure at the moment. 13:52
smbOn the other hand that econet protocol is not loaded by default and I don't know the use of it either.13:53
smbmaco, I'd probably go and contact the original author about it13:53
Dabiansmb: Then again, i guess even if its only locally exploitable, it will still be security issue, unless you need priviledges to call the function.13:54
smbErr13:54
smbWhich was in this case Leann. 13:54
macoheh13:54
smbGuess she sent that somewhere. So maybe we ask her where13:55
=== yofel_ is now known as yofel
sconklinmaco, smb: Just wandering in . . . econet is essentially unmaintained, so these patches were arrived at through a group effort14:01
smbmaco, sconklin Ijust checked Linus upstream.14:01
smbSeems that what went there is different and exists early14:02
smbInstead of checking for NULL multiple times14:02
DabianHeh .. that was my original idea, to exit early.14:04
DabianBut I don't know what the code actually does.14:04
DabianIt seems like its possible to do "something" useful, even if saddr is NULL, but I am not sure what.14:05
Dabiansmb: I guess that explains why the code missed the check later in the code.14:06
macoi was guessing it was more to do with the spaghetti...14:06
smbDabian, I think (but I cannot say for sure) that we may have a patch that evolved later before hitting upstream14:06
Dabian"a patch that evolved later, before hitting upstream"? (Im not native english, what does this mean?)14:08
smbDabian, It means it changed14:09
smbAnd in Linus tree there is a different change that we have now14:09
Dabiansmb: As in .. you made a patch, but changed it before shipping it upstream?14:09
smbAs in we got the patch from someone (at least the other two) and maybe found the issue and told it the other person and on the way to upstream it changed even more but nobody told us14:10
smbWe just now see it in Linus tree14:10
DabianAhh ok ... so .. you got Linus.A code .. patched it to Linus.Ap1 .. sending it upstream, when Linus.B code is available, the changes dosen't match the Linus.Ap1 code.14:11
DabianHmm .. I guess this means we have to check the Linus.B code, to see if it checks correctly?14:12
Dabianand if it does, then eventually adopt it?14:12
smbAs far as I see it is safer as it does the check right at the beginning of the function and immediately returns with an error if saddr is NULL14:13
smbSo mostly it is checking whether the other two patches are the same as we got or different/better and replace the changes made in our tree whenever needed14:14
Dabiansmb: Thats safe.  However, if something useful can be done, even if saddr is NULL, maybe Leanns patch is supior (with a check added for line 506)14:14
smbDabian, Maybe, though that sounds like something to discuss with those upstream people working with that as an additional patch. This one mainly targets to prevent an oops14:17
Dabiansmb: Right. I guess the code is viewable on http://kernel.org ?14:20
smbDabian, Yes. I saw it in the git tree14:21
DabianYou don't happen to have the url handy?14:21
DabianIs the change in linux-next, mainline, snapshot or stable?14:22
smbDabian, I mainline. But as I use git I forget the url. A second14:23
Dabianaah ok.14:23
smbhttp://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git14:24
smbhttp://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fa0e846494792e722d817b9d3d625a4ef4896c9614:24
smbDabian, the second link is the actual commit for that14:25
Dabiansmb: Right, they just exit if saddr is null, or msg->msg_namelen is short.  if msg or msg->namelen is NULL, they still have a problem though.  Not sure if thats possible. 14:31
DabianI also wonder why they set the mutex before the check.14:31
DabianWhy not change line 291 to:14:32
apwjdstrand, hiya14:33
Dabianif (msg->msg_flags & ~(MSG_DONTWAIT|MSG_CMSG_COMPAT)) || (saddr == NULL || msg->msg_namelen < sizeof(struct sockaddr_ec))14:33
Dabianthat way they can skip line 300-30314:33
apwthey have likely gone for clarity over performance, as this is a dead protocol anyhow14:34
smbDabian, Just personal feeling but this does look a bit like more spagetti14:34
Dabianchange line 288 to: *      Check the flags and verify address.14:34
jdstrandhey apw14:34
apwwas it you who was asking me something something last night?14:34
Dabiansmb: Well, you could add a line after 292, with a nice comment, and another if. That would look ugly to me, but personal taste differs, and it would be equally good. In both cases, you don't have to lock the mutex.14:35
DabianThere might be a reason they lock the mutex first though, but I can't guess what it might be.14:36
Dabiansmb: At any rate, this GNU patch solves the problem maco spottet.14:37
smbI guess the mutex is held for being able to make the changes on success. But right, it will fix that problem. And i am probably lazy there but I'd leave improvements to people actually using that protocol. :-P14:39
apwjdstrand, was it you who was asking me something something last night?14:44
jdstrandapw: I did. hold on...14:44
DabianI have no idea what the protocol is used for. :)14:45
jdstrand13:52 < jdstrand> apw: hi! I'm looking at bug #507148, but you gave maverick kernels for a bug in lucid14:45
ubot2Launchpad bug 507148 in xserver-xorg-video-ati (Ubuntu Lucid) (and 4 other projects) "[lucid] desktop runs out of video memory on ATI Radeon Mobility 7500 (affects: 8) (heat: 46)" [High,Invalid] https://launchpad.net/bugs/50714814:45
jdstrand13:53 < jdstrand> apw: in other words, mdeslaur and I reported the problem back in the lucid cycle, and I followed up on it a lot and it was fixed in lucid. was the regression on lucid or maverick?14:45
jdstrand13:57 < jdstrand> apw: based on http://bugs.freedesktop.org/show_bug.cgi?id=26302#c27, it looks like a problem on the lucid kernel. would you mind making lucid kernels available for testing?14:45
jdstrand14:03 < jdstrand> apw: acutally, it seems both lucid and maverick, but a lucid kernel would be most appreciated, and I could confirm whether or not reverting/going with upstream causes a regression on lucid release14:45
ubot2Freedesktop bug 26302 in Driver/Radeon "[M7 LW] desktop runs out of video memory on ATI Radeon Mobility 7500" [Major,Resolved: fixed]14:45
apwjdstrand, ok the issue is that the fix as applied has been identified to cause a separate regression and therefore is bad.  in theory there is a 'proper' fix to your issue which should fix you and not introduce this additional regression...14:47
apwjdstrand, ahh so you want a lucid kernel.  i'll see about that14:47
* jdstrand nods14:47
jdstrandapw: I care most about not regressing the fix for my wife's laptop, and she runs lucid ;)14:48
apwjdstrand, i care about finding out if the replacement fix works for you too :)14:49
jdstrandapw: it would be most great if it was on the latest lucid-security kernel that went out yesterday14:49
apwas it happens i am building lucid ones for that, so i'll get you a link once they appear14:49
jdstrandapw: great, thanks14:49
apwthe utter slowness of launchpad is a major detrement to the ammount of work i can get done, sigh14:56
JFoyep14:59
cking+114:59
sconklinapw: I've thought about a browser plugin that will accumulate the time I spend waiting for launchpad page loads14:59
apwi would be made very depressed by the results15:00
JFooh please no15:00
ckingsconklin, charge it to the LP team ;-)15:00
JFothat would end up making me a part-time employee ;-P15:00
JFoespecially on Tuesday when I am gathering metrics for the meeting15:01
apwJFo, didn't you already do this: tag bugs 605614, 608429, 612626 and other similar bugs and monitor for new15:01
ubot2Launchpad bug 605614 in linux (Ubuntu Maverick) (and 3 other projects) "[ATI] GPU lockup with gfxpayload=keep (affects: 10) (heat: 50)" [Undecided,Won't fix] https://launchpad.net/bugs/60561415:01
ubot2Launchpad bug 608429 in linux (Ubuntu) (and 1 other project) "black screen after grub menu (affects: 3) (heat: 32)" [Undecided,Incomplete] https://launchpad.net/bugs/60842915:01
ubot2Launchpad bug 612626 in linux (Ubuntu) (and 1 other project) "start in low graphic mode for nvidia card (affects: 1) (heat: 30)" [Undecided,Incomplete] https://launchpad.net/bugs/61262615:01
apwyeah thanks ubot215:01
JFoheh15:01
JFoapw, I think those were the ones we needed to decide on a tag for15:02
JFoso I have not tagged them as yet15:02
JFoand I need to write something that will help me find any more 15:02
JFoor any new ones15:02
apwas i am calling the bug list you are making the 'key bugs' list, how about kernel-key-gfxpayload15:03
JFothink that gfxpayload=keep was the search term used15:03
apwand kernel-key for our purposes15:03
JFoworks for me15:03
JFoso kernel-key are the bugs on our list?15:03
JFoor just these bugs?15:03
apwi was thinking kernel-key was our equivalent of pcert as an input to the lsit15:04
JFoand we are eliminating the kernel-needs-review, kernel-candidate and kernel-reviewed tags?15:04
JFook15:04
apwJFo, i suspect we will but i have not though about those at all in this context15:04
JFosince we are no longer doing the top 5015:04
JFook15:04
* apw notes that your list is now updating regularly ... goood stuf15:05
JFo:)15:07
JFocron FTW!15:08
=== bjf[afk] is now known as bjf
JFotgardner, any thoughts on bug 676245 ?15:51
ubot2Launchpad bug 676245 in linux (Ubuntu) "Broadcom NetXtreme II BCM5709 -- no network found on ISO install (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/67624515:51
JFothe qa guys tell me that it worked on this box in the past15:51
JFothis is for Alpha 1 testing15:51
tgardnerJFo, looking...15:52
JFosorry, found during rather15:52
JFothank you sir15:52
apwjdstrand, ok test kernels are in the bug15:52
JFoapw, any more thoughts on bug 670181 ?15:52
ubot2Launchpad bug 670181 in linux (Ubuntu) "Dell Precision M6300 SD Card Reader (Ricoh R5C592 memory stick) Will Not Mount After Upgrade To 10.10 (affects: 2) (heat: 12)" [Medium,Triaged] https://launchpad.net/bugs/67018115:52
JFolooks like the guy isn't even using an XD card15:53
* JFo grows old waiting for LP to churn16:01
=== jj-afk is now known as jjohansen
bjf##16:09
bjf## Ubuntu Kernel Team Meeting - Today @ 17:00 UTC - #ubuntu-meeting16:09
bjf##      agenda: https://wiki.ubuntu.com/KernelTeam/Meeting16:09
bjf##16:09
=== diwic is now known as diwic_afk
=== amitk is now known as amitk-afk
jdstrandapw: thanks16:14
smoserjjohansen, ping here.16:30
smoserpv-on-hvm :-(16:30
jjohansenyeah16:30
jjohansenso if things verify out, it would be no pv-on-hvm in -virtual kernel16:30
smoseryou think that is not a solvable problem ?16:32
smoserbecause that would basically force us to have separate cluster compute images (as they'll require pv-on-hvm)16:32
smosercan we pv-on-hvm as a module ? or is that not possible ?16:33
jjohansenit is already a module16:33
bjf##16:38
bjf## Kernel team meeting in 20 minutes16:38
bjf##16:38
smoserjjohansen, it is ?16:42
smoseri swear i saw 'Y' yesterday16:42
smosergrep HVM /mnt/boot/config-2.6.37-5-virtual 16:43
smoserCONFIG_XEN_PVHVM=y16:43
smoseror is that really just an option to something else that is a module (i only looked at the config)16:43
JFosconklin, great find on that article16:55
sconklinI imagine that it made some people frown16:56
JFoI imagine so16:56
apwo/17:00
apwheh missed17:00
sconklinhttp://www.techeye.net/software/nokias-meego-is-doomed17:04
sconklinapw: ^^17:04
apwsconklin, tgardner, smb, summary in your inbox17:09
smbapw so it is17:09
JFo<-lunch17:33
apwsconklin, tgardner i have realised that when you hard push a branch it reports atomically where it was before in the return17:33
apwso you can tell if you could have lost anything when you push ... obvious17:34
ogasawarabjf, sconklin: have either of you started rebasing the master-next branches yet?  just want to make sure I don't duplicate effort here.17:35
apwsconklin, another good reason for a master-merging or something, a marker that you are doing the rebase17:35
bjfogasawara, i've done a first pass on maverick, we are still discussing17:36
sconklinapw: that may not be obvious or visible to people, since they may push without realizing that a new branch has been added17:36
bjfapw, i'm not sure what you are suggesting at this point17:37
ogasawarabjf: ack, I'll wait till you guys give me the green light.17:37
albatrosi just wanted to report that bug 676644 has been fixed indeed, have been running tests for about 20 hours now without any errors18:03
ubot2Launchpad bug 676644 in linux (Ubuntu Maverick) (and 1 other project) "sata-via: read errors, slowdowns with VIA VT6420 (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/67664418:03
albatroswhereas previously these tests resulted in thousands of errors18:04
albatrosI just wondered if a fix for that issue in Maverick would be issued for lucid as well18:04
apwalbatros, indeed i have marked it released for natty18:09
apwalbatros, i was going to propose it for maverick, not sure about lucid18:09
apwalbatros, i have not tried to backport that far18:09
albatrosOK, not critical to me t all, thank you for working to fix things so quickly.18:11
albatrosI'll just switch to maverick then.18:12
albatrosbb18:13
apwjjohansen, hello18:15
jjohansenhey18:15
apwjjohansen, this i386 not working thing that might be the pvops on hvm thing18:15
jjohansenright18:15
apwjjohansen, seem this is a blocker for server18:15
apwjjohansen, have we confirmed this option is the issue ?18:16
tgardnerapw, jjohansen is OTP18:16
jjohansenapw: no, I was testing last night, and I need to verify today18:16
jjohansenI had one of my tests fail18:16
jjohansenbut I think that was my mistake18:16
apwjjohansen, ok ... we need to make a call in the next hour ish whether to turn it off, as its blocking server for alpha118:18
apwso talk to me when you are done with the phone18:19
jjohansenapw: I already talked to smoser about that, the answer is no18:20
jjohansenleave it for alpha 118:21
apwjjohansen, so they are happy with the status quo ... i'll feed that back18:21
jjohansenapw: I wouldn't say happy, but smoser doesn't want pv-on-hvm disabled either18:21
apwjjohansen, yep got you ...18:22
apwjjohansen, and thanks18:22
smoserapw, well, i'm not happy that i386 and t1.micro do not work18:23
smoserbut turning off pv-on-hvm is not something i'm going to suggest should happen as it will cause other fallout that i dont want to deal with.18:24
apwsmoser, a bit of a mess and no mistake18:24
jjohansenapw: the hope is that either my testing was bad, or we can work around it18:24
smoserwell, i dont thin its likely that the honorable jjohansen has bad testing, so i'm crossing fingers for work around18:25
smbAt least proving that this is the cause gives a better hint to where to search as the "no messages" before18:25
smoserand alpha2 having cluster-compute instances (which require hvm) and t1.micro and i386 all from the same -virtual kernel18:25
apwjjohansen, ok if we need to make any kernrel changes for alpha-1 it needs to be 'now' as we are already in freeze18:27
jjohansenapw: yeah, no requests from me, we will get it fixed for alpha218:28
alex88after committing a change to natty kernel on http://kernel.ubuntu.com/git how much time it would be in the natty daily build?18:29
apwalex88, normally withing 24 hours in the pre-proposed builds, a few days in the main archive18:35
alex88apw, you've commited that change that i need :) the marvell driver.. btw, pre-proposed builds means those here: http://cdimage.ubuntu.com/daily-live/current/ ?18:41
alex88sorry for asking..can you please reply? I have to go in ten minutes..18:48
apwalex88, no i mean the ones in the pre-proposed PPA18:53
apwwe won't be putting that particular fix into a kernel on a CD until after alpha-118:54
alex88oh, and what about  the natty daily? i've tried to change the kernel into the live cd to let me install but i'm having problems with casper18:54
apwalex88, its not easy indeed.  the natty daily CDs won't change until after the alpha releases now18:54
alex88ok thank you very much..18:55
* tgardner --> lunch19:03
bjfapw, what was that wiki formatting bug that you filed? (the bullet items were all the same level)19:09
apwbjf, hrm19:11
apwhttps://bugs.launchpad.net/ubuntu-website/+bug/67561119:18
ubot2Launchpad bug 675611 in ubuntu-website "with new ubuntu theme all bullet items are rendered off the left of the pane and at the same indent regardless of list indent (affects: 2) (heat: 17)" [Undecided,Fix released]19:18
apwbjf ^^19:18
bjfapw, thanks19:18
=== diwic_afk is now known as diwic
* jjohansen -> lunch19:59
tgardnerapw, re: bug #681727, have you actually pushed patches to the list?20:07
ubot2Launchpad bug 681727 in linux-meta (Ubuntu) "linux-backports-modules-wireless-maverick-generic not available for kernel 2.6.35-23 (affects: 2) (heat: 12)" [High,In progress] https://launchpad.net/bugs/68172720:07
apwtgardner, in theory at least20:09
tgardnerapw, hmm, I can't remember them20:09
tgardnernothing in patchworks either20:09
apwi can't see them in my outbox either ... let me check20:09
apwtgardner, i've pushed send again ... got t20:10
apwgot them now ?20:10
hallyn_does anyone here know offhand whether aufs tries to mark fields with a particular poison (i.e. maybe 66010101)?20:10
apwhallyn_, is that not 'list poison' ?20:10
apwtgardner, too many interruptions it seems20:11
tgardnerapw, yeah, they are trickling in now20:12
tgardnerat least [0/2] so dar20:12
tgardnerfar*20:12
apwtgardner, dunno if i did it wrong or just didn't get to the actual pressing return ... perhaps it was when i clicked an lost my screen the first time20:12
tgardnerapw, np, I was just noticing some noise on the wireless mailing list about this bug20:13
apwhallyn_, not list poison then ... /me lets grep search for him20:13
apwtgardner, thanks for the kick up the ass20:13
* apw needs to be more methodical20:13
tgardnerapw, I think your second patch is wrong, you're futzing with alsa:20:18
tgardner-Depends: ${misc:Depends}, linux-backports-modules-alsa-${kernel-abi-version}-generic-pae20:18
tgardner+Depends: ${misc:Depends}, linux-backports-modules-compat-wireless-2.6.36-RELEASE_NAME-generic-pae (= ${binary:Version})20:18
apwtgardner, crap20:18
* apw goes fix it20:18
apwthat happened cause i had to redo it following finger trouble20:18
JFoogasawara, got a sec?20:19
JFoif not that is cool20:19
jdstrandapw: fyi, followed on bug #50714820:19
ubot2Launchpad bug 507148 in xserver-xorg-video-ati (Ubuntu Lucid) (and 4 other projects) "[lucid] desktop runs out of video memory on ATI Radeon Mobility 7500 (affects: 8) (heat: 46)" [High,Invalid] https://launchpad.net/bugs/50714820:19
jdstranderr20:19
jdstrandI followed up on that bug20:19
ogasawaraJFo: sure, just gimme 5min to finish up a rebase20:19
JFok20:19
hallyn_apw: that's the thing, i've grepped for it with no luck, which seems weird :)  but ok, thanks, will keep looking20:20
apwtgardner, V2 in the pipe ...20:23
tgardnerapw, ack20:24
robbiewapw: regarding https://bugs.launchpad.net/ubuntu/+source/linux/+bug/669496, is it blocking the use of the i386 ISOs or just all the i386 ec2 instances20:31
ubot2Launchpad bug 669496 in linux (Ubuntu Natty) (and 1 other project) "natty fails ec2 boot on i386 or t1.micro (affects: 1) (heat: 12)" [Critical,Confirmed]20:31
robbiewfrom the title and the bug comments, I was assuming just ec220:32
apwi believe the latter, jjohansen ^^20:32
jjohansenlater just i386 instances on ec2, not uec20:33
robbiewjjohansen: thnx20:33
robbiewskaet_: ^^^^^ ;)20:33
skaet_robbiew, jjohansen,  ack.  :)20:34
* robbiew returns Server threat level to Defcon 120:35
* maco tries to remember whether defcon levels go up or down20:35
ohsixcan anyone explain the physical sector size discrepancy here: http://paste.ubuntu.com/538409/ ?20:36
ogasawaraJFo: sorry, taking longer than I expected and have to run to my dr apt.  can I ping ya when I get back in an hour or so?20:39
JFoogasawara, after thinking a bit more, I'll likely send you an e-mail for you to look at when it is convenient :)20:42
JFois that cool?20:43
ogasawaraJFo: cool, works for me20:43
JFogood deal20:43
* ogasawara back in a bit20:44
=== _LibertyZero_ is now known as LibertyZero
bdmurrayapw: bug 511747 looks fixed to me is that right?21:10
ubot2Launchpad bug 511747 in xf86-input-evtouch (Ubuntu Lucid) (and 3 other projects) "support for Acer 1420P (affects: 6) (heat: 40)" [Medium,Triaged] https://launchpad.net/bugs/51174721:10
jasonlifeI'm trying to upload my patched kernel to my ppa, and it seems uploading kernel to ppa is different than normal packages..  After I changed changelog and ran debuild -S -sa, I noticed .dsc and .diff.gz doesn't have the suffix I used during changelog update..  Anyone has an idea about uploading custom kernel to ppa?21:14
tgardnerskaet_, bug #676245 won't make it into A1 unless we re-upload the kernel.21:26
ubot2Launchpad bug 676245 in linux (Ubuntu Natty) (and 1 other project) "Broadcom NetXtreme II BCM5709 -- no network found on ISO install (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/67624521:26
apwbdmurray, yeah from the testing responces there it is fixed for linux (Ubuntu)21:28
apwbdmurray, do feel free to make it Fix Released21:28
bdmurrayapw: and the evtouch parts?21:29
apwbdmurray, that would have to be referred to cnd21:29
skaet_tgardner, anything else in the kernel along with it?21:29
skaet_s/it/bug 676245 fix/21:30
tgardnerskaet_, well, the rebase to -rc421:30
ubot2Launchpad bug 676245 in linux (Ubuntu Natty) (and 1 other project) "Broadcom NetXtreme II BCM5709 -- no network found on ISO install (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/67624521:30
* apw looks at skaet_ 21:30
* skaet_ is thinking of what can go wrong vs. getting it fixed...21:31
tgardnerskaet_, I've smoke tested -rc4 on a server, but thats about it21:31
* apw hasn't even boot tested it yet21:31
cndbdmurray, the Ubuntu utouch stack will not use xf86-input-evtouch21:32
cndI've never looked at it really21:32
cndso I don't have any more information for you21:32
tgardnerskaet_, the difference between whats in the archive and the next upload is _only_ a couple hundred patches.21:33
* apw wonders why bnx2 is so important21:34
tgardnerdell servers21:34
cndbdmurray, on a cursory glance, I think the bug should be marked as invalid for evtouch21:34
cndit's really an issue that has been fixed in the kernel21:34
apwtgardner, and why indeed do the damn names of the files change every week; this must be the 3rd time this particular issue has appered21:34
skaet_tgartner, _only_, huh.  21:35
tgardnerapw, firmware file names seem to be fungib;e21:35
apwtgardner, are those ? in our module udeb thingy?21:35
tgardnerapw, nope, they are firmware file names need in the nic-modules d-i file.21:36
apwtgardner, supprised the build doesn't fail when they change name in that case21:36
tgardnerapw, the names were'nt there in the first place. I had to add them so tha the bnx2 driver could load its firmware21:37
tgardnerfrom a udeb21:37
tgardnerskaet_, glp v2.6.37-rc3..v2.6.37-rc4|wc -l21:37
tgardner39321:37
apwtgardner, hrm, didn't we have that issue in lucid too though, so am supprised they arn't there already21:37
skaet_tgardner, thnx.21:37
apwbut ... never mind, an issue for anohter time21:37
tgardnerapw, I dropped them in the early natty rebase 'cause upstream had build errors wherein they didn't convert the firmware files correctly21:38
apwtgardner, ahhh then it makes sense, /me forgets about it21:38
skaet_tgardner, any way the fix can just be applied to the kernel that's already uploaded?21:38
tgardnerapw, I should have filed a bug so I didn't forget about it (as I clearly did)21:38
tgardnerskaet_, for you we'll do anything :)21:39
apwtgardner, as everything is on master-next (right?) we could just slam master to the tag and cherry that one perhaps21:39
tgardnerapw, my thinking exactly21:39
apwtgardner, you or me ?21:39
tgardnerapw, you're EOD, right?21:39
apwtgardner, t'is pretty late yep21:40
tgardnerapw, I can take care of it. should only take a bit.21:40
apwtgardner, ok ... i suspect its not an abi bumper so it should be low impact, but drop me a note if there are any time delay things to do21:41
skaet_thanks tgardner, apw!  :)21:41
apwskaet_, don't expect it for 7 hours or so!21:41
tgardnerapw, skaet_: I'll get it uploaded in the next hour or so.21:41
apw(as it takes that long to build)21:41
skaet_:)21:42
* skaet_ looking forward to seeing when it shows up now... 21:42
skaet_please post in ubuntu-release when its ready ;)21:42
tgardnerskaet_, how about I post when its uploaded? I'll be in bed when its 'ready'21:43
skaet_heh.  fair nuf.  just want a record there so cjwatson knows what's going on, when I'm in bed.  ;)21:44
apwskaet_, i assume we are in freeze still, so it'll block on accept ?21:46
tgardnerapw, soft freeze still21:47
skaet_apw soft freeze for alphas21:47
apwahh ok21:47
skaet_it should get picked up by the autobuilder for tomorrows images if all goes well. 21:48
* tgardner is outta here23:13

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!