| === Amaranth_ is now known as Amaranth | ||
| === v is now known as stalcup | ||
| ebroder | Anybody want to provide a second opinion on bug #656503? I'm inclined to take the whole patch - the only thing that seems remotely superfluous is the removal of the trailing newlines, but I don't want to decide to do that unilaterally | 03:46 |
|---|---|---|
| ubottu | Launchpad bug 656503 in utouch-geis (Ubuntu) "event dispatch can hang under some circumstances" [Undecided,New] https://launchpad.net/bugs/656503 | 03:46 |
| ebroder | (http://launchpadlibrarian.net/59171925/utouch-geis.debdiff is the patch) | 03:46 |
| ebroder | Actually, now that I'm looking at it, I'm confused how that change to the while loop is..actually a change | 03:49 |
| RAOF | It looks like it calls xcb_poll_for_event once per loop rather than once, but that's just from looking at the patch; context may well change that. | 03:50 |
| ebroder | There's another call to xcb_poll_for_event at the bottom of the loop | 03:50 |
| ebroder | (The "@@ -763,15 +763,13 @@" hunk) | 03:51 |
| RAOF | Ah, yeah. There it is. | 03:52 |
| RAOF | Oh. | 03:52 |
| RAOF | If event->response_type != GenericEvent you've got an infinite loop. | 03:53 |
| RAOF | That change really is a change. | 03:53 |
| ebroder | Oh, I see | 03:53 |
| RAOF | Is the changing to explicit C linkage needed? | 03:54 |
| RAOF | I mean, the minimal patch is quite a lot smaller than that debdiff (which needs the changelog cleaning up, of course) | 03:54 |
| ebroder | I was on the fence about the C linkage. I feel like it's something I would be willing to fix in an SRU if someone asked for it - C vs. C++ linkage is well-understood, and it won't affect any runtimes | 03:55 |
| ebroder | (And anything in the archive that isn't broken currently has the extern "C" around the include, so it shouldn't affect rebuilding) | 03:56 |
| ebroder | But if somebody else tells me they don't think it's appropriate, I've got no poblems with that | 03:57 |
| ebroder | *problems, obviously | 03:58 |
| RAOF | Heh. | 03:58 |
| RAOF | I think those changes are sane, but I'm not a member of ubuntu-sru :) | 04:01 |
| ebroder | That's good enough for me. Lord knows I've SRU'd worse before, and we are talking about universe :-P | 04:02 |
| ebroder | Actually, thinking about it more, I would sponsor the C++ change if there was a bug, but I don't really want to without a bug | 04:07 |
| dholbach | good morning! | 07:12 |
| hrw | hi | 08:11 |
| === elky is now known as melissa | ||
| === melissa is now known as elky | ||
| === yofel_ is now known as yofel | ||
| === menesis1 is now known as menesis | ||
| === freeflyi1g is now known as freeflying | ||
| bcurtiswx | http://imagebin.ca/view/2ogKiw.html is a pic of a patch thats failing.. the line of the start of the patch matches the code and i can't see where the patch would go wrong. any suggestions ? | 15:10 |
| udienz | keluar dulu | 15:15 |
| geser | bcurtiswx: white-space? try "patch -l --dry-run" and your usual options | 15:18 |
| bcurtiswx | i've been using quilt geser, will that do the same thing? | 15:20 |
| geser | IIRC quilt doesn't use -l (and the --dry-run is only for testing) | 15:22 |
| geser | but if you know if it's the white-space or not, you can either refresh the whole patch or edit the patch and fixing the whitespace (depending on what is easier) | 15:23 |
| bcurtiswx | geser, OK thx | 15:25 |
| geser | as you seem to use vim, you can also use "set list listchars=tab:>-,trail:.,extends:>,precedes:<,nbsp:%" to make white-space visible | 15:28 |
| bcurtiswx | geser, will it highlight the whitespace ? | 15:33 |
| bcurtiswx | ah i c | 15:34 |
| bcurtiswx | nvm | 15:34 |
| === dholbach_ is now known as dholbach | ||
| achiang | bcurtiswx: the actual error message from patch would be helpful too. :) | 16:07 |
| bcurtiswx | achiang, i just got that the hunk failed. no specific error message | 16:11 |
| achiang | bcurtiswx: well, patch(1) takes a --verbose argument... why not try with that and pastebin the entire operation? | 16:12 |
| bcurtiswx | achiang, OK it'll be a bit. thx for the help so far :) | 16:13 |
| achiang | np | 16:13 |
| === Rh0nda is now known as Rhonda | ||
| === hrw is now known as hrw|gone | ||
| === menesis1 is now known as menesis | ||
| === apachelogger is now known as releaselogger | ||
| === releaselogger is now known as apachelogger | ||
| micahg | debfx: will you be working on the SRU for bug 680820? | 18:54 |
| ubottu | Launchpad bug 680820 in purple-plugin-pack (Ubuntu Maverick) "Missing IRC More plugin" [Low,Triaged] https://launchpad.net/bugs/680820 | 18:54 |
| === bilalakhtar_ is now known as bilalakhtar | ||
| MTecknology | How do I use reportbug to report a bug to bugs.debian.org? | 20:16 |
| MTecknology | I tried --bts=Debian and --bts=bugs.debian.org; but I get an error saying I need to use ubuntu-bug instead | 20:17 |
| ebroder | MTecknology: Did you read the message it spits out? Mine says to put "bts debian" in ~/.reportbugrc | 20:18 |
| ebroder | MTecknology: (Or pass -B debian) | 20:18 |
| MTecknology | ebroder: oops- thanks :) | 20:19 |
| debfx | micahg: yes, i'll upload it today | 20:30 |
| micahg | debfx: ok, thanks | 20:38 |
| highvoltage | /win 18 | 20:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!