| === wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant, wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jelmer | wgrant: those regular expressions for filenames are confusingly named, as they do more than just tell you whether the file is a source file :-/ | 08:01 |
|---|---|---|
| wgrant | jelmer: Yeah... I should probably have renamed them when I refactored all that stuff a year ago. | 08:20 |
| wgrant | Thanks for the review, anyway. | 08:20 |
| jelmer | wgrant: These would probably also be good candidates for migration to python-debian. | 08:23 |
| wgrant | jelmer: More than likely. | 08:23 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant, wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: wgrant || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | wgrant: Hi! | 10:38 |
| henninge | wgrant: what's the second review? | 10:38 |
| wgrant | henninge: Ah, jelmer already took care of it. | 10:38 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| wgrant | Forgot to take it off the queue, sorry. | 10:38 |
| henninge | wgrant: np. | 10:38 |
| wgrant | henninge: I was going to replace the doctests, but decided that it might be better in a different branch. You want it in this one? | 10:39 |
| henninge | wgrant: Well, instead of adding the corner cases to the doctest, yes, I'd like that. | 10:40 |
| wgrant | henninge: OK. Thanks. | 10:40 |
| henninge | It's not a big branch yet | 10:40 |
| wgrant | No, but I don't generally like mixing code refactors and test replacements. | 10:41 |
| bigjools | henninge: can I add this to your queue please: https://code.launchpad.net/~julian-edwards/launchpad/ppa-pockets-bug-684321/+merge/42824 | 11:02 |
| wgrant | bigjools: Yay. | 11:03 |
| bigjools | wgrant: should speed things up a little, but not as much as the components fix | 11:03 |
| wgrant | bigjools: Yeah. | 11:03 |
| wgrant | bigjools: Did the components fix make it into the release? | 11:03 |
| bigjools | wgrant: just wait for some b******s to ask for components+pockets in PPAs now! | 11:04 |
| wgrant | bigjools: I've done both in the past :P | 11:04 |
| wgrant | But then I asked for multiple PPAs per person, and that was granted, so I am happy now :) | 11:04 |
| bigjools | wgrant: I think it's missed the release :/ | 11:06 |
| bigjools | shoulda landed it on db-devel.... | 11:06 |
| wgrant | Hm? | 11:06 |
| wgrant | Don't we rollout from devel now? | 11:06 |
| * wgrant checks. | 11:07 | |
| bigjools | wgrant: yes but we pick a revno and release that | 11:07 |
| bigjools | stable, not devel | 11:07 |
| wgrant | Er, that, yeah. | 11:07 |
| wgrant | But the db-stable merge is the latest stable rev. | 11:07 |
| wgrant | So everything before that must be included. | 11:07 |
| * bigjools looks more | 11:08 | |
| bigjools | ah yes, so it will be in | 11:08 |
| wgrant | The removal of one or both flushes should make things significantly faster too. | 11:09 |
| wgrant | But I need to test that on DF next week :) | 11:09 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bigjools || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | bigjools: Hi! ;) | 11:13 |
| bigjools | wgrant: yes :) | 11:13 |
| bigjools | henninge: hi! | 11:13 |
| henninge | bigjools: reviewing now | 11:13 |
| bigjools | henninge: cherers | 11:14 |
| bigjools | cheers, too | 11:14 |
| henninge | bigjools: | 11:17 |
| henninge | 93+ # Cast to a list so we don't trip up with the security proxy not | 11:17 |
| henninge | 94+ # understandiung EnumItems | 11:17 |
| henninge | Is that a known bug? | 11:17 |
| bigjools | henninge: I don't know. It's easily fixed in lp_sitecustomize though | 11:19 |
| bigjools | depends on what the foundations chaps say | 11:19 |
| henninge | bigjools: So did you discover this? I am relly just asking if there is a bug for it ... ;) | 11:20 |
| bigjools | henninge: well I discovered it but like Australia, there's some debate over whether I was first or not | 11:21 |
| henninge | bigjools: ;-) | 11:22 |
| bigjools | henninge: if you look in lib/lp_sitecustomize.py you'll see the proxy is removed for a few objects | 11:23 |
| bigjools | Deferred being one that I previously added :) | 11:24 |
| bigjools | we could add EnumItems there too but I want to check with Gary first | 11:25 |
| henninge | yes, that's actually all I was going to ask you to do ... ;) (Talk to gary) | 11:26 |
| henninge | thanks | 11:26 |
| henninge | bigjools: r=me | 11:26 |
| bigjools | henninge: : thanks | 11:26 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === henninge_ changed the topic of #launchpad-reviews to: On call: - || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === henninge_ is now known as henninge | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: -/- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado-lunch is now known as salgado | ||
| === deryck[lunch] is now known as deryck | ||
| === mrevell_ is now known as mrevell | ||
| === benji is now known as benji-lunch | ||
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === benji-lunch is now known as benji | ||
| thumper | abentley: rc needed https://code.launchpad.net/~thumper/launchpad/makefile-fix/+merge/42810 | 19:23 |
| thumper | abentley: and morning | 19:23 |
| abentley | thumper: :-) | 19:23 |
| abentley | thumper: approved. | 19:25 |
| thumper | abentley: thanks | 19:46 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!