=== wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant, wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [08:01] wgrant: those regular expressions for filenames are confusingly named, as they do more than just tell you whether the file is a source file :-/ [08:20] jelmer: Yeah... I should probably have renamed them when I refactored all that stuff a year ago. [08:20] Thanks for the review, anyway. [08:23] wgrant: These would probably also be good candidates for migration to python-debian. [08:23] jelmer: More than likely. === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant, wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: wgrant || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:38] wgrant: Hi! [10:38] wgrant: what's the second review? [10:38] henninge: Ah, jelmer already took care of it. === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:38] Forgot to take it off the queue, sorry. [10:38] wgrant: np. [10:39] henninge: I was going to replace the doctests, but decided that it might be better in a different branch. You want it in this one? [10:40] wgrant: Well, instead of adding the corner cases to the doctest, yes, I'd like that. [10:40] henninge: OK. Thanks. [10:40] It's not a big branch yet [10:41] No, but I don't generally like mixing code refactors and test replacements. [11:02] henninge: can I add this to your queue please: https://code.launchpad.net/~julian-edwards/launchpad/ppa-pockets-bug-684321/+merge/42824 [11:03] bigjools: Yay. [11:03] wgrant: should speed things up a little, but not as much as the components fix [11:03] bigjools: Yeah. [11:03] bigjools: Did the components fix make it into the release? [11:04] wgrant: just wait for some b******s to ask for components+pockets in PPAs now! [11:04] bigjools: I've done both in the past :P [11:04] But then I asked for multiple PPAs per person, and that was granted, so I am happy now :) [11:06] wgrant: I think it's missed the release :/ [11:06] shoulda landed it on db-devel.... [11:06] Hm? [11:06] Don't we rollout from devel now? [11:07] * wgrant checks. [11:07] wgrant: yes but we pick a revno and release that [11:07] stable, not devel [11:07] Er, that, yeah. [11:07] But the db-stable merge is the latest stable rev. [11:07] So everything before that must be included. [11:08] * bigjools looks more [11:08] ah yes, so it will be in [11:09] The removal of one or both flushes should make things significantly faster too. [11:09] But I need to test that on DF next week :) === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bigjools || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:13] bigjools: Hi! ;) [11:13] wgrant: yes :) [11:13] henninge: hi! [11:13] bigjools: reviewing now [11:14] henninge: cherers [11:14] cheers, too [11:17] bigjools: [11:17] 93 + # Cast to a list so we don't trip up with the security proxy not [11:17] 94 + # understandiung EnumItems [11:17] Is that a known bug? [11:19] henninge: I don't know. It's easily fixed in lp_sitecustomize though [11:19] depends on what the foundations chaps say [11:20] bigjools: So did you discover this? I am relly just asking if there is a bug for it ... ;) [11:21] henninge: well I discovered it but like Australia, there's some debate over whether I was first or not [11:22] bigjools: ;-) [11:23] henninge: if you look in lib/lp_sitecustomize.py you'll see the proxy is removed for a few objects [11:24] Deferred being one that I previously added :) [11:25] we could add EnumItems there too but I want to check with Gary first [11:26] yes, that's actually all I was going to ask you to do ... ;) (Talk to gary) [11:26] thanks [11:26] bigjools: r=me [11:26] henninge: : thanks === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === henninge_ changed the topic of #launchpad-reviews to: On call: - || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === henninge_ is now known as henninge === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === matsubara is now known as matsubara-lunch === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: -/- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === salgado is now known as salgado-lunch === matsubara-lunch is now known as matsubara === deryck is now known as deryck[lunch] === salgado-lunch is now known as salgado === deryck[lunch] is now known as deryck === mrevell_ is now known as mrevell === benji is now known as benji-lunch === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === benji-lunch is now known as benji [19:23] abentley: rc needed https://code.launchpad.net/~thumper/launchpad/makefile-fix/+merge/42810 [19:23] abentley: and morning [19:23] thumper: :-) [19:25] thumper: approved. [19:46] abentley: thanks === matsubara is now known as matsubara-afk === salgado is now known as salgado-afk