[08:01] <jelmer> wgrant: those regular expressions for filenames are confusingly named, as they do more than just tell you whether the file is a source file :-/
[08:20] <wgrant> jelmer: Yeah... I should probably have renamed them when I refactored all that stuff a year ago.
[08:20] <wgrant> Thanks for the review, anyway.
[08:23] <jelmer> wgrant: These would probably also be good candidates for migration to python-debian.
[08:23] <wgrant> jelmer: More than likely.
[10:38] <henninge> wgrant: Hi!
[10:38] <henninge> wgrant: what's the second review?
[10:38] <wgrant> henninge: Ah, jelmer already took care of it.
[10:38] <wgrant> Forgot to take it off the queue, sorry.
[10:38] <henninge> wgrant: np.
[10:39] <wgrant> henninge: I was going to replace the doctests, but decided that it might be better in a different branch. You want it in this one?
[10:40] <henninge> wgrant: Well, instead of adding the corner cases to the doctest, yes, I'd like that.
[10:40] <wgrant> henninge: OK. Thanks.
[10:40] <henninge> It's not a big branch yet
[10:41] <wgrant> No, but I don't generally like mixing code refactors and test replacements.
[11:02] <bigjools> henninge: can I add this to your queue please: https://code.launchpad.net/~julian-edwards/launchpad/ppa-pockets-bug-684321/+merge/42824
[11:03] <wgrant> bigjools: Yay.
[11:03] <bigjools> wgrant: should speed things up  a little, but not as much as the components fix
[11:03] <wgrant> bigjools: Yeah.
[11:03] <wgrant> bigjools: Did the components fix make it into the release?
[11:04] <bigjools> wgrant: just wait for some b******s to ask for components+pockets in PPAs now!
[11:04] <wgrant> bigjools: I've done both in the past :P
[11:04] <wgrant> But then I asked for multiple PPAs per person, and that was granted, so I am happy now :)
[11:06] <bigjools> wgrant: I think it's missed the release :/
[11:06] <bigjools> shoulda landed it on db-devel....
[11:06] <wgrant> Hm?
[11:06] <wgrant> Don't we rollout from devel now?
[11:07]  * wgrant checks.
[11:07] <bigjools> wgrant: yes but we pick a revno and release that
[11:07] <bigjools> stable, not devel
[11:07] <wgrant> Er, that, yeah.
[11:07] <wgrant> But the db-stable merge is the latest stable rev.
[11:07] <wgrant> So everything before that must be included.
[11:08]  * bigjools looks more
[11:08] <bigjools> ah yes, so it will be in
[11:09] <wgrant> The removal of one or both flushes should make things significantly faster too.
[11:09] <wgrant> But I need to test that on DF next week :)
[11:13] <henninge> bigjools: Hi! ;)
[11:13] <bigjools> wgrant: yes :)
[11:13] <bigjools> henninge: hi!
[11:13] <henninge> bigjools: reviewing now
[11:14] <bigjools> henninge: cherers
[11:14] <bigjools> cheers, too
[11:17] <henninge> bigjools:
[11:17] <henninge> 93	+        # Cast to a list so we don't trip up with the security proxy not
[11:17] <henninge> 94	+        # understandiung EnumItems
[11:17] <henninge> Is that a known bug?
[11:19] <bigjools> henninge: I don't know.  It's easily fixed in lp_sitecustomize though
[11:19] <bigjools> depends on what the foundations chaps say
[11:20] <henninge> bigjools: So did you discover this? I am relly just asking if there is a bug for it ... ;)
[11:21] <bigjools> henninge: well I discovered it but like Australia, there's some debate over whether I was first or not
[11:22] <henninge> bigjools: ;-)
[11:23] <bigjools> henninge: if you look in lib/lp_sitecustomize.py you'll see the proxy is removed for a few objects
[11:24] <bigjools> Deferred being one that I previously added :)
[11:25] <bigjools> we could add EnumItems there too but I want to check with Gary first
[11:26] <henninge> yes, that's actually all I was going to ask you to do ... ;) (Talk to gary)
[11:26] <henninge> thanks
[11:26] <henninge> bigjools: r=me
[11:26] <bigjools> henninge: : thanks
[19:23] <thumper> abentley: rc needed https://code.launchpad.net/~thumper/launchpad/makefile-fix/+merge/42810
[19:23] <thumper> abentley: and morning
[19:23] <abentley> thumper: :-)
[19:25] <abentley> thumper: approved.
[19:46] <thumper> abentley: thanks