/srv/irclogs.ubuntu.com/2010/12/13/#launchpad-dev.txt

wallyworldthumper: do you need to change the overall mp status to Approve, or i can....?02:34
thumperwallyworld: well, someone does02:34
StevenKwallyworld: You should be able to02:34
wallyworldthumper: i know i can - just wasn't  sure what the correct protocol was02:34
wallyworldthanks02:35
thumperwallyworld: if you have the reviews, you can change the overall status02:35
thumperthat's fine as protocol goes02:35
wgrantspm: How should I coerce you into adding my key to PQM?02:48
StevenKwgrant: Via an RT02:48
wgrant:(02:48
* wgrant dislikes RT.02:48
wgrantMostly because it's Perl.02:48
StevenKwgrant: Then check out http://jifty.org/view/FAQ02:50
thumperOMFG02:53
thumperlaunchpad.dev is seriously borked02:54
thumperhow do I turn of dev mode?02:54
wgrantthumper: The 500 JS requests per page?02:54
thumperwgrant: yeah02:54
wgrantthumper: configs/development/launchpad.conf02:54
wgrants/devmode on/devmode off/02:54
wgrantReduces it to a nice fast one request.02:54
StevenKwgrant: You didn't just review your lunch due to that web page? :-)02:55
thumperI remember deryck saying that devmode had a problem, but that is just absurd02:55
wgrantStevenK: I am immune to such things.02:55
wgrantthumper: It is just about unusable, yeah.02:56
wgrantFortunately, devmode is not important.02:56
thumperno, it is unusable02:56
wgrantIt does load *eventually*.02:56
StevenKwgrant: Wait until Wednesday02:56
wgrantAfter firing off 500 requests through a single-threaded slow appserver, generating dozens of oopses in the process.02:56
wgrantStevenK: Oh?02:57
StevenKAnd then I'll see how immune you are in person :-)02:57
wgrantAh, right.02:57
* thumper screams a little03:57
thumpergah03:57
StevenKthumper?04:01
* wgrant is reminded of Wellington, where thumper spent most of the time muttering "fuck fuck fucking fuck"04:02
StevenK-            return "You already have a PPA named '%s'." % proposed_name04:06
StevenK+            return "A PPA named '%s' already exists." % proposed_name04:06
StevenKthumper: Does that address your concerns re: bug 682548?04:06
_mup_Bug #682548: Archive.validate has poor wording for matching team ppas <confusing-ui> <ppa> <trivial> <Soyuz:Triaged> <https://launchpad.net/bugs/682548>04:06
thumperStevenK: I would have preferred two different errors depending on whether the PPA is for me or a team I'm a member of04:07
thumperperhaps "You already have a PPA named '%s'." % proposed_name for me04:07
thumperand "%s already has a PPA named '%s'." % (owner.display_name, proposed_name)04:07
thumperfor a team04:07
thumperthat's much nicer04:07
StevenKI can abstract that easily04:08
StevenK... maybe04:08
thumperyes you can04:12
thumperI looked at it when I was making the related  change04:13
thumperbut decided not to get too distracted04:13
thumperI'm still dealing with the other branch actually04:13
thumperright now04:13
StevenKthumper: I have a branch for this change, so I'm happy to fix it04:14
thumpergood :-)04:14
thumperwallyworld: ping04:29
wallyworldthumper: pong04:30
thumperwallyworld: have you landed your built-packages-listing branch yet?04:30
thumperbecause I want you to delete some whitespace04:30
wallyworldthumper: it's in ec2 now04:30
wallyworldthumper: can i pull it from ec2?04:31
thumperwallyworld: what about the filter follow up?04:31
wallyworldthumper: no, i was going to land the base branch first04:31
wallyworldthumper: i can make the changes in the 2nd one04:31
thumperwallyworld: you have space between the open brace and the hyperlink04:31
thumperwallyworld: (<a href="blah">04:32
thumperwallyworld: followed by a newline, then 'some text'04:32
* wallyworld looks04:32
thumperwallyworld: will give a blank space between ( and some text04:32
thumperto avoid that, you need the text to be hard against the closing > of the anchor tag04:32
wallyworldthumper: you mean it should be:  .....ourceBuilds">Lean more about....  ?04:36
thumperyep04:36
wallyworldthumper: ok. will fix in the filter branch. thanks for letting me know. i didn't notice the extra space04:37
StevenKthumper: If I look at https://bugs.launchpad.net/soyuz/+bug/680889 and then click the diff link from the linked MP, the floating diff box starts at line 123 and I can't dismiss it04:54
_mup_Bug #680889: Needs to handle "all linux-any" like "linux-any" <qa-needstesting> <soyuz-build> <Soyuz:Fix Committed by wgrant> <https://launchpad.net/bugs/680889>04:54
lifeless=== Top 10 Time Out Counts by Page ID ===04:55
lifeless    Hard / Soft  Page ID04:55
lifeless      86 / 4920  Archive:+index04:55
lifeless      56 /  194  BugTask:+index04:55
lifeless      32 /    0  Person:EntryResource:retractTeamMembership04:55
lifeless      29 /  366  POFile:+translate04:55
lifeless      15 /  234  Distribution:+bugs04:55
lifeless      12 /  112  ProjectGroupSet:CollectionResource:#project_groups04:55
lifeless       6 /  251  Distribution:+bugtarget-portlet-bugfilters-stats04:55
lifeless       5 /    5  ProjectGroup:+milestones04:55
lifeless       4 /   12  DistroArchSeries:+index04:55
lifeless       4 /    7  NullBugTask:+index04:55
lifelesssomeone should do a deploy ;)04:55
wgrantlifeless: A couple of my other revs are blocking it.04:57
wgrantI would QA them if I had DF access :)04:57
lifelesswgrant: you don't need df access04:58
lifelesswgrant: you can ask spm or another losa to do superuser stuff involved in qa04:58
wgrantlifeless: ROFL04:58
spmhmmm?04:58
lifelesswgrant: but also please ensure you file bugs/rts so that we can qa such things on qastaging in the future04:58
StevenKlifeless: Can be summed up as "Please run soyuz services on qastaging"05:03
StevenKBut that's rofl-tastic at the moment, given asuka's load05:04
lifelessStevenK: needs to be more specific or it won't happen.05:04
lifelessStevenK: please help it happen.05:05
lifelessas for load, there's another box coming, don't wait to describe (in detail) whats needed for that box.05:05
wgrantIt's also not clear how staging Soyuz should work.05:06
wgrantGiven that staging doesn't have the archives.05:06
lifelessthe goal is simple.05:07
wgrantSure.05:07
wgrantBut Soyuz isn't :)05:07
lifelesseverything else I happily delegate to folk working :)05:07
wgrantHeh.05:07
lifelessseriously. We need an archive on a box running soyuz stuff against qastaging? RT IT.05:07
lifeless-now- -please-.05:07
wgrantWe need to first work out if it's possible.05:08
lifelesswgrant: huh? no.05:08
lifelesswgrant: that would be backwards.05:09
lifelessI've tried rting this and got back a 'huh, please spell out whats not running' - staging *is* running all soyuz services according to the losas.05:09
wgrantstaging is running buildd-manager.05:10
wgrantI don't think qastaging is.05:10
lifelessqastaging isn't yet.05:10
wgrantAnd AFAIK they're not running anything else.05:10
lifelessbut you can qa on staging too.05:10
lifelesswgrant: if they aren't, RT IT05:10
lifelessor tell me, and I will file an RT, in all caps, because I'm having to repeat silly, obvious, clearly sensible things on my holiday :)05:10
lifelessjames and charlie both want the work queue for losas/sysadmins present in rt, not in our heads to be filed when its become top priority.05:11
spmand for us too - makes it easier to get a scope for work and what's important vs what can wait05:12
lifelesswe know we want this, and we know that theres stuff to do to make it work, so what stops us from rting the specifics today?05:12
lifelessI *can't* because I don't know the specifics.05:12
lifelesswgrant: StevenK: ^ seriously.05:12
wgrantI think Soyuz people (since we're about to blink out of existence) need to talk about what makes sense, given experiences with dogfood. Until then we do not know specifics.05:13
lifelesshow can you not know specifics?05:13
lifelessI don't mean *how*, I mean *what*05:13
wgrantAh, so the general specifics, I see :P05:13
lifelessservice foo-bar talking to qastaging db05:13
lifelessthats specific05:14
lifelesswhat machine? - losa choice05:14
lifelesssoyuz folk are of course welcome to talk to bigjools and so forth, but its not a question of what makes sense: we /need/ to be able to qa /everything/ on [qa]staging05:16
lifelessdogfood as a place to do major experimentation and stress testing is great.05:16
lifelessblocking deployments because a patch happens to be to the foo-bar component and that only runs on dogfood - thats a huge problem05:17
wgrantSure.05:17
lifelessit partitions the codebase, blocks the whole team, increases the risk of subsequent deploys.05:17
lifelessSo all I'm asking is that the missing services be:05:17
lifeless - enumerated05:17
lifeless - in an RT05:17
lifeless - or a bug05:17
lifelessand I'm totally  baffled what is hard/objectionable/unworthy in that request.05:17
lifelesscan you help me understand?05:18
wgrantThe publisher will explode at the slightest problem. For example, staging won't have any of the archives on disk. What will the publisher do? Boom. What if something that the publisher wants is deleted from the production librarian? Boom.05:20
wgrantI'm sure there are others.05:20
wgrantHow do we test ftpmaster-tools changes?05:20
lifelessask a losa to run the command05:20
wgrantWhat if we need to test override behaviour?05:20
wgrantHmm.05:20
lifelessif you need the archives on disk, ask for that in the rt05:21
lifelessthats *exactly* the sort of thing I'm asking be written down and made explicit05:21
wgrantThat's an awful lot of data to be copying around.05:23
lifelesshaving a good solid QA pipeline is fundamental to continuous deployments05:23
lifelessare you worried about cost or somethinhg?05:24
lifelessif so, say so!05:24
wgrantAnd practicality of syncing that regularly.05:25
lifelesshow often does it need syncing?05:26
spmchuckles05:26
lifelessI would say once a week when the db is reset05:26
lifelessmore importantly05:27
lifelesswgrant: this is a guess, but are you trying to make sure it will all work before asking for it ?05:27
wgrantlifeless: Yes.05:28
wgrantAsking for impossible things is not something I want to do!05:28
lifelesswgrant: thats a particularly bad antipattern05:28
lifelessplease stop05:28
lifelessteamwork depends on clearly articulating and socialising the needs *before* solutions are arrived at.05:29
lifelessits only impossible until a solution is arrived at05:29
lifelessand no discussion on sollutions can happen until the requirements and constraints have been articulated05:29
lifelessyou should feel *no shame* at asking for a dozen impossible things before breakfast [assuming they are things we want to do that will help us]05:30
spmwgrant: fwiw? you'd be hardpressed, REALLY hardpressed to outdo lifeless for impossible RT's and impossible numbers of same.05:30
wgrantSo, I don't see how discussing this on an RT ticket will help, when it mostly needs thought within Soyuz. Perhaps I misunderstand your use of RT.05:30
lifelesssoyuz is only a fraction of the solution space05:31
spmit's both discussion, task request, please help, everything05:31
lifelessthe gsas05:31
lifelessand losas05:31
lifelessare the ones that will be:05:31
lifeless - provisioning05:31
lifeless - admining05:31
lifeless - maintaining05:31
lifeless - implementing05:31
lifeless - supporting05:31
lifelessit05:31
lifelessits TOTALLY premature to have any discussion about *how* without them being involved, and their *requested* forum is RT.05:32
spmand loling at it's crackfullness. don't forget this one.05:32
lifelessspm: yeah but you do that on your sekret comments05:32
spmnot always05:32
lifelesstrue05:32
wgrantlifeless: We don't know what we want.05:32
spmsometimes we practice democratic and open crackful sharing05:32
lifelessanyhow, this is way depressing for my holidays.05:32
lifelesswgrant: I know what we want.05:32
lifelesswgrant: I just don't know how to enumerate it.05:33
lifelesswgrant: and I'm feeling sad that I'm not getting much support on that.05:33
lifelesswgrant: anyhow, I'll leave you be, and will sit on all ex-soyuz folk at the epic and get this written down05:37
lifelessunless one of you takes pity on me and writes it up05:37
wgrantDo we have goals for the Epic yet?05:42
lifelessbroadly yes05:43
lifelessthere will be some presentations - e.g. a ta update, strategy update, tl update05:44
lifelessand we'll be settling into the new team structure05:44
StevenKHudson, damn it!05:45
StevenKWANT!05:45
* spm notes the prior comments about crack05:45
spmspm 1, stevenk 005:46
StevenKHudson is far less crackful than buildbot05:46
spmspm 2, stevenk 005:46
spm(was a nil response, auto win. sorry)05:46
StevenKAnd doesn't require writing PYTHON to teach it how to build a project05:47
wgrantJust a lot of XML?05:47
lifelessno05:47
wgrantBut JAVA!05:48
spmyes.05:48
lifelesspretty nice, I know05:48
* spm has supported jvm's before. it's not pretty.05:48
lifelessfast though05:48
spmuntil a GC comes along, then you freeze for a second or more.05:51
pooliehm05:52
lifelesswell you want to avoid stop the world gcs05:52
lifelesswhich current gc engines are pretty good at, if tuned to the workload05:52
poolieyou would think so05:52
spmI remain... sceptical. based on prior experience.05:53
StevenKspm: Given current buildbot, or java, which would you prefer?05:53
poolieare we talking about Hudson for testing lp?05:53
spmstrawman choice :-)05:53
StevenKJust so I know if I'm pushing uphill or down05:53
poolieif that has occasional pauses it shouldn't really matter05:54
spmha. no. this is personal opinion not pushback. if LP decides it want's hudson, that's cool.05:54
lifelesswe're considering a java db for some stuff05:54
lifeless(cassandra)05:54
pooliehow about using jvm based things like Flume for logging? or cassandra05:54
lifelessno problem05:55
lifelessthere are several considerations of course05:55
lifelesscanonical runs some jvm services internally already05:55
pooliewell, my question was more "do the SAs fear it"05:55
lifelessAIUI the biggest consideration is the preffered tech mandate for best-of-breed fungible components05:56
poolieiow trying to decide if they're the best option to be used everywhere?05:59
lifelessbringing in something different to whats already used, for instance05:59
poolieright, the "is it worth changing/diverging" conversation06:04
lifelesswith the first of a kind06:05
spmI'm not too fussed myself over what tech you choose. just saying that my experiences with JV< is that it does have some nasty side effects. and GC under load is a biggie.06:05
lifelesswe can get into a bit of an overoptimisation discussion06:05
pooliemm06:05
pooliei mean of course erlang and python use gc too06:05
spmnot that you'd notice from some of the "leaks" we see... :-)06:06
poolieso the thing would have to be whether the jvm is worse at it (whihc seems a bit unlikely) or whether the application architecture exacerbates the problem06:06
lifelessthe reason you don't notice the pauses in python is because its never fast to start with06:06
spmhaha06:06
poolie:) or indeed gil06:06
spmjust at $job-1 we were running via a j2ee. wit hextra gc logging. and the amount of time lost to gc's was truly astonishing.06:08
pooliewell, you probably don't know how much time we're losing to gc inside python :)06:10
pooliei'm just saying it might be even more06:10
poolie(though it's probably not)06:10
spmthat would make me a sad panda06:11
poolieit might have just been more visible with extra logging one06:11
lifelessgill + gc would exceed stop the world gc + object moving overheads IMO06:11
poolie*on06:11
spmcan/should we be tuning python for that in any way? just thinking that with jvm you can tweak a fair bit to optimise for your load and usage.06:13
lifelessspm: yes, rt #idunnoitsmyholiday06:14
lifelessspm: 'single threaded appservers'06:14
spmhahahaha06:14
lifelessspm: wins on two counts06:14
lifelessfirstly one thread06:14
spmok, so you guys are worrying about that then already. /me washes hands.06:14
lifelesssecondly smaller memory footprint so overhead per-cpu of gc time is reduced06:14
lifelesseven though the total time on the machine is increased, if that makes sense06:15
spmyeah that was the unobvious killer - you can't just throw memory at a jvm, that can make things worse.06:15
lifelessyou might like the cassandra slides I sent around06:15
spmshrug. I have a .procmail From: lifeless >> /dev/null06:16
spmit saves time.06:16
spm:-P06:16
lifelesss/null/rw/06:16
spmread-only surely?06:17
lifelessraid warning :P06:17
spmhahaha06:17
pooliespm i think the "can't throw memory at it" problem is kind of related to it insisting on the whole app being inside a single OS process06:18
pooliewhich is an example of an architectural limit06:18
poolieand kind of the opposite of robert's single-thread appserver experiment06:18
spmyeah, I'd go with that06:18
spmcertainly we did notice that we could only get so much out of a single process, then it made more sense to fire up more on the same (4 cpu, not cores, cpu) server06:19
spmthe process couldn't use the h/w resources it had available.06:20
spmmind you... coldfusion code; which gets interpreted by the CF interpreter, which itself is a jvm/j2ee container. wheee.06:21
poolieright, that's just what i mean06:21
pooliepython obviously has this effect to an even higher degree, because of only really using one core at a time06:21
spmso poolie, you'll write a fix for python for us ... today?06:22
pooliebetter minds than mine have failed06:22
pooliethe best idea is to run more processes06:23
spm:-)06:23
pooliethis is kind of good for horizontal scaling and robustness anyhow06:23
spmyeah, it's a nice match there.06:23
spmif frustrating.06:23
pooliewhy frustrating?06:25
spmin that, eg, we don't fire up multiple squids or apaches etc to max h/w out. they can just make use of it. recognising I'm comparing apples with fish, so a tad unfair.06:27
poolie!?06:27
pooliebut apache at least does spawn multiple processes06:27
poolieand squid does that too for some specific bits, last time i looked06:27
spmyeah - it's handled internal to itself. it's not a start apache1 through 200 thing.06:27
poolieah, yes06:28
pooliemaybe we could fix that06:28
spmha. from rambling discussions comes "hey that's a problem, we should look at fixing that" :-D06:28
pooliedo you really manually start 200 things?06:29
poolieit seems it could at least be scripted06:29
poolieanyhow, that could be good to file bugs about06:30
spmwe have, more or less, apps 1-16 ish, plus edge 1-5. each with their own separate configs and such. so sorta. 200 is more for how many apache processes I've enabled previous with a single trivial change.06:33
spmwhich is also about 20 different init.d scripts :-/06:34
pooliesheesh06:35
pooliethat definitely seems worth fixing06:35
lifelesstheres a pending MP from me with a config autogenerator06:36
lifelesswhich is a first step at reducing the insanity06:36
spmhow would/could you fix the multiple procs per server thing? idly curious.06:37
lifelessme? i wouldn't.06:37
spm:-)06:37
lifelessI'd make the variation per configured proc 006:37
lifelessand then use existing sysadmin tools to dial the number of processes desired06:37
poolie+106:37
lifelesslast thing I want to maintain is another process-manager implementation :)06:37
spm:-)06:38
spmoh bother stubs not around. and staging update failed in a rather impresive and interesting way.06:39
wgrantspm: WTF, but OK.07:31
wgrantThanks.07:31
spmwgrant: yes. :-)07:32
spmthe cleanup of the allowed email addresses is painful. all these ... funky ones.07:32
lifelesswtf?07:33
wgrant"Note that due to PQM's finnkiy nature, all submissions must come from the 1st/default address."07:33
spmpqm - only accepts the 1st email in a gpg key07:33
lifelessgpgv07:34
spmsend from another, even if in the allowed key, fail.07:34
lifelessoh07:34
lifelessso there are two discrete things07:34
lifelessgpgv07:34
lifelessand email addresses used for per project/branch permissions07:34
lifelessgpgv ensures you own the email address07:35
lifelessand the email address is what the policy check is done on.07:35
lifelesstrivial to list N addresses for a person if you want to07:36
lifelessjust a config issue07:36
spmyou're kidding. gnnnnnnnnnnnngh.07:36
lifelessno07:36
lifelessnoone has ever asked me07:36
spmhahahahaahhaha07:36
spmwe thought you knew :-D07:37
lifelessnope07:37
spmso where/how?07:37
lifelessjust throw any additional emails you want folk to support in the email list for the group07:37
lifelessdone07:37
spmahh. code change?07:38
lifelessno07:38
* spm notes to self, rob is on HOLIDAYS... let it go......07:38
lifelessyou can even turn off email checking entirely if you just have one group07:38
lifelesskeep verify_sigs on though :)07:38
spmwe do have others, but I don't think they're really used. and could possibly be dropped safely.07:39
lifelessI do object to the 'finnkiy nature' bit07:40
lifelesswhen its a config issue:)07:40
StevenKLet's just switch to tarmac07:40
* StevenK hides07:40
wgrantIsn't that almost done?07:40
spmlifeless: that's still finicky (now spelt with more correct)07:41
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
mrevellMorning09:18
=== mrevell changed the topic of #launchpad-dev to: Launchpad Development Channel | BUG JAM! | PQM open for business | firefighting: - | Get the code: https:/​/​dev.launchpad.net/​Getting
wgrantDoes anyone know what's up with the lucid_db_lp?11:16
wgrantIt looks force-worthy.11:16
deryckMorning, all.12:02
=== henninge_ is now known as henninge
=== fjlacoste is now known as flacoste
=== matsubara is now known as matsubara-lunch
danilosgary_poster, hi :)14:49
gary_posterheh, hey danilos14:49
danilosgary_poster, so, canonical/launchpad/versioninfo.py loads bzr-version-info.py using imp.load_source('...', 'bzr-version-info.py') and that tries to read it from the cwd14:50
gary_posterhuh14:50
danilosgary_poster, that means that none of our cronscripts which are run like $LP_PY /path/to/lp/tree/cronscripts/blah.py get a reasonable value of version info data14:51
danilosgary_poster, small script to demonstrate the problem: https://pastebin.canonical.com/40858/14:51
danilosgary_poster, I figure we can run our scripts using (cd $LP_ROOT && $LP_PY ...) to work-around the problem, but that'd probably be ugly for the future and we'd want to fix versioninfo to read LP_ROOT/bzr-version-info.py instead14:52
gary_posterdanilos: /me wonders if a symlink into lib is not a reasonable colution14:53
gary_posters14:53
danilosgary_poster, I have no particular opinion, I basically want to solve bug 682186 and ensure nobody else runs into it themselves :)14:54
_mup_Bug #682186: X-Generator: Launchpad (build Unknown) <Launchpad Translations:Triaged> <https://launchpad.net/bugs/682186>14:54
danilosgary_poster, btw, I've tried that (symlinking into lib) and that doesn't work for me14:55
gary_posterdanilos, duped, weird14:56
gary_posterdanilos: I'll futz around for a sec and get back to you if I find something I think is reasonable14:57
danilosgary_poster, imp.find_module can find it then though14:57
danilosgary_poster, anyway, thanks, got a call now :)14:59
gary_posterflacoste: do you happen to know why Steve A used the imp module to implement and canonical/launchpad/versioninfo.py's import of bzr-version-info.py?  His checkin message is "add revno to main template". :-)15:12
gary_posterSeems like a simpler, more robust approach would be to symlink that file from the top of the tree into lib (as an importable name) and then do try: ... except ImportError: in canonical/launchpad/versioninfo.py .15:12
gary_posterAny idea why it is the way it is, historically or otherwise?  symlinks were supported in bzr at the time, as far as I can tell from a quick web search.15:12
=== Ursinha is now known as Ursinha-lunch
=== salgado is now known as salgado-afk
=== salgado-afk is now known as salgado-lunch
bigjoolsmthaddon: how's the script doing?15:18
mthaddonbigjools: have done a few more runs - all still taking an hour or so15:18
bigjoolsmthaddon: that's weird, I'd expect it to finish to completion with the limit you used.  Maybe it is finishing to completion, it's just genuinely taking that long15:19
bigjoolscan I take a peek at the log?15:19
mthaddonbigjools: devpad:~mthaddon/2010-12-13-ppa-log-parser*.log15:20
bigjoolsmthaddon: so it looks like it's hitting the limit each time15:22
bigjoolsI'd be tempted to remove that15:23
EdwinGrubbslifeless: ping15:23
mthaddonbigjools: I'd rather not - I really don't think there's any point to running a script as long as the last run we did - I'm fine to do it batches like this until we catch up15:23
mthaddonbigjools: do we have any way of estimating how far from catching up we are?15:23
bigjoolsmthaddon: roughly, it's processing around the "Tue Sep 21" date range15:24
bigjoolsso it has a long way to go15:24
mthaddonok15:25
bigjoolsmthaddon: huh actualy scratch that15:25
bigjoolsit's processing files in some weird ordering15:25
bigjoolsso I have NFI how long it will take, especially when it logs lines like "Finished parsing <gzip on 0x8722e18>"15:25
bigjools:/15:25
=== matsubara-lunch is now known as matsubara
gary_posterdanilos: http://pastebin.ubuntu.com/543094/ is smallest change that works locally.  http://pastebin.ubuntu.com/543095/ is in the direction of a cleanup, IMO (would also maybe want to change bzr-version-info.py name or something).15:38
gary_posterNext steps: maybe check with losas to see if they read bzr-version-info.py from some surprising place, or if it is always in the root of the tree.  I think it is always in the root of the tree, including in production.  Then choose one of those two, apply, and do something else. ;-)15:38
=== Ursinha-lunch is now known as Ursinha
flacostegary_poster: no idea15:58
gary_posterack flacoste thanks15:58
danilosgary_poster, hey, done with a call, let me look at that16:04
=== salgado-lunch is now known as salgado
=== beuno is now known as beuno-lunch
danilosgary_poster, I don't mind either solution, I'd be happy to drive the fix forward, but I am not sure where'd I put a test for it :) and whether it would be a useless test (i.e. more of a baggage test that takes long time to run since I'd have to use popen or something to make sure python is outside the tree)16:18
gary_posterdanilos, that would be great if you would drive it forward, though you can also ask me to.  For test, a popen.call from an alt directory calling the equivalent of "bin/py -c 'from canonical.launchpad.versioninfo import revno; print revno is not None'" might be good enough.16:21
gary_posterand should be pretty fast.16:22
danilosgary_poster, right, that's what I was thinking, but popen is an order of magnitude slower than a bare unit test or something, that's what I meant by "slow"16:25
gary_postersure16:25
danilosgary_poster, anyway, I'll go with your second (symlink) option and only add a test to that, how does that feel to you?16:26
gary_posterdanilos: sounds good to me, cool16:29
gary_posterthank you16:29
danilosgary_poster, no worries, it solves a bug for me as well :)16:30
gary_poster:-)16:31
danilosgary_poster, do you think it's ok to move versioninfo to lp.app or lp.services along the way?16:50
danilosgary_poster, (I'll do it only if it doesn't cause too much work, but just wondering)16:50
gary_posterdanilos: I think that would be another nice cleanup, yeah.  maybe app?  <shrug>16:51
gary_poster(lp.app I mean)16:51
danilosgary_poster, yeah, that's what I lean to as well16:52
gary_postercool16:52
=== benji is now known as benji-lunch
=== beuno-lunch is now known as beuno
jcsackettdid something land to speed up ec2 test recently? i just noticed runs are taking like 3.5 hours, where they used to take 4-5 hours for me.17:10
jcsacketti suppose this could have happened awhile ago, and i've just been oblivious.17:11
bigjoolsdid windmill get turned off?17:18
marsthat could do it17:29
marswindmill takes 40 minutes to run17:29
bigjoolsI noticed it's not running locally for me17:31
danilosbigjools, is it perhaps crawling locally for you?17:34
bigjoolsdanilos: more of an amble17:35
* bigjools EODs17:35
deryckjcsackett, it is windmill being turned off that saved the time.17:45
jcsackettderyck: ah, cool. glad that happened. 3.5 hours for results is way better.17:54
=== benji-lunch is now known as benji
=== al-maisan is now known as almaisan-away
lifelessEdwinGrubbs: ?18:37
=== matsubara is now known as matsubara-afk
lifelessjml: ping19:16
lifelessflacoste: ping19:27
jmllifeless: hi19:29
jmllifeless: wassup?19:29
flacostehi lifeless19:30
lifelessoh hai, I pinged, then remembered you're on leave now, right ?19:30
lifelessso I mailed flacoste instead :)19:30
lifelessflacoste: hi19:30
jmllifeless: ok :)19:30
lifelessso one thing I was very worried about in the bugjam was that we'd close stuff we shouldn't, and I've forwarded you a particular mail that triggered those fears, along with a plea for some guidance to the jammers19:31
lifelessjml: I was wondering with your testtools open bug19:33
lifelessjml: if it was a threading correctness issue that python-on-linux handles better19:33
Ursinhahi abentley, is it possible to the owner of an mp to set its status to Approved? even if the person isn't a reviewer?19:33
lifelessno19:34
abentleyUrsinha, no, and we certainly don't want it.19:34
lifelessUrsinha: if this is for tarmac, its a problem - we need to be using the merge queues facility, not the old 'lands stuff that is approved' hack19:34
Ursinhamars, ^19:34
Ursinhaabentley, I see I'm able to change the status of the mp to approved19:34
Ursinhaand I'm not a reviewer19:35
abentleyUrsinha, which mp?19:35
Ursinhaabentley, this one: https://code.launchpad.net/~ursinha/launchpad/add-ec2land-rules-orphaned-branches-no-conflicts/+merge/3138619:35
lifelessUrsinha: you are19:35
Ursinhalifeless, a launchpad reviewer?19:35
Ursinhano19:35
lifelessyup19:35
lifelessUrsinha: yes, you are in ~launchpad19:36
lifelesswhich is in ~canonical-launchpad-reviewers19:36
lifelessand ~launchpad-reviewers19:36
Ursinhalifeless, ~launchpad is a subgroup of the other two, and not the inverse?19:37
Ursinhathat makes no sense...19:37
lifelesssure it does19:37
lifelessas far as LP is concerned, all canonical lp staff are permitted to land things and review.19:37
lifelesswe use social glue for the process of learning, not technical.19:37
Ursinhalifeless, right19:38
lifelessmaybe not optimal, but thats a different discussion.19:38
Ursinhalifeless, this is for tarmac19:38
lifelessas far as lp is concerned, you are a reviewer for lp:launchpad and lp:launchpad/db-devel/trunk19:38
Ursinhawe're discussing changing lp-land to set the mp to approved, so tarmac can handle it19:38
lifelesstarmac shouldn't need that19:38
lifelesswith the merge queue stuff19:39
Ursinhalifeless, is that implemented already?19:39
lifelessand lp-land is the wrong time to set it, as aaron says.19:39
lifelessUrsinha: I don't know. I shouldn't be here anyway :)19:39
abentleyUrsinha, lp-land is all about PQM.  Are you planning to make Tarmac read emails the way PQM does?19:39
EdwinGrubbslifeless: I was just going to ask if there was a workaround for when somebody forgets to use [rollback=] in the pqm commit message that was better than just marking the bug qa-untestable temporarily.19:39
lifelessEdwinGrubbs: no; as you can see from abentley's excellent LEP we have a lot of polish to go on the deployment magic19:40
Ursinhaabentley, no, just use the same mechanism to make people able to be part of the simplify merge machinery beta19:40
lifelessEdwinGrubbs: I deliberately closed my eyes and went 'lalalala' at the start, so that we'd have *some* deployments rather than still be building up infrastructure now :)19:40
lifelessEdwinGrubbs: you just need to manually do the arithmetic when someone forgets a tag like that at the moment.19:41
EdwinGrubbsok, thanks19:41
abentleyUrsinha, Tarmac currently uses an "approved" review as a signal that it should perform a merge, right?19:41
Ursinhaabentley, I believe it uses the mp status19:41
abentleyUrsinha, I mean a status of "approved" on the whole proposal.19:41
Ursinhaabentley, ah, yes19:41
abentleyUrsinha, so this is not going to be any kind of smooth transition.  Because we don't use the Approved status that way.19:42
Ursinhaabentley, is the Approved status used in any way today?19:43
abentleyUrsinha, yes.  It's set when the last reviewer approves it.19:43
Ursinhaabentley, and what does that mean?19:43
abentleyUrsinha, it means that the reviewer has no major objections to landing it, but there may be some requested changes.19:44
Ursinhaabentley, wait, you're talking about the queue_status or the vote status?19:45
lifelessqueue status19:45
lifelesswell19:45
lifelessmp status19:45
Ursinharight19:45
lifelessqueue status is orthogonal19:45
abentleyUrsinha, I'm talking about the merge proposal status.19:45
Ursinhathat's the name of the property, I don't know why is that called this way19:45
lifelessI'm going to leave this discussion in abentley's more than capable hands, and go play some wow. enjoy!19:45
abentleyUrsinha, we could change Tarmac, or we could change our practice.  I think changing our practice would be expedient.19:47
abentleyUrsinha, So we would be changing it such that the reviewer never marks it "Approved".  The submitter would do that.19:48
abentleyUrsinha, that would give them a window to make any suggested changes.19:49
abentleyUrsinha, and if the submitter isn't a reviewer, they would need to ask a reviewer to do that, just as they need to get a committer to land on PQM.19:49
abentleyUrsinha, But if we're changing our practice anyway, I don't see value in using lp-land to land merge proposals.19:50
Ursinhaabentley, right, so you suggest changing the practice by marking mps Approved with a different meaning, and doing that manually19:53
abentleyUrsinha, right.19:53
UrsinhaI agree lp-land isn't the right place to do that, we're trying to find more automated ways to test the smm changes19:53
abentleyUrsinha, lp-land only exists because pqm isn't well integrated with Launchpad.19:54
Ursinhaabentley, right19:54
lifelessone final note19:56
lifelessa team of 30 is slow to change19:57
Ursinhalifeless, what do you suggest?19:57
lifelessyou may find that new instructions will not be followed immediately, so plan for that happening.19:57
lifelessUrsinha: myself, I'd help rockstar finish merge queues.19:57
lifelessMy understanding was that that was the plan.19:57
abentleylifeless, indeed, that is planned and will result in a better system.  Only question is "when".19:58
lifelessanyhow, I only popped back to make that note about inertia; folk will do the old process for some time after a change is announced19:58
lifelessso if the system would be fragile, were someone to do the old process, then thats a risk that needs some consideration.19:58
Ursinhalifeless, one of the ideas of using ec2 land / bzr lp-land to set things up was to help with that, afaik19:59
abentleyUrsinha, the problem is that "Approved" is already being used with a laxer meaning.  If people follow current practise, lp-land can't help with that.20:00
abentleyUrsinha, because by the time they run "lp-land" the change will already be merged.20:00
Ursinhaabentley, right, got it20:01
=== rockstar` is now known as rockstar
deryckbenji, ping20:24
benjihey deryck, what's up?20:24
deryckbenji, hey, is revno 12032 in devel users?  Something about smoke test script?20:25
benjideryck: I'm afraid I can't parse the quesiton "is revno 12032 in devel users?"20:28
benjirevno 12032 does contain a librarian smoke test script20:28
deryckbenji, sorry I fail.  "yours" I meant.  Is it your rev in devel?  Did you land it?20:29
benjioh, yes, I did20:29
deryckbenji, can I ask for qa from you for that? :-)  If it gets marked qa-ok, I can deploy a revno we need and get a feature out.20:30
benjideryck: sure; I'd say that it's untestable, so I'll mark it thusly20:32
deryckawesome.  easy peasy then.20:32
deryckbenji, thanks!20:32
benjideryck: done20:34
deryckcool20:37
wgrantsinzui: Uh, how did my rev roll back yours? :/20:47
wgrantIt's not in the diff.20:47
=== salgado is now known as salgado-afk
=== flacoste changed the topic of #launchpad-dev to: Launchpad Development Channel | BUG JAM! | New starter this week: wgrant | PQM open for business | firefighting: - | Get the code: https:/​/​dev.launchpad.net/​Getting
wgrantMorning all.20:59
mwhudsonmorning21:01
marsmorning21:03
wallyworld_abentley: thumper: mumble?21:06
abentleywallyworld_, thumper may be delayed.21:06
abentleywallyworld_, see his email.21:06
wallyworld_abentley: ok. we can do it later21:08
wallyworld_abentley: my stupid pulse audio was not working again too, so it's reboot time :-(21:09
jcsackettsinzui: question for you on bug 684151. you say we can just change the name to remove '-secondary', but then won't it clash with the form instance at the top of the page?22:01
_mup_Bug #684151: Search field at the bottom of a search results page never works <trivial> <launchpad-web:In Progress by jcsackett> <https://launchpad.net/bugs/684151>22:01
sinzuijcsackett, no, field names are not unique22:01
sinzuijcsackett, the error is making the names unique because the ids are unique22:02
sinzuithe ids do need to be unique22:02
jcsackettsinzui: okay. question the second; how does one go about testing this, since the usual create_initialized_view and pass in "field.text" approach isn't sure to hit the right form?22:03
jcsackettthe only tests for this i see are launchpad-search-pages.txt, which all go via "+search", which isn't specific to the form being used. :-/22:03
sinzuijcsackett,  get the second form by id and verify its input type="text" element have a sane name attr22:04
sinzuijcsackett, It can be done using the beautiful soup instance returned by get_tag_by_id()22:04
jcsackettah, so just test the name instance, don't bother testing function from that form?22:05
jcsackettthat's much easier. :-P22:05
sinzuijcsackett, Correct. We can test the contracts provide rather than the view's processing of the data22:06
jcsackettsinzui: dig. thanks!22:06
thumperwell that took longer than expected23:33
spmthumper: this is your haircut you left for, yesterday morning?23:33
thumperspm: heh, no23:34
thumperspm: my daughter's class was going for a walk this morning23:34
spmoh lovely23:34
thumperspm: and I went to help thinking it would be all over in 1.5 hours23:34
thumperspm: but no23:34
spmbut no.23:34
thumperspm: delayed further by a tree falling down on the route we took23:35

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!