[02:34] thumper: do you need to change the overall mp status to Approve, or i can....? [02:34] wallyworld: well, someone does [02:34] wallyworld: You should be able to [02:34] thumper: i know i can - just wasn't sure what the correct protocol was [02:35] thanks [02:35] wallyworld: if you have the reviews, you can change the overall status [02:35] that's fine as protocol goes [02:48] spm: How should I coerce you into adding my key to PQM? [02:48] wgrant: Via an RT [02:48] :( [02:48] * wgrant dislikes RT. [02:48] Mostly because it's Perl. [02:50] wgrant: Then check out http://jifty.org/view/FAQ [02:53] OMFG [02:54] launchpad.dev is seriously borked [02:54] how do I turn of dev mode? [02:54] thumper: The 500 JS requests per page? [02:54] wgrant: yeah [02:54] thumper: configs/development/launchpad.conf [02:54] s/devmode on/devmode off/ [02:54] Reduces it to a nice fast one request. [02:55] wgrant: You didn't just review your lunch due to that web page? :-) [02:55] I remember deryck saying that devmode had a problem, but that is just absurd [02:55] StevenK: I am immune to such things. [02:56] thumper: It is just about unusable, yeah. [02:56] Fortunately, devmode is not important. [02:56] no, it is unusable [02:56] It does load *eventually*. [02:56] wgrant: Wait until Wednesday [02:56] After firing off 500 requests through a single-threaded slow appserver, generating dozens of oopses in the process. [02:57] StevenK: Oh? [02:57] And then I'll see how immune you are in person :-) [02:57] Ah, right. [03:57] * thumper screams a little [03:57] gah [04:01] thumper? [04:02] * wgrant is reminded of Wellington, where thumper spent most of the time muttering "fuck fuck fucking fuck" [04:06] - return "You already have a PPA named '%s'." % proposed_name [04:06] + return "A PPA named '%s' already exists." % proposed_name [04:06] thumper: Does that address your concerns re: bug 682548? [04:06] <_mup_> Bug #682548: Archive.validate has poor wording for matching team ppas [04:07] StevenK: I would have preferred two different errors depending on whether the PPA is for me or a team I'm a member of [04:07] perhaps "You already have a PPA named '%s'." % proposed_name for me [04:07] and "%s already has a PPA named '%s'." % (owner.display_name, proposed_name) [04:07] for a team [04:07] that's much nicer [04:08] I can abstract that easily [04:08] ... maybe [04:12] yes you can [04:13] I looked at it when I was making the related change [04:13] but decided not to get too distracted [04:13] I'm still dealing with the other branch actually [04:13] right now [04:14] thumper: I have a branch for this change, so I'm happy to fix it [04:14] good :-) [04:29] wallyworld: ping [04:30] thumper: pong [04:30] wallyworld: have you landed your built-packages-listing branch yet? [04:30] because I want you to delete some whitespace [04:30] thumper: it's in ec2 now [04:31] thumper: can i pull it from ec2? [04:31] wallyworld: what about the filter follow up? [04:31] thumper: no, i was going to land the base branch first [04:31] thumper: i can make the changes in the 2nd one [04:31] wallyworld: you have space between the open brace and the hyperlink [04:32] wallyworld: ( [04:32] wallyworld: followed by a newline, then 'some text' [04:32] * wallyworld looks [04:32] wallyworld: will give a blank space between ( and some text [04:32] to avoid that, you need the text to be hard against the closing > of the anchor tag [04:36] thumper: you mean it should be: .....ourceBuilds">Lean more about.... ? [04:36] yep [04:37] thumper: ok. will fix in the filter branch. thanks for letting me know. i didn't notice the extra space [04:54] thumper: If I look at https://bugs.launchpad.net/soyuz/+bug/680889 and then click the diff link from the linked MP, the floating diff box starts at line 123 and I can't dismiss it [04:54] <_mup_> Bug #680889: Needs to handle "all linux-any" like "linux-any" [04:55] === Top 10 Time Out Counts by Page ID === [04:55] Hard / Soft Page ID [04:55] 86 / 4920 Archive:+index [04:55] 56 / 194 BugTask:+index [04:55] 32 / 0 Person:EntryResource:retractTeamMembership [04:55] 29 / 366 POFile:+translate [04:55] 15 / 234 Distribution:+bugs [04:55] 12 / 112 ProjectGroupSet:CollectionResource:#project_groups [04:55] 6 / 251 Distribution:+bugtarget-portlet-bugfilters-stats [04:55] 5 / 5 ProjectGroup:+milestones [04:55] 4 / 12 DistroArchSeries:+index [04:55] 4 / 7 NullBugTask:+index [04:55] someone should do a deploy ;) [04:57] lifeless: A couple of my other revs are blocking it. [04:57] I would QA them if I had DF access :) [04:58] wgrant: you don't need df access [04:58] wgrant: you can ask spm or another losa to do superuser stuff involved in qa [04:58] lifeless: ROFL [04:58] hmmm? [04:58] wgrant: but also please ensure you file bugs/rts so that we can qa such things on qastaging in the future [05:03] lifeless: Can be summed up as "Please run soyuz services on qastaging" [05:04] But that's rofl-tastic at the moment, given asuka's load [05:04] StevenK: needs to be more specific or it won't happen. [05:05] StevenK: please help it happen. [05:05] as for load, there's another box coming, don't wait to describe (in detail) whats needed for that box. [05:06] It's also not clear how staging Soyuz should work. [05:06] Given that staging doesn't have the archives. [05:07] the goal is simple. [05:07] Sure. [05:07] But Soyuz isn't :) [05:07] everything else I happily delegate to folk working :) [05:07] Heh. [05:07] seriously. We need an archive on a box running soyuz stuff against qastaging? RT IT. [05:07] -now- -please-. [05:08] We need to first work out if it's possible. [05:08] wgrant: huh? no. [05:09] wgrant: that would be backwards. [05:09] I've tried rting this and got back a 'huh, please spell out whats not running' - staging *is* running all soyuz services according to the losas. [05:10] staging is running buildd-manager. [05:10] I don't think qastaging is. [05:10] qastaging isn't yet. [05:10] And AFAIK they're not running anything else. [05:10] but you can qa on staging too. [05:10] wgrant: if they aren't, RT IT [05:10] or tell me, and I will file an RT, in all caps, because I'm having to repeat silly, obvious, clearly sensible things on my holiday :) [05:11] james and charlie both want the work queue for losas/sysadmins present in rt, not in our heads to be filed when its become top priority. [05:12] and for us too - makes it easier to get a scope for work and what's important vs what can wait [05:12] we know we want this, and we know that theres stuff to do to make it work, so what stops us from rting the specifics today? [05:12] I *can't* because I don't know the specifics. [05:12] wgrant: StevenK: ^ seriously. [05:13] I think Soyuz people (since we're about to blink out of existence) need to talk about what makes sense, given experiences with dogfood. Until then we do not know specifics. [05:13] how can you not know specifics? [05:13] I don't mean *how*, I mean *what* [05:13] Ah, so the general specifics, I see :P [05:13] service foo-bar talking to qastaging db [05:14] thats specific [05:14] what machine? - losa choice [05:16] soyuz folk are of course welcome to talk to bigjools and so forth, but its not a question of what makes sense: we /need/ to be able to qa /everything/ on [qa]staging [05:16] dogfood as a place to do major experimentation and stress testing is great. [05:17] blocking deployments because a patch happens to be to the foo-bar component and that only runs on dogfood - thats a huge problem [05:17] Sure. [05:17] it partitions the codebase, blocks the whole team, increases the risk of subsequent deploys. [05:17] So all I'm asking is that the missing services be: [05:17] - enumerated [05:17] - in an RT [05:17] - or a bug [05:17] and I'm totally baffled what is hard/objectionable/unworthy in that request. [05:18] can you help me understand? [05:20] The publisher will explode at the slightest problem. For example, staging won't have any of the archives on disk. What will the publisher do? Boom. What if something that the publisher wants is deleted from the production librarian? Boom. [05:20] I'm sure there are others. [05:20] How do we test ftpmaster-tools changes? [05:20] ask a losa to run the command [05:20] What if we need to test override behaviour? [05:20] Hmm. [05:21] if you need the archives on disk, ask for that in the rt [05:21] thats *exactly* the sort of thing I'm asking be written down and made explicit [05:23] That's an awful lot of data to be copying around. [05:23] having a good solid QA pipeline is fundamental to continuous deployments [05:24] are you worried about cost or somethinhg? [05:24] if so, say so! [05:25] And practicality of syncing that regularly. [05:26] how often does it need syncing? [05:26] chuckles [05:26] I would say once a week when the db is reset [05:27] more importantly [05:27] wgrant: this is a guess, but are you trying to make sure it will all work before asking for it ? [05:28] lifeless: Yes. [05:28] Asking for impossible things is not something I want to do! [05:28] wgrant: thats a particularly bad antipattern [05:28] please stop [05:29] teamwork depends on clearly articulating and socialising the needs *before* solutions are arrived at. [05:29] its only impossible until a solution is arrived at [05:29] and no discussion on sollutions can happen until the requirements and constraints have been articulated [05:30] you should feel *no shame* at asking for a dozen impossible things before breakfast [assuming they are things we want to do that will help us] [05:30] wgrant: fwiw? you'd be hardpressed, REALLY hardpressed to outdo lifeless for impossible RT's and impossible numbers of same. [05:30] So, I don't see how discussing this on an RT ticket will help, when it mostly needs thought within Soyuz. Perhaps I misunderstand your use of RT. [05:31] soyuz is only a fraction of the solution space [05:31] it's both discussion, task request, please help, everything [05:31] the gsas [05:31] and losas [05:31] are the ones that will be: [05:31] - provisioning [05:31] - admining [05:31] - maintaining [05:31] - implementing [05:31] - supporting [05:31] it [05:32] its TOTALLY premature to have any discussion about *how* without them being involved, and their *requested* forum is RT. [05:32] and loling at it's crackfullness. don't forget this one. [05:32] spm: yeah but you do that on your sekret comments [05:32] not always [05:32] true [05:32] lifeless: We don't know what we want. [05:32] sometimes we practice democratic and open crackful sharing [05:32] anyhow, this is way depressing for my holidays. [05:32] wgrant: I know what we want. [05:33] wgrant: I just don't know how to enumerate it. [05:33] wgrant: and I'm feeling sad that I'm not getting much support on that. [05:37] wgrant: anyhow, I'll leave you be, and will sit on all ex-soyuz folk at the epic and get this written down [05:37] unless one of you takes pity on me and writes it up [05:42] Do we have goals for the Epic yet? [05:43] broadly yes [05:44] there will be some presentations - e.g. a ta update, strategy update, tl update [05:44] and we'll be settling into the new team structure [05:45] Hudson, damn it! [05:45] WANT! [05:45] * spm notes the prior comments about crack [05:46] spm 1, stevenk 0 [05:46] Hudson is far less crackful than buildbot [05:46] spm 2, stevenk 0 [05:46] (was a nil response, auto win. sorry) [05:47] And doesn't require writing PYTHON to teach it how to build a project [05:47] Just a lot of XML? [05:47] no [05:48] But JAVA! [05:48] yes. [05:48] pretty nice, I know [05:48] * spm has supported jvm's before. it's not pretty. [05:48] fast though [05:51] until a GC comes along, then you freeze for a second or more. [05:52] hm [05:52] well you want to avoid stop the world gcs [05:52] which current gc engines are pretty good at, if tuned to the workload [05:52] you would think so [05:53] I remain... sceptical. based on prior experience. [05:53] spm: Given current buildbot, or java, which would you prefer? [05:53] are we talking about Hudson for testing lp? [05:53] strawman choice :-) [05:53] Just so I know if I'm pushing uphill or down [05:54] if that has occasional pauses it shouldn't really matter [05:54] ha. no. this is personal opinion not pushback. if LP decides it want's hudson, that's cool. [05:54] we're considering a java db for some stuff [05:54] (cassandra) [05:54] how about using jvm based things like Flume for logging? or cassandra [05:55] no problem [05:55] there are several considerations of course [05:55] canonical runs some jvm services internally already [05:55] well, my question was more "do the SAs fear it" [05:56] AIUI the biggest consideration is the preffered tech mandate for best-of-breed fungible components [05:59] iow trying to decide if they're the best option to be used everywhere? [05:59] bringing in something different to whats already used, for instance [06:04] right, the "is it worth changing/diverging" conversation [06:05] with the first of a kind [06:05] I'm not too fussed myself over what tech you choose. just saying that my experiences with JV< is that it does have some nasty side effects. and GC under load is a biggie. [06:05] we can get into a bit of an overoptimisation discussion [06:05] mm [06:05] i mean of course erlang and python use gc too [06:06] not that you'd notice from some of the "leaks" we see... :-) [06:06] so the thing would have to be whether the jvm is worse at it (whihc seems a bit unlikely) or whether the application architecture exacerbates the problem [06:06] the reason you don't notice the pauses in python is because its never fast to start with [06:06] haha [06:06] :) or indeed gil [06:08] just at $job-1 we were running via a j2ee. wit hextra gc logging. and the amount of time lost to gc's was truly astonishing. [06:10] well, you probably don't know how much time we're losing to gc inside python :) [06:10] i'm just saying it might be even more [06:10] (though it's probably not) [06:11] that would make me a sad panda [06:11] it might have just been more visible with extra logging one [06:11] gill + gc would exceed stop the world gc + object moving overheads IMO [06:11] *on [06:13] can/should we be tuning python for that in any way? just thinking that with jvm you can tweak a fair bit to optimise for your load and usage. [06:14] spm: yes, rt #idunnoitsmyholiday [06:14] spm: 'single threaded appservers' [06:14] hahahaha [06:14] spm: wins on two counts [06:14] firstly one thread [06:14] ok, so you guys are worrying about that then already. /me washes hands. [06:14] secondly smaller memory footprint so overhead per-cpu of gc time is reduced [06:15] even though the total time on the machine is increased, if that makes sense [06:15] yeah that was the unobvious killer - you can't just throw memory at a jvm, that can make things worse. [06:15] you might like the cassandra slides I sent around [06:16] shrug. I have a .procmail From: lifeless >> /dev/null [06:16] it saves time. [06:16] :-P [06:16] s/null/rw/ [06:17] read-only surely? [06:17] raid warning :P [06:17] hahaha [06:18] spm i think the "can't throw memory at it" problem is kind of related to it insisting on the whole app being inside a single OS process [06:18] which is an example of an architectural limit [06:18] and kind of the opposite of robert's single-thread appserver experiment [06:18] yeah, I'd go with that [06:19] certainly we did notice that we could only get so much out of a single process, then it made more sense to fire up more on the same (4 cpu, not cores, cpu) server [06:20] the process couldn't use the h/w resources it had available. [06:21] mind you... coldfusion code; which gets interpreted by the CF interpreter, which itself is a jvm/j2ee container. wheee. [06:21] right, that's just what i mean [06:21] python obviously has this effect to an even higher degree, because of only really using one core at a time [06:22] so poolie, you'll write a fix for python for us ... today? [06:22] better minds than mine have failed [06:23] the best idea is to run more processes [06:23] :-) [06:23] this is kind of good for horizontal scaling and robustness anyhow [06:23] yeah, it's a nice match there. [06:23] if frustrating. [06:25] why frustrating? [06:27] in that, eg, we don't fire up multiple squids or apaches etc to max h/w out. they can just make use of it. recognising I'm comparing apples with fish, so a tad unfair. [06:27] !? [06:27] but apache at least does spawn multiple processes [06:27] and squid does that too for some specific bits, last time i looked [06:27] yeah - it's handled internal to itself. it's not a start apache1 through 200 thing. [06:28] ah, yes [06:28] maybe we could fix that [06:28] ha. from rambling discussions comes "hey that's a problem, we should look at fixing that" :-D [06:29] do you really manually start 200 things? [06:29] it seems it could at least be scripted [06:30] anyhow, that could be good to file bugs about [06:33] we have, more or less, apps 1-16 ish, plus edge 1-5. each with their own separate configs and such. so sorta. 200 is more for how many apache processes I've enabled previous with a single trivial change. [06:34] which is also about 20 different init.d scripts :-/ [06:35] sheesh [06:35] that definitely seems worth fixing [06:36] theres a pending MP from me with a config autogenerator [06:36] which is a first step at reducing the insanity [06:37] how would/could you fix the multiple procs per server thing? idly curious. [06:37] me? i wouldn't. [06:37] :-) [06:37] I'd make the variation per configured proc 0 [06:37] and then use existing sysadmin tools to dial the number of processes desired [06:37] +1 [06:37] last thing I want to maintain is another process-manager implementation :) [06:38] :-) [06:39] oh bother stubs not around. and staging update failed in a rather impresive and interesting way. [07:31] spm: WTF, but OK. [07:31] Thanks. [07:32] wgrant: yes. :-) [07:32] the cleanup of the allowed email addresses is painful. all these ... funky ones. [07:33] wtf? [07:33] "Note that due to PQM's finnkiy nature, all submissions must come from the 1st/default address." [07:33] pqm - only accepts the 1st email in a gpg key [07:34] gpgv [07:34] send from another, even if in the allowed key, fail. [07:34] oh [07:34] so there are two discrete things [07:34] gpgv [07:34] and email addresses used for per project/branch permissions [07:35] gpgv ensures you own the email address [07:35] and the email address is what the policy check is done on. [07:36] trivial to list N addresses for a person if you want to [07:36] just a config issue [07:36] you're kidding. gnnnnnnnnnnnngh. [07:36] no [07:36] noone has ever asked me [07:36] hahahahaahhaha [07:37] we thought you knew :-D [07:37] nope [07:37] so where/how? [07:37] just throw any additional emails you want folk to support in the email list for the group [07:37] done [07:38] ahh. code change? [07:38] no [07:38] * spm notes to self, rob is on HOLIDAYS... let it go...... [07:38] you can even turn off email checking entirely if you just have one group [07:38] keep verify_sigs on though :) [07:39] we do have others, but I don't think they're really used. and could possibly be dropped safely. [07:40] I do object to the 'finnkiy nature' bit [07:40] when its a config issue:) [07:40] Let's just switch to tarmac [07:40] * StevenK hides [07:40] Isn't that almost done? [07:41] lifeless: that's still finicky (now spelt with more correct) === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === almaisan-away is now known as al-maisan [09:18] Morning === mrevell changed the topic of #launchpad-dev to: Launchpad Development Channel | BUG JAM! | PQM open for business | firefighting: - | Get the code: https:/​/​dev.launchpad.net/​Getting [11:16] Does anyone know what's up with the lucid_db_lp? [11:16] It looks force-worthy. [12:02] Morning, all. === henninge_ is now known as henninge === fjlacoste is now known as flacoste === matsubara is now known as matsubara-lunch [14:49] gary_poster, hi :) [14:49] heh, hey danilos [14:50] gary_poster, so, canonical/launchpad/versioninfo.py loads bzr-version-info.py using imp.load_source('...', 'bzr-version-info.py') and that tries to read it from the cwd [14:50] huh [14:51] gary_poster, that means that none of our cronscripts which are run like $LP_PY /path/to/lp/tree/cronscripts/blah.py get a reasonable value of version info data [14:51] gary_poster, small script to demonstrate the problem: https://pastebin.canonical.com/40858/ [14:52] gary_poster, I figure we can run our scripts using (cd $LP_ROOT && $LP_PY ...) to work-around the problem, but that'd probably be ugly for the future and we'd want to fix versioninfo to read LP_ROOT/bzr-version-info.py instead [14:53] danilos: /me wonders if a symlink into lib is not a reasonable colution [14:53] s [14:54] gary_poster, I have no particular opinion, I basically want to solve bug 682186 and ensure nobody else runs into it themselves :) [14:54] <_mup_> Bug #682186: X-Generator: Launchpad (build Unknown) [14:55] gary_poster, btw, I've tried that (symlinking into lib) and that doesn't work for me [14:56] danilos, duped, weird [14:57] danilos: I'll futz around for a sec and get back to you if I find something I think is reasonable [14:57] gary_poster, imp.find_module can find it then though [14:59] gary_poster, anyway, thanks, got a call now :) [15:12] flacoste: do you happen to know why Steve A used the imp module to implement and canonical/launchpad/versioninfo.py's import of bzr-version-info.py? His checkin message is "add revno to main template". :-) [15:12] Seems like a simpler, more robust approach would be to symlink that file from the top of the tree into lib (as an importable name) and then do try: ... except ImportError: in canonical/launchpad/versioninfo.py . [15:12] Any idea why it is the way it is, historically or otherwise? symlinks were supported in bzr at the time, as far as I can tell from a quick web search. === Ursinha is now known as Ursinha-lunch === salgado is now known as salgado-afk === salgado-afk is now known as salgado-lunch [15:18] mthaddon: how's the script doing? [15:18] bigjools: have done a few more runs - all still taking an hour or so [15:19] mthaddon: that's weird, I'd expect it to finish to completion with the limit you used. Maybe it is finishing to completion, it's just genuinely taking that long [15:19] can I take a peek at the log? [15:20] bigjools: devpad:~mthaddon/2010-12-13-ppa-log-parser*.log [15:22] mthaddon: so it looks like it's hitting the limit each time [15:23] I'd be tempted to remove that [15:23] lifeless: ping [15:23] bigjools: I'd rather not - I really don't think there's any point to running a script as long as the last run we did - I'm fine to do it batches like this until we catch up [15:23] bigjools: do we have any way of estimating how far from catching up we are? [15:24] mthaddon: roughly, it's processing around the "Tue Sep 21" date range [15:24] so it has a long way to go [15:25] ok [15:25] mthaddon: huh actualy scratch that [15:25] it's processing files in some weird ordering [15:25] so I have NFI how long it will take, especially when it logs lines like "Finished parsing " [15:25] :/ === matsubara-lunch is now known as matsubara [15:38] danilos: http://pastebin.ubuntu.com/543094/ is smallest change that works locally. http://pastebin.ubuntu.com/543095/ is in the direction of a cleanup, IMO (would also maybe want to change bzr-version-info.py name or something). [15:38] Next steps: maybe check with losas to see if they read bzr-version-info.py from some surprising place, or if it is always in the root of the tree. I think it is always in the root of the tree, including in production. Then choose one of those two, apply, and do something else. ;-) === Ursinha-lunch is now known as Ursinha [15:58] gary_poster: no idea [15:58] ack flacoste thanks [16:04] gary_poster, hey, done with a call, let me look at that === salgado-lunch is now known as salgado === beuno is now known as beuno-lunch [16:18] gary_poster, I don't mind either solution, I'd be happy to drive the fix forward, but I am not sure where'd I put a test for it :) and whether it would be a useless test (i.e. more of a baggage test that takes long time to run since I'd have to use popen or something to make sure python is outside the tree) [16:21] danilos, that would be great if you would drive it forward, though you can also ask me to. For test, a popen.call from an alt directory calling the equivalent of "bin/py -c 'from canonical.launchpad.versioninfo import revno; print revno is not None'" might be good enough. [16:22] and should be pretty fast. [16:25] gary_poster, right, that's what I was thinking, but popen is an order of magnitude slower than a bare unit test or something, that's what I meant by "slow" [16:25] sure [16:26] gary_poster, anyway, I'll go with your second (symlink) option and only add a test to that, how does that feel to you? [16:29] danilos: sounds good to me, cool [16:29] thank you [16:30] gary_poster, no worries, it solves a bug for me as well :) [16:31] :-) [16:50] gary_poster, do you think it's ok to move versioninfo to lp.app or lp.services along the way? [16:50] gary_poster, (I'll do it only if it doesn't cause too much work, but just wondering) [16:51] danilos: I think that would be another nice cleanup, yeah. maybe app? [16:51] (lp.app I mean) [16:52] gary_poster, yeah, that's what I lean to as well [16:52] cool === benji is now known as benji-lunch === beuno-lunch is now known as beuno [17:10] did something land to speed up ec2 test recently? i just noticed runs are taking like 3.5 hours, where they used to take 4-5 hours for me. [17:11] i suppose this could have happened awhile ago, and i've just been oblivious. [17:18] did windmill get turned off? [17:29] that could do it [17:29] windmill takes 40 minutes to run [17:31] I noticed it's not running locally for me [17:34] bigjools, is it perhaps crawling locally for you? [17:35] danilos: more of an amble [17:35] * bigjools EODs [17:45] jcsackett, it is windmill being turned off that saved the time. [17:54] deryck: ah, cool. glad that happened. 3.5 hours for results is way better. === benji-lunch is now known as benji === al-maisan is now known as almaisan-away [18:37] EdwinGrubbs: ? === matsubara is now known as matsubara-afk [19:16] jml: ping [19:27] flacoste: ping [19:29] lifeless: hi [19:29] lifeless: wassup? [19:30] hi lifeless [19:30] oh hai, I pinged, then remembered you're on leave now, right ? [19:30] so I mailed flacoste instead :) [19:30] flacoste: hi [19:30] lifeless: ok :) [19:31] so one thing I was very worried about in the bugjam was that we'd close stuff we shouldn't, and I've forwarded you a particular mail that triggered those fears, along with a plea for some guidance to the jammers [19:33] jml: I was wondering with your testtools open bug [19:33] jml: if it was a threading correctness issue that python-on-linux handles better [19:33] hi abentley, is it possible to the owner of an mp to set its status to Approved? even if the person isn't a reviewer? [19:34] no [19:34] Ursinha, no, and we certainly don't want it. [19:34] Ursinha: if this is for tarmac, its a problem - we need to be using the merge queues facility, not the old 'lands stuff that is approved' hack [19:34] mars, ^ [19:34] abentley, I see I'm able to change the status of the mp to approved [19:35] and I'm not a reviewer [19:35] Ursinha, which mp? [19:35] abentley, this one: https://code.launchpad.net/~ursinha/launchpad/add-ec2land-rules-orphaned-branches-no-conflicts/+merge/31386 [19:35] Ursinha: you are [19:35] lifeless, a launchpad reviewer? [19:35] no [19:35] yup [19:36] Ursinha: yes, you are in ~launchpad [19:36] which is in ~canonical-launchpad-reviewers [19:36] and ~launchpad-reviewers [19:37] lifeless, ~launchpad is a subgroup of the other two, and not the inverse? [19:37] that makes no sense... [19:37] sure it does [19:37] as far as LP is concerned, all canonical lp staff are permitted to land things and review. [19:37] we use social glue for the process of learning, not technical. [19:38] lifeless, right [19:38] maybe not optimal, but thats a different discussion. [19:38] lifeless, this is for tarmac [19:38] as far as lp is concerned, you are a reviewer for lp:launchpad and lp:launchpad/db-devel/trunk [19:38] we're discussing changing lp-land to set the mp to approved, so tarmac can handle it [19:38] tarmac shouldn't need that [19:39] with the merge queue stuff [19:39] lifeless, is that implemented already? [19:39] and lp-land is the wrong time to set it, as aaron says. [19:39] Ursinha: I don't know. I shouldn't be here anyway :) [19:39] Ursinha, lp-land is all about PQM. Are you planning to make Tarmac read emails the way PQM does? [19:39] lifeless: I was just going to ask if there was a workaround for when somebody forgets to use [rollback=] in the pqm commit message that was better than just marking the bug qa-untestable temporarily. [19:40] EdwinGrubbs: no; as you can see from abentley's excellent LEP we have a lot of polish to go on the deployment magic [19:40] abentley, no, just use the same mechanism to make people able to be part of the simplify merge machinery beta [19:40] EdwinGrubbs: I deliberately closed my eyes and went 'lalalala' at the start, so that we'd have *some* deployments rather than still be building up infrastructure now :) [19:41] EdwinGrubbs: you just need to manually do the arithmetic when someone forgets a tag like that at the moment. [19:41] ok, thanks [19:41] Ursinha, Tarmac currently uses an "approved" review as a signal that it should perform a merge, right? [19:41] abentley, I believe it uses the mp status [19:41] Ursinha, I mean a status of "approved" on the whole proposal. [19:41] abentley, ah, yes [19:42] Ursinha, so this is not going to be any kind of smooth transition. Because we don't use the Approved status that way. [19:43] abentley, is the Approved status used in any way today? [19:43] Ursinha, yes. It's set when the last reviewer approves it. [19:43] abentley, and what does that mean? [19:44] Ursinha, it means that the reviewer has no major objections to landing it, but there may be some requested changes. [19:45] abentley, wait, you're talking about the queue_status or the vote status? [19:45] queue status [19:45] well [19:45] mp status [19:45] right [19:45] queue status is orthogonal [19:45] Ursinha, I'm talking about the merge proposal status. [19:45] that's the name of the property, I don't know why is that called this way [19:45] I'm going to leave this discussion in abentley's more than capable hands, and go play some wow. enjoy! [19:47] Ursinha, we could change Tarmac, or we could change our practice. I think changing our practice would be expedient. [19:48] Ursinha, So we would be changing it such that the reviewer never marks it "Approved". The submitter would do that. [19:49] Ursinha, that would give them a window to make any suggested changes. [19:49] Ursinha, and if the submitter isn't a reviewer, they would need to ask a reviewer to do that, just as they need to get a committer to land on PQM. [19:50] Ursinha, But if we're changing our practice anyway, I don't see value in using lp-land to land merge proposals. [19:53] abentley, right, so you suggest changing the practice by marking mps Approved with a different meaning, and doing that manually [19:53] Ursinha, right. [19:53] I agree lp-land isn't the right place to do that, we're trying to find more automated ways to test the smm changes [19:54] Ursinha, lp-land only exists because pqm isn't well integrated with Launchpad. [19:54] abentley, right [19:56] one final note [19:57] a team of 30 is slow to change [19:57] lifeless, what do you suggest? [19:57] you may find that new instructions will not be followed immediately, so plan for that happening. [19:57] Ursinha: myself, I'd help rockstar finish merge queues. [19:57] My understanding was that that was the plan. [19:58] lifeless, indeed, that is planned and will result in a better system. Only question is "when". [19:58] anyhow, I only popped back to make that note about inertia; folk will do the old process for some time after a change is announced [19:58] so if the system would be fragile, were someone to do the old process, then thats a risk that needs some consideration. [19:59] lifeless, one of the ideas of using ec2 land / bzr lp-land to set things up was to help with that, afaik [20:00] Ursinha, the problem is that "Approved" is already being used with a laxer meaning. If people follow current practise, lp-land can't help with that. [20:00] Ursinha, because by the time they run "lp-land" the change will already be merged. [20:01] abentley, right, got it === rockstar` is now known as rockstar [20:24] benji, ping [20:24] hey deryck, what's up? [20:25] benji, hey, is revno 12032 in devel users? Something about smoke test script? [20:28] deryck: I'm afraid I can't parse the quesiton "is revno 12032 in devel users?" [20:28] revno 12032 does contain a librarian smoke test script [20:29] benji, sorry I fail. "yours" I meant. Is it your rev in devel? Did you land it? [20:29] oh, yes, I did [20:30] benji, can I ask for qa from you for that? :-) If it gets marked qa-ok, I can deploy a revno we need and get a feature out. [20:32] deryck: sure; I'd say that it's untestable, so I'll mark it thusly [20:32] awesome. easy peasy then. [20:32] benji, thanks! [20:34] deryck: done [20:37] cool [20:47] sinzui: Uh, how did my rev roll back yours? :/ [20:47] It's not in the diff. === salgado is now known as salgado-afk === flacoste changed the topic of #launchpad-dev to: Launchpad Development Channel | BUG JAM! | New starter this week: wgrant | PQM open for business | firefighting: - | Get the code: https:/​/​dev.launchpad.net/​Getting [20:59] Morning all. [21:01] morning [21:03] morning [21:06] abentley: thumper: mumble? [21:06] wallyworld_, thumper may be delayed. [21:06] wallyworld_, see his email. [21:08] abentley: ok. we can do it later [21:09] abentley: my stupid pulse audio was not working again too, so it's reboot time :-( [22:01] sinzui: question for you on bug 684151. you say we can just change the name to remove '-secondary', but then won't it clash with the form instance at the top of the page? [22:01] <_mup_> Bug #684151: Search field at the bottom of a search results page never works [22:01] jcsackett, no, field names are not unique [22:02] jcsackett, the error is making the names unique because the ids are unique [22:02] the ids do need to be unique [22:03] sinzui: okay. question the second; how does one go about testing this, since the usual create_initialized_view and pass in "field.text" approach isn't sure to hit the right form? [22:03] the only tests for this i see are launchpad-search-pages.txt, which all go via "+search", which isn't specific to the form being used. :-/ [22:04] jcsackett, get the second form by id and verify its input type="text" element have a sane name attr [22:04] jcsackett, It can be done using the beautiful soup instance returned by get_tag_by_id() [22:05] ah, so just test the name instance, don't bother testing function from that form? [22:05] that's much easier. :-P [22:06] jcsackett, Correct. We can test the contracts provide rather than the view's processing of the data [22:06] sinzui: dig. thanks! [23:33] well that took longer than expected [23:33] thumper: this is your haircut you left for, yesterday morning? [23:34] spm: heh, no [23:34] spm: my daughter's class was going for a walk this morning [23:34] oh lovely [23:34] spm: and I went to help thinking it would be all over in 1.5 hours [23:34] spm: but no [23:34] but no. [23:35] spm: delayed further by a tree falling down on the route we took