| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| StevenK | henninge: Hi! Could you look at https://code.edge.launchpad.net/~stevenk/launchpad/archive-validate-stringfix/+merge/43496 when you have a few moments? | 09:30 |
|---|---|---|
| henninge | StevenK: Has the TeamSubscriptionPolicy any bearing on the test or ist that just noise? | 11:07 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: StevenK || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | Ah, "open teams cannot have ppas" ;-) | 11:09 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | henninge_, one quick branch for you: https://code.launchpad.net/~danilo/launchpad/bug-680044/+merge/43515 | 13:55 |
| === henninge_ is now known as henninge | ||
| henninge | danilos: looking | 14:20 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: danilos || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | henninge, changing the topic probably took longer than reviewing it :) | 14:22 |
| danilos | henninge, but thanks :) | 14:22 |
| * henninge gets back from getting a drink ;) | 14:22 | |
| === fjlacoste is now known as flacoste | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | danilos: done | 14:24 |
| danilos | henninge, thanke schön | 14:25 |
| === matsubara is now known as matsubara-lunch | ||
| henninge | ;) | 14:25 |
| jcsackett | henninge: got one for the queue for you. https://code.edge.launchpad.net/~jcsackett/launchpad/redirects-681034/+merge/43392 | 14:26 |
| === jcsackett changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: jcsackett || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | jcsackett: looking | 14:28 |
| jcsackett | thanks. | 14:28 |
| === sinzui changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: jcsackett || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | jcsackett: review done. ;) | 15:17 |
| jcsackett | henninge: cool, thanks. | 15:17 |
| === salgado is now known as salgado-afk | ||
| === salgado-afk is now known as salgado-lunch | ||
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: -,- || queue: [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| === henninge changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: sinzui,- || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | Hi abentley, Hi sinzui! I am looking at the delete-team-4 branch. | 15:51 |
| henninge | sinzui: I am a bit confused why the test uses the 'admin' celebrity while it talks about registry experts. | 15:52 |
| henninge | I saw that the target_person must be registry experts. What is the meaning of the target_person here? | 15:52 |
| sinzui | henninge, in the setup of the test to put the teams into the correct hierarchy? | 15:59 |
| sinzui | henninge, in the Test case has a member of registry admins logged in. The specific tests uses `with celebrity_logged_in('admin'):` to temporarily become and admin to place the teams in the relationship. Otherwise I would need to switch between both team owners to do the invitation dance | 16:02 |
| henninge | ah, of course | 16:03 |
| henninge | the join method is still part of the setup, I thought it was already what is being tested. | 16:03 |
| henninge | s/method/call/ | 16:04 |
| sinzui | henninge, decided not to make the teams share an owner because that case is rare and create a permission case that implementation can easily accomplish, but still be broken | 16:05 |
| sinzui | I should ad a comment about the reason in the test | 16:05 |
| === salgado-lunch is now known as salgado | ||
| henninge | sinzui: why do you import removeSecurityProxy locally? | 16:08 |
| sinzui | hmm | 16:12 |
| === henninge changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | henninge, I think this is misguided approach taken in the module. It happens several times. I dates from when we had a poor understanding of when we need to elevate permissions to accomplish a task | 16:13 |
| sinzui | I will use a single import for the whole module | 16:14 |
| henninge | sinzui: thank you. With that, r=me ;) | 16:14 |
| === benji is now known as benji-lunch | ||
| === benji-lunch is now known as benji | ||
| sinzui | abentley, do you have time to review my branch: https://code.launchpad.net/~sinzui/launchpad/mailing-list-simple-0/+merge/43522 | 18:22 |
| abentley | sinzui, sure. | 18:23 |
| === danilos changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [sinzui, danilo x 2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | abentley, I am EOD but put two (related) branches up for review; if you prefer OCR, feel free to ignore them; thanks :) | 18:26 |
| abentley | danilos, I do prefer OCR, but I'll see what I can dol. | 18:27 |
| abentley | s/dol/do | 18:27 |
| danilos | abentley, yeah, if someone else has a real OCR branch, just do it before mine | 18:27 |
| danilos | abentley, cheers | 18:27 |
| abentley | sinzui, I can't think of anything insightful to say. | 18:37 |
| abentley | sinzui, r=me. | 18:37 |
| sinzui | thanks abentley | 18:37 |
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [danilo x 2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-afk | ||
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | abentley: Are you up for reviewing a short and fairly simple branch? https://code.launchpad.net/~allenap/launchpad/bug-mail-case-sensitive-domain-bug-48464-fix/+merge/43547 | 20:29 |
| abentley | allenap, sure. | 20:29 |
| allenap | Thanks :) | 20:29 |
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | allenap, you should add to copyright years, not delete them. i.e. 2009-2010 not 2010. Unless you've removed all the code that dates from 2009... | 20:31 |
| allenap | abentley: Ah, okay, I'll fix that. | 20:32 |
| abentley | allenap, aside from that, looks good. | 20:32 |
| allenap | abentley: I never really knew how to treat them before. | 20:32 |
| allenap | abentley: Cheers! | 20:32 |
| abentley | allenap, Oh, I guess the new tests need docs. | 20:33 |
| allenap | abentley: Okay. | 20:33 |
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| gary_poster | abentley: please take a look at https://code.launchpad.net/~gary/launchpad/bug683115/+merge/43572 when you have a chance. A quick one. | 20:53 |
| abentley | gary_poster, r=me | 21:03 |
| gary_poster | thanks abentley | 21:03 |
| === abentley changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!