| === Edwin is now known as Guest64532 | ||
| danilos | henninge, can I nudge you to take a look at https://code.launchpad.net/~danilo/launchpad/bug-682186/+merge/43549 (abentley only 'needsfixing'-ed it because of a [not so tiny] lint issue :) | 09:43 |
|---|---|---|
| henninge | danilos: r=me ;) | 09:47 |
| danilos | henninge, thanks again :) | 09:48 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: pcjc2 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| jcsackett | gmb: thanks for reviewing that MP even though i hadn't thrown it into the queue. :-) | 13:25 |
| gmb | jcsackett: It was in the +activereviews queue and I was bored :) | 13:27 |
| jcsackett | heheh. works for me. thanks again. :-) | 13:27 |
| gmb | allenap: Fancy a bugjam review? | 13:55 |
| allenap | gmb: Absolutely. | 13:55 |
| gmb | allenap: https://code.edge.launchpad.net/~gmb/launchpad/fix-update-bug-watch/+merge/43643 | 13:55 |
| gmb | Code cleanup. Loverly jubbly. | 13:56 |
| === henninge_ is now known as henninge | ||
| === vednis is now known as mars | ||
| === vednis is now known as mars | ||
| bac | hi gmb. Have time for https://code.launchpad.net/~bac/launchpad/bug-662994/+merge/43647 | 14:43 |
| gmb | bac: Sure. | 14:43 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | cool | 14:44 |
| === matsubara is now known as matsubara-lunch | ||
| gmb | bac: r=me with some stylistic nitpicks | 14:57 |
| bac | gmb: great, thanks | 14:57 |
| === gmb changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | thanks gmb. fwiw, i wasn't following the PSG strictly but it wasn't as ugly as shown by the diff in the MP, which is disturbing | 15:21 |
| === salgado is now known as salgado-lunch | ||
| mars | gmb, hi, I'll be out for a while yet - have a staff meeting in Montreal I need to attend | 15:45 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| mars | gmb, unping, oops, I didn't see the topic first | 15:45 |
| === mars changed the topic of #launchpad-reviews to: On call: mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb, mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | mars: No worries; I'd just popped out to run an errand. | 16:26 |
| gmb | allenap`, deryck: If either of you have a moment for another bugjam branch, there's one here: https://code.edge.launchpad.net/~gmb/launchpad/bug-557032/+merge/43671 | 16:41 |
| deryck | gmb, I can take it. | 16:41 |
| gmb | deryck: Thanks | 16:42 |
| gmb | It's a small one. Just a merge of one of Bryce's many patches. | 16:42 |
| deryck | gmb: looks good. r=me | 16:45 |
| gmb | Ta | 16:46 |
| deryck | np | 16:46 |
| === deryck is now known as deryck[lunch] | ||
| === gmb changed the topic of #launchpad-reviews to: On call: mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars[meeting] || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars|| Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jcsackett | mars: when you're back from lunch https://code.launchpad.net/~jcsackett/launchpad/linkifier-bugs/+merge/43677 | 17:51 |
| === jcsackett changed the topic of #launchpad-reviews to: On call: mars || Reviewing: lunch || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === deryck[lunch] is now known as deryck | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: jcsackett || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === sinzui changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | mars: do you have time to review https://code.launchpad.net/~sinzui/launchpad/mailing-list-email-0/+merge/43656 | 19:52 |
| === _thumper_ is now known as thumper | ||
| abentley | mars: could you please review https://code.edge.launchpad.net/~abentley/launchpad/use-existing/+merge/43701 ? | 20:40 |
| mars | abentley, sinzui, sure | 20:51 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [sinzui, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | mars, thanks. | 20:52 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: abentley || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| mars | shortest wins | 20:54 |
| sinzui | mine is not short | 20:57 |
| mars | sinzui, yes, sorry. I'll review Aaron's, then some work with Chex, then yours | 20:58 |
| abentley | mars, a .bzr directory is a control directory, and its format is a ControlFormat. | 21:07 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| mars | abentley, ok | 21:07 |
| mars | abentley, so lines 55 and 65 are summarized as '# create the .bzr control directory' then | 21:09 |
| === salgado is now known as salgado-afk | ||
| abentley | mars, Well, except that we're actually manipulating the database. | 21:11 |
| mars | ah | 21:12 |
| mars | abentley, ok, no worries then | 21:13 |
| mars | sinzui, you are a doctest eating machine | 21:34 |
| sinzui | I am reading one right now and I cannot think why it keep repeating the same information | 21:35 |
| sinzui | I think I need to delete most if it | 21:36 |
| === matsubara is now known as matsubara-afk | ||
| mars | sinzui, is there any way to use a factory for the mailman tests instead of sample data? | 21:43 |
| mars | for the email addresses | 21:43 |
| === mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | mars, I do not think sample data is being used for any mailman test. we do not have any mailman sample data | 21:49 |
| mars | sinzui, ok. I saw the test had some specific email addresses in it, and wasn't sure if they were sample data or not. I may have not read them carefully enough | 21:56 |
| mars | sinzui, ah, I see | 21:57 |
| mars | line 558 is the difference | 21:57 |
| mars | I wasn't sure if gerbil's email was in the database or not | 21:57 |
| mars | I guess the answer is 'not' | 21:58 |
| mars | sinzui, interesting typo on line 538 as well | 21:58 |
| sinzui | mars, the messages require an email address. I prefer not to use the factory to create random data for items under test. Many tests are using removeSecurityProxy() to get the email address to create a message. I think that implies bad design | 22:09 |
| sinzui | mars, all the email addresses in the test are rodents starting with a different letter of the alphabet. | 22:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!