=== Edwin is now known as Guest64532
[09:43] <danilos> henninge, can I nudge you to take a look at https://code.launchpad.net/~danilo/launchpad/bug-682186/+merge/43549 (abentley only 'needsfixing'-ed it because of a [not so tiny] lint issue :)
[09:47] <henninge> danilos: r=me ;)
[09:48] <danilos> henninge, thanks again :)
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb || Reviewing: pcjc2 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb || Reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
[13:25] <jcsackett> gmb: thanks for reviewing that MP even though i hadn't thrown it into the queue. :-)
[13:27] <gmb> jcsackett: It was in the +activereviews queue and I was bored :)
[13:27] <jcsackett> heheh. works for me. thanks again. :-)
[13:55] <gmb> allenap: Fancy a bugjam review?
[13:55] <allenap> gmb: Absolutely.
[13:55] <gmb> allenap: https://code.edge.launchpad.net/~gmb/launchpad/fix-update-bug-watch/+merge/43643
[13:56] <gmb> Code cleanup. Loverly jubbly.
=== henninge_ is now known as henninge
=== vednis is now known as mars
=== vednis is now known as mars
[14:43] <bac> hi gmb.  Have time for https://code.launchpad.net/~bac/launchpad/bug-662994/+merge/43647
[14:43] <gmb> bac: Sure.
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:44] <bac> cool
=== matsubara is now known as matsubara-lunch
[14:57] <gmb> bac: r=me with some stylistic nitpicks
[14:57] <bac> gmb: great, thanks
=== gmb changed the topic of #launchpad-reviews to:  On call:  - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:21] <bac> thanks gmb.  fwiw, i wasn't following the PSG strictly but it wasn't as ugly as shown by the diff in the MP, which is disturbing
=== salgado is now known as salgado-lunch
[15:45] <mars> gmb, hi, I'll be out for a while yet - have a staff meeting in Montreal I need to attend
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:45] <mars> gmb, unping, oops, I didn't see the topic first
=== mars changed the topic of #launchpad-reviews to:  On call:  mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-lunch is now known as matsubara
=== salgado-lunch is now known as salgado
=== gmb changed the topic of #launchpad-reviews to:  On call:  gmb, mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:26] <gmb> mars: No worries; I'd just popped out to run an errand.
[16:41] <gmb> allenap`, deryck: If either of you have a moment for another bugjam branch, there's one here: https://code.edge.launchpad.net/~gmb/launchpad/bug-557032/+merge/43671
[16:41] <deryck> gmb, I can take it.
[16:42] <gmb> deryck: Thanks
[16:42] <gmb> It's a small one. Just a merge of one of Bryce's many patches.
[16:45] <deryck> gmb: looks good.  r=me
[16:46] <gmb> Ta
[16:46] <deryck> np
=== deryck is now known as deryck[lunch]
=== gmb changed the topic of #launchpad-reviews to:  On call:  mars[meeting] || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to:  On call:  mars[meeting] || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to:  On call:  mars|| Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[17:51] <jcsackett> mars: when you're back from lunch https://code.launchpad.net/~jcsackett/launchpad/linkifier-bugs/+merge/43677
=== jcsackett changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: lunch || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck[lunch] is now known as deryck
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: jcsackett || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[19:52] <sinzui> mars: do you have time to review https://code.launchpad.net/~sinzui/launchpad/mailing-list-email-0/+merge/43656
=== _thumper_ is now known as thumper
[20:40] <abentley> mars: could you please review https://code.edge.launchpad.net/~abentley/launchpad/use-existing/+merge/43701 ?
[20:51] <mars> abentley, sinzui, sure
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: - || queue: [sinzui, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[20:52] <abentley> mars, thanks.
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: abentley || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[20:54] <mars> shortest wins
[20:57] <sinzui> mine is not short
[20:58] <mars> sinzui, yes, sorry.  I'll review Aaron's, then some work with Chex, then yours
[21:07] <abentley> mars, a .bzr directory is a control directory, and its format is a ControlFormat.
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:07] <mars> abentley, ok
[21:09] <mars> abentley, so lines 55 and 65 are summarized as '# create the .bzr control directory' then
=== salgado is now known as salgado-afk
[21:11] <abentley> mars, Well, except that we're actually manipulating the database.
[21:12] <mars> ah
[21:13] <mars> abentley, ok, no worries then
[21:34] <mars> sinzui, you are a doctest eating machine
[21:35] <sinzui> I am reading one right now and I cannot think why it keep repeating the same information
[21:36] <sinzui> I think I need to delete most if it
=== matsubara is now known as matsubara-afk
[21:43] <mars> sinzui, is there any way to use a factory for the mailman tests instead of sample data?
[21:43] <mars> for the email addresses
=== mars changed the topic of #launchpad-reviews to:  On call:  mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:49] <sinzui> mars, I do not think sample data is being used for any mailman test. we do not have any mailman sample data
[21:56] <mars> sinzui, ok.  I saw the test had some specific email addresses in it, and wasn't sure if they were sample data or not. I may have not read them carefully enough
[21:57] <mars> sinzui, ah, I see
[21:57] <mars> line 558 is the difference
[21:57] <mars> I wasn't sure if gerbil's email was in the database or not
[21:58] <mars> I guess the answer is 'not'
[21:58] <mars> sinzui, interesting typo on line 538 as well
[22:09] <sinzui> mars, the messages require an email address. I prefer not to use the factory to create random data for items under test. Many tests are using removeSecurityProxy() to get the email address to create a message. I think that implies bad design
[22:09] <sinzui> mars, all the email addresses in the test are rodents starting with a different letter of the alphabet.