/srv/irclogs.ubuntu.com/2010/12/16/#bzr.txt

chxjust out of curiosity ,how can i use bzr blame to find the oldest surviving code in a tree?00:00
mkanatGee, that's a good question.00:20
mkanatchx: I'm betting that's plugin territory.00:20
mwhudsonespecially as i guess you'll want some heuristics00:22
mwhudson(only considering non-blanks lines for example?)00:22
chxhrm, right00:45
chxand no } either00:45
=== Meths_ is now known as Meths
mwhudsonwell, in some lesser languages, yea :)00:49
spivOr in Python code with lots of multiline dict literals ;)00:54
pooliespiv:01:08
poolie<vila> oh, and I tried to warn spiv this morning but he was gone, his patch changing the branch creation signatures broke loom01:08
poolie<vila> I didn't have time to look at that but I'm afraid that will mean some hard compatibility issue for such plugins: 2.3 XOR the rest01:08
spivNo, I don't think it's a hard compatibility problem, I thought I'd already chatted with vila about this.01:11
spivImplementations of BranchFormat.initialize etc need to accept a new optional keyword arg.01:12
spivThat won't impact their compatibility with old bzrlib versions at all.01:12
=== zyga is now known as zyga-gone
pooliespiv, well, from what he said it was actually breaking looms01:20
pooliei have not tested  myself01:20
spivI just made the small patch to bzr-loom it needs to be compatible.01:32
pooliegreat01:33
spivCompatibility with older bzr is unaffected.01:33
spivhttps://code.launchpad.net/~spiv/bzr-loom/bzr-2.3-compat/+merge/4385101:35
poolie:)01:35
mkanatWhy does bzr seem to print spaces out to the right side of the terminal for some things that it prints to the terminal?01:44
mkanatI'd think that it was just my terminal, except that it's only the first and last line of the commit output.01:44
fullermdMaybe where it had printed a progress bar, so had to put spaces to cover it up?01:45
mkanatfullermd: Oh, that could be, yeah.01:45
poolieprobably that02:01
Chris79Hi, anyone here using the bzr-eclipse plugin with eclipse helios on win 7? I have trouble committing / updateing a project pulled from a remote bzr repo. Thanks for you help!06:23
vilahi all !07:07
vilapoolie: thanks for the pqm email !07:07
vilapoolie: I have *no* idea what is happening there though... never saw this kind of failure07:08
vilait may be another isolation issue uncovered by my fix...07:09
mgzmorning vila.07:10
vilamgz: hey !07:11
mgzjust looks like doctest isolation vila?07:16
vilamgz: now you're really reading above my shoulder ! This is in a private mail from poolie, how on earth can you see that ? :D07:17
mgzas in, you accidentally provided some.07:17
mgzit's in the mp!07:17
vilalol, pfew, I feel better :D07:18
vilaok, so I accidentally provided what ?07:18
mgzsome isolation :)07:19
vilaha ! yes, that's the idea07:19
poolieon phone atm07:19
poolieperhaps we should look at tarmac now07:19
vilaI'll have a look today07:20
vilamgz: given the order of the tests, that sounds right, and id didn't fail here because I have (as almost everybody running the tests) a valid whoami07:22
vilain my home directory07:22
vilawhich is now reached because BZR_HOME has been cleared07:22
mgzyup.07:22
mgzannoyingly the proper fix here is moderately hard.07:23
vilathat's exactly the type of failure I was afraid of and why my fix may seem very shallow but the problem is deeper07:23
vilajust a sec07:23
pooliedon't know if it's actually going to fix this type of issue07:23
mgzall the bzrlib.tests.TestCase.setUp code needs factoring out into a method that can be passed to the doctest constructor07:24
vilapoolie: no, in fact it will *uncover* other occurrences of this type of issue07:24
poolieis that good?07:24
vilayes07:24
vilaotherwise we don't test what we think we test07:25
mgzbut it was nice ignoring the fact doctests were borked vila :)07:25
vilamgz: hehe, we could just delete them :D07:25
vilakidding ! I don't want to start a religious discussion about doctests so early in my day :D07:26
mgzI'll bump the doctest bug up my todo list, can you hack around this failure by adding some whoami setting line to the doctest that fails?07:27
mgzideally without further breaking the underlying environment...07:27
mgznow I need to go get ready and things.07:27
vilahttps://code.launchpad.net/~vila/bzr/690563-better-env-isolation/+merge/4387107:28
vilamgz: as soon as I reproduce it (my pqmlike setup was broken, fixing it right now)07:29
vilapoolie: feedback on the above would be good (mgz too if you're still there), I don't want to land as is, but don't want to deploy to be said after the fact "Oh, why didn't you use *this* name instead ;)07:30
vilajust added a comment explaining one dormant bug we have today07:31
pooliesure, i was going to do a couple more reviews07:34
poolievila are you going to clean up the existing methods and their users?07:36
poolieor add an alternative?07:36
pooliei'd like the first a bit more07:36
vilaMy plan is to first remove all uses of _captureVar in the code base07:37
vilathen I can cleanup further but I suspect some plugins may be using _captureVar and there I don't know if I should deprecate or delete it07:37
vilaI think I'll probably go with several submissions to address and discuss each controversial point one by one07:39
vilaI smell bike-shedding coming up at least as hard as the import saga ;D07:40
poolieon the environment stuff? i doubt it07:41
vilapoolie: smooth_upgrade still on your list ?07:41
poolievila, mgz: can i get you two to agree on https://code.launchpad.net/~gz/bzr/add_two_in_unicode_cwd_686611/+merge/4315207:41
vilamgz, poolie : yeah, can you agree ?07:41
vila:D07:41
poolieit is still on my list07:42
vilamgz: more seriously, what do you have in mind here ? I'm open to patches on any stable branches (it's simple enough), the main problem I mentioned was merging up to trunk but even if you plan a different fix for trunk, handling the merges yourself will be the simplest (unless we do it in sync via discussion here)07:43
pooliewhat does "with a boolean False path" mean there?07:46
poolieoh i see, meaning if we call it with ''07:49
poolievila, will merging that to 2.0 actually make things harder when we merge up? why?07:52
vilapoolie: only the NEWS related part is messy especially when we cross 2.2 -> 2.307:54
poolieok07:54
pooliebut, generally speaking, we are still going to fix things in 2.207:54
poolieso we have to cross that07:54
vilabut even the 2.0 -> 2.1 doesn't merge that cleanly if news_merge is not configured07:54
poolieit's not a reason not to merge any particular change?07:54
vilanot at all07:54
poolieok, so i approved that with tweaks07:54
vilathe one doing the merge should just be aware of the issue07:54
* mgz returns08:03
mgzwill comment on both those mps.08:07
vilamgz: ok08:07
mgzI'd be happy to do the merging up if it'll be particularly painful vila.08:07
vilamgz: error prone more than painful, which is why I mentioned it08:08
vilamgz: is there a bug filed for doctest isolation ?08:42
mgzit's bug 32132008:43
ubot5Launchpad bug 321320 in Bazaar "bzr's doctests are not isolated (branchbuilder doctests check global gpg configuration)" [High,Confirmed] https://launchpad.net/bugs/32132008:43
vilamgz: if you dont' know... 8-) Rock & roll !08:43
vilamgz: http://paste.ubuntu.com/544336/ is enough to fix the failure I'm encountering while trying to land bug #690563 fix08:45
ubot5Launchpad bug 690563 in Bazaar "bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local failure" [Medium,In progress] https://launchpad.net/bugs/69056308:45
mgzthat's the sort of thing I meant, yep08:46
vilamgz: sounds ok to land with this workaround until we fix 321... ok08:46
poolievila, ok, upgrade thing is reviewed08:46
mgzyou'll then be leaking that envvar again, but... that's only what we were doing before anyway08:46
vilapoolie: ok, I'll tweak as much I feel reasonable and land it then08:48
vilamgz: damn, you're right ! ... and wrong too, I should not let this leak happen, hmm08:49
mgzimport osutils instead and use set_or_unset twice?08:50
vilahow does one disable a doctest ?08:50
vilamgz: would still be too brittle for my taste08:50
mgzno easy way to disable them, apart from changing the syntax so the scraper doesn't spot them08:51
vilaoh easy, I would just comment out branchbuilder in the list of doc tests with a ref to 321320 to fix it08:51
mgzah, or that works.08:51
vilaI'll add a comment to that effect to the bug08:51
mgzhow am I spelling my name in news these days...08:51
poolievila that would be great, thanks08:52
vilamgz: unicode bug cruncher would be appropriate ;D08:52
vilamgz: a bit restrictive though...08:53
poolie:)08:53
poolieok, i should go08:54
vilapoolie: enjoy your evening ! And thanks for the reviews !08:55
mgzbye poolie!08:55
vilamgz: so this will be http://paste.ubuntu.com/544345/, still ok ?08:59
vilagrr, fill-paragraph is too agressive, the bzrlib.branchbuilder should be on its own line09:00
mgzLooks fine. Could explicitly state it involves no user being set in the environment.09:00
vilaindeed !09:00
viladone09:01
mgzI've pushed up NEWS for the bug 686611, could I ask you to look at it again and maybe land it for me vila?09:04
ubot5Launchpad bug 686611 in Bazaar 2.2 "`bzr add file1 file2` in non-ascii folder fails, but `bzr add file1` works" [Low,Confirmed] https://launchpad.net/bugs/68661109:04
mgz+fix09:04
vilaubot5: why the hell are you choosing 2.2 when most of the discussion is whether we start fixing it in 2.0 ???09:07
ubot5Error: I am only a bot, please don't think I'm intelligent :)09:07
vilaubot5: I wasn't implying anything...09:07
ubot5Error: I am only a bot, please don't think I'm intelligent :)09:07
mgzit's possibly the last milestone I added to the bug?09:08
mgzit's a little odd it picks that one though.09:09
vilano big deal :) I was just surprised and wondered if *you* had changed your mind (sent to pqm)09:10
vilaa fix for 'lost connection during test' will make me so happy... ;D09:16
mgzurk, running out of time, will have to file paths bug later.09:27
vilaspiv: oh ! Thanks for the loom fix ! Sorry to mention it so late, I was thrilled when I read the irc log !09:28
vilamgz: let me know about where you end up merging this fix up09:28
vilamgz: I expect it to be a bit stretched along the day if you wait for pqm09:29
mgzvila: yup, and I'll put them in the review queue anyway as I can only submit to bzr.dev09:31
mgzwill start some time early afternoon when I get back.09:31
vilamgz: really ? We should fix that09:31
vilamgz: ok09:31
vilagrr, one more pqm failure without mail :(10:04
vilamgz: if you're still around may be you can submit for me ;)10:09
taconehello, i need a quick way to check if bzr is locked. anyone ?10:28
Pengtacone: bzr info, if you're really asking about the lock status of a bzrdir.10:42
taconeyes, that. thanks !10:43
=== Leonidas_ is now known as Leonidas
=== zyga is now known as zyga-food
mgzack, vila, sorry, I didn't notice, you commented the wrong line to skip that doctest14:36
mgzyou want _test_suite_modules_to_doctest 'bzrlib.branchbuilder'14:37
vilano ???14:37
mgzbut did _test_suite_testmod_names 'bzrlib.tests.test_branchbuilder'14:37
mgzthat'll fix that and I'll send to pqm so we get the output in case it complains again14:38
vilaand I'm banging my head on an apport failure for nothing ?14:38
mgz(personally, I'd do that as a seperate branch, first, then send lp:~vila/bzr/690563-test-isolation without that change on it at all.14:38
vilawhy ?14:39
mgzit's not really related, and wants to be backed out in the future. also, if that change is wrong, 's more obvious pqm'ed seperately14:40
mgzI don't think it matters much in this case.14:40
vilait *is* related, the change *uncover* the problem14:40
mgzright, but say, for example, the wrong line was commented out.14:40
mgzhaving a pqm run first just for that workaround makes it more obvious we've just lost a bunch of tests.14:41
mgz(just... babune would be clearer, but doesn't run each change)14:41
vilayeah :-/ I don't know what happened, I clearly remember seeing your comment on _modules_to_doctest...14:42
mgzbrains are funny things.14:42
mgzsometimes they work, sometimes...14:42
vilaright, that's a bit excessive I think, it will also clutter the bzr.dev history plus I'm almost ready to submit a more robust alternative (while also realizing there is an even more robust one possible ;-/)14:43
vilawhat was the problem with apport tests last time ?14:44
vilaor was it maxb ?14:44
maxb?14:45
mgzhefixedit.14:46
mgzsee bug 68643914:47
ubot5Launchpad bug 686439 in Bazaar "easy_install breaks due to SandboxViolation on SLES" [Medium,Fix released] https://launchpad.net/bugs/68643914:47
vilapython -Werror -O ./bzr selftest -s bt.test_crash fails reliably on my pqmlike host14:47
vilaI thought that was why my submission was failing and start bisecting like crazy until I realize it was related to '-Werror -O'14:48
mgzah, different thing.14:48
* vila bangs ahead a bit nore14:50
vilapython2.5 only so unrelated to pqm14:50
vilamgz: I've filed an RT about pqm access, I'll keep you informed (but the admins are quite busy these days ;-/)14:52
vilamgz: your fix has landed for 2.0, tell me when you're ready for 2.114:54
mgzjust doing it now.14:54
mgzvila: https://code.launchpad.net/~gz/bzr/merge_2.0_to_2.1/+merge/4391315:01
PengThe admins are too busy? Sounds like somebody needs to have their sleeping privileges taken away.15:02
=== Ursinha is now known as Ursinha-brb
vilaPeng: that the problem with admins: they are the ones handling the privileges15:02
=== zyga-food is now known as zyga
fullermdHow does one go about aquiring these "sleeping privileges" of which you speak?15:12
vilamgz: sent to pqm15:19
mgzthanks!15:19
vila. o O (Damn, no he will be suspicious about his lack of sleep)15:19
vilas/no/now/ shudder tyop ekoj15:20
lvhHi!15:50
lvhI'm ordinarily an Emacs user, but if I want to try bzr with Eclipse/Pydev, should I use the Eclipse-Bzr plugin or the QBzr plugin?15:51
jamlvh: AIUI eclipse-bzr has closer integration, but qbzr has more total polish15:54
lvhjam: Hm, okay.15:55
lvhjam: I'll try both and see what happens.15:55
lvhjam: It's not the case that one is particularly deprecated/bad, right?15:55
vilajam: good morning !15:55
vilamgz: yeeeeehaaaa, one more blue target on babune ;)15:56
vilamgz: 2.1 landed15:57
mgzcool! will do the next merge step.15:57
jammorning vila15:57
jamI'm very happy that we're really close to getting lp-forking-service rolled out on qastaging.15:58
mgzblue macs mean I could feasably tackle the filesystem normalisation issue.15:58
jamthe service is installed and running, and the mp is submitted to activate it15:58
vilajam: yeeehaaa ! :D15:58
vilamgz: or submit your fixes to turn the windows one blue ;)15:59
jamfullermd: sorry, no sleeping priviledges are available at this time. Please submit form INTS5525. Expect processing to take 1-5 weeks.15:59
mgzyeah, to many things not enough time.15:59
vilaI know :)15:59
mgz+o16:01
vila+o..... female symbol turned clock-wise ? some unknown smiley ? /me facepalms tyop ! to+o :D16:05
mgzright :)16:06
mgzyou can sort of parse what I said with the wrong too? but the meaning is different16:08
mgzvila: https://code.launchpad.net/~gz/bzr/merge_2.1_to_2.2/+merge/4392516:08
vilawell, my parser is tolerant to some form of typos :)16:08
=== deryck is now known as deryck[lunch]
vilamgz: sent16:09
mgzthanks! I can do the last one myself, but will probably bug you anyway to check I've understood spiv's split correctly.16:10
vilamgz: and now the tricky one :) You'll have to update the doc/en/release-notes manually during the merge16:10
vilabecause NEWS -> doc/en/release-notes/bzr-2.3.txt which produces horribly wrong merge results16:11
vilagaryVDM ! gary ! gary ! Come back !16:12
=== beuno is now known as beuno-lunch
hallyn_Hi,  when i try to do a 'bzr merge-upstream' from a packaging tree, i get:16:33
hallyn_bzr: ERROR: Merge upstream in merge mode is not yet supported.16:34
hallyn_will it do any harm if i temporarily remove 'merge = True' from .bzr-buildddeb/default.conf ?16:35
jelmerhallyn_, hi16:37
jelmerhallyn_: if you're trying to run "bzr merge-upstream" I wonder if you should need "merge = True" at all16:37
jelmerhallyn_, Does your packaging branch contain the upstream source code ?16:37
hallyn_no16:38
jelmerhallyn_: "bzr merge-upstream" will add the upstream source, is that what you're trying to do?16:38
hallyn_upstream source code is in lp:vmbuilder, the packaging branch is at bzr+ssh://bazaar.launchpad.net/~vmbuilder-dev/vmbuilder/packaging/16:38
hallyn_heh, i don't know.  i didn't create the trees, i inherited them16:38
hallyn_i'm just trying to build a package to propose for archive, based on the new pacakaging and source trees16:39
jelmerhallyn_: So you mainly want to add a new changelog entry for the appropriate revision in lp:vmbuilder /16:39
jelmer?16:39
hallyn_i did that16:39
hallyn_now i want a bzr command in place of building a source package and asking someone to dput that.  i.e. somethint to create a tree that someone can review and sponsor16:40
hallyn_AIUI that was bzr merge-upstream...16:40
jelmerhallyn_: Ah, ok. You're probably after "bzr builddeb -S"16:40
jelmerhallyn_: "bzr merge-upstream" merges in an upstream revision and updated debian/changelog appropriately16:41
hallyn_no, that creates the package which i then have to scp somewhere for someont to look at out of band16:41
jelmerhallyn_: So you'd like to propose a merge that somebody can review?16:41
hallyn_right, what i want is a bzr tree which someone can review and sponsor as though it had been a package16:42
hallyn_if that makes any sense at all16:42
hallyn_(sorry, terrible network lag due to sync)16:42
hallyn_yes16:42
jelmerhallyn_: yep - I think "bzr lp-propose" should do that, or you can click "Propose for merging" on the branch web page16:42
hallyn_awesome, let me try that, thanks16:43
hallyn_well no, wait16:43
* hallyn_ wonders why hundreds of megs are being xferred to sync one changed U1 file)16:43
hallyn_jelmer: i guess where i am confused is that this is not the actual source tree.  I'ts *just8 the packaging tree with only the contents of debian/16:44
jelmerhallyn_: You would propose your branch for merging into the packaging branch16:45
jelmerhallyn_: The upstream branch is only used by "bzr builddeb" and should not be relevant here16:45
hallyn_the packaging branch being which?16:45
jelmerlp:~vmbuilder-dev/vmbuilder/packaging/16:46
hallyn_IIUC i've already pushed the change into the packaging branch16:46
hallyn_ok, yes16:46
hallyn_i own that.  So now the next step is actuallyuploading the resulting package to the archive16:46
jelmerhallyn_: The only way to do that is to create a source tarball and upload it16:46
hallyn_jelmer: ok, thanks.  i think the hope was for there to be a single bzr tree containing source+packaging which could be diffed for whoever sponsors the package upload.  But I guess that doesn't quite fit into this setup16:48
=== dbarth_ is now known as dbarth
=== deryck[lunch] is now known as deryck
vilamgz: 2.2 landed17:28
mgzpull me push you.17:28
vilatoo bad, I missed the joke ;-/17:29
=== beuno-lunch is now known as beuno
vilamgz: by the way, you've got a mac ?18:20
* vila revises his beliefs...18:21
=== smoser is now known as smoser`
=== smoser` is now known as smoser
mgzvila: no. I have babune!18:35
vilaLOL18:35
vilaI should definitely make it easier to use selftest-subset then :)18:35
mgzwhat's bug 687653 about ubot5?18:51
ubot5Bug 687653 on http://launchpad.net/bugs/687653 is private18:51
mgzvila: does this look about right? http://paste.ubuntu.com/544559/18:54
vilamgz: pretty much, but I think we don't copy the new entry across the 2.2/2.3 barrier (cooking time here, but check what I did with ... can't remember, last merge from 2.2)18:57
mgzah, I see what you mean.19:01
mgzso I can just revert doc/en/release-notes/bzr-2.3.txt19:01
lifelessmgz: hola19:35
mgzshazam.19:35
lifelessmgz: I think jam is preoccupied atm19:35
lifelessmgz: so we should decide if its environmental or not, and move forward accordingly19:35
jamlifeless: sorry, I'm missing the context19:36
jamtesttools stuff?19:36
lifelessjam: yes19:36
lifelessjam: we can't reproduce the problem19:36
mgzjam, can you just run that test and still repo the random failure?19:37
jamlifeless: k. Fully reproducible here, what would you like from me19:37
jammgz: what test?19:37
jam(i'm missing something from the traceback, I guess)19:37
mgzthe one that fails.19:37
jamjust the failing one?19:37
lifelessjam: probably drop into pdb and see whats going on19:37
lifelessmgz has a crazy theory about twisted but I think thats ... crazy :)19:38
jamlifeless: is there a new testtools I should be using?19:38
mgzotherwise yeah, stick a breakpoint in the __str__ method and step out from there to see what happens19:38
lifelessjam: just tip19:38
lifelessto run a single test, python -m testtools <testid>19:39
lifelessgrah19:39
lifelesstesttools.run <testid>19:39
lifeless[doesn't work for scenarios yet, but the failing test wasn't a scenario test anyhow IIRC]19:39
lifelesswhat seems to be different to me is that we get just the class name, not the <..> sutff19:41
mgzyup. which implies either the exception doesn't propogate, or that __str__ method is never called and something else stringifies it.19:42
jamlifeless: so I'm sitting here, and I can paste the output19:45
jamwhat are you looking for?19:45
jamlifeless: also note, you are doing "raise UnprintableError"19:46
jamnot "raise UnprintableError()"19:46
jamI don't know if that matters19:46
jamlifeless: http://paste.ubuntu.com/544575/19:47
jamIf I just run the test and capture the 'stream.getvalue()' that is the traceback the test runner sees19:47
jamIf I create the class in a python interactive shell19:47
jamand raise it19:47
jamthat is what I see19:47
jamI'm assuming something in testtools is supposed to be catching the error for formatting and isn't?19:48
jamAren't you just using traceback.format_exc() ?19:48
mgznope, this is the whole point of these tests.19:48
mgzthey need to be going through TestResult._exc_info_to_unicode19:49
lifelessformat_exc generates non-local-encoding bytestrings19:49
mgzso, if you do that same microtest, but try/except round the raise and pass to testtools.TestResult()._exc_info_to_unicode do you get the same final line?19:52
mgzbecause that's what your test failure imples.19:52
mgz+i19:52
mgzeither that, or it's somehow escaping that method.19:53
jammgz: I'm trying to get there, but you also need a test case19:54
jammgz: are you saying inside the created file?19:54
mgzor just on the terminal19:56
mgzputting a break point anywhere before or during the actual test run would also work, but there are a lot of testtools levels to step through, and the fact these tests use generated files probably isn't helping any19:58
jammgz: using this hack: http://paste.ubuntu.com/544580/19:58
jamI get this: http://paste.ubuntu.com/544581/19:58
jamprinted to stdout19:58
jammgz: so yes, testtools.TestResult._exc_info_to_unicode(exc_info, ...) is generating output that only has the class name19:59
mgzokay, that's borked. step into the execution of that call?20:00
mgzyou should end up in testtools.compat20:00
mgzif you didn't, all the other tests would fail...20:01
jammgz: at what point?20:01
lifelessmgz: jam's query is interesting20:01
lifeless            testline="raise UnprintableError")20:01
jamthe immediate jump is to unittest._exc_info_to_string20:01
lifelessaren't you meant to construct things always, these days ?20:01
mgzdoesn't make any difference.20:01
jamlifeless: I think you are, but it doesn't seem to change the tracebacks20:01
lifelesskk20:02
jamAt least manually doing "raise Foo" and "raise Foo()" gave the same results20:02
mgzso jam, what should happen is from testtools.compat._format_exc_info the exception instance is passed to testtools.compat._exception_to_text to do the stringifying20:03
jammgz: (Pdb) tr._exc_info_to_unicode.im_func.func_globals['traceback']20:04
jam<module '__fake_traceback' (built-in)>20:04
mgzoooo... I wonder if there's a __unicode__ method screwing me up here?20:04
jamwhich looks like it is properly overriding the thing you want to20:04
jammgz: when I step through it, I've gotten into the testtools.compat._format_exc_info20:06
mgzjump forward to near the end and the _exception_to_text call20:07
mgzhm, no __unicode__ issue on 2.6.6 at least: http://paste.ubuntu.com/544585/20:08
jammgz: if I'm doing it right, for some reason at the point of "svalue = _exception_to_text(evalue)" the evalue is None20:08
jameven though there is an earlier "if evalue is None: return"20:08
jamah wait, probably just a bug in "pp evalue" in the debugger20:08
jamsince this class isn't printable20:08
jammgz: unicode(evalue) returns20:09
jamunicode(evalue) == u''20:09
mgzException.__repr__(evalue) would give you feedback if pdb has issues20:09
mgzokay, that's bad and wrong, and the bug.20:09
mgzI'll defend the test from it.20:09
jammgz: so is this just a bug in python 2.6.4 then?20:10
jam(Pdb) evalue.__unicode__20:10
jam<built-in method __unicode__ of UnprintableError object at 0x025732B0>20:10
mgzI presume they added a seperate __unicode__ method to the base Exception class... then removed it again.20:10
lifelessyes20:10
lifelessI thought I mentioned that the first day ;)20:10
mgz...you did? where did you ;_;20:10
lifelesshere20:10
mgzthanks jam! you have been very patient with me.20:11
lifeless /lastlog futzed|changed might find my comment20:11
lifelessI'm not 100% sure I did - but there is a python bug on __unicode__ in Exception in 2.6.x20:11
vilalifeless: by the way, when do you plan to push a debian release of python-testtools ? Our MRE/SRU is blocked on that so far (in short)20:12
lifelessvila: when we can release20:12
jammgz: http://mail.python.org/pipermail/python-bugs-list/2006-September/035171.html20:12
lifelessvila: which is why I'm talking to mgz and jam now20:12
vilalifeless: great, so this will be 0.9.8 ?20:12
mgzI'll put a branch up now avoiding that.20:12
lifelessvila: something like that20:13
jammgz: I assume you can just add "def __unicode__(self): raise RuntimeError"20:13
mgzyup, that's what I'll do.20:13
val_ping vila20:16
mgzlifeless: https://code.launchpad.net/~gz/testtools/avoid_exception_unicode_method_bug_689858/+merge/4396720:23
lifelessjam: can you confirm that that passes?20:23
jamruns clean20:25
jamlifeless, mgz: ^^20:25
lifelessthanks20:25
lifelessI'll pull it in and do a release later today20:25
=== Ursinha-brb is now known as Ursinha
=== Ursinha-afk is now known as Ursinha
mgzha, lifeless, I see you even commented in the bug for the __unicode__ method backout20:54
lifelessmgz: yes, this is why I was able to mention it easily :)20:54
lifelesswhat was the issue number again ?20:54
mgzhttp://bugs.python.org/issue610820:54
mgzjust adding note to the bug so I have a record.20:55
lifelesscare to put that as a note in the branch too ?20:56
lifelessspiv: ^ btw, thats why we override __unicode__20:57
lifelessspiv: or something20:57
mgzdone.20:59
mgzquite glad I ran into this now, I'm fiddling with unicode and exceptions in bzr currently.20:59
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
renatosilvahow to resolve conflicts in bynary files?22:02
renatosilvabzr status is showing as removed and unknown even if I bzr resolve binfile (where binfile is the right one, resolved)22:03

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!