/srv/irclogs.ubuntu.com/2010/12/16/#launchpad-dev.txt

wallyworldbac: ack00:00
StevenKbac: Sorry, we were afk discussing a feature00:09
wallyworlddo i recall correctly that there is no need for GoogleServiceLayer anymore? ie we are not using any google apis anywhere?00:53
wgrantWe still use it for search.01:02
wgrantJust not for maps.01:02
wallyworldok. thanks. a test i was running timeout out waiting for setup() so i was just wondering01:04
pooliecan someone answer out of hand abentley's question on https://code.edge.launchpad.net/~mbp/launchpad/690021-rlimit/+merge/4373301:19
poolieif a scan branches job aborts unexpected (is killed by rlimit) what will happen?01:20
pooliewill the jobs be failed, or re-run?01:20
pooliewallyworld: ^^ do you know?01:40
wallyworldpoolie: i think any branches that haven't been scanned yet would need to be rescanned, but i'm not 100%01:41
wallyworldpoolie: the scan branches job is just a cron script so shouldn;t any branches not scanned when the job is killed be picked up next time the job is run?01:43
pooliei would have thought so01:44
pooliei guess they may just fail repeatedly01:44
poolieif it scans multiple branches in a single process invocation this might mean that we get stuck with none being scanned?01:44
pooliethis is probably still an improvement over the whole machine bogging down though01:44
wallyworldi'm wondering about the same thing myself01:44
wallyworldpoolie: each python BranchScanJob instance works on a single branch but i'm not sure how these are invoked from the calling script ie if one fails, does it continue with the others01:53
* poolie looks02:00
poolieyeah it's not obvious to me yet02:14
poolieit looks to me like if we kill the process, it will still be seen as running02:17
poolieoh i guess we could just look at what has actually happened recently to the scanner02:18
pooliei don't suppose there are docs of the lp jobs system?02:26
poolieah, some in https://dev.launchpad.net/Foundations/JobSystem02:26
wallyworldpoolie: tim would be able to provide an immediate answer but he is away till monday02:28
pooliei will request a review from him and sit on this until then02:29
* wallyworld sad - lost power, huge thunder storm, limited internet connectivity :-(03:21
spivwallyworld: http://www.bom.gov.au/products/IDN65152.shtml has a fun diagram03:24
mwhudsonheh yes03:24
wallyworldspiv: yeah, and my wife has the car and it can't be put under cover :-(03:24
wallyworldlucky i got a 3G modem for these type of emergencies03:25
wallyworldthe rain here is pissing down03:25
wgrant"This thunderstorm is very dangerous"03:50
wgrantNot something I thought I'd hear from the BoM.03:50
spmwallyworld: aarnet lost au.mirror... so you're not alone03:51
wallyworldspm: sucks for them and me :-(03:52
wgrantI want a storm :(03:54
wgrantMaybe not quite that big.03:54
wgrantBut it's getting disappointingly warm down here.03:54
wgrantlifeless: Hah, I win. Soyuz is out of the top-10 timeouts.03:57
wallyworldwgrant: where are you?03:57
wgrantI am safe for now.03:57
wgrantwallyworld: Melbourne.03:57
wgrantit's been nice and rainy the last couple of weeks.03:57
wgrantBut this week is fairly warm.03:58
pooliehuge thunderstorm here too03:58
wallyworldwgrant: well you know what they say about mne - 4 seasons in one day - careful what you wish for03:58
poolie*by sydney standards, would be a shower in bne03:58
wgrantTrue, true.03:58
wallyworldpoolie: :-)03:58
wallyworldworst part about having no power - it's way past my afternoon coffee time :-(04:15
StevenKwallyworld: Coffee shop?04:19
wallyworldi think the whole suburb is out04:19
wallyworldit would be a looong drive and the window doesn't win up properly on my 2nd car which is a bomb04:20
wallyworlds/win/wind04:20
lifelesswgrant: till jan 17th04:26
wgrantlifeless: :(04:41
lifelesswgrant: something real small would be to add a garbo job populating bugmessage.index04:43
wgrantlifeless: Sadly Steve and I hae something real big.04:44
lifelessfun times!04:45
wgrants/hae/ha[tv]e/04:45
StevenKHate seems more appropos04:45
StevenKapropos, even04:45
* wallyworld about to disappear. laptop battery almost dead :-(05:16
* nigelb congratulates lp folks on new team structure :)05:39
poolie:)05:53
=== almaisan-away is now known as al-maisan
wgrantwallyworld: You have power again?07:55
wallyworldwgrant: yeah. i decded to go out and find a coffee shop with power (there were several suburbs without) and when I got back, it was on again \o/07:56
wallyworldjust turned out the cricket to take a peek - not good for us :-(07:56
wgrantExcellent!08:00
wgrantAnd I don't care about cricket :P08:00
wallyworldwhat? shame on you!08:03
mrevellHi09:17
danilosbigjools, hi, do you have a minute to chat about bug 685624?11:51
_mup_Bug #685624: Translation template build jobs should use the new BuildFarmJob <lp-soyuz> <lp-translations> <Launchpad itself:New> < https://launchpad.net/bugs/685624 >11:51
bigjoolsdanilos: 60 seconds and counting11:51
henningedanilos: I was just about to ping you ...11:52
danilosbigjools, I am hoping for a mumble chat11:52
bigjoolsdanilos: ok give me 5 mins11:52
daniloshenninge, should be quick, I am on a countdown11:52
daniloshenninge, heh, so, what's up with you while I am on hold for Julian? :)11:53
henningedanilos: the test for setCurrentTranslation is failing and i don't understand why this is supposed to work this way.11:54
daniloshenninge, I am guessing because of makeCurrentUbuntu/makeCurrentUpstream changes11:55
henningedanilos: no, it is related to my "fix" in setCurrentTranslation I believe.11:55
daniloshenninge, oh, you should not have changed setCurrentTranslation lightly11:56
henningedanilos: line 183 in test_setcurrenttranslation.11:56
henningedanilos: well, it is pretty isolated to other_side sharing but that is what is failing now.11:56
daniloshenninge, some of the decisions in setCurrentTranslations are relatively arbitrary (i.e. we could have gone either way since it doesn't matter too much), but most of the critical ones are not11:57
henningedanilos: I don't understand why "the sharing policy has no effect"11:57
daniloshenninge, I'll have to thing carefully about this particular case though11:57
henningedanilos: please do ;)11:58
daniloshenninge, so, just to confirm we are looking at the same thing, it's test_c_None__n_None__o_shared__follows11:58
henningeright11:58
henningedanilos: but there are a couple more failing11:59
henningedanilos: all with "__follows"12:00
henningethat's what sets "share_with_other_side" on setCurrentTranslation12:00
henningesets to *True*, obviously12:00
bigjoolsdanilos: wake up12:00
danilosbigjools, coming12:01
daniloshenninge, be right back12:01
deryckMorning, all.12:03
daniloshenninge, ok, back to you12:07
daniloshenninge, well, you did invert the logic in setCurrentTranslation completely for a few things :)12:07
daniloshenninge, well, maybe not12:08
daniloshenninge, I see you tried to move makeCurrent stuff into it though12:08
henningedanilos: what do you mean?12:08
daniloshenninge, btw, I think your change for translation credits is wrong as well: translation credits does need to read explicitely from the upstream side12:09
daniloshenninge, well, unsetting of the flag that makeCurrent* methods used to do12:09
daniloshenninge, so, here's what I think we should do: keep makeCurrent* methods and switch them to the new model by using explicit UPSTREAM for getImportedTM and UBUNTU for getCurrentTM methods12:10
daniloshenninge, note that we should not make those calls side-sensitive since it's obvious makeCurrent methods are already using the new model (just like the translation credits message is)12:10
daniloshenninge, they are only using getCurrent/getImportedTM methods in a low-level way (explicit side requests, not expecting them to be side-aware)12:11
henningedanilos: hm, getCurrentTM *is* explicit about sides anyway.12:11
henningedanilos: I am not sure about keeping makeCurrent around.12:12
henningedanilos: I just think that my change to setCurrentTranslation was not correct12:12
daniloshenninge, well, makeCurrent* is directly used by setCurrentTranslation (I didn't know that), which means that it's an integral part of the setCurrentTranslation design12:12
daniloshenninge, please, don't try to fix setCurrentTranslation *now*12:13
daniloshenninge, if you remember, we spent days on designing, implementing and providing tests for it12:13
daniloshenninge, so, if shareIfPossible and makeCurrent* are used by it, they are "new model" methods and we should keep them12:13
henningedanilos: but I, too, remember that makeCurrent* was a temporary solution.12:14
daniloshenninge, perhaps, but as a step from, if you remember, DB triggers!12:14
daniloshenninge, they are still improvement enough over DB triggers12:15
daniloshenninge, and we can worry about getting rid of them later, they are not critical and require much careful consideration which I'd rather not do right now :)12:15
daniloshenninge, if you feel you can do that, make sure you do it without changing any setcurrenttranslation tests :)12:16
henningedanilos: well, I see which part of my change makes that test fail.12:16
henningeI just still don't understand why it's supposed  to work this way.12:16
daniloshenninge, and make sure you back out this change: https://pastebin.canonical.com/41104/12:17
daniloshenninge, the problem with how setCurrentTranslation is supposed to work is that it has many different conditions and they are hard to get unless you consider the whole picture12:18
henningedanilos: ah yes, I was guessing there ...12:18
daniloshenninge, that's why we have constructed a matrix of things that need to happen, and you can read it on https://dev.launchpad.net/Translations/Specs/UpstreamImportIntoUbuntu/FixingIsImported/setCurrentTranslation12:19
henningedanilos: actually, reading the code for setCurrentTranslation last night helped me better undstand what is going on there.12:20
daniloshenninge, I am sure it did, but some of it will not be clear from reading the code, because we 'unified' different matrix cells when what we wanted was for the same things to happen12:21
daniloshenninge, if you really want to get rid of makeCurrent, you'll have to modify A and B actions in the matrix (which call setFlag)12:25
daniloshenninge, good side of that approach would be that you should already have all the relevant messages that you might need to unset12:25
henningedanilos: test_setcurrenttranslation is passing again ;)12:27
henningewithout makeCurrent* and just one line change in setCurrentTranslation12:27
daniloshenninge, heh, did you remove it? :P12:27
daniloshenninge, which one line is that? :)12:27
daniloshenninge, don't forget there's a possibility that we forgot some tests even though there's like a million of them :)12:28
henningehttps://pastebin.canonical.com/41106/12:28
henningeRemove a flag before setting it.12:28
henningeWithout that it is causing erros elsewhere (withoug makeCurrent*)12:29
henningedanilos: I reverted the canges to the '*' action but that is the one I don't understand yet.12:30
henningedanilos: I don't see why I'd need to change 'A' and 'B' actions because they just unset flags.12:30
henningedanilos: what we lose by not using makeCurrent* is the unsetting of flags.12:30
daniloshenninge, right12:30
daniloshenninge, sorry, my bad :)12:31
henningethat' ok ;)12:31
daniloshenninge, so, I guess you should go on with removing makeCurrent* methods then :)12:31
daniloshenninge, it is basically a missing method if we compare it with the wiki page12:32
daniloshenninge, btw, I'd say it'd probably be a good idea to mention https://dev.launchpad.net/Translations/Specs/UpstreamImportIntoUbuntu/FixingIsImported/setCurrentTranslation in the comments of _setTranslation somewhere12:33
daniloshenninge, and look through "Capture the flag" section on that wiki page to understand why is '*' like it is12:34
henningedanilos: ah yes, I remember reading about "Capture the flag"12:37
henningedon't think I understood it back than, either :-P12:37
* henninge tries harder this tim12:37
henningee12:37
daniloshenninge, do not forget that action '*' or '+' happen only after A/B/Z and a numbered action has gone through12:43
henningeyes, thanks.12:44
daniloshenninge, that's why the need for makeCurrent* is removed in all other actions, but seems jtv only forgot to implement the line you are adding12:44
henningedanilos: Reading through the "guiding principles" I see that it may conflict with the sharing policy we discussed at a higher level.12:45
henningedanilos: I was asking you yesterday "when it comes to calling setCurrentTranslation, the decission if this new translations should be shared has already been made"12:46
henninge"it is passed into setCurrentTranslation as share_with_other_side"12:47
daniloshenninge, yes, exactly12:47
henningeWe had discussed that uploads on the upstream side would automatically update Ubuntu translations but not the other way round.12:47
daniloshenninge, it should still worry about unsetting the flags, I just forgot a few bits of the design myself :)12:48
daniloshenninge, yes, that's how it should be implemented today12:48
henningesetCurrentTranslation prevents that by design, though, AFAIUI12:48
henninge"stealing the flag" only happens if the other side is untranslated.12:49
henningeotherwise "share_with_other_side" is ignored.12:49
henningeI think.12:49
* henninge needs to read to the end.12:49
henningedanilos: oh sorry, I think I found my error in thinking12:50
henningeUpstream uploads only update Ubuntu translations if they were not changed on the Ubuntuside.12:51
henningeI forgot about that. Never mind my rambling ...12:52
henninge;-)12:52
daniloshenninge, heh, don't worry12:58
daniloshenninge, anyway, try to get that branch into landable state asap, I want it behind us today :)12:58
henningedanilos: I am currently re-running lp.translations tests on it. See what's left.12:59
henningeI am also going to revert the the renaming of getImportedTranslationMessage to reduce the branch size.12:59
daniloshenninge, cool12:59
henningeonly two failures left ...13:02
=== matsubara_ is now known as matsubara
pcjc2Hi, One of our users uses a text based web-browser, and whilst LP works really well on my local instance with that browser, the Launchpad OpenID provider causes it problems13:40
pcjc2Is the code for the LP OpenID provider available somewhere?13:40
pcjc2The bug is pretty trivial actually.. the "Continue" button on the login page is served up with a "<button>" element, rather than an "<input ....  type=button>", which that web browser doesn't support13:41
pcjc2The dummy OpenID provider in the LP checkout does not have that problem13:41
benjipcjc2: I think a bug has been filed for that; let me see if I can find it13:59
benjipcjc2: https://bugs.launchpad.net/launchpad/+bug/52322914:04
_mup_Bug #523229: The Continue button isn't selectable in w3m for sso login <iso-testing> <lp-foundations> <Canonical SSO provider:Won't Fix> <Launchpad itself:Triaged by gary> < https://launchpad.net/bugs/523229 >14:04
pcjc2ok, shame its wontfix14:06
pcjc2ah - just in the SSO provider, never mind14:07
gary_posterpcjc2: work-around is to install elinks.  Use it with env variable (BROWSER=elinks).  The change I'm trying to get is to have the w3m <button> support in natty backported to maverick and lucid.14:17
pcjc2A question of user preference I'm afraid... but thanks though - I've pointed the user at the bug report, and hopefully he'll be able to find the newer package. He's in Debian I believe14:18
gary_postercool pcjc2 .14:18
pcjc2It was just one nit in the process of moving our projects bugs to LP - some of our users might come off as "strange" in their preferences for softwar14:18
pcjc2e14:18
gary_poster:-) I know the same could be said of me14:19
pcjc2One refuses to use anything modern, and back-ports everything to some old UNIX variant with ~1 user in the world14:19
gary_posterheh14:19
pcjc2(This wasn't the guy in question.., but I believe the reporter of the W3M issue is still running on a 486 or something)14:20
gary_posterheh14:20
pcjc2(Hell - I have BBC micros in the loft for the sake of nostalgia, but I don't try to do work on them any more ;))14:20
* benji shovels coal into his steam-powered laptop.14:23
daniloshenninge, hi, how is the branch coming along?14:32
henningedanilos: I am was just about to prepare the mp.14:32
daniloshenninge, cool14:32
pcjc2OT: Just a quote which came in today from that user  - "I read all my mail raw exactly as it comes across the wire, without using *any* MUA that does any decoding behind my back.  I have a little program I wrote myself that decodes base64, but it's a major PITA."14:32
pcjc2"Hence if mail arrives in base64 and neither its source nor its subject line give a strong signal that it's important, it usually gets deleted by the firmware in my fingers without ever reaching my eyeballs.  Any responses to this message that are encoded in base64 are likely to receive such fate."14:33
pcjc2We tend not to pander to him too much ;)14:33
henningedanilos: but I don't think it still fits the bug ... or the kanban card.14:33
daniloshenninge, oh well, I wouldn't worry about that too much14:33
danilospcjc2, sounds very "smart", what does he do if I use my real name in Cyrillic when I try to email him? "unknown sender, delete" :)14:35
pcjc2No idea.. He's Russian I believe.. but he believes all computers should be in English, and no time wasted on i18n14:35
pcjc2He's a nice enough guy... just a reminder that you can meet some very strange people on the interweb14:36
=== salgado is now known as salgado-lunch
=== Ursinha is now known as Ursinha-brb
danilosbigjools, IBuildFarmJob doesn't specify .build at all, I am very much surprised to see it being required15:08
bigjoolsdanilos: it's delegated I think15:08
danilosbigjools, to what?15:09
bigjoolsspecific_job15:10
bigjoolsIIRC15:10
pcjc2Is it normal for "bin/test bugimport" to take about 35-40 seconds?15:10
danilosbigjools, but what interface are specific_jobs supposed to implement?15:12
danilosbigjools, afaics, BuildFarmJobDerived delegates to BuildFarmJob but none of them implement .build15:12
bigjoolsdanilos: see lib/lp/soyuz/model/buildpackagejob.py15:13
bigjoolsdanilos: looks like it's not in the interface.15:14
danilosbigjools, that doesn't answer my question: what should .build be at all15:17
bigjoolsdanilos: it's either a binarypackagebuild or a sourcepackagerecipebuild for the other job types15:17
bigjoolsdoes that map to the ttbj jobs?15:17
danilosbigjools, I am not sure it does, and that is the whole problem15:18
bigjoolsah :/15:18
danilosbigjools, well, we do have translationtemplatesbuild job but that is an IBuildFarmJob (BuildFarmJobDerived) as far as I can see15:18
danilosbigjools, it sounds weird for it to link to itself via .build15:18
danilosbigjools, that's why we probably have this confusion in the first place15:19
danilosbigjools, and it seems PackageBuild is also inherits from BuildFarmJobDerived15:20
bigjoolsthis whole model is a nightmare at the moment15:21
bigjoolsloads of it is still there to support non converted jobs but I don't know what any more15:21
danilosbigjools, right, this is what sounds weird: BuildPackageJob inherits from BFJD (BuildFarmJobDerived), and .build points at a BinaryPackageBuild which inherits from BFJD as well15:22
danilosbigjools, so, it seems as if we are either using the same data structure for two different things or that I am very confused :)15:23
danilosbigjools, if we simply implemented .build to point at self in TranslationTemplatesBuild, I wonder what would happen :)15:23
danilosbigjools, basically, the problem is that we don't need that much indirection in translations15:24
danilosbigjools, maybe we do because of the buildmaster design, but it seems neither noodles nor abentley are around today :(15:24
bigjoolsdanilos: the indirection is there because it's trying to support the old model as well15:25
bigjoolswe need to remove it and it will all become simpler15:25
bigjoolsbut right now I have not been involved enough in that to sort it out15:25
bigjoolswe could ask wgrant to take a look15:25
danilosbigjools, right, so basically, I think that we just need to remove that and start using the new TranslationTemplatesBuild classes instead of the old ones15:26
danilosbigjools, perhaps the way to simplify this in translations is to put .build on *old* translation build class pointing to the new translation build class15:26
daniloswould that be correct?15:26
bigjoolsI can't say with any certainty15:26
bigjoolssorry to be useless15:26
danilosbigjools, heh, you probably have at least a better idea than I do, that sounds like an easy thing to do, and I'll ask around (email noodles and abentley to see if that's correct)15:27
bigjoolsdanilos: noodles would be the best start15:27
danilosbigjools, right, thanks15:28
=== salgado-lunch is now known as salgado
bigjoolsdo we have any tests for the front page?16:08
=== deryck is now known as deryck[lunch]
bigjoolsmrevell, when you've changed it before did you need to fix tests?16:10
mrevellbigjools, No, certainly not for when I did what's new, but I think flacoste made the most recent big change to the front page so he may have more recent info on test coverage.16:10
bigjoolsI can't see anything referencing the "Getting started" section either.  I guess for such a simple page it's hardly worth tests.16:14
=== beuno is now known as beuno-lunch
jamjml are you around? Or really anyone with twisted experience16:31
jamI should mention that my above load test contrasts with being exactly 0.98 to the ssh loopback at any load level.16:52
EdwinGrubbsbigjools: ping17:02
bigjoolsEdwinGrubbs: 'sup17:02
EdwinGrubbsbigjools: I'm working on the bug to prevent a person/team from being merged while it has a ppa.17:02
bigjoolsok17:03
EdwinGrubbsbigjools: in your comment on the bug, you said that it could have the same restriction as for renaming a person, which is to prevent renames if the person has a ppa with published packages.17:03
=== al-maisan is now known as almaisan-away
EdwinGrubbsbigjools: sinzui and wgrant pointed out that the ppa might show up in searches, and that the ppa would have to be in a DELETED status before it is merged, since it uses the user name to determine the directory that it will delete, and merge persons have "-merged" appended to the name.17:05
bigjoolsEdwinGrubbs: yes, the code that is used in renaming can be re-used for blocking merging, it does that already17:05
EdwinGrubbsbigjools: but shouldn't we block merges even if the ppa does not have a published package?17:06
bigjoolsEdwinGrubbs: the code that's used in renaming DTRT17:06
bigjoolseither (has publications and is DELETED) OR (has no publications ever)17:07
sinzuiEdwinGrubbs, bigjools read the last comments on bug 68411217:07
_mup_Bug #684112: Link to PPA merged owner from +archivesubscriptions is broken <404> <lp-registry> <merge-deactivate> <tales> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/684112 >17:07
sinzuiEdwinGrubbs, bigjools I think my suggest is bad. I suspect that the clean up proc will never remove the directories because the user/team names have changed17:07
bigjoolssinzui: indeed, I had overlooked that17:08
bigjoolsit needs a manual cleanup to get the orphaned PPA repos17:08
sinzuibigjools, the list is small. could re prepare a shell script to remove them?17:08
bigjoolsshould be fairly trivial, we just get a list of all repos and check that they are valid in LP17:09
EdwinGrubbsbigjools: another question: since a ppa in DELETING status says that it is "Deleted", it will be annoying and confusing that they still can't merge the person, because the ppa needs to be in DELETED status. How long should I tell the user to wait before trying to merge again?17:13
bigjoolsEdwinGrubbs: 5-10 minutes, we need to wait for the publisher cron job to run17:13
EdwinGrubbsok, thanks17:14
bigjoolsgee, a message queueing system would sure be useful :17:17
=== benji is now known as benji-lunch
=== deryck[lunch] is now known as deryck
jcsackettsinzui: we're generally trying to clean up use of "assert something" and actually do proper exception raising these days, right?17:56
sinzuijcsackett, yes17:57
jcsackettokay, thanks.17:57
=== beuno-lunch is now known as beuno
=== benji-lunch is now known as benji
jcsacketthenninge: when you return, there are comments/questions on your MP.18:32
jcsackett...wrong channel.18:36
=== salgado is now known as salgado-brb
=== salgado-brb is now known as salgado
=== Ursinha-brb is now known as Ursinha
=== EdwinGrubbs is now known as Edwin-afk2
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
derycklater on, all.21:03
salgadobac, I'm jealous of you; I wish I could've deleted all that poll code22:02
bacsalgado: yeah, i know22:02
salgadoand then close all those bugs as won't-fix/invalid22:03
salgadoit must've felt good. :)22:03
bacsalgado: it is kind of sad, though.  i wish it would've been a viable feature22:03
salgadoindeed, but this was yet another feature we directed too much time that would be better spent improving other things. IMHO22:04
=== fjlacoste is now known as flacoste
bacsalgado: oh, i agree killing it off at this point was the right thing.22:04
lifelessonce we get on top of things22:35
lifelessfast22:35
lifelesseasy to use22:35
lifelessetc22:36
lifelesswe can revisit these little-apps22:36
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!