[00:00] bac: ack [00:09] bac: Sorry, we were afk discussing a feature [00:53] do i recall correctly that there is no need for GoogleServiceLayer anymore? ie we are not using any google apis anywhere? [01:02] We still use it for search. [01:02] Just not for maps. [01:04] ok. thanks. a test i was running timeout out waiting for setup() so i was just wondering [01:19] can someone answer out of hand abentley's question on https://code.edge.launchpad.net/~mbp/launchpad/690021-rlimit/+merge/43733 [01:20] if a scan branches job aborts unexpected (is killed by rlimit) what will happen? [01:20] will the jobs be failed, or re-run? [01:40] wallyworld: ^^ do you know? [01:41] poolie: i think any branches that haven't been scanned yet would need to be rescanned, but i'm not 100% [01:43] poolie: the scan branches job is just a cron script so shouldn;t any branches not scanned when the job is killed be picked up next time the job is run? [01:44] i would have thought so [01:44] i guess they may just fail repeatedly [01:44] if it scans multiple branches in a single process invocation this might mean that we get stuck with none being scanned? [01:44] this is probably still an improvement over the whole machine bogging down though [01:44] i'm wondering about the same thing myself [01:53] poolie: each python BranchScanJob instance works on a single branch but i'm not sure how these are invoked from the calling script ie if one fails, does it continue with the others [02:00] * poolie looks [02:14] yeah it's not obvious to me yet [02:17] it looks to me like if we kill the process, it will still be seen as running [02:18] oh i guess we could just look at what has actually happened recently to the scanner [02:26] i don't suppose there are docs of the lp jobs system? [02:26] ah, some in https://dev.launchpad.net/Foundations/JobSystem [02:28] poolie: tim would be able to provide an immediate answer but he is away till monday [02:29] i will request a review from him and sit on this until then [03:21] * wallyworld sad - lost power, huge thunder storm, limited internet connectivity :-( [03:24] wallyworld: http://www.bom.gov.au/products/IDN65152.shtml has a fun diagram [03:24] heh yes [03:24] spiv: yeah, and my wife has the car and it can't be put under cover :-( [03:25] lucky i got a 3G modem for these type of emergencies [03:25] the rain here is pissing down [03:50] "This thunderstorm is very dangerous" [03:50] Not something I thought I'd hear from the BoM. [03:51] wallyworld: aarnet lost au.mirror... so you're not alone [03:52] spm: sucks for them and me :-( [03:54] I want a storm :( [03:54] Maybe not quite that big. [03:54] But it's getting disappointingly warm down here. [03:57] lifeless: Hah, I win. Soyuz is out of the top-10 timeouts. [03:57] wgrant: where are you? [03:57] I am safe for now. [03:57] wallyworld: Melbourne. [03:57] it's been nice and rainy the last couple of weeks. [03:58] But this week is fairly warm. [03:58] huge thunderstorm here too [03:58] wgrant: well you know what they say about mne - 4 seasons in one day - careful what you wish for [03:58] *by sydney standards, would be a shower in bne [03:58] True, true. [03:58] poolie: :-) [04:15] worst part about having no power - it's way past my afternoon coffee time :-( [04:19] wallyworld: Coffee shop? [04:19] i think the whole suburb is out [04:20] it would be a looong drive and the window doesn't win up properly on my 2nd car which is a bomb [04:20] s/win/wind [04:26] wgrant: till jan 17th [04:41] lifeless: :( [04:43] wgrant: something real small would be to add a garbo job populating bugmessage.index [04:44] lifeless: Sadly Steve and I hae something real big. [04:45] fun times! [04:45] s/hae/ha[tv]e/ [04:45] Hate seems more appropos [04:45] apropos, even [05:16] * wallyworld about to disappear. laptop battery almost dead :-( [05:39] * nigelb congratulates lp folks on new team structure :) [05:53] :) === almaisan-away is now known as al-maisan [07:55] wallyworld: You have power again? [07:56] wgrant: yeah. i decded to go out and find a coffee shop with power (there were several suburbs without) and when I got back, it was on again \o/ [07:56] just turned out the cricket to take a peek - not good for us :-( [08:00] Excellent! [08:00] And I don't care about cricket :P [08:03] what? shame on you! [09:17] Hi [11:51] bigjools, hi, do you have a minute to chat about bug 685624? [11:51] <_mup_> Bug #685624: Translation template build jobs should use the new BuildFarmJob < https://launchpad.net/bugs/685624 > [11:51] danilos: 60 seconds and counting [11:52] danilos: I was just about to ping you ... [11:52] bigjools, I am hoping for a mumble chat [11:52] danilos: ok give me 5 mins [11:52] henninge, should be quick, I am on a countdown [11:53] henninge, heh, so, what's up with you while I am on hold for Julian? :) [11:54] danilos: the test for setCurrentTranslation is failing and i don't understand why this is supposed to work this way. [11:55] henninge, I am guessing because of makeCurrentUbuntu/makeCurrentUpstream changes [11:55] danilos: no, it is related to my "fix" in setCurrentTranslation I believe. [11:56] henninge, oh, you should not have changed setCurrentTranslation lightly [11:56] danilos: line 183 in test_setcurrenttranslation. [11:56] danilos: well, it is pretty isolated to other_side sharing but that is what is failing now. [11:57] henninge, some of the decisions in setCurrentTranslations are relatively arbitrary (i.e. we could have gone either way since it doesn't matter too much), but most of the critical ones are not [11:57] danilos: I don't understand why "the sharing policy has no effect" [11:57] henninge, I'll have to thing carefully about this particular case though [11:58] danilos: please do ;) [11:58] henninge, so, just to confirm we are looking at the same thing, it's test_c_None__n_None__o_shared__follows [11:58] right [11:59] danilos: but there are a couple more failing [12:00] danilos: all with "__follows" [12:00] that's what sets "share_with_other_side" on setCurrentTranslation [12:00] sets to *True*, obviously [12:00] danilos: wake up [12:01] bigjools, coming [12:01] henninge, be right back [12:03] Morning, all. [12:07] henninge, ok, back to you [12:07] henninge, well, you did invert the logic in setCurrentTranslation completely for a few things :) [12:08] henninge, well, maybe not [12:08] henninge, I see you tried to move makeCurrent stuff into it though [12:08] danilos: what do you mean? [12:09] henninge, btw, I think your change for translation credits is wrong as well: translation credits does need to read explicitely from the upstream side [12:09] henninge, well, unsetting of the flag that makeCurrent* methods used to do [12:10] henninge, so, here's what I think we should do: keep makeCurrent* methods and switch them to the new model by using explicit UPSTREAM for getImportedTM and UBUNTU for getCurrentTM methods [12:10] henninge, note that we should not make those calls side-sensitive since it's obvious makeCurrent methods are already using the new model (just like the translation credits message is) [12:11] henninge, they are only using getCurrent/getImportedTM methods in a low-level way (explicit side requests, not expecting them to be side-aware) [12:11] danilos: hm, getCurrentTM *is* explicit about sides anyway. [12:12] danilos: I am not sure about keeping makeCurrent around. [12:12] danilos: I just think that my change to setCurrentTranslation was not correct [12:12] henninge, well, makeCurrent* is directly used by setCurrentTranslation (I didn't know that), which means that it's an integral part of the setCurrentTranslation design [12:13] henninge, please, don't try to fix setCurrentTranslation *now* [12:13] henninge, if you remember, we spent days on designing, implementing and providing tests for it [12:13] henninge, so, if shareIfPossible and makeCurrent* are used by it, they are "new model" methods and we should keep them [12:14] danilos: but I, too, remember that makeCurrent* was a temporary solution. [12:14] henninge, perhaps, but as a step from, if you remember, DB triggers! [12:15] henninge, they are still improvement enough over DB triggers [12:15] henninge, and we can worry about getting rid of them later, they are not critical and require much careful consideration which I'd rather not do right now :) [12:16] henninge, if you feel you can do that, make sure you do it without changing any setcurrenttranslation tests :) [12:16] danilos: well, I see which part of my change makes that test fail. [12:16] I just still don't understand why it's supposed to work this way. [12:17] henninge, and make sure you back out this change: https://pastebin.canonical.com/41104/ [12:18] henninge, the problem with how setCurrentTranslation is supposed to work is that it has many different conditions and they are hard to get unless you consider the whole picture [12:18] danilos: ah yes, I was guessing there ... [12:19] henninge, that's why we have constructed a matrix of things that need to happen, and you can read it on https://dev.launchpad.net/Translations/Specs/UpstreamImportIntoUbuntu/FixingIsImported/setCurrentTranslation [12:20] danilos: actually, reading the code for setCurrentTranslation last night helped me better undstand what is going on there. [12:21] henninge, I am sure it did, but some of it will not be clear from reading the code, because we 'unified' different matrix cells when what we wanted was for the same things to happen [12:25] henninge, if you really want to get rid of makeCurrent, you'll have to modify A and B actions in the matrix (which call setFlag) [12:25] henninge, good side of that approach would be that you should already have all the relevant messages that you might need to unset [12:27] danilos: test_setcurrenttranslation is passing again ;) [12:27] without makeCurrent* and just one line change in setCurrentTranslation [12:27] henninge, heh, did you remove it? :P [12:27] henninge, which one line is that? :) [12:28] henninge, don't forget there's a possibility that we forgot some tests even though there's like a million of them :) [12:28] https://pastebin.canonical.com/41106/ [12:28] Remove a flag before setting it. [12:29] Without that it is causing erros elsewhere (withoug makeCurrent*) [12:30] danilos: I reverted the canges to the '*' action but that is the one I don't understand yet. [12:30] danilos: I don't see why I'd need to change 'A' and 'B' actions because they just unset flags. [12:30] danilos: what we lose by not using makeCurrent* is the unsetting of flags. [12:30] henninge, right [12:31] henninge, sorry, my bad :) [12:31] that' ok ;) [12:31] henninge, so, I guess you should go on with removing makeCurrent* methods then :) [12:32] henninge, it is basically a missing method if we compare it with the wiki page [12:33] henninge, btw, I'd say it'd probably be a good idea to mention https://dev.launchpad.net/Translations/Specs/UpstreamImportIntoUbuntu/FixingIsImported/setCurrentTranslation in the comments of _setTranslation somewhere [12:34] henninge, and look through "Capture the flag" section on that wiki page to understand why is '*' like it is [12:37] danilos: ah yes, I remember reading about "Capture the flag" [12:37] don't think I understood it back than, either :-P [12:37] * henninge tries harder this tim [12:37] e [12:43] henninge, do not forget that action '*' or '+' happen only after A/B/Z and a numbered action has gone through [12:44] yes, thanks. [12:44] henninge, that's why the need for makeCurrent* is removed in all other actions, but seems jtv only forgot to implement the line you are adding [12:45] danilos: Reading through the "guiding principles" I see that it may conflict with the sharing policy we discussed at a higher level. [12:46] danilos: I was asking you yesterday "when it comes to calling setCurrentTranslation, the decission if this new translations should be shared has already been made" [12:47] "it is passed into setCurrentTranslation as share_with_other_side" [12:47] henninge, yes, exactly [12:47] We had discussed that uploads on the upstream side would automatically update Ubuntu translations but not the other way round. [12:48] henninge, it should still worry about unsetting the flags, I just forgot a few bits of the design myself :) [12:48] henninge, yes, that's how it should be implemented today [12:48] setCurrentTranslation prevents that by design, though, AFAIUI [12:49] "stealing the flag" only happens if the other side is untranslated. [12:49] otherwise "share_with_other_side" is ignored. [12:49] I think. [12:49] * henninge needs to read to the end. [12:50] danilos: oh sorry, I think I found my error in thinking [12:51] Upstream uploads only update Ubuntu translations if they were not changed on the Ubuntuside. [12:52] I forgot about that. Never mind my rambling ... [12:52] ;-) [12:58] henninge, heh, don't worry [12:58] henninge, anyway, try to get that branch into landable state asap, I want it behind us today :) [12:59] danilos: I am currently re-running lp.translations tests on it. See what's left. [12:59] I am also going to revert the the renaming of getImportedTranslationMessage to reduce the branch size. [12:59] henninge, cool [13:02] only two failures left ... === matsubara_ is now known as matsubara [13:40] Hi, One of our users uses a text based web-browser, and whilst LP works really well on my local instance with that browser, the Launchpad OpenID provider causes it problems [13:40] Is the code for the LP OpenID provider available somewhere? [13:41] The bug is pretty trivial actually.. the "Continue" button on the login page is served up with a "