[13:58] <jcsackett> sinzui: i'm on call today but i don't think it makes sense for me to grab the review you have in the queue.
[13:58] <jcsackett> what with you being the one who does my follow up. :-P
[13:58] <sinzui> I will ask bac or EdwinGrubbs
[13:59] <bac> sinzui:  i can do it
[14:00] <jcsackett> thanks, bac.
[14:08] <jcsackett> sinzui, bac: mind if i take you out of the queue in the topic?
[15:47] <bac> sinzui: i haven't gotten to your review yet and now i have the YUI thing for an hour.  are you in a huge rush?
[15:47] <sinzui> No rush at all
[16:22] <henninge> danilos: did you want to review the branch or shall I ask jcsackett to look at it?
[16:23] <danilos> henninge, just go for jcsackett, I can only glance to see that you didn't remove something important :P
[16:25] <henninge> jcsackett: Hi! I have a somewhat oversized branch but it has a lot of mechanical changes. I wrote up a nice cover letter, too. ;)
[16:26] <jcsackett> henninge: shoot me the MP, i'm happy to look at it.
[16:26] <henninge> https://code.launchpad.net/~henninge/launchpad/db-devel-688519-getusedtranslationmessage/+merge/43924
[16:26] <henninge> jcsackett: thanks
[16:28] <bigjools> mrevell: care to take a butcher's? https://code.launchpad.net/~julian-edwards/launchpad/front-page-link-to-ppas-bug-583707/+merge/43929
[16:28] <mrevell> bigjools, I certainly would.
[16:29] <bigjools> as long as you don't tell me to sling my butcher's
[16:52] <mrevell> sorry for the delay bigjools, I'm having some trouble getting it to run.
[16:52] <bigjools> mrevell: can I help?
[16:53] <mrevell> bigjools, When I run make run I get the following:
[16:54] <mrevell> http://pastebin.ubuntu.com/544503/
[16:54] <bigjools> mrevell: run rocketfuel-get
[16:54] <bigjools> your sourcecode is out of date
[16:55] <mrevell> Oh, I had but after I'd pulled your branch. Do I need to merge in devel?
[16:57] <mrevell> yes, I do, right, working
[16:58] <bigjools> mrevell: no need to merge
[16:58] <bigjools> just update sourcecode
[17:10] <henninge> jcsackett: I have to run out now, sorry.
[17:10] <jcsackett> henninge: no worries.
[17:17] <bigjools> mrevell: any good?
[17:18] <mrevell> bigjools, I've updated sourcecode and it then asked me to rerun link-external... so I did that and it still won't make run ... I'm trying rocketfuel-get again for good measure.
[17:18] <bigjools> rerun?
[17:19] <bigjools> mrevell: easy steps: 1. rf-get, 2. get my branch, 3. link-ext..., 4. make run
[17:20] <bigjools> that should be enough
[17:20] <mrevell> Yeah, did all that ... ah,  it's complaining about repo format when I do the rf-get
[17:22] <mrevell> bigjools, running rf-setup to get a clean sheet
[17:22] <bigjools> !
[17:22] <bigjools> mrevell: can you paste output?
[17:24] <mrevell> bigjools, link-external-sourcecode gives me this: http://pastebin.ubuntu.com/544510/
[17:24] <bigjools> mrevell: try utilities/link-external-sourcecode ../../lp-sourcecode
[17:25] <mrevell> hmm
[17:25] <mrevell> bigjools, http://pastebin.ubuntu.com/544511/
[17:25] <mrevell> oh, source-deps
[17:25] <mrevell> ?
[17:26] <bigjools> sourcedeps my bad
[17:26] <bigjools> ok now?
[17:27] <mrevell> okay, so that worked, thanks ... make run gives me: http://pastebin.ubuntu.com/544512/
[17:27] <mrevell> which is what I was getting earlier
[17:28] <mrevell> bigjools, When I try rocketfuel-get it's complaining about different rich root support. Does that sound familiar?
[17:28] <bigjools> ignore it
[17:28] <bigjools> mrevell: ok
[17:28] <bigjools> try utilities/update-sourcecode
[17:29] <mrevell> running
[17:30] <mrevell> each one said "no change"
[17:30] <mrevell> trying make run ... no luck
[17:34] <bigjools> hmph
[17:35] <bigjools> mrevell: have you got lp-sourcedeps/eggs/testtools-0.9.8_r151-py2.6.egg
[17:36] <mrevell> bigjools, no
[17:37] <bigjools> mrevell: are you running utilities/update-sourcecode in my branch's directory?
[17:37] <mrevell> I am
[17:37]  * bigjools is stumped
[17:38] <mrevell> trying update-sourcecode again as I have no better ideas
[17:38] <bigjools> mrevell: this has happened to me before - I think I blew away all my eggs and restarted
[17:38] <bigjools> but it'd  be nice to work out wtf is going on
[18:03] <leonardr> benji-lunch, going to give you an incremental diff for yesterday's branch
[18:06] <bac> hi sinzui
[18:11] <sinzui> hi bac
[18:13] <sinzui> EdwinGrubbs, bac: I have another branch of 3 trivial bugs that needs review
[18:13] <bac> hi sinzui.  i was testing your branch and created a new team with mailing list.  i was momentarily confused when i got the message "Mailing list requested and queued for approval"
[18:13] <sinzui> yuck
[18:13] <bac> is that still there just to indicate it isn't available immediately?  very misleading
[18:13] <EdwinGrubbs> sinzui: I can take it.
[18:13] <sinzui> lets get that message out of the code
[18:13] <sinzui> bac, the list is not available immediately
[18:14] <bac> sinzui: yes, as above
[18:14] <bac> i think a new message that said "give us a few minutes already" would be swell
[18:14] <bac> "hold your horses"
[18:15] <sinzui> bac: maybe: "The mailing list will be available in a few minutes"
[18:15] <bac> not as colorful but will work
[18:15] <sinzui> There is a bug I decided to postpone. the team page implies the list and archive are working immediately
[18:16] <sinzui> I want a message I can show in the portlet and on the configure page.
[18:16] <leonardr> benji-lunch: https://code.launchpad.net/~leonardr/launchpadlib/retry-on-invalid-token/+merge/43784
[18:16] <leonardr> now going to work on your feedback
[18:17] <bac> sinzui: when creating a mailing list the button still says "Apply for a mailing list" which is misleading too
[18:17] <sinzui> yeo
[18:17] <sinzui> yep
[18:17] <sinzui> that is also in the ug
[18:17] <sinzui> bug
[18:17] <bac> oh ok
[18:17] <sinzui> there is a counter part too. The list is deactivated, but the button say create a list
[18:17] <benji> leonardr: looking
[18:21] <bac> sinzui: so i'm confused.  are you saying all of those issues are bundled in another bug?
[18:21] <sinzui> yes
[18:21] <sinzui> teo bug
[18:21] <sinzui> two bugs
[18:22] <bac> sinzui: ok, then i won't mention them in this review.  gotcha.
[18:22] <bac> sinzui: were you getting an assertion error due to the lack of a page_title
[18:22] <sinzui> bac: I thought I could fix them in this branch, but I think they should be a separate branch
[18:23] <bac> sinzui: +1
[18:23] <sinzui> bac, yes
[18:23] <bac> sinzui: why is that assertion not seen in the web UI?
[18:24] <sinzui> I think the upcall to the parent may be different. The class *should* provide page_title because the parent's label is different, thus the page title is different (and wrong) too
[18:26] <bac> sinzui: r=bac
[18:36] <jcsackett> henninge: just in case you're no monitoring the channel i accidentally sent this message to first, there are comments/questions on your MP.
[18:37] <jcsackett> please, no more 800+ branches, folks. :-P
[19:19] <leonardr> benji: "programmatic enforcement of the
[19:19] <leonardr>     given rules is warranted"
[19:19] <leonardr> you mean by raising ValueError?
[19:20]  * leonardr considering raising ValueError if the values given are _inconsistent_, but leaving it alone otherwise
[19:30] <benji> leonardr: right; it seems that there are many combinations of arguments that leave some ignored, offering opportunities for user frustration; it would be nice to short circuit some of that frustration
[20:05] <flacoste> gary_poster: can you make sure that bug 673252 is QAed?
[20:05] <_mup_> Bug #673252: server.* scope not robust on misspelt scopes <feature-flags> <lp-foundations> <qa-needstesting> <Launchpad itself:Fix Committed by stub> < https://launchpad.net/bugs/673252 >
[20:05] <gary_poster> flacoste: ok, on call, but will arrange
[20:05] <flacoste> jcsackett: and you can QA bug 681034?
[20:05] <_mup_> Bug #681034: UnknownURLScheme raised running distributionmirror-prober script <lp-registry> <oops> <qa-needstesting> <Launchpad itself:Fix Committed by jcsackett> < https://launchpad.net/bugs/681034 >
[20:06] <gary_poster> benji, do you have availablility to QA the bug above
[20:06] <gary_poster> ?
[20:06] <jcsackett> ah, flacoste, sorry. i qa'ed it but forgot to change the tag. one moment.
[20:06] <benji> gary_poster: sure
[20:07] <gary_poster> thank you much benji
[20:07] <benji> gary_poster: wait, jcsackett said that he QAed it
[20:07] <gary_poster> benji that was another bug?
[20:07] <jcsackett> benji: i qa'd 681034.
[20:08] <jcsackett> distributionmirror-prober.
[20:08] <benji> ah!  the reverse-cronology of the scroll-back confused me; I'll QA 673252
[20:10] <benji> generally we need to be better about writing down solid reproduction steps
[20:17] <benji> gary_poster, flacoste: 673252 is qa-ok
[20:17] <gary_poster> thank you benji
[20:17] <benji> np
[20:18] <flacoste> thanks
[20:29] <jcsackett> flacoste: 681034 is tagged qa-ok.
[22:15] <EdwinGrubbs> sinzui: review sent