=== jelmer changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === matsubara_ is now known as matsubara === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:58] sinzui: i'm on call today but i don't think it makes sense for me to grab the review you have in the queue. [13:58] what with you being the one who does my follow up. :-P [13:58] I will ask bac or EdwinGrubbs [13:59] sinzui: i can do it [14:00] thanks, bac. [14:08] sinzui, bac: mind if i take you out of the queue in the topic? === sinzui changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado [15:47] sinzui: i haven't gotten to your review yet and now i have the YUI thing for an hour. are you in a huge rush? [15:47] No rush at all === deryck is now known as deryck[lunch] [16:22] danilos: did you want to review the branch or shall I ask jcsackett to look at it? [16:23] henninge, just go for jcsackett, I can only glance to see that you didn't remove something important :P [16:25] jcsackett: Hi! I have a somewhat oversized branch but it has a lot of mechanical changes. I wrote up a nice cover letter, too. ;) === henninge changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: - || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:26] henninge: shoot me the MP, i'm happy to look at it. [16:26] https://code.launchpad.net/~henninge/launchpad/db-devel-688519-getusedtranslationmessage/+merge/43924 [16:26] jcsackett: thanks === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: henninge || queue: [ - ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:28] mrevell: care to take a butcher's? https://code.launchpad.net/~julian-edwards/launchpad/front-page-link-to-ppas-bug-583707/+merge/43929 [16:28] bigjools, I certainly would. [16:29] as long as you don't tell me to sling my butcher's [16:52] sorry for the delay bigjools, I'm having some trouble getting it to run. [16:52] mrevell: can I help? [16:53] bigjools, When I run make run I get the following: [16:54] http://pastebin.ubuntu.com/544503/ [16:54] mrevell: run rocketfuel-get [16:54] your sourcecode is out of date [16:55] Oh, I had but after I'd pulled your branch. Do I need to merge in devel? [16:57] yes, I do, right, working [16:58] mrevell: no need to merge [16:58] just update sourcecode [17:10] jcsackett: I have to run out now, sorry. [17:10] henninge: no worries. [17:17] mrevell: any good? [17:18] bigjools, I've updated sourcecode and it then asked me to rerun link-external... so I did that and it still won't make run ... I'm trying rocketfuel-get again for good measure. [17:18] rerun? === benji is now known as benji-lunch [17:19] mrevell: easy steps: 1. rf-get, 2. get my branch, 3. link-ext..., 4. make run [17:20] that should be enough [17:20] Yeah, did all that ... ah, it's complaining about repo format when I do the rf-get === deryck[lunch] is now known as deryck [17:22] bigjools, running rf-setup to get a clean sheet [17:22] ! [17:22] mrevell: can you paste output? [17:24] bigjools, link-external-sourcecode gives me this: http://pastebin.ubuntu.com/544510/ [17:24] mrevell: try utilities/link-external-sourcecode ../../lp-sourcecode [17:25] hmm [17:25] bigjools, http://pastebin.ubuntu.com/544511/ [17:25] oh, source-deps [17:25] ? [17:26] sourcedeps my bad [17:26] ok now? [17:27] okay, so that worked, thanks ... make run gives me: http://pastebin.ubuntu.com/544512/ [17:27] which is what I was getting earlier [17:28] bigjools, When I try rocketfuel-get it's complaining about different rich root support. Does that sound familiar? [17:28] ignore it [17:28] mrevell: ok [17:28] try utilities/update-sourcecode [17:29] running [17:30] each one said "no change" [17:30] trying make run ... no luck [17:34] hmph [17:35] mrevell: have you got lp-sourcedeps/eggs/testtools-0.9.8_r151-py2.6.egg [17:36] bigjools, no [17:37] mrevell: are you running utilities/update-sourcecode in my branch's directory? [17:37] I am [17:37] * bigjools is stumped [17:38] trying update-sourcecode again as I have no better ideas [17:38] mrevell: this has happened to me before - I think I blew away all my eggs and restarted [17:38] but it'd be nice to work out wtf is going on [18:03] benji-lunch, going to give you an incremental diff for yesterday's branch [18:06] hi sinzui [18:11] hi bac [18:13] EdwinGrubbs, bac: I have another branch of 3 trivial bugs that needs review [18:13] hi sinzui. i was testing your branch and created a new team with mailing list. i was momentarily confused when i got the message "Mailing list requested and queued for approval" [18:13] yuck [18:13] is that still there just to indicate it isn't available immediately? very misleading [18:13] sinzui: I can take it. [18:13] lets get that message out of the code [18:13] bac, the list is not available immediately [18:14] sinzui: yes, as above [18:14] i think a new message that said "give us a few minutes already" would be swell [18:14] "hold your horses" [18:15] bac: maybe: "The mailing list will be available in a few minutes" [18:15] not as colorful but will work [18:15] There is a bug I decided to postpone. the team page implies the list and archive are working immediately [18:16] I want a message I can show in the portlet and on the configure page. [18:16] benji-lunch: https://code.launchpad.net/~leonardr/launchpadlib/retry-on-invalid-token/+merge/43784 [18:16] now going to work on your feedback [18:17] sinzui: when creating a mailing list the button still says "Apply for a mailing list" which is misleading too [18:17] yeo [18:17] yep [18:17] that is also in the ug [18:17] bug [18:17] oh ok === benji-lunch is now known as benji [18:17] there is a counter part too. The list is deactivated, but the button say create a list [18:17] leonardr: looking [18:21] sinzui: so i'm confused. are you saying all of those issues are bundled in another bug? [18:21] yes [18:21] teo bug [18:21] two bugs [18:22] sinzui: ok, then i won't mention them in this review. gotcha. [18:22] sinzui: were you getting an assertion error due to the lack of a page_title [18:22] bac: I thought I could fix them in this branch, but I think they should be a separate branch [18:23] sinzui: +1 [18:23] bac, yes [18:23] sinzui: why is that assertion not seen in the web UI? [18:24] I think the upcall to the parent may be different. The class *should* provide page_title because the parent's label is different, thus the page title is different (and wrong) too [18:26] sinzui: r=bac === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: - || queue: [ - ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:36] henninge: just in case you're no monitoring the channel i accidentally sent this message to first, there are comments/questions on your MP. [18:37] please, no more 800+ branches, folks. :-P === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: grabbing lunch || queue: [ - ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === salgado is now known as salgado-brb === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || Reviewing: - || queue: [ - ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [19:19] benji: "programmatic enforcement of the [19:19] given rules is warranted" [19:19] you mean by raising ValueError? [19:20] * leonardr considering raising ValueError if the values given are _inconsistent_, but leaving it alone otherwise [19:30] leonardr: right; it seems that there are many combinations of arguments that leave some ignored, offering opportunities for user frustration; it would be nice to short circuit some of that frustration === salgado-brb is now known as salgado [20:05] gary_poster: can you make sure that bug 673252 is QAed? [20:05] <_mup_> Bug #673252: server.* scope not robust on misspelt scopes

< https://launchpad.net/bugs/673252 > [20:05] flacoste: ok, on call, but will arrange [20:05] jcsackett: and you can QA bug 681034? [20:05] <_mup_> Bug #681034: UnknownURLScheme raised running distributionmirror-prober script

< https://launchpad.net/bugs/681034 > [20:06] benji, do you have availablility to QA the bug above [20:06] ? [20:06] ah, flacoste, sorry. i qa'ed it but forgot to change the tag. one moment. [20:06] gary_poster: sure [20:07] thank you much benji [20:07] gary_poster: wait, jcsackett said that he QAed it [20:07] benji that was another bug? [20:07] benji: i qa'd 681034. [20:08] distributionmirror-prober. [20:08] ah! the reverse-cronology of the scroll-back confused me; I'll QA 673252 [20:10] generally we need to be better about writing down solid reproduction steps [20:17] gary_poster, flacoste: 673252 is qa-ok [20:17] thank you benji [20:17] np [20:18] thanks [20:29] flacoste: 681034 is tagged qa-ok. === EdwinGrubbs is now known as Edwin-afk2 === fjlacoste is now known as flacoste [22:15] sinzui: review sent === salgado is now known as salgado-afk === jcsackett changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === matsubara is now known as matsubara-afk