| StevenK | WTB reviewer, PST | 06:45 |
|---|---|---|
| wallyworld | StevenK: ? | 07:07 |
| StevenK | wallyworld: WoW-ism, it expands into "Want To Buy reviewer, Please Send Tell" | 07:08 |
| StevenK | Where tell is a WoW-ism for privmsg | 07:09 |
| wallyworld | StevenK: does that mean you want a review to do? :-) | 07:09 |
| wallyworld | trivial one: https://code.edge.launchpad.net/~wallyworld/launchpad/oops-bug-filing-location/+merge/44005 | 07:09 |
| * StevenK stabs wallyworld | 07:09 | |
| StevenK | No, I want someone to review one of MINE! | 07:09 |
| wallyworld | it's really trivial - change launchpad-code to launchpad in 3 places | 07:10 |
| wallyworld | tick and flick really | 07:10 |
| wallyworld | sorry | 07:10 |
| wallyworld | no, i am, really :-) | 07:10 |
| StevenK | +1 | 07:10 |
| wallyworld | thanks :-) | 07:10 |
| StevenK | Are you a mentat reviewer, or not yet> | 07:11 |
| StevenK | s/\>/?/ | 07:11 |
| wallyworld | no, not yet | 07:11 |
| StevenK | s/\(mentat\) \(reviewer\)/\2 (\1)/ | 07:11 |
| wallyworld | btw, i know the urls redirect but there was a bug and it is bugjam :-) | 07:12 |
| wgrant | Excuses, excuses. | 07:12 |
| wallyworld | StevenK: so shouldn;t there be an on call reviewer around? the channel topic always seems blank | 07:13 |
| wallyworld | i have another mp too but the sound of crickets is quite loud | 07:13 |
| wgrant | wallyworld: This is APac. | 07:16 |
| wgrant | There is no good OCR coverage yet. | 07:16 |
| wgrant | But this should change in 6 months, when there are three more... | 07:16 |
| wallyworld | wgrant: sure. maybe i don't recall seeing the topic set in the evenings or early mornings AEST | 07:17 |
| StevenK | I see it early mornings from the US people | 07:17 |
| StevenK | Or jelmer, if he forgot to edit the topic | 07:18 |
| wgrant | Well, a few weeks ago the UK would have been awake by this time. | 07:18 |
| wgrant | But DST makes me cry. | 07:18 |
| * wallyworld needs to find some glasses | 07:18 | |
| wallyworld | i love dst :-) wish we had it :-( | 07:18 |
| StevenK | Queensland is broken, find a better state. | 07:19 |
| wallyworld | can't beat the climate though | 07:20 |
| wgrant | Too hot :( | 07:20 |
| wallyworld | only if you're soft :-) | 07:20 |
| wgrant | Only 9.2EB of data left :( | 07:28 |
| StevenK | "Only" | 07:29 |
| henninge | danilos: were you aware of assert statements being deprecated now? | 09:37 |
| henninge | bac: are assert statements really deprecated now? Were do I read about that? | 09:41 |
| henninge | bac: and Hi! ;) | 09:41 |
| danilos | henninge, I didn't | 09:46 |
| henninge | I am not sure that is true ... | 09:46 |
| danilos | henninge, https://dev.launchpad.net/PythonStyleGuide | 09:49 |
| danilos | henninge, which points to https://dev.launchpad.net/AssertionsInLaunchpad | 09:49 |
| henninge | yes, reading that | 09:49 |
| henninge | it's a year old and describing how they can be used | 09:50 |
| henninge | my reviewer just sounded like there is a newer guideline. | 09:50 |
| danilos | henninge, our style guide uses them for a few examples as well, and doesn't explicitely forbid them so use them :) | 09:52 |
| danilos | henninge, also, with python's dynamic typing, it'd be very weird to do away with them | 09:53 |
| henninge | danilos: the suggestion was to turn this particular one into a Value error. | 09:53 |
| henninge | if side is None: | 09:54 |
| henninge | raise ValueError("Translation side must be specified"). | 09:54 |
| danilos | henninge, if that particular assertion would be hit as a cause of programmer error, it should stay an assertion imo | 09:54 |
| henninge | danilos: yes, that is my impression, too. | 09:54 |
| henninge | glad we agree ;-) | 09:54 |
| danilos | henninge, well, valueerror in an OOPS would not make much sense, and would, arguably, be catchable in callsites | 09:55 |
| danilos | henninge, assertionerrors should never be handled in call sites so we'd know a developer has made an error | 09:55 |
| henninge | danilos: I never said I liked the suggestions, I was just wondering why he said that asserts are deprecated now. | 09:56 |
| henninge | I'll be interested in his answer | 09:56 |
| danilos | henninge, oh, I don't know that, but let me consult my crystal ball... I'll let you take a peak as well :) | 09:56 |
| henninge | well, I could also call him to wake him and ask him ... ;-) | 09:57 |
| henninge | some kind of crystal ball that would be ... | 09:57 |
| StevenK | Is there any reviewer up for a short one? | 10:05 |
| henninge | Looks like abel is not around any more. | 10:16 |
| henninge | StevenK: what have you got? | 10:16 |
| StevenK | I suspect he is off sick still | 10:16 |
| StevenK | henninge: https://code.launchpad.net/~stevenk/launchpad/p3a-description-fix/+merge/44013 +8/-9 | 10:17 |
| henninge | oh, didn't know he was | 10:17 |
| henninge | +8/-9? Too big! :-P | 10:17 |
| StevenK | Haha | 10:17 |
| === stub1 is now known as stub | ||
| henninge | StevenK: You also fixed two long lines, right? Or are those that part of the actual fix? | 10:22 |
| StevenK | henninge: Before and after they fix they are one-char off | 10:23 |
| henninge | ??? | 10:24 |
| henninge | I meant these: | 10:24 |
| henninge | 32- "PPA named p3a for Celso Providelo" (ppa:cprov/p3a), which is hosted | 10:24 |
| henninge | 33- by Launchpad and has the following description: | 10:24 |
| henninge | 34+ "PPA named p3a for Celso Providelo" (ppa:cprov/p3a), which is hosted by | 10:24 |
| henninge | 35+ Launchpad and has the following description: | 10:24 |
| henninge | that is just cosmetic, not part of the fix, right? | 10:24 |
| StevenK | henninge: Oh, sorry. Those had to be changed due to turning on -NORMALIZE_WHITESPACE | 10:24 |
| StevenK | Well, turning off ... :-) | 10:24 |
| henninge | oh, to match the lines breaks in the actual message? I see | 10:25 |
| StevenK | Yes, it's icky :-( | 10:25 |
| henninge | StevenK: thanks for the fix. r=me ;) | 10:25 |
| StevenK | henninge: Thanks! :-) | 10:25 |
| === matsubara-afk is now known as matsubara | ||
| danilos | StevenK, hi, considering you are likely the only soyuz guy around, would you mind reviewing https://code.launchpad.net/~danilo/launchpad/bug-685624/+merge/44035 (it's very short, I am just worried that I don't break anything) | 12:56 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | good morning launchpad | 13:04 |
| bac | checking in for my last review shift of 2010! | 13:04 |
| danilos | bac, I've got one for you then :) | 13:09 |
| danilos | https://code.launchpad.net/~danilo/launchpad/bug-685624/+merge/44035 | 13:09 |
| bac | danilos: ok | 13:09 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: danilos || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | Hi bac, I've got a couple of branches that need reviewing. Can I stick them in the queue? | 13:12 |
| bac | gmb: sure | 13:12 |
| * bac misses abel | 13:12 | |
| === gmb changed the topic of #launchpad-reviews to: n call: bac || Reviewing: danilos || queue: [gmb*2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: On call: bac || Reviewing: danilos || queue: [gmb*2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| salgado | folks, kiko has bribed me into doing a trivial fix to allow the drivers of a blueprint's target to edit that bp, but I'm off to catch a plane soon and after that I'll be completely deprived of 'net access, so I was wondering if anybody would be willing to land that branch for me? | 13:37 |
| salgado | the merge-proposal is https://code.edge.launchpad.net/~salgado/launchpad/target-driver-edit-blueprint/+merge/44046 | 13:37 |
| danilos | bac, I am thinking of heading off for some food, I assume there are no big questions that you've got? | 13:38 |
| bac | danilos: the branch looks good | 13:40 |
| bac | danilos: the description was much more complicated than the code, which is quite simple. | 13:41 |
| danilos | bac, right, it was quite an exercise for me to get to understand exactly what's going on and to see if we can try to get at TTB from a TTBJ without storing the data; complexity of the model didn't help there, just like the fact that TTBJ is serving two different purposes didn't | 13:41 |
| danilos | bac, I am expecting to have fun time QAing this though :) | 13:42 |
| bac | danilos: yeah, good luck with that. what is the ETA for cleaning this up for good? | 13:42 |
| danilos | bac, wgrant mentioned how he'd like to get it all switched to the new model maybe as early as next week | 13:42 |
| bac | wow! | 13:42 |
| danilos | bac, I am morally supporting him :) | 13:43 |
| danilos | bac, for someone who understands well exactly what's going on where it's mostly just moving code around, afaiu | 13:43 |
| danilos | (missing comma warning :) | 13:43 |
| danilos | ...what's going on where *,* it's... | 13:44 |
| bac | danilos: r=bac | 13:44 |
| danilos | bac, thanks | 13:44 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb1 || queue: [gmb2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | salgado: i'll look at it. if no substantial changes are required i can land it | 13:45 |
| salgado | bac, great, thanks! | 13:45 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb1 || queue: [gmb2, salgado] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | salgado: have a nice trip | 13:46 |
| salgado | bac, I might even be able to do the changes if you review it now. it's just getting it through ec2 that I won't be able to | 13:46 |
| jcsackett | bac, mind if throw https://code.launchpad.net/~jcsackett/launchpad/linkifier-bugs-2/+merge/43980 on your queue? | 13:50 |
| bac | jcsackett: sure | 13:51 |
| === jcsackett changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb1 || queue: [gmb2, salgado, bac] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === jcsackett changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb1 || queue: [gmb2, salgado, jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jcsackett | thanks. | 13:51 |
| jcsackett | henninge: your branch from yesterday is r=me for code*; i have requested review from sinzui for follow up. nice start on that clean up. :-) | 13:52 |
| bac | salgado: r=bac with one tiny fix | 13:52 |
| bac | salgado: are you leaving for the holidays or a work trip? will you be around to QA it? | 13:52 |
| henninge | jcsackett: thank you! ;) | 13:52 |
| salgado | bac, good catch; I'm leaving on holidays. if I get instructions to QA it, would you be kind enough to do it for me? if not I can see if somebody from Linaro can do it | 13:55 |
| bac | salgado: i can QA it for you. i'll subscribe to the bug. please update the MP with a commit message. | 13:56 |
| salgado | oh, I need to file a bug as well | 13:56 |
| salgado | bac, have we moved all bugs to launchpad yet? | 13:58 |
| salgado | looks like we did | 13:58 |
| bac | salgado: yes we did | 13:59 |
| salgado | bac, ok, bug filed, linked to branch and security adapter renamed. should I add QA instructions on the bug or mp? | 14:02 |
| bac | salgado: uh, MP i guess | 14:04 |
| bac | gmb: hey it does not look like we have a dependency on lxml | 14:04 |
| gmb | Rats. | 14:05 |
| gmb | That's damnably irritating. | 14:06 |
| bac | gmb: yep. | 14:06 |
| gmb | bac: So we've three options: | 14:06 |
| gmb | 1) Regexes (urgh) | 14:06 |
| gmb | 2) BeautifulSoup (performance problems) | 14:07 |
| gmb | 3) Bug someone to make lxml a dependency. | 14:07 |
| gmb | 3 is annoying but I'd rather do that than take the performance hit. | 14:07 |
| bac | 3a) And get it deployed | 14:07 |
| gmb | Yes, that too :) | 14:07 |
| bac | WWmthaddonD? | 14:07 |
| gmb | Heh. | 14:08 |
| gmb | bac: Do you know to whom I need to talk to get it made into a dependency? | 14:08 |
| bac | [flacoste, gary, mars] maybe? | 14:08 |
| gmb | Righto, I shall talk to one of the above. | 14:08 |
| bac | getting _new will be great but i think landing the tabindex branch is more urgent | 14:09 |
| gmb | bac: There is no tabindex branch at the moment. | 14:09 |
| gmb | It's a truly horrible problem | 14:10 |
| bac | oh, i was kindof hoping your other branch in queue was it | 14:10 |
| gmb | No, sorry :/ | 14:10 |
| bac | i'm just worried about poor dustin having an aneurysm | 14:10 |
| gmb | Well, naturally. As am I. I don't want to be at the platform rally and have his head explode all over me. | 14:10 |
| gmb | Lessee how quickly I can get the dependency problem sorted. | 14:11 |
| bac | i think an uncontained aneurysm is fairly rare | 14:11 |
| gmb | But he was *really* cross... | 14:11 |
| bac | of course they said that about jet engines before RR proved them wrong | 14:11 |
| gmb | This is true. | 14:11 |
| gmb | And as we know, all engineers are just basically machines for producing code. | 14:12 |
| gmb | ... this is going down a rabbit hole. | 14:12 |
| bac | yes | 14:12 |
| bac | well i'll continue on with the review then | 14:12 |
| gmb | Cool, thanks. | 14:12 |
| * gary_poster looks around to try and figure out what's up | 14:12 | |
| === salgado is now known as salgado-brb | ||
| deryck | gmb: I think the dependency issue is as easy as building a tarball of lxml, adding it to download-cache, and then adding lxml == FOO to versions.cfg. | 14:13 |
| deryck | gary_poster can confirm ^^ | 14:13 |
| deryck | or deny ;) | 14:13 |
| bac | deryck: really? can't it just be added to launchpad-dependencies? | 14:13 |
| gmb | Ooo. | 14:13 |
| deryck | bac: I thought for python libs we preferred buildout. | 14:14 |
| bac | deryck: oh there's that | 14:14 |
| bac | that's why my name was not in the list | 14:14 |
| deryck | maybe I'm nosing my way into a topic I don't really know enough about :-) | 14:14 |
| * gmb summons gary_poster to add his $0.02... | 14:15 | |
| bac | gary_poster: the only other lxml in our code base is in migrater tools, not production code | 14:15 |
| gary_poster | we prefer Python eggs, but lxml egg is really annoying to build | 14:15 |
| gary_poster | gotcha bac | 14:15 |
| deryck | ah, right, I had heard that about lxml | 14:15 |
| * deryck has never actually built lxml | 14:16 | |
| * gary_poster has, and has the scars to prove it | 14:16 | |
| benji | run away! run away! | 14:16 |
| gary_poster | :-) | 14:16 |
| deryck | heh | 14:16 |
| * deryck runs away now | 14:16 | |
| gary_poster | lemme remember how to look at our deb dependencies and I'll report back gmb. 1 sec | 14:17 |
| gmb | gary_poster: Thanks. | 14:17 |
| bac | good new gmb. your tests pass now. :) | 14:18 |
| gmb | Heh | 14:18 |
| * bac blames his poor spelling on frigid fingers which he blames on a horrible sanyo heat pump | 14:18 | |
| gary_poster | gmb, we did use to have lxml as a deb dependency. It was dropped Thu, 10 Sep 2009 "(tests run fine without)" | 14:20 |
| gmb | Hah | 14:20 |
| gmb | I hereby repudiate that statment. | 14:20 |
| gary_poster | :-) | 14:20 |
| henninge | bac: Is it ok if I append my mp to the queue? | 14:20 |
| bac | yes, of course | 14:20 |
| === henninge changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb1 || queue: [gmb2, salgado, jcsackett,henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | bac: thanks | 14:21 |
| gary_poster | so, I can point you to how to update the deb dependecies, or you can ping me to do it...next week. Or *maybe* this afternoon. kinda booked right now. | 14:21 |
| gary_poster | gmb: ^^ | 14:21 |
| * gary_poster tries to find doc link meanwhile | 14:21 | |
| gmb | gary_poster: Feel free to point me at it and I'll give it a shot. | 14:21 |
| gary_poster | cool | 14:21 |
| gary_poster | gmb https://dev.launchpad.net/Hacking#Changing%20the%20launchpad%20dependency%20debs | 14:23 |
| gmb | Thanks | 14:23 |
| gary_poster | np. I'm no expert, but I've done it before gmb, so I can at least stare at a problem with you :-) | 14:23 |
| gmb | gary_poster: Cool, thanks. I'll ping you if I run into difficulties. | 14:24 |
| bac | gmb: review done with one suggestion, other than the obvious. | 14:31 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: jcsackett || queue: [gmb2,henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | Cool, thanks. | 14:32 |
| flacoste | gmb: did you solve your problem? | 14:38 |
| gmb | flacoste: Yes, I think so. Well, we'll see shortly anyway. | 14:40 |
| abentley | bac, could you please review https://code.launchpad.net/~abentley/launchpad/email-url-body/+merge/43838 ? | 14:48 |
| bac | sure, abentley, chunk it on the queue | 14:48 |
| === abentley changed the topic of #launchpad-reviews to: On call: bac || Reviewing: jcsackett || queue: [gmb2,henninge,abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | bac, thanks. | 14:49 |
| === salgado-brb is now known as salgado | ||
| gmb | bac: I've replied to your review and uploaded a new version of launchpad-dependencies, which is building now. | 15:19 |
| bac | gmb: thanks | 15:20 |
| bac | jcsackett: is 'blacklist' the best word to use in that context? it seems you're just trying to find the URLs that match a pattern but they aren't blacklisted, which has a specific, loaded connotation to me. | 15:23 |
| jcsackett | bac: i'm open to other names; i was thinking blacklist in a proxy sense--these URIs don't count/aren't linked. | 15:23 |
| bac | 'ignored'? | 15:24 |
| jcsackett | bac: if that works better for you, i'm happy to make that change. | 15:24 |
| danilos | henninge, fwiw, you still seem to have left some changes to credits handling which made the side context sensitive instead of explicitely using UPSTREAM as the side | 15:28 |
| danilos | henninge, I am thinking of line 640 (so, tests) | 15:29 |
| bac | jcsackett: can you explain what handle_parens_in_trailers is doing? | 15:30 |
| bac | it really needs a docstring and explanation | 15:31 |
| jcsackett | bac: happy to provide comments in it--i had some and must have deleted them. | 15:31 |
| danilos | henninge, I am talking about https://code.launchpad.net/~henninge/launchpad/db-devel-688519-getusedtranslationmessage/+merge/43924, fwiw ;) | 15:31 |
| jcsackett | bac: basically, it's capturing closing parens out of the trailers from the url and adding them to the url if there is an unpaired open paren in the url. | 15:32 |
| jcsackett | this deals with http://wikipedia.org/something_(some_catagory) style urls. | 15:32 |
| jcsackett | right now the trailing paren is dropped, and without restructuring the entire regex there's no real way to capture the last parens if and only if there are a like number of unpaired opens in the url. | 15:33 |
| bac | jcsackett: so were the closing parens incorrectly characterized as trailers and are being moved back to the url proper? | 15:33 |
| jcsackett | bac: yes. | 15:33 |
| bac | oh, ok | 15:33 |
| jcsackett | bac: if there are unpaired open parens in the url, the closing paren in the trailer is put back in the url. | 15:33 |
| bac | jcsackett: i see now | 15:33 |
| bac | jcsackett: but if all the missing parens are not at the beginning of the trailers then it doesn't work so well, right? | 15:34 |
| bac | b/c you break out of the loop at the first non-) | 15:35 |
| jcsackett | bac: the way the regex is structured, there should only be relevant closing ones at the end. if the trailer had text &c in it first it wouldn't close of the url there. | 15:35 |
| jcsackett | in reality, this should only ever capture one paren, but i wanted to cover something like http:///thisurl.com/has_(too_many(parens)) as long as i was handling it. | 15:36 |
| jcsackett | bac: i'll modify the test to double check some more irritating combinations are also handled right. | 15:37 |
| bac | jcsackett: what would this do? | 15:37 |
| bac | (http://example.com/path_(with_parens)and_stuff) | 15:37 |
| bac | would the extra be part of the url? trailer is only punctuation, right? | 15:37 |
| jcsackett | bac: good question. i'll add that example to the text case. | 15:38 |
| bac | yes, please make some corner case tests for that method | 15:38 |
| jcsackett | bac: my intuition is that http://example.com/path_(with_parens)and_stuff would be linkified, and the surrounding parens would not. | 15:38 |
| jcsackett | obviously, if the user typos and "and stuff" shouldn't be part of the URI, there's no way to handle that. | 15:39 |
| bac | jcsackett: i approved the branch but have several suggestions | 15:39 |
| bac | included in the MP | 15:39 |
| jcsackett | bac: when you say plain english for the regex, you mean the enormous _re_linkify? | 15:40 |
| jcsackett | b/c speaking plainly, i still have no idea what some of it does. :-P | 15:40 |
| bac | jcsackett: no, the trailers regex that i asked you to relocate | 15:41 |
| jcsackett | bac:ah, i see. i got mixed up. | 15:41 |
| bac | were it closer to its use it would be less confusing | 15:41 |
| bac | jcsackett: looking at that regex with all punctuation i cannot recall which are things to be matched and which are special regex chars | 15:42 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: gmb || queue: [henninge,abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | danilos: well, since the factory produces upstream templates, the side will be UPSTREAM. So the test ist not really side sensitive. It also checks the flags directly instead of using getFlag. | 15:43 |
| henninge | danilos: so, are you saying this should be fixed before I can land this? | 15:43 |
| danilos | henninge, right, but the way the test is written it will fail if we change the factory method | 15:43 |
| henninge | are we going to change it? | 15:44 |
| danilos | henninge, we are not planning to, no, but the test is sometimes used as a documentation as well, and now it implies that setTranslationCreditsAsTranslated might be side-aware when it's not | 15:44 |
| danilos | (well, it is, in the sense that it will always use the UPSTREAM side) | 15:45 |
| bac | gmb: remind me how to get your subscription widget tests to run | 15:48 |
| bac | gmb: i hate to do it, but i'm going to pass on your branch. i don't think i can add anything of value. please find a reviewer with more JS experience. | 15:53 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: henninge || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| gmb | bac: Okay, no worries. I do the same thing quite often :) | 15:56 |
| gmb | allenap, deryck: Would either of you be able to review my JS branch for the subscriptions widget? | 15:58 |
| deryck | gmb: I can | 15:59 |
| gmb | deryck: Cool, thanks. https://code.launchpad.net/~gmb/launchpad/use-subscribe-form-for-fun-and-profit-bug-687747/+merge/43629 | 15:59 |
| * deryck looks | 15:59 | |
| salgado | bac, thanks a lot for taking care of that branch for me. kiko said he's going to ping you once it lands to help with QA, if needed | 16:02 |
| bac | salgado: ok. is it ready to land now? | 16:02 |
| salgado | bac, yep, I've done the change you suggested | 16:02 |
| bac | ok | 16:02 |
| bac | salgado: have a good holiday. | 16:03 |
| salgado | bac, thanks! you too | 16:03 |
| bac | salgado: sending to ec2 now | 16:04 |
| bac | henninge: but *why* are leading '/' in filenames bad? | 16:11 |
| henninge | bac: it's about consistency | 16:11 |
| henninge | bac: we normalize on no leading '/' | 16:12 |
| henninge | so that they stay comparable. | 16:12 |
| henninge | also, tar usually strips leading slashes off file names unless you tell it not to. | 16:12 |
| bac | henninge: ok, i see | 16:13 |
| jcsackett | bac: when you get a chance, there's a comment in reply to part of your comments on my MP; i've got to run out for a bit. | 16:14 |
| bac | jcsackett: ok | 16:14 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | bac: it's also a bit dangerous to have leading slashes in tarballs. If not careful you might unpack your files into system directories. | 16:14 |
| henninge | of course, only if you'd be working as root ... | 16:15 |
| bac | henninge: yeah, tbh i forgot we were talking about tarballs... | 16:15 |
| henninge | bac: thanks for the review ;) | 16:16 |
| deryck | gmb: looks good to me. Nice tests. I'll add a comment to the MP for getting prettier CSS temporarily, but otherwise, this looks fine. r=me | 16:16 |
| gmb | deryck: Thanks,. | 16:16 |
| deryck | gmb: np | 16:16 |
| gmb | deryck: Thank you for explaining that godawful logger | 16:24 |
| gmb | I spent ages trying to work that out | 16:24 |
| gmb | (and then I just maximized firebug and logged directly to the JS console :)) | 16:24 |
| deryck | gmb: heh, np. It's not documented anywhere as far as I know. | 16:24 |
| deryck | it is awful, and I hope to fix something up for it long term. | 16:24 |
| === matsubara is now known as matsubara-afk | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | where did salgado go? | 16:42 |
| henninge | EdwinGrubbs: Are you up for a UI review? | 16:43 |
| EdwinGrubbs | henninge: I can do it in a little while. Isn't there a UI mentee that needs some more practice? | 16:44 |
| henninge | EdwinGrubbs: oh, you have graduated? Missed that. ;) | 16:44 |
| * henninge updates wiki page | 16:45 | |
| henninge | Congrats! | 16:45 |
| EdwinGrubbs | henninge: actually, I don't think I have graduated, but I also don't have a mentor. | 16:46 |
| * henninge reverts | 16:46 | |
| henninge | EdwinGrubbs: I could do that for you, if you want. | 16:46 |
| henninge | Anyway, that does not help in this case. | 16:48 |
| EdwinGrubbs | henninge: I can start on it in about 30 minutes. | 16:48 |
| henninge | EdwinGrubbs: ok, let me prepare the mp. | 16:50 |
| danilos | bac, one more up: https://code.launchpad.net/~danilo/launchpad/bug-676011/+merge/44066 :) | 16:56 |
| === danilos changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [danilos] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | danilos: looks good | 17:06 |
| danilos | bac, thanks | 17:07 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| * bac -> lunch | 17:08 | |
| === sinzui changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| henninge | EdwinGrubbs: https://code.edge.launchpad.net/~henninge/launchpad/devel-bugjamming-1/+merge/44070 | 17:17 |
| * EdwinGrubbs looks | 17:17 | |
| henninge | EdwinGrubbs: please look for the implementation details to see the screen shots. | 17:17 |
| henninge | sinzui: are you able to mentor Edwin's ui review? | 17:18 |
| === henninge changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [sinzui, henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | henninge, I can, but I am off to a hair cut for lunch. Can you wait 90 minutes? | 17:18 |
| henninge | sinzui: I will be off, too. I will look at the replies later tonight. | 17:19 |
| henninge | EdwinGrubbs: please forward to sinzui for mentoring. | 17:19 |
| EdwinGrubbs | ok | 17:19 |
| === deryck is now known as deryck[lunch] | ||
| === benji is now known as benji-lunch | ||
| === danilos changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [sinzui, henninge, danilo] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | (I've put up another very simple branch up for review which solves an OOPS that we've seen 857 times yesterday because of the 'rosetta' product being removed) | 17:59 |
| danilos | 6 lines changed total, anybody up for a review? | 18:00 |
| bac | danilos: yep | 18:00 |
| danilos | bac, it's up at https://code.launchpad.net/~danilo/launchpad/bug-691634/+merge/44077 | 18:01 |
| bac | 180 OOPS/line -- pretty goo | 18:01 |
| danilos | bac, yeah :) | 18:03 |
| danilos | bac, I've also filed a separate bug 691646 to get rid of the 'rosetta' product from the sampledata (including test sampledata) to see if something else breaks as well when we mirror our production state today | 18:03 |
| _mup_ | Bug #691646: Remove 'rosetta' product from the sampledata <lp-translations> <tech-debt> <Launchpad itself:Triaged> < https://launchpad.net/bugs/691646 > | 18:04 |
| bac | thanks danilos | 18:05 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: sinzui || queue: [ henninge, danilo] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | sinzui: your css file has a conflcit | 18:13 |
| bac | conflict | 18:13 |
| === danilos changed the topic of #launchpad-reviews to: On call: bac || Reviewing: sinzui || queue: [ henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| danilos | bac, ta, cheers | 18:25 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: henninge || queue: [ ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === benji-lunch is now known as benji | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || Reviewing: - || queue: [ ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| flacoste | gary_poster: https://code.edge.launchpad.net/~flacoste/launchpad/bug-688503/+merge/44102 | 21:20 |
| gary_poster | got it flacoste. | 21:21 |
| flacoste | sorry about the wrapping | 21:21 |
| flacoste | seems that my editor wraps a little after the code page :-/ | 21:22 |
| flacoste | i should probably turn off auto-wrapping with lp-propose | 21:22 |
| flacoste | and i'm missing the special body plugin | 21:22 |
| gary_poster | flacoste, do you already know what signal we use for log rotation? I was going to try and investigate, but if you know, there's no need | 21:39 |
| gary_poster | eh, maybe sigusr1 :-P | 21:40 |
| gary_poster | sigusr2 | 21:41 |
| gary_poster | anyway, no conflicts, which was all I was worried about | 21:41 |
| flacoste | gary_poster: right, i checked for existing signals | 21:46 |
| flacoste | that's also a reason i split this into two modules | 21:46 |
| flacoste | sighup and haproxy | 21:46 |
| flacoste | since we already have a sigusr1 and sigusr2 modules | 21:46 |
| gary_poster | gotcha | 21:46 |
| gary_poster | flacoste: approved. You could update the PPR heading, but I don't think it matters much. You need me to QA this next week? | 21:48 |
| flacoste | gary_poster: yes, please | 21:48 |
| gary_poster | coool, will do | 21:48 |
| flacoste | thanks and enjoy your week-end! | 21:49 |
| gary_poster | thanks :-) have a great vacation | 21:49 |
| flacoste | thank you | 21:49 |
| === bac changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [ ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | and that concludes my OCR duties for 2010. have a great weekend. | 21:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!