[01:50] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/bug-692114-recipes-main-component/+merge/44184 would enjoy your perusal.
[01:50] <StevenK> Are you sure?
[01:52] <StevenK> wgrant: Can't you use IArchive.getComponentsForSeries()?
[01:54] <wgrant> StevenK: I considered that, but how?
[01:54] <StevenK> IDistribution.current_release ?
[01:54] <wgrant> Which component do I take from that list?
[01:55] <StevenK> It's for a PPA, so it should always be main, and it allows us to extend recipes without having to change that bit, right?
[01:55] <wgrant> StevenK: But if an archive has more than one component, which one do I pick?
[01:57] <StevenK> And that really does sound like swapping one hard code for another
[01:58] <wgrant> Yes.
[01:58] <wgrant> We will need a proper solution eventually.
[01:58] <wgrant> But it is larger than just getComponentsForSeries.
[01:59] <StevenK> thumper: ^ when you have a sec
[02:09] <thumper> done
[02:10] <wgrant> Thanks StevenK, thumper.
[04:52] <wgrant> StevenK: Around for another one?
[05:04] <StevenK> wgrant: Suppose
[05:05] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/bug-685401-expired-queue-files/+merge/44190
[05:05] <wgrant> It will be good when we have five qualified reviewers here.
[05:09] <StevenK> wgrant: +1, but I'm not sure if thumper is still around
[05:09] <wgrant> Hopefully not.
[05:09] <wgrant> Thanks.
[06:14] <StevenK> wgrant: Looks like your MP is +1 from thumper too
[06:16] <wgrant> StevenK: Indeed, thanks.
[06:16] <wgrant> Thanks thumper.
[06:21] <thumper> wgrant: np
[06:23] <StevenK> thumper: You could have a look at my +34/-7 MP if you have time -- a no, bugger off is perfectly fine
[06:26] <thumper> StevenK: link?
[06:29] <StevenK> thumper: https://code.launchpad.net/~stevenk/launchpad/text_to_html-no-linkify/+merge/44192
[06:31] <thumper> done
[14:15] <jcsackett> anyone available to review https://code.launchpad.net/~jcsackett/launchpad/better-bug-linking-531889/+merge/44098
[14:18] <leonardr> jcsackett, i'll take it
[14:18] <jcsackett> thanks, leonarder.
[14:18] <jcsackett> er, leonardr.
[14:18]  * leonardr is now even leonarder
[14:20] <leonardr> jcsackett: i'm not sure why you left the ? in the regular expression
[14:20] <leonardr> eg. you went from number\.? to number?
[14:21] <leonardr> which i think will match either "number" or "numbe"
[14:21] <jcsackett> leonardr: you are correct; i should switch that to (number)?, i think.
[14:21] <jcsackett> no, wait, number i already part of a ?'d group.
[14:22] <leonardr> yeah
[14:22] <leonardr> just take out the ?
[14:22] <jcsackett> okay, i'll just remove that '?'. good spot. :-)
=== bac` is now known as bac
[14:25] <leonardr> jcsackett: what's the change on line 69 of the diff?
[14:25] <leonardr> are these just spacing/line formatting chagnes at the end?
[14:26] <jcsackett> leonardr: just fixing indentation in that broken up string.
[14:26] <jcsackett> that line should be aligned with the two lines above it that it's part of.
[14:27] <leonardr> jcsackett: r=me with that change
[14:28] <jcsackett> leonardr: thanks, and thanks for the review!
[14:28] <leonardr> np
=== sinzui changed the topic of #launchpad-reviews to: On call: -  || Reviewing: - || queue: [ sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:01] <leonardr> EdwinGrubbs, can you take a look at benji's review of https://code.launchpad.net/~leonardr/launchpadlib/retry-on-invalid-token/+merge/43784 ?
[15:01] <EdwinGrubbs> sure
=== abentley changed the topic of #launchpad-reviews to: On call: abentley  || Reviewing: - || queue: [ sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck is now known as deryck[lunch]
=== abentley changed the topic of #launchpad-reviews to: On call: abentley  || Reviewing: - || queue: [ ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[17:12] <EdwinGrubbs> leonardr: review sent
[17:13] <leonardr> thanks
[17:16] <allenap> abentley: Do you have time for https://code.launchpad.net/~allenap/launchpad/bug-activity-grouping-bug-353890/+merge/44247? It's quite long, but a lot of it is doctest/import change noise.
[17:18] <abentley> allenap, okay.
[17:19] <allenap> abentley: Thanks.
=== abentley changed the topic of #launchpad-reviews to: On call: abentley  || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[17:19] <allenap> abentley: I need to head off in about 20 minutes, so please kick it back if you'd prefer for me to be available.
[17:25] <abentley> allenap, there's a lot here.  Maybe it's better to get a proper review tomorrow.
[17:25] <allenap> abentley: Okay, I'll do that. Thanks.
[17:25] <allenap> abentley: Okay, I'll do that. Thanks.
[17:26] <abentley> allenap, tx.
=== abentley changed the topic of #launchpad-reviews to: On call: abentley  || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck[lunch] is now known as deryck
=== benji is now known as benji-lunch
=== benji-lunch is now known as benji
[21:08] <abentley> thumper, https://code.launchpad.net/~abentley/launchpad/move-reviewer-selection/+merge/44250
[21:18] <abentley> thumper, here's the other: https://code.edge.launchpad.net/~abentley/launchpad/more-diff-update-msg/+merge/44288
[21:26] <thumper> done
[21:28] <abentley> thumper, thanks.
[21:28] <abentley> thumper, that first one was my first use of soupmatchers.  Kinda undocumented, but looks powerful.
[21:29] <thumper> yeah
[21:54] <james_w> abentley, what sort of documentation were you looking for?
[21:56] <abentley> james_w, it seemed to lack documentation of parameter types.  I didn't find anything that told me I needed to use HTMLContains, either.
[21:56] <james_w> abentley, did you find the README?
[21:56] <abentley> james_w, no.  I don't usually look for that.
[21:56] <james_w> ok
[21:56] <abentley> james_w, I read the source.
[21:56] <james_w> ok
[21:59] <abentley> james_w, Within doesn't mention that its inputs need to be tags.  I tried HTML ids first.
[22:00] <james_w> abentley, do you think that the API should be improved, or it was just confusion from poor documentation?
[22:03] <abentley> james_w, It would definitely be nicer if the DocumentPart matchers worked on HTML strings.
[22:03] <james_w> abentley, so you can type '<a class="foo">' and it will parse it to get the match spec?
[22:04] <abentley> james_w, right.
[22:04] <james_w> seems feasible
[22:04] <abentley> james_w, it would also be nice if there was a shorthand for Tag('foo', None, attrs={'id': 'foo'})
[22:05] <james_w> yeah
[22:08] <abentley> james_w, this is my test: http://pastebin.ubuntu.com/546111/
[22:10] <abentley> james_w, ideally it would be assertThat(browser.contents, Not(tag_id('field.reviewer').within(tag_id(''mergeproposal-extra-options))) or something.
[22:10] <james_w> right