/srv/irclogs.ubuntu.com/2010/12/22/#launchpad-reviews.txt

=== leonardr changed the topic of #launchpad-reviews to: On call: leonardr || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== leonardr changed the topic of #launchpad-reviews to: On call: - || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningeHi jelmer!12:08
henningejelmer: I have a nice branch for you ;)12:09
jelmerHi Henning!12:09
jelmerThat's great, I prefer nice branches over not so nice branches :-P12:09
henningeWonderful! ;)12:09
henningehttps://code.launchpad.net/~henninge/launchpad/devel-487137-custom-language-codes/+merge/4444612:09
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: henninge || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningeI just mailed in incremental diff because most changes have already been approved. It should show up in the mp soon.12:10
henningejelmer: ^12:10
henningethanks ;)12:10
jelmerhenninge: are there no explicit tests to see that a "normal" user can't add custom language codes?13:22
henningejelmer: is that not what the "Unprivileged access" section shows?13:23
jelmerhenninge: You're right, sorry!13:24
jelmerhenninge: not sure how I missed that13:27
jelmerhenninge: r=me13:27
henningejelmer: thank you :-D13:28
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== henninge_ is now known as henninge
=== sinzui changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
jcsackettjelmer, can i throw another (very, very) small branch on your queue?15:33
jcsacketthttps://code.launchpad.net/~jcsackett/launchpad/autofocus-2-135018/+merge/4447215:33
jelmerjcsackett: sure15:34
jcsackettthanks.15:34
=== jcsackett changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
jelmerjcsackett: I'll do yours first15:35
jcsackettjelmer: works for me. :-P15:35
jelmerjcsackett: r=me15:40
jcsackettjelmer: thanks!15:40
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
jelmersinzui: What is "discluded" ? :-)16:37
sinzuiopposite of include16:37
jelmerexcluded?16:38
sinzuiah16:38
sinzuimuch better work16:38
sinzuiword16:38
jelmerapparently discluded is a word but it means disclosed16:39
sinzuiI do not think I mean that. I will change the comment to us exclude16:44
jelmersinzui: r=me16:46
sinzuithanks jelmer16:46
=== deryck is now known as deryck[lunch]
=== bdmurray_ is now known as bdmurray
=== deryck[lunch] is now known as deryck
=== leonardr is now known as leonardr-dentist
=== jelmer changed the topic of #launchpad-reviews to: On call: None || reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== leonardr-dentist is now known as leonardr
jcsackettanyone available to review a branch that makes a quick change to one template? https://code.launchpad.net/~jcsackett/launchpad/mergeproposal-status-icon-589584/+merge/4453122:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!