=== leonardr changed the topic of #launchpad-reviews to: On call: leonardr || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== leonardr changed the topic of #launchpad-reviews to: On call: - || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
henninge | Hi jelmer! | 12:08 |
---|---|---|
henninge | jelmer: I have a nice branch for you ;) | 12:09 |
jelmer | Hi Henning! | 12:09 |
jelmer | That's great, I prefer nice branches over not so nice branches :-P | 12:09 |
henninge | Wonderful! ;) | 12:09 |
henninge | https://code.launchpad.net/~henninge/launchpad/devel-487137-custom-language-codes/+merge/44446 | 12:09 |
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: henninge || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
henninge | I just mailed in incremental diff because most changes have already been approved. It should show up in the mp soon. | 12:10 |
henninge | jelmer: ^ | 12:10 |
henninge | thanks ;) | 12:10 |
jelmer | henninge: are there no explicit tests to see that a "normal" user can't add custom language codes? | 13:22 |
henninge | jelmer: is that not what the "Unprivileged access" section shows? | 13:23 |
jelmer | henninge: You're right, sorry! | 13:24 |
jelmer | henninge: not sure how I missed that | 13:27 |
jelmer | henninge: r=me | 13:27 |
henninge | jelmer: thank you :-D | 13:28 |
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== henninge_ is now known as henninge | ||
=== sinzui changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== sinzui changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
jcsackett | jelmer, can i throw another (very, very) small branch on your queue? | 15:33 |
jcsackett | https://code.launchpad.net/~jcsackett/launchpad/autofocus-2-135018/+merge/44472 | 15:33 |
jelmer | jcsackett: sure | 15:34 |
jcsackett | thanks. | 15:34 |
=== jcsackett changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
jelmer | jcsackett: I'll do yours first | 15:35 |
jcsackett | jelmer: works for me. :-P | 15:35 |
jelmer | jcsackett: r=me | 15:40 |
jcsackett | jelmer: thanks! | 15:40 |
=== jelmer changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
jelmer | sinzui: What is "discluded" ? :-) | 16:37 |
sinzui | opposite of include | 16:37 |
jelmer | excluded? | 16:38 |
sinzui | ah | 16:38 |
sinzui | much better work | 16:38 |
sinzui | word | 16:38 |
jelmer | apparently discluded is a word but it means disclosed | 16:39 |
sinzui | I do not think I mean that. I will change the comment to us exclude | 16:44 |
jelmer | sinzui: r=me | 16:46 |
sinzui | thanks jelmer | 16:46 |
=== deryck is now known as deryck[lunch] | ||
=== bdmurray_ is now known as bdmurray | ||
=== deryck[lunch] is now known as deryck | ||
=== leonardr is now known as leonardr-dentist | ||
=== jelmer changed the topic of #launchpad-reviews to: On call: None || reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== leonardr-dentist is now known as leonardr | ||
jcsackett | anyone available to review a branch that makes a quick change to one template? https://code.launchpad.net/~jcsackett/launchpad/mergeproposal-status-icon-589584/+merge/44531 | 22:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!