=== leonardr changed the topic of #launchpad-reviews to: On call: leonardr || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === leonardr changed the topic of #launchpad-reviews to: On call: - || Reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:08] Hi jelmer! [12:09] jelmer: I have a nice branch for you ;) [12:09] Hi Henning! [12:09] That's great, I prefer nice branches over not so nice branches :-P [12:09] Wonderful! ;) [12:09] https://code.launchpad.net/~henninge/launchpad/devel-487137-custom-language-codes/+merge/44446 === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || Reviewing: henninge || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:10] I just mailed in incremental diff because most changes have already been approved. It should show up in the mp soon. [12:10] jelmer: ^ [12:10] thanks ;) [13:22] henninge: are there no explicit tests to see that a "normal" user can't add custom language codes? [13:23] jelmer: is that not what the "Unprivileged access" section shows? [13:24] henninge: You're right, sorry! [13:27] henninge: not sure how I missed that [13:27] henninge: r=me [13:28] jelmer: thank you :-D === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === henninge_ is now known as henninge === sinzui changed the topic of #launchpad-reviews to: On call: jelmer || eviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === sinzui changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:33] jelmer, can i throw another (very, very) small branch on your queue? [15:33] https://code.launchpad.net/~jcsackett/launchpad/autofocus-2-135018/+merge/44472 [15:34] jcsackett: sure [15:34] thanks. === jcsackett changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:35] jcsackett: I'll do yours first [15:35] jelmer: works for me. :-P [15:40] jcsackett: r=me [15:40] jelmer: thanks! === jelmer changed the topic of #launchpad-reviews to: On call: jelmer || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:37] sinzui: What is "discluded" ? :-) [16:37] opposite of include [16:38] excluded? [16:38] ah [16:38] much better work [16:38] word [16:39] apparently discluded is a word but it means disclosed [16:44] I do not think I mean that. I will change the comment to us exclude [16:46] sinzui: r=me [16:46] thanks jelmer === deryck is now known as deryck[lunch] === bdmurray_ is now known as bdmurray === deryck[lunch] is now known as deryck === leonardr is now known as leonardr-dentist === jelmer changed the topic of #launchpad-reviews to: On call: None || reviewing: None || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === leonardr-dentist is now known as leonardr [22:53] anyone available to review a branch that makes a quick change to one template? https://code.launchpad.net/~jcsackett/launchpad/mergeproposal-status-icon-589584/+merge/44531